Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge in consistency between the files in gromacs_solvated.tar.gz and gromacs.tar.gz #53

Open
dingye18 opened this issue Nov 19, 2024 · 2 comments

Comments

@dingye18
Copy link

I just found that that atomic charges of part of the molecules are different in gromacs_solvated.tar.gz and gromacs.tar.gz.
Such as the mobley_820789, the atomic charges in gromacs/mobley_820789.top are:
image

While in gromacs_solvated/mobley_820789.top:
image
That's quite different. And only the parameters in gromacs/mobley_820789.top can reproduce the result in literature.
Openff-toolkit was used to regenerate the atomic charges of mobley_820789 with gaff-1.8, and the regenerated charges were consistent with the content in gromacs/mobley_820789.top.

How did the charges in gromacs_solvated generated? And was it processed after gaff-1.7?

@davidlmobley
Copy link
Member

Wow, yes, these are VERY different. That's quite concerning.

At this point (given how much time has elapsed) i don't have any information on provenance other than what's present in our scripts and paper. I certainly HOPE all of this was generated fully consistently via the scripts, but also the superficial first impression of the files is that this is what one would get if there is some kind of human error in generation protocol (e.g. someone copied the wrong file somewhere), which makes me worried. Do you have a sense of how widespread this problem is?

@dingye18
Copy link
Author

Well, I did a simple analysis today.
If we compare the non-bond parameters only, there are 452 molecules that contain different parameters between gromacs_solvated.tar.gz and gromacs.tar.gz.
But some of the charge parameters are closer, indicating that they may be generated with different random seeds.

If we enlarge the tolerance of the charges difference to 0.01 e, there are 29 molecules that contains different parameters within these two set.

mobley_6334915
mobley_3047364
mobley_1735893
mobley_6861308
mobley_2523689
mobley_628086
mobley_9979854
mobley_4936555
mobley_2929847
mobley_5948990
mobley_820789
mobley_6727159
mobley_2364370
mobley_7754849
mobley_5200358
mobley_7455579
mobley_3259411
mobley_902954
mobley_3572203
mobley_4792268
mobley_8754702
mobley_7326706
mobley_3802803
mobley_2269032
mobley_5890803
mobley_5571660
mobley_3265457
mobley_1770205
mobley_8124669

If you want to fix this problem, I recommend you to regenerate the files in gromacs_solvated.tar.gz as it contains parameters that do not reproduce the calculated solvation free energies.

If you want, I can submit a PR to fix this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants