diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 9e55294332e..4dbe149c57d 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -9,7 +9,7 @@ template_path=.github/ISSUE_TEMPLATE/bug_report.md ### Step 0: Are you in the right place? * For issues or feature requests related to __the code in this repository__ - file a Github issue. + file a GitHub issue. * If this is a __feature request__ please use the Feature Request template. * For general technical questions, post a question on [StackOverflow](http://stackoverflow.com/) with the `firebase` tag. diff --git a/.github/actions/testing_report_generation/action.yml b/.github/actions/testing_report_generation/action.yml index f50bf4c641c..14c826d2252 100644 --- a/.github/actions/testing_report_generation/action.yml +++ b/.github/actions/testing_report_generation/action.yml @@ -9,7 +9,7 @@ inputs: required: true default: 'nightly-testing' issue-title: - description: 'Title of a Github Issue' + description: 'Title of a GitHub Issue' required: true default: 'Nightly Testing Report' assignee: diff --git a/SharedTestUtilities/FIRSampleAppUtilities.m b/SharedTestUtilities/FIRSampleAppUtilities.m index 7dfa9f8433f..8f088b93420 100644 --- a/SharedTestUtilities/FIRSampleAppUtilities.m +++ b/SharedTestUtilities/FIRSampleAppUtilities.m @@ -27,15 +27,15 @@ NSString *const kGoogleAppIDPlistKey = @"GOOGLE_APP_ID"; // Dummy plist GOOGLE_APP_ID NSString *const kDummyGoogleAppID = @"1:123:ios:123abc"; -// Github Repo URL String -NSString *const kGithubRepoURLString = @"https://github.com/firebase/firebase-ios-sdk/"; +// GitHub Repo URL String +NSString *const kGitHubRepoURLString = @"https://github.com/firebase/firebase-ios-sdk/"; // Alert contents NSString *const kInvalidPlistAlertTitle = @"GoogleService-Info.plist"; NSString *const kInvalidPlistAlertMessage = @"This sample app needs to be updated with a valid " @"GoogleService-Info.plist file in order to configure " @"Firebase.\n\n" @"Please update the app with a valid plist file, " - @"following the instructions in the Firebase Github " + @"following the instructions in the Firebase GitHub " @"repository at: %@"; @implementation FIRSampleAppUtilities @@ -81,16 +81,16 @@ + (BOOL)containsRealServiceInfoPlistInBundle:(NSBundle *)bundle { + (void)presentAlertForInvalidServiceInfoPlistFromViewController: (UIViewController *)viewController { - NSString *message = [NSString stringWithFormat:kInvalidPlistAlertMessage, kGithubRepoURLString]; + NSString *message = [NSString stringWithFormat:kInvalidPlistAlertMessage, kGitHubRepoURLString]; UIAlertController *alertController = [UIAlertController alertControllerWithTitle:kInvalidPlistAlertTitle message:message preferredStyle:UIAlertControllerStyleAlert]; UIAlertAction *viewReadmeAction = [UIAlertAction - actionWithTitle:@"View Github" + actionWithTitle:@"View GitHub" style:UIAlertActionStyleDefault handler:^(UIAlertAction *_Nonnull action) { - NSURL *githubURL = [NSURL URLWithString:kGithubRepoURLString]; + NSURL *githubURL = [NSURL URLWithString:kGitHubRepoURLString]; [FIRSampleAppUtilities navigateToURL:githubURL fromViewController:viewController]; }]; [alertController addAction:viewReadmeAction]; diff --git a/scripts/check_firestore_core_api_absl.py b/scripts/check_firestore_core_api_absl.py index bcf0fe2bc7b..87101e2d5a2 100755 --- a/scripts/check_firestore_core_api_absl.py +++ b/scripts/check_firestore_core_api_absl.py @@ -19,7 +19,7 @@ the Unity SDK, when it is built from google3. """ -# TODO(b/192129206) : Remove this check once Unity SDK is built from Github. +# TODO(b/192129206) : Remove this check once Unity SDK is built from GitHub. import argparse import logging import six diff --git a/scripts/create_spec_repo/Sources/SpecRepoBuilder/main.swift b/scripts/create_spec_repo/Sources/SpecRepoBuilder/main.swift index 7cb9202f2bf..716e6314159 100644 --- a/scripts/create_spec_repo/Sources/SpecRepoBuilder/main.swift +++ b/scripts/create_spec_repo/Sources/SpecRepoBuilder/main.swift @@ -113,10 +113,10 @@ struct SpecRepoBuilder: ParsableCommand { @Option(parsing: .upToNextOption, help: "Podspecs that will not be pushed to repo.") var excludePods: [String] = [] - @Option(help: "Github Account Name.") + @Option(help: "GitHub Account Name.") var githubAccount: String = "FirebasePrivate" - @Option(help: "Github Repo Name.") + @Option(help: "GitHub Repo Name.") var sdkRepoName: String = "SpecsTesting" @Option(help: "Local Podspec Repo Name.") diff --git a/scripts/health_metrics/generate_code_coverage_report/README.md b/scripts/health_metrics/generate_code_coverage_report/README.md index dc8d46c0bf2..455f58a6146 100644 --- a/scripts/health_metrics/generate_code_coverage_report/README.md +++ b/scripts/health_metrics/generate_code_coverage_report/README.md @@ -28,11 +28,11 @@ comment of a pull request. If such comment has existed, this comment will be ove report. Since the flag is `presubmit` here, the following options are required for a PR request: -- `log-link`: Log link to unit tests. This is generally a actions/runs/ link in Github Actions. +- `log-link`: Log link to unit tests. This is generally a actions/runs/ link in GitHub Actions. - `pull-request-num`: A report will be posted in this pull request. - `base-commit`: The commit sha used to compare the diff of the current`commit`. -An example in a Github Actions workflow: +An example in a GitHub Actions workflow: ``` swift run CoverageReportGenerator --presubmit "firebase/firebase-ios-sdk" --commit "${GITHUB_SHA}" \ --token $(gcloud auth print-identity-token) --xcresult-dir "/Users/runner/test/codecoverage" \ diff --git a/scripts/health_metrics/pod_test_code_coverage_report.sh b/scripts/health_metrics/pod_test_code_coverage_report.sh index 982dcb7d9d5..100b8d85312 100755 --- a/scripts/health_metrics/pod_test_code_coverage_report.sh +++ b/scripts/health_metrics/pod_test_code_coverage_report.sh @@ -64,7 +64,7 @@ else # Run unit tests of pods and put xcresult bundles into OUTPUT_PATH, which # should be a targeted dir of actions/upload-artifact in workflows. # In code coverage workflow, files under OUTPUT_PATH will be uploaded to - # Github Actions. + # GitHub Actions. scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb "${SDK}".podspec --platforms="$(tr '[:upper:]' '[:lower:]'<<<${PLATFORM})" --test-specs="${TEST_SPEC}" fi