Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'extras' field to be modified on all objects in QCArchive #602

Open
dotsdl opened this issue Jun 23, 2020 · 0 comments
Open

Allow 'extras' field to be modified on all objects in QCArchive #602

dotsdl opened this issue Jun 23, 2020 · 0 comments

Comments

@dotsdl
Copy link
Collaborator

dotsdl commented Jun 23, 2020

Is your feature request related to a problem? Please describe.

There are cases in which e.g. Molecules have been submitted previously, but now we want them to have additional metadata for downstream use in benchmarking. Modification of a molecule after submission is not allowed (for good reason!), but there are cases where post-hoc modification of descriptive data that doesn't impact computation is of real value.

Describe the solution you'd like

The extras field on an object in the QCArchive ecosystem is explicitly not part of the schema, so modification of it on an object in the database should be permitted, even with caution. This would give a single known point on an object that can mutate with time, enabling downstream work that can also change with time. It is the responsibility of the modifier to ensure their changes are appropriate to the downstream consumers of that extras metadata.

Describe alternatives you've considered

Alternatives to this include generating content downstream that could otherwise be stored persistently in extras. This isn't always easy to do: information useful for downstream work, such as canonical smiles for a molecule, may not be as easy to generate downstream as it is upstream to submission.

Adding extras to an existing Molecule could be done with the same submission artifacts that were used for submission, addressing this problem.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant