Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to be fixed in 1.4 test suite #55

Open
6 tasks
smavros opened this issue Apr 28, 2022 · 0 comments
Open
6 tasks

Tests to be fixed in 1.4 test suite #55

smavros opened this issue Apr 28, 2022 · 0 comments

Comments

@smavros
Copy link

smavros commented Apr 28, 2022

Errors

  • JSONTest issue AttributeError: 'MonetTypeCompiler' object has no attribute 'visit_JSON' #52, 87 failures due to lack of dialect support for JSON type
  • IdentityColumnTest the errors comes from the fact that one column of this test's table is named "desc" which collides with the SQL Standard DESC keyword.
  • IdentityAutoincrementTest same as IdentityColumnTest
  • CTETests use the INSERT INTO for tables with recursive keys (create table foo (id int primary key, num int references foo(id));) which is known to not work properly in Monet (FK constraint violated in self table references MonetDB#6131) e.g. insert into foo values (1,null), (2,1); raises FOREIGN KEY constraint 'foo.foo_num_fkey' violated
  • QuotedNameArgumentTests are failing because of the NOT supported column CHECK constraint. Of course this is not raising an error or an exception but simply issues a warning through MonetDB dialect compiler so the user would know that the CHECK is a no-op. The problem comes from the fact that for the testing suite the SAWarnings are turned into errors (see. sqlalchemy/testing/warnings.py). Another issue with this group of tests is that we do not support comment_reflection which, I guess, was supposed to be supported given the fact that we support _COMMENT_s for SQL objects.

Failures

@smavros smavros mentioned this issue May 9, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant