[PORT] Fix organs being replaced when not needed #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request So it seems `regenerate_organs` on species was actually replacing organs not belonging to the species regardless, which was making it so the `HEAL_ORGANS` flag which is supposed to heal your organs and supposedly replace missing ones too. However, this made it so anything using that would also remove and replace all organs not native to your species, including prosthetic organs, cybernetic organs, organs alien to your species, and the nightmare heart itself when you're not a nightmare and it tries to revive and convert you. This just makes it mimic its behaviour when used to convert from one species to another, which is to not replace organs alien to your previous species, and making it also not replace those when `replace_current = FALSE`. ## Why It's Good For The Game Fixes tgstation#81546. Fixes ethereal reviving eating your prosthetics. ## Changelog :cl: fix: Ethereal heart revive doesn't delete organs alien to your species, like prosthetics, cybernetics, and possibly itself. fix: Nightmare heart revive doesn't delete organs alien to your species, like itself, upon which it would stop the conversion to shadowperson. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Port of tgstation#81575
Changelog
🆑 00-Steven
fix: Ethereal heart revive doesn't delete organs alien to your species, like prosthetics, cybernetics, and possibly itself.
fix: Nightmare heart revive doesn't delete organs alien to your species, like itself, upon which it would stop the conversion to shadowperson.
fix: Bloodsucker torpor, doesn't delete organs alien to your species, which would result in things such as wings being lost (therefore preventing ultrakill jokes from lasting more than 10 minutes)
/:cl: