Add node_exporter acceptance test for proxy settings

Author: ShaunMaxwell

.github/workflows/ci.yml

@@ -1,7 +1,4 @@
 ---
-# Managed by modulesync - DO NOT EDIT
-# https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
-
 name: CI
 
 on: pull_request
@@ -74,11 +71,16 @@ jobs:
         with:
           ruby-version: '3.0'
           bundler-cache: true
+      - name: Start squid
+        run: ./scripts/start-squid.sh
       - name: Run tests
         run: bundle exec rake beaker
         env:
           BEAKER_PUPPET_COLLECTION: ${{ matrix.puppet.collection }}
           BEAKER_setfile: ${{ matrix.setfile.value }}
+      - name: squid logs
+        run: docker logs squid --tail 50
+        if: always()
 
   tests:
     needs:

.sync.yml

@@ -3,3 +3,5 @@ spec/spec_helper.rb:
   spec_overrides: "require 'spec_helper_methods'"
 spec/spec_helper_acceptance.rb:
   unmanaged: false
+.github/workflows/ci.yml:
+  unmanaged: true

scripts/start-squid.sh

@@ -0,0 +1,23 @@
+#!/bin/bash
+
+cat << EOF > /tmp/squid.conf
+http_port 3128
+http_access allow all
+logfile_rotate 0
+cache_log stdio:/dev/stdout
+access_log stdio:/dev/stdout
+cache_store_log stdio:/dev/stdout
+EOF
+
+docker run --detach --rm \
+  --name squid \
+  --hostname squid \
+  --publish 3128:3128 \
+  --env='SQUID_CONFIG_FILE=/etc/squid/my-squid.conf' \
+  --volume=/tmp/squid.conf:/etc/squid/my-squid.conf:ro \
+  b4tman/squid
+
+sleep 3
+docker logs squid --tail 100
+
+docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' squid > ~/SQUID_IP

spec/acceptance/node_exporter_spec.rb

@@ -54,4 +54,22 @@
     end
   end
   # rubocop:enable RSpec/RepeatedExampleGroupBody,RSpec/RepeatedExampleGroupDescription
+
+  describe 'install with proxy' do
+    it 'installs idempotently with no errors' do
+      pp = "class{'prometheus::node_exporter': proxy_server => 'http://squid:3128', proxy_type => 'http'}"
+      # Run it twice and test for idempotency
+      apply_manifest(pp, catch_failures: true)
+      apply_manifest(pp, catch_changes: true)
+    end
+
+    describe service('node_exporter') do
+      it { is_expected.to be_running }
+      it { is_expected.to be_enabled }
+    end
+
+    describe port(9100) do
+      it { is_expected.to be_listening.with('tcp6') }
+    end
+  end
 end

spec/setup_acceptance_node.pp

@@ -4,3 +4,8 @@
     ensure => present,
   }
 }
+
+file_line { '/etc/hosts-squid':
+  path => '/etc/hosts',
+  line => "${facts['squid_ip']} squid",
+}

spec/spec_helper_acceptance.rb

@@ -5,6 +5,8 @@
 
 require 'voxpupuli/acceptance/spec_helper_acceptance'
 
+ENV['BEAKER_FACTER_SQUID_IP'] = File.read(File.expand_path('~/SQUID_IP')).chomp
+
 configure_beaker
 
 Dir['./spec/support/acceptance/**/*.rb'].sort.each { |f| require f }