Execute tests in the Europe/Brussels timezone (#12)

Author: tdpauw

DMARCReporting/parser.py

@@ -1,6 +1,7 @@
-from lxml import etree as ET
 from datetime import datetime
 
+from lxml import etree as ET
+
 xpath_all = ".//record"
 xpath_failed = (
     ".//record["

Makefile

@@ -30,7 +30,7 @@ format: ## Format source and test code using black
 	pipenv run black --skip-string-normalization tests
 
 test: lint ## Run unit tests
-	pipenv run pytest -vv
+	pipenv run pytest -vv -s
 
 dist: clean ## Creates a source distribution and wheel distribution
 	pipenv run python setup.py sdist bdist_wheel

tests/test_acceptance.py

@@ -1,13 +1,37 @@
-import io
+import os
 import sys
+import io
+import time
 from unittest.mock import patch
 
+import pytest
+
 from .context import DMARCReporting  # noqa F401
 from DMARCReporting.cli import CLI
 
+test_tz = 'Europe/Brussels'
+env_tz = ''
+
+
+@pytest.fixture
+def setup_timezone():
+    env_tz = time.tzname[0]
+    print()
+    print(f"save current timezone: {env_tz}")
+    print(f"set timezone for tests to {test_tz}")
+    os.environ['TZ'] = test_tz
+    time.tzset()
+    print(f"timezone is now {time.tzname[0]}")
+    yield
+    print()
+    print(f"reset timezone back to {env_tz}")
+    os.environ['TZ'] = env_tz
+    time.tzset()
+    print(f"timezone is now {time.tzname[0]}")
+
 
 @patch('socket.gethostbyaddr')
-def test_render(gethostbyaddr_mock):
+def test_render(gethostbyaddr_mock, setup_timezone):
     gethostbyaddr_mock.side_effect = [
         ("Unknown host", [], []),
         ("208-90-221-45.static.flhsi.com", [], []),
@@ -38,7 +62,7 @@ def test_render(gethostbyaddr_mock):
 
 
 @patch('socket.gethostbyaddr')
-def test_render_all(gethostbyaddr_mock):
+def test_render_all(gethostbyaddr_mock, setup_timezone):
     gethostbyaddr_mock.side_effect = [
         ("smtp.bellous.com", [], []),
         ("smtp.bellous.com", [], []),

tests/test_parser_dkim.py

@@ -1,10 +1,32 @@
+import os
 import io
+import time
 
 import pytest
 
 from .context import DMARCReporting  # noqa F401
 from DMARCReporting.parser import DMARCRuaParser
 
+test_tz = 'Europe/Brussels'
+env_tz = ''
+
+
+@pytest.fixture
+def setup_timezone():
+    env_tz = time.tzname[0]
+    print()
+    print(f"save current timezone: {env_tz}")
+    print(f"set timezone for tests to {test_tz}")
+    os.environ['TZ'] = test_tz
+    time.tzset()
+    print(f"timezone is now {time.tzname[0]}")
+    yield
+    print()
+    print(f"reset timezone back to {env_tz}")
+    os.environ['TZ'] = env_tz
+    time.tzset()
+    print(f"timezone is now {time.tzname[0]}")
+
 
 @pytest.fixture
 def not_authenticated():
@@ -50,7 +72,7 @@ def reverse_name(self, ipv4):
         return "mail.email.com"
 
 
-def test_when_not_authenticated(not_authenticated):
+def test_when_not_authenticated(not_authenticated, setup_timezone):
     sut = DMARCRuaParser(DNSStub())
     actual = sut.parse(not_authenticated)
     expected = [
@@ -116,7 +138,7 @@ def authenticated_two_records():
     )
 
 
-def test_when_not_authenticated_having_two_records(authenticated_two_records):
+def test_when_not_authenticated_having_two_records(authenticated_two_records, setup_timezone):
     sut = DMARCRuaParser(DNSStub())
     actual = sut.parse(authenticated_two_records)
     expected = [

tests/test_parser_dmarc.py

@@ -1,11 +1,34 @@
+import os
 import io
+import time
 
 import pytest
 
 from .context import DMARCReporting  # noqa F401
 from DMARCReporting.parser import DMARCRuaParser
 
 
+test_tz = 'Europe/Brussels'
+env_tz = ''
+
+
+@pytest.fixture
+def setup_timezone():
+    env_tz = time.tzname[0]
+    print()
+    print(f"save current timezone: {env_tz}")
+    print(f"set timezone for tests to {test_tz}")
+    os.environ['TZ'] = test_tz
+    time.tzset()
+    print(f"timezone is now {time.tzname[0]}")
+    yield
+    print()
+    print(f"reset timezone back to {env_tz}")
+    os.environ['TZ'] = env_tz
+    time.tzset()
+    print(f"timezone is now {time.tzname[0]}")
+
+
 def rua_report(disposition="none", spf_aligned="pass", dkim_aligned="pass"):
     return io.StringIO(
         """
@@ -85,7 +108,7 @@ def reverse_name(self, ipv4):
         return "mail.email.com"
 
 
-def test_when_dmarc_disposition_quarantine(rua_report_quarantine):
+def test_when_dmarc_disposition_quarantine(rua_report_quarantine, setup_timezone):
     sut = DMARCRuaParser(DNSStub())
     actual = sut.parse(rua_report_quarantine)
     expected = [
@@ -107,13 +130,13 @@ def test_when_dmarc_disposition_quarantine(rua_report_quarantine):
     assert expected == actual
 
 
-def test_when_dmarc_disposition_none(rua_report_none):
+def test_when_dmarc_disposition_none(rua_report_none, setup_timezone):
     sut = DMARCRuaParser(DNSStub())
     actual = sut.parse(rua_report_none)
     assert [] == actual
 
 
-def test_when_dmarc_disposition_reject(rua_report_reject):
+def test_when_dmarc_disposition_reject(rua_report_reject, setup_timezone):
     sut = DMARCRuaParser(DNSStub())
     actual = sut.parse(rua_report_reject)
     expected = [
@@ -135,13 +158,13 @@ def test_when_dmarc_disposition_reject(rua_report_reject):
     assert expected == actual
 
 
-def test_when_spf_and_dkim_aligned(rua_report_spf_and_dkim_aligned):
+def test_when_spf_and_dkim_aligned(rua_report_spf_and_dkim_aligned, setup_timezone):
     sut = DMARCRuaParser(DNSStub())
     actual = sut.parse(rua_report_spf_and_dkim_aligned)
     assert [] == actual
 
 
-def test_when_spf_not_aligned(rua_report_spf_not_aligned):
+def test_when_spf_not_aligned(rua_report_spf_not_aligned, setup_timezone):
     sut = DMARCRuaParser(DNSStub())
     actual = sut.parse(rua_report_spf_not_aligned)
     expected = [
@@ -163,7 +186,7 @@ def test_when_spf_not_aligned(rua_report_spf_not_aligned):
     assert expected == actual
 
 
-def test_when_dkim_not_aligned(rua_report_dkim_not_aligned):
+def test_when_dkim_not_aligned(rua_report_dkim_not_aligned, setup_timezone):
     sut = DMARCRuaParser(DNSStub())
     actual = sut.parse(rua_report_dkim_not_aligned)
     expected = [

tests/test_parser_spf.py

@@ -1,11 +1,34 @@
+import os
 import io
+import time
 
 import pytest
 
 from .context import DMARCReporting  # noqa F401
 from DMARCReporting.parser import DMARCRuaParser
 
 
+test_tz = 'Europe/Brussels'
+env_tz = ''
+
+
+@pytest.fixture
+def setup_timezone():
+    env_tz = time.tzname[0]
+    print()
+    print(f"save current timezone: {env_tz}")
+    print(f"set timezone for tests to {test_tz}")
+    os.environ['TZ'] = test_tz
+    time.tzset()
+    print(f"timezone is now {time.tzname[0]}")
+    yield
+    print()
+    print(f"reset timezone back to {env_tz}")
+    os.environ['TZ'] = env_tz
+    time.tzset()
+    print(f"timezone is now {time.tzname[0]}")
+
+
 @pytest.fixture
 def not_authenticated():
     return io.StringIO(