Actually fix non-empty rbtree infinite iteration, bump version to 0.10.8 (and yes, I tested it locally)

MrElectrify · MrElectrify · commit 9e3c033ca580 · 2024-03-07T19:48:21.000-08:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -3,7 +3,7 @@ name = "eastl-rs"
 authors = ["Andrew Buck"]
 description = "EASTL binary-compatible Rust implementations"
 documentation = "https://docs.rs/crate/eastl-rs"
-version = "0.10.7"
+version = "0.10.8"
 edition = "2021"
 license-file = "LICENSE"
 readme = "README.md"
diff --git a/src/internal/rb_tree/node.rs b/src/internal/rb_tree/node.rs
@@ -222,7 +222,13 @@ impl<K, V> Node<K, V> {
                 parent = parent_parent;
             }
 
-            Some(parent)
+            // I have deliberated on this and truly have no clue why we are doing this, but it works
+            // and is how it is originally implemented
+            if !ptr::eq(self.right, parent) {
+                self = parent;
+            }
+
+            Some(self)
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,13 @@ impl<K, V> Node<K, V> {`
`222`	`222`	`parent = parent_parent;`
`223`	`223`	`}`
`224`	`224`
`225`		`- Some(parent)`
	`225`	`+ // I have deliberated on this and truly have no clue why we are doing this, but it works`
	`226`	`+ // and is how it is originally implemented`
	`227`	`+ if !ptr::eq(self.right, parent) {`
	`228`	`+ self = parent;`
	`229`	`+ }`
	`230`	`+`
	`231`	`+ Some(self)`
`226`	`232`	`}`
`227`	`233`	`}`
`228`	`234`