From ac5d9dd4f9946e69ed270b427eb5d8325e55919c Mon Sep 17 00:00:00 2001 From: macndev Date: Fri, 19 Mar 2021 15:32:33 -0500 Subject: [PATCH 01/54] rebase 0413 removing pieces of Offline that need MADC/pcie --- ...agmentAna_module.cc => FragmentAna_module.cc.sav} | 0 DAQ/src/{SConscript => SConscript.sav} | 0 setup.sh | 12 ++++++------ 3 files changed, 6 insertions(+), 6 deletions(-) rename Analyses/src/{FragmentAna_module.cc => FragmentAna_module.cc.sav} (100%) rename DAQ/src/{SConscript => SConscript.sav} (100%) diff --git a/Analyses/src/FragmentAna_module.cc b/Analyses/src/FragmentAna_module.cc.sav similarity index 100% rename from Analyses/src/FragmentAna_module.cc rename to Analyses/src/FragmentAna_module.cc.sav diff --git a/DAQ/src/SConscript b/DAQ/src/SConscript.sav similarity index 100% rename from DAQ/src/SConscript rename to DAQ/src/SConscript.sav diff --git a/setup.sh b/setup.sh index 369ca3f528..5f28afe0c5 100644 --- a/setup.sh +++ b/setup.sh @@ -101,7 +101,7 @@ build=$($MU2E_BASE_RELEASE/buildopts --build) # and is therefore different from the value shown in # SETUP_ environment vars, or by the "ups active" command. export MU2E_UPS_QUALIFIERS=+e20:+${build} -export MU2E_ART_SQUALIFIER=s105 +export MU2E_ART_SQUALIFIER=s107 MU2E_G4_GRAPHICS_QUALIFIER='' if [[ $($MU2E_BASE_RELEASE/buildopts --g4vis) == qt ]]; then @@ -121,18 +121,18 @@ fi export MU2E_G4_EXTRA_QUALIFIER='' # Setup the framework and its dependent products -setup -B art v3_06_03 -q${MU2E_UPS_QUALIFIERS} -setup -B art_root_io v1_05_01 -q${MU2E_UPS_QUALIFIERS} +setup -B art v3_08_00 -q${MU2E_UPS_QUALIFIERS} +setup -B art_root_io v1_07_00 -q${MU2E_UPS_QUALIFIERS} # Geant4 and its cross-section files. if [[ $($MU2E_BASE_RELEASE/buildopts --trigger) == "off" ]]; then - setup -B geant4 v4_10_6_p03 -q${MU2E_UPS_QUALIFIERS}${MU2E_G4_GRAPHICS_QUALIFIER}${MU2E_G4_VECGEOM_QUALIFIER}${MU2E_G4_MT_QUALIFIER}${MU2E_G4_EXTRA_QUALIFIER} + setup -B geant4 v4_10_7_p01c -q${MU2E_UPS_QUALIFIERS}${MU2E_G4_GRAPHICS_QUALIFIER}${MU2E_G4_VECGEOM_QUALIFIER}${MU2E_G4_MT_QUALIFIER}${MU2E_G4_EXTRA_QUALIFIER} else setup -B xerces_c v3_2_3 -q${MU2E_UPS_QUALIFIERS} fi # Get access to raw data formats. -setup -B mu2e_artdaq_core v1_05_06b -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} +setup -B mu2e_artdaq_core v1_05_07 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} setup -B heppdt v03_04_02 -q${MU2E_UPS_QUALIFIERS} setup -B BTrk v1_02_30 -q${MU2E_UPS_QUALIFIERS}:p383b @@ -143,7 +143,7 @@ setup curl v7_64_1 setup cryptopp v08_02_00 -q${MU2E_UPS_QUALIFIERS} # The build system. -setup -B scons v3_1_2 -q +p383b +setup -B scons v3_1_2a -q +p392 # The debugger setup -B gdb v9_2 From 2b20e3aabd560227c827e660a5f2d1aca0c3b9dd Mon Sep 17 00:00:00 2001 From: macndev Date: Wed, 24 Mar 2021 13:39:13 -0500 Subject: [PATCH 02/54] first round of rebase changes changes for compatibility with art v3_08_00, no MADC or pcie yet --- Analyses/src/BFieldPlotter_module.cc | 1 + Analyses/src/CORSIKAGenPlots_module.cc | 1 + Analyses/src/CRYGenPlots_module.cc | 1 + Analyses/src/CaloCalib_module.cc | 1 + Analyses/src/CaloDigiAna_module.cc | 1 + Analyses/src/CaloHitFinderInspect_module.cc | 1 + Analyses/src/CaloTrackMatchExample_module.cc | 1 + Analyses/src/ReadCaloDigi_module.cc | 1 + Analyses/src/ReadStrawHitReco_module.cc | 1 + Analyses/src/SConscript | 1 + Analyses/src/VMMonitor_module.cc | 1 + BFieldTest/src/SConscript | 1 + CRVFilters/src/SConscript | 1 + CRVResponse/src/CrvStepsFromStepPointMCs_module.cc | 1 + CRVResponse/src/SConscript | 1 + CalPatRec/src/SConscript | 1 + CaloCluster/src/SConscript | 1 + CaloDiag/src/SConscript | 1 + CaloFilters/src/SConscript | 1 + CaloMC/src/CaloNoiseSimGenerator.cc | 1 + CaloMC/src/SConscript | 1 + CaloReco/src/CaloTemplateWFProcessor.cc | 1 + CaloReco/src/SConscript | 1 + CommonMC/src/SConscript | 1 + Compression/src/SConscript | 1 + ConditionsService/inc/ConditionsService.hh | 2 +- ConditionsService/src/ConditionsService_service.cc | 2 ++ ConditionsService/src/SConscript | 1 + CosmicReco/src/SConscript | 1 + CutAndCountAnalysis/src/SConscript | 1 + DbService/inc/DbService.hh | 2 +- DbService/src/DbServiceTest_module.cc | 1 + DbService/src/DbService_service.cc | 1 + DbService/src/SConscript | 3 ++- EventDisplay/src/SConscript | 1 + EventGenerator/src/SConscript | 1 + EventMixing/src/SConscript | 1 + ExtinctionMonitorFNAL/Analyses/src/SConscript | 1 + ExtinctionMonitorFNAL/Digitization/src/SConscript | 1 + ExtinctionMonitorFNAL/Reconstruction/src/SConscript | 1 + ExtinctionMonitorFNAL/TruthAlgs/src/SConscript | 1 + ExtinctionMonitorFNAL/Utilities/src/SConscript | 1 + Filters/src/CompressPhysicalVolumes_module.cc | 1 + Filters/src/DetectorStepFilter_module.cc | 1 + Filters/src/EMFBoxHitsFilter_module.cc | 1 + Filters/src/EMFPixelHitsFilter_module.cc | 1 + Filters/src/EMFPixelSimFilter_module.cc | 1 + Filters/src/FilterCosmicsStage1_module.cc | 1 + Filters/src/FilterG4Out_module.cc | 1 + Filters/src/FilterOutEmptyEvents_module.cc | 1 + Filters/src/FilterStatusG4_module.cc | 1 + Filters/src/FilterStepPointAngleVsTarget_module.cc | 1 + Filters/src/FilterStepPointKinEnPDG_module.cc | 1 + Filters/src/FilterStepPointMomentum_module.cc | 1 + Filters/src/FilterStepPointPDG_module.cc | 1 + .../src/FilterStepPointPositionMomentum_module.cc | 1 + Filters/src/FilterStepPointPzVsTarget_module.cc | 1 + Filters/src/FilterStepPointReflection_module.cc | 1 + Filters/src/SConscript | 1 + Filters/src/SelectStepPointsByTime_module.cc | 1 + Filters/src/VetoIncorrectHits_module.cc | 1 + GeneralUtilities/src/SConscript | 1 + GeometryService/inc/GeometryService.hh | 2 +- GeometryService/src/GeometryService_service.cc | 1 + GeometryService/src/SConscript | 1 + GlobalConstantsService/inc/GlobalConstantsService.hh | 2 +- .../src/GlobalConstantsService_service.cc | 1 + GlobalConstantsService/src/SConscript | 1 + HelloWorld/src/SConscript | 1 + Mu2eBTrk/src/SConscript | 1 + Mu2eG4/src/ConstructEnvBox_tool.cc | 1 + Mu2eG4/src/ConstructEnvCalo01_tool.cc | 1 + Mu2eG4/src/ConstructEnvMuCapture_tool.cc | 1 + Mu2eG4/src/ConstructEnvTube_tool.cc | 1 + Mu2eG4/src/ConstructTrackerDetail5.cc | 1 + Mu2eG4/src/HelicalProtonAbsorber.cc | 3 +++ Mu2eG4/src/Mu2eG4Cuts.cc | 1 + Mu2eG4/src/Mu2eG4MTRunManager.cc | 1 + Mu2eG4/src/Mu2eG4MT_module.cc | 3 ++- Mu2eG4/src/Mu2eG4_module.cc | 2 ++ Mu2eG4/src/Mu2eStudyWorld.cc | 1 + Mu2eG4/src/Mu2eUniverse.cc | 1 + Mu2eG4/src/Mu2eWorld.cc | 1 + Mu2eG4/src/SConscript | 1 + Mu2eG4/src/SensitiveDetectorHelper.cc | 1 + Mu2eG4/src/WorldMaker.cc | 2 ++ Mu2eG4/src/constructCRV.cc | 2 ++ Mu2eG4/src/constructDS.cc | 2 ++ Mu2eG4/src/constructDiskCalorimeter.cc | 2 ++ Mu2eG4/src/constructExtMonFNAL.cc | 2 ++ Mu2eG4/src/constructExtMonFNALBuilding.cc | 2 ++ Mu2eG4/src/constructMBS.cc | 3 +++ Mu2eG4/src/constructMSTM.cc | 3 +++ Mu2eG4/src/constructPSEnclosure.cc | 2 ++ Mu2eG4/src/constructPSShield.cc | 2 ++ Mu2eG4/src/constructProtonAbsorber.cc | 1 + Mu2eG4/src/constructProtonBeamDump.cc | 2 ++ Mu2eG4/src/constructSTM.cc | 3 +++ Mu2eG4/src/constructStoppingTarget.cc | 1 + Mu2eG4/src/constructStudyEnv_v001.cc | 3 +++ Mu2eG4/src/constructTS.cc | 1 + Mu2eG4/src/constructTSdA.cc | 3 +++ Mu2eG4/src/constructTargetPS.cc | 3 +++ Mu2eG4/src/constructTrackerv5.cc | 1 + Mu2eG4/src/constructVirtualDetectors.cc | 3 +++ Mu2eG4/src/constructVisualizationRegions.cc | 2 ++ Mu2eG4/src/constructWorldVolume.cc | 3 +++ Mu2eG4/src/finishNesting.cc | 3 +++ Mu2eG4/src/generateFieldMap.cc | 1 + Mu2eG4Helper/inc/Mu2eG4Helper.hh | 2 +- Mu2eG4Helper/src/Mu2eG4Helper_service.cc | 1 + Mu2eG4Helper/src/SConscript | 1 + Mu2eUtilities/src/SConscript | 1 + ParticleID/src/PIDLogL1D.cc | 1 + ParticleID/src/PIDLogLEp.cc | 1 + ParticleID/src/SConscript | 1 + Print/src/SConscript | 1 + ProditionsService/inc/ProditionsService.hh | 2 +- ProditionsService/src/ProditionsService_service.cc | 1 + ProditionsService/src/SConscript | 1 + Sandbox/inc/BarService.hh | 2 +- Sandbox/inc/Bug01Service.hh | 2 +- Sandbox/inc/FooService.hh | 2 +- Sandbox/inc/XBarService.hh | 2 +- Sandbox/src/BarService_service.cc | 1 + Sandbox/src/BarTest_module.cc | 1 + Sandbox/src/Bug01Service_service.cc | 1 + Sandbox/src/FooService_service.cc | 1 + Sandbox/src/FooTest_module.cc | 1 + Sandbox/src/SConscript | 1 + Sandbox/src/XBarService_service.cc | 1 + Sandbox/src/XBarTest_module.cc | 1 + SeedService/inc/SeedService.hh | 2 +- SeedService/src/SConscript | 1 + SeedService/src/SeedService_service.cc | 1 + SimulationConditions/src/SConscript | 1 + SimulationConditions/src/SimBookkeeperCache.cc | 2 ++ Sources/src/SConscript | 1 + TEveEventDisplay/src/SConscript | 4 +++- TrackCaloMatching/src/SConscript | 1 + TrackerAlignment/src/AlignTrackCollector_module.cc | 1 + TrackerAlignment/src/SConscript | 1 + TrackerConditions/src/SConscript | 1 + TrackerMC/src/MakeStrawGasSteps_module.cc | 1 + TrackerMC/src/SConscript | 1 + TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc | 1 + Trigger/src/SConscript | 1 + TrkDiag/src/SConscript | 1 + TrkExt/src/SConscript | 1 + TrkFilters/src/SConscript | 1 + TrkHitReco/src/SConscript | 1 + TrkHitReco/src/StrawHitReco_module.cc | 2 +- TrkPatRec/src/SConscript | 1 + TrkPatRec/src/TimeAndPhiClusterFinder_module.cc | 2 +- TrkReco/src/SConscript | 1 + UtilityModules/src/SConscript | 1 + Validation/src/SConscript | 1 + scripts/build/python/sconstruct_helper.py | 12 ++++++------ setup.sh | 4 ++-- 159 files changed, 202 insertions(+), 24 deletions(-) diff --git a/Analyses/src/BFieldPlotter_module.cc b/Analyses/src/BFieldPlotter_module.cc index 7e7b9c7f21..17d6674db1 100644 --- a/Analyses/src/BFieldPlotter_module.cc +++ b/Analyses/src/BFieldPlotter_module.cc @@ -14,6 +14,7 @@ #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" #include "art_root_io/TFileService.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // ROOT includes #include "TFile.h" diff --git a/Analyses/src/CORSIKAGenPlots_module.cc b/Analyses/src/CORSIKAGenPlots_module.cc index 33bcaa2edb..85cb776ac5 100644 --- a/Analyses/src/CORSIKAGenPlots_module.cc +++ b/Analyses/src/CORSIKAGenPlots_module.cc @@ -15,6 +15,7 @@ #include "art/Framework/Principal/SubRun.h" #include "art_root_io/TFileService.h" #include "art/Framework/Services/Registry/ServiceHandle.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "canvas/Utilities/InputTag.h" #include "fhiclcpp/ParameterSet.h" diff --git a/Analyses/src/CRYGenPlots_module.cc b/Analyses/src/CRYGenPlots_module.cc index d8ced9cd40..fd1f380e26 100644 --- a/Analyses/src/CRYGenPlots_module.cc +++ b/Analyses/src/CRYGenPlots_module.cc @@ -15,6 +15,7 @@ #include "art/Framework/Principal/SubRun.h" #include "art_root_io/TFileService.h" #include "art/Framework/Services/Registry/ServiceHandle.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "canvas/Utilities/InputTag.h" #include "fhiclcpp/ParameterSet.h" diff --git a/Analyses/src/CaloCalib_module.cc b/Analyses/src/CaloCalib_module.cc index 73c77294ee..26dd579306 100644 --- a/Analyses/src/CaloCalib_module.cc +++ b/Analyses/src/CaloCalib_module.cc @@ -36,6 +36,7 @@ #include "art/Framework/Principal/Handle.h" #include "art/Framework/Principal/Selector.h" #include "art/Framework/Principal/Provenance.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "cetlib_except/exception.h" #include "fhiclcpp/ParameterSet.h" #include "messagefacility/MessageLogger/MessageLogger.h" diff --git a/Analyses/src/CaloDigiAna_module.cc b/Analyses/src/CaloDigiAna_module.cc index 4b5e4b6fc2..e6982ce514 100644 --- a/Analyses/src/CaloDigiAna_module.cc +++ b/Analyses/src/CaloDigiAna_module.cc @@ -22,6 +22,7 @@ #include "art_root_io/TFileDirectory.h" #include "messagefacility/MessageLogger/MessageLogger.h" #include "art/Framework/Services/Optional/RandomNumberGenerator.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes. #include "CalorimeterGeom/inc/Calorimeter.hh" diff --git a/Analyses/src/CaloHitFinderInspect_module.cc b/Analyses/src/CaloHitFinderInspect_module.cc index 9a364caf11..06ec872c2f 100644 --- a/Analyses/src/CaloHitFinderInspect_module.cc +++ b/Analyses/src/CaloHitFinderInspect_module.cc @@ -11,6 +11,7 @@ #include "art/Framework/Principal/Handle.h" #include "art/Framework/Principal/Selector.h" #include "art/Framework/Principal/Provenance.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "cetlib_except/exception.h" #include "fhiclcpp/ParameterSet.h" #include "messagefacility/MessageLogger/MessageLogger.h" diff --git a/Analyses/src/CaloTrackMatchExample_module.cc b/Analyses/src/CaloTrackMatchExample_module.cc index 94ba3018c1..947b3dd11a 100644 --- a/Analyses/src/CaloTrackMatchExample_module.cc +++ b/Analyses/src/CaloTrackMatchExample_module.cc @@ -35,6 +35,7 @@ #include "art/Framework/Principal/Handle.h" #include "art/Framework/Principal/Selector.h" #include "art/Framework/Principal/Provenance.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "cetlib_except/exception.h" #include "fhiclcpp/ParameterSet.h" #include "messagefacility/MessageLogger/MessageLogger.h" diff --git a/Analyses/src/ReadCaloDigi_module.cc b/Analyses/src/ReadCaloDigi_module.cc index 186caa2359..320b80787b 100644 --- a/Analyses/src/ReadCaloDigi_module.cc +++ b/Analyses/src/ReadCaloDigi_module.cc @@ -26,6 +26,7 @@ #include "art_root_io/TFileDirectory.h" #include "messagefacility/MessageLogger/MessageLogger.h" #include "art/Framework/Services/Optional/RandomNumberGenerator.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes. #include "CalorimeterGeom/inc/Calorimeter.hh" diff --git a/Analyses/src/ReadStrawHitReco_module.cc b/Analyses/src/ReadStrawHitReco_module.cc index c3a4f651cd..90c850f493 100644 --- a/Analyses/src/ReadStrawHitReco_module.cc +++ b/Analyses/src/ReadStrawHitReco_module.cc @@ -21,6 +21,7 @@ #include "art/Framework/Services/Registry/ServiceHandle.h" #include "art_root_io/TFileService.h" #include "art/Framework/Principal/Provenance.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "fhiclcpp/ParameterSet.h" diff --git a/Analyses/src/SConscript b/Analyses/src/SConscript index e6ea54d1f3..d843701463 100644 --- a/Analyses/src/SConscript +++ b/Analyses/src/SConscript @@ -57,6 +57,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Analyses/src/VMMonitor_module.cc b/Analyses/src/VMMonitor_module.cc index 5379275cf7..34056780a3 100644 --- a/Analyses/src/VMMonitor_module.cc +++ b/Analyses/src/VMMonitor_module.cc @@ -13,6 +13,7 @@ #include "art/Framework/Core/EDAnalyzer.h" #include "art/Framework/Core/ModuleMacros.h" +#include "art/Framework/Principal/Event.h" namespace mu2e { diff --git a/BFieldTest/src/SConscript b/BFieldTest/src/SConscript index f107037dec..b0873a0bd3 100644 --- a/BFieldTest/src/SConscript +++ b/BFieldTest/src/SConscript @@ -27,6 +27,7 @@ helper.make_plugins( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CRVFilters/src/SConscript b/CRVFilters/src/SConscript index d6b0a3fb93..2a446e2cc5 100644 --- a/CRVFilters/src/SConscript +++ b/CRVFilters/src/SConscript @@ -21,6 +21,7 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/CRVResponse/src/CrvStepsFromStepPointMCs_module.cc b/CRVResponse/src/CrvStepsFromStepPointMCs_module.cc index 7cb387e19f..b4a43d875c 100644 --- a/CRVResponse/src/CrvStepsFromStepPointMCs_module.cc +++ b/CRVResponse/src/CrvStepsFromStepPointMCs_module.cc @@ -12,6 +12,7 @@ #include "fhiclcpp/types/Atom.h" #include "fhiclcpp/types/Sequence.h" #include "canvas/Utilities/InputTag.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "CLHEP/Units/GlobalPhysicalConstants.h" #include "GeometryService/inc/GeomHandle.hh" diff --git a/CRVResponse/src/SConscript b/CRVResponse/src/SConscript index 93fa9740b4..bb3b46cccb 100644 --- a/CRVResponse/src/SConscript +++ b/CRVResponse/src/SConscript @@ -54,6 +54,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CalPatRec/src/SConscript b/CalPatRec/src/SConscript index a23ffa3373..e704ba6da2 100644 --- a/CalPatRec/src/SConscript +++ b/CalPatRec/src/SConscript @@ -46,6 +46,7 @@ mainlib = helper.make_mainlib( [ 'mu2e_TrkDiag', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/CaloCluster/src/SConscript b/CaloCluster/src/SConscript index 9740b3ec6d..d48bc2a362 100644 --- a/CaloCluster/src/SConscript +++ b/CaloCluster/src/SConscript @@ -37,6 +37,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Framework_Core', 'art_Utilities', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CaloDiag/src/SConscript b/CaloDiag/src/SConscript index e6ea54d1f3..d843701463 100644 --- a/CaloDiag/src/SConscript +++ b/CaloDiag/src/SConscript @@ -57,6 +57,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CaloFilters/src/SConscript b/CaloFilters/src/SConscript index 0fbb9187f4..bcf1564555 100644 --- a/CaloFilters/src/SConscript +++ b/CaloFilters/src/SConscript @@ -54,6 +54,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CaloMC/src/CaloNoiseSimGenerator.cc b/CaloMC/src/CaloNoiseSimGenerator.cc index d6f4c50324..2f9240e6d9 100644 --- a/CaloMC/src/CaloNoiseSimGenerator.cc +++ b/CaloMC/src/CaloNoiseSimGenerator.cc @@ -15,6 +15,7 @@ #include #include #include +#include diff --git a/CaloMC/src/SConscript b/CaloMC/src/SConscript index 9ba121d6a7..c7cb2f62d8 100644 --- a/CaloMC/src/SConscript +++ b/CaloMC/src/SConscript @@ -39,6 +39,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Framework_Principal', 'art_Framework_Core', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CaloReco/src/CaloTemplateWFProcessor.cc b/CaloReco/src/CaloTemplateWFProcessor.cc index dbe1b80ffd..0397b2fa6e 100644 --- a/CaloReco/src/CaloTemplateWFProcessor.cc +++ b/CaloReco/src/CaloTemplateWFProcessor.cc @@ -11,6 +11,7 @@ #include #include #include +#include namespace mu2e { diff --git a/CaloReco/src/SConscript b/CaloReco/src/SConscript index de48db7abe..8d20178ce4 100644 --- a/CaloReco/src/SConscript +++ b/CaloReco/src/SConscript @@ -33,6 +33,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Framework_Core', 'art_Utilities', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CommonMC/src/SConscript b/CommonMC/src/SConscript index 6e2f982b98..5f9bbddeb0 100644 --- a/CommonMC/src/SConscript +++ b/CommonMC/src/SConscript @@ -38,6 +38,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_TrackerConditions', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Compression/src/SConscript b/Compression/src/SConscript index f143c41aa8..922c16cbed 100644 --- a/Compression/src/SConscript +++ b/Compression/src/SConscript @@ -39,6 +39,7 @@ helper.make_plugins( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/ConditionsService/inc/ConditionsService.hh b/ConditionsService/inc/ConditionsService.hh index 783f4909d2..bb3cc5edfc 100644 --- a/ConditionsService/inc/ConditionsService.hh +++ b/ConditionsService/inc/ConditionsService.hh @@ -23,7 +23,7 @@ #include "fhiclcpp/ParameterSet.h" #include "art/Framework/Services/Registry/ActivityRegistry.h" #include "art/Framework/Services/Registry/ServiceHandle.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" #include "cetlib_except/exception.h" // Mu2e include files. diff --git a/ConditionsService/src/ConditionsService_service.cc b/ConditionsService/src/ConditionsService_service.cc index 0422c1bc68..6f6fd5d849 100644 --- a/ConditionsService/src/ConditionsService_service.cc +++ b/ConditionsService/src/ConditionsService_service.cc @@ -11,6 +11,7 @@ // Framework include files #include "messagefacility/MessageLogger/MessageLogger.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e include files #include "ConditionsService/inc/ConditionsService.hh" @@ -105,3 +106,4 @@ namespace mu2e { } // end namespace mu2e DEFINE_ART_SERVICE(mu2e::ConditionsService); + diff --git a/ConditionsService/src/SConscript b/ConditionsService/src/SConscript index 59668de654..ac1d77423b 100644 --- a/ConditionsService/src/SConscript +++ b/ConditionsService/src/SConscript @@ -36,6 +36,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'canvas', 'cetlib', 'cetlib_except', diff --git a/CosmicReco/src/SConscript b/CosmicReco/src/SConscript index 068ded82a2..0b214a9652 100644 --- a/CosmicReco/src/SConscript +++ b/CosmicReco/src/SConscript @@ -41,6 +41,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/CutAndCountAnalysis/src/SConscript b/CutAndCountAnalysis/src/SConscript index b01c16aed8..13cdb00bf7 100644 --- a/CutAndCountAnalysis/src/SConscript +++ b/CutAndCountAnalysis/src/SConscript @@ -50,6 +50,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/DbService/inc/DbService.hh b/DbService/inc/DbService.hh index 76d56c1336..b5596d9791 100644 --- a/DbService/inc/DbService.hh +++ b/DbService/inc/DbService.hh @@ -9,7 +9,7 @@ #include "fhiclcpp/types/OptionalSequence.h" #include "art/Framework/Services/Registry/ServiceTable.h" #include "art/Framework/Services/Registry/ActivityRegistry.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" #include "cetlib_except/exception.h" #include "DbService/inc/DbEngine.hh" diff --git a/DbService/src/DbServiceTest_module.cc b/DbService/src/DbServiceTest_module.cc index d6d2daf511..4402735bee 100644 --- a/DbService/src/DbServiceTest_module.cc +++ b/DbService/src/DbServiceTest_module.cc @@ -13,6 +13,7 @@ #include "art/Framework/Core/ModuleMacros.h" #include "art/Framework/Principal/Handle.h" //#include "art/Framework/Services/Optional/TFileService.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "fhiclcpp/ParameterSet.h" #include "DbService/inc/DbHandle.hh" diff --git a/DbService/src/DbService_service.cc b/DbService/src/DbService_service.cc index 1d311417ec..e3813c6b19 100644 --- a/DbService/src/DbService_service.cc +++ b/DbService/src/DbService_service.cc @@ -3,6 +3,7 @@ #include "DbService/inc/DbIdList.hh" #include "DbTables/inc/DbUtil.hh" #include "ConfigTools/inc/ConfigFileLookupPolicy.hh" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" namespace mu2e { diff --git a/DbService/src/SConscript b/DbService/src/SConscript index 3aed6b0320..030cfff554 100644 --- a/DbService/src/SConscript +++ b/DbService/src/SConscript @@ -35,7 +35,8 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'MF_MessageLogger', - 'fhiclcpp', + 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'boost_filesystem', diff --git a/EventDisplay/src/SConscript b/EventDisplay/src/SConscript index e3ce1ba408..f62a4133ff 100644 --- a/EventDisplay/src/SConscript +++ b/EventDisplay/src/SConscript @@ -44,6 +44,7 @@ userlibs = [ rootlibs, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/EventGenerator/src/SConscript b/EventGenerator/src/SConscript index 84d0f70314..a49495f4a5 100644 --- a/EventGenerator/src/SConscript +++ b/EventGenerator/src/SConscript @@ -44,6 +44,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'CRY', 'fhiclcpp', + 'fhiclcpp_types', 'MF_MessageLogger', 'cetlib', 'cetlib_except', diff --git a/EventMixing/src/SConscript b/EventMixing/src/SConscript index d071f808f4..388215805d 100644 --- a/EventMixing/src/SConscript +++ b/EventMixing/src/SConscript @@ -28,6 +28,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'hep_concurrency', diff --git a/ExtinctionMonitorFNAL/Analyses/src/SConscript b/ExtinctionMonitorFNAL/Analyses/src/SConscript index 01a94e7647..05905aabf2 100644 --- a/ExtinctionMonitorFNAL/Analyses/src/SConscript +++ b/ExtinctionMonitorFNAL/Analyses/src/SConscript @@ -57,6 +57,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/ExtinctionMonitorFNAL/Digitization/src/SConscript b/ExtinctionMonitorFNAL/Digitization/src/SConscript index 98515ca578..0e654fb84b 100644 --- a/ExtinctionMonitorFNAL/Digitization/src/SConscript +++ b/ExtinctionMonitorFNAL/Digitization/src/SConscript @@ -29,6 +29,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/ExtinctionMonitorFNAL/Reconstruction/src/SConscript b/ExtinctionMonitorFNAL/Reconstruction/src/SConscript index 7ef9f32506..e418f1737b 100644 --- a/ExtinctionMonitorFNAL/Reconstruction/src/SConscript +++ b/ExtinctionMonitorFNAL/Reconstruction/src/SConscript @@ -31,6 +31,7 @@ helper.make_plugins( [ mainlib, my_libs, 'art_Framework_Core', 'art_Framework_Principal', 'fhiclcpp', + 'fhiclcpp_types', 'boost_filesystem', 'boost_system', 'Hist', diff --git a/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript b/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript index 18b7cc077f..511b149451 100644 --- a/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript +++ b/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript @@ -21,6 +21,7 @@ helper.make_plugins ( [ 'mu2e_Mu2eUtilities', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/ExtinctionMonitorFNAL/Utilities/src/SConscript b/ExtinctionMonitorFNAL/Utilities/src/SConscript index 4d402ba7af..c48c89ea52 100644 --- a/ExtinctionMonitorFNAL/Utilities/src/SConscript +++ b/ExtinctionMonitorFNAL/Utilities/src/SConscript @@ -19,6 +19,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ExtinctionMonitorFNAL_Geometry', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Filters/src/CompressPhysicalVolumes_module.cc b/Filters/src/CompressPhysicalVolumes_module.cc index 0e294c1618..cb3bfd856f 100644 --- a/Filters/src/CompressPhysicalVolumes_module.cc +++ b/Filters/src/CompressPhysicalVolumes_module.cc @@ -16,6 +16,7 @@ #include "art/Framework/Principal/Event.h" #include "art/Framework/Principal/SubRun.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" #include "Mu2eUtilities/inc/SimParticleParentGetter.hh" diff --git a/Filters/src/DetectorStepFilter_module.cc b/Filters/src/DetectorStepFilter_module.cc index ece682ca2d..1b7e3fdb0f 100644 --- a/Filters/src/DetectorStepFilter_module.cc +++ b/Filters/src/DetectorStepFilter_module.cc @@ -13,6 +13,7 @@ #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" #include "DataProducts/inc/PDGCode.hh" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StrawGasStep.hh" #include "MCDataProducts/inc/CaloShowerStep.hh" diff --git a/Filters/src/EMFBoxHitsFilter_module.cc b/Filters/src/EMFBoxHitsFilter_module.cc index 9b77a4e991..96c4821365 100644 --- a/Filters/src/EMFBoxHitsFilter_module.cc +++ b/Filters/src/EMFBoxHitsFilter_module.cc @@ -18,6 +18,7 @@ #include "art/Framework/Core/ModuleMacros.h" #include "canvas/Persistency/Common/FindManyP.h" #include "art_root_io/TFileService.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "RecoDataProducts/inc/ExtMonFNALRawHitCollection.hh" #include "MCDataProducts/inc/ExtMonFNALHitTruthAssn.hh" diff --git a/Filters/src/EMFPixelHitsFilter_module.cc b/Filters/src/EMFPixelHitsFilter_module.cc index ead00c7854..e9d8f2306d 100644 --- a/Filters/src/EMFPixelHitsFilter_module.cc +++ b/Filters/src/EMFPixelHitsFilter_module.cc @@ -15,6 +15,7 @@ #include "art/Framework/Core/ModuleMacros.h" #include "canvas/Persistency/Common/FindManyP.h" #include "art_root_io/TFileService.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "RecoDataProducts/inc/ExtMonFNALRawHitCollection.hh" #include "MCDataProducts/inc/ExtMonFNALHitTruthAssn.hh" diff --git a/Filters/src/EMFPixelSimFilter_module.cc b/Filters/src/EMFPixelSimFilter_module.cc index c640f1c5c5..611a1c96c1 100644 --- a/Filters/src/EMFPixelSimFilter_module.cc +++ b/Filters/src/EMFPixelSimFilter_module.cc @@ -15,6 +15,7 @@ #include "art/Framework/Core/ModuleMacros.h" #include "canvas/Persistency/Common/FindManyP.h" #include "art_root_io/TFileService.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/ExtMonFNALSimHitCollection.hh" diff --git a/Filters/src/FilterCosmicsStage1_module.cc b/Filters/src/FilterCosmicsStage1_module.cc index 40f22fc463..e70f16fb75 100644 --- a/Filters/src/FilterCosmicsStage1_module.cc +++ b/Filters/src/FilterCosmicsStage1_module.cc @@ -13,6 +13,7 @@ #include "art/Framework/Principal/Run.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" diff --git a/Filters/src/FilterG4Out_module.cc b/Filters/src/FilterG4Out_module.cc index b6e9e16c15..9f9b7ffa10 100644 --- a/Filters/src/FilterG4Out_module.cc +++ b/Filters/src/FilterG4Out_module.cc @@ -33,6 +33,7 @@ // art includes. #include "fhiclcpp/types/OptionalSequence.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "art/Framework/Core/EDFilter.h" #include "art/Framework/Principal/Event.h" diff --git a/Filters/src/FilterOutEmptyEvents_module.cc b/Filters/src/FilterOutEmptyEvents_module.cc index 6da5527b74..8a71669368 100644 --- a/Filters/src/FilterOutEmptyEvents_module.cc +++ b/Filters/src/FilterOutEmptyEvents_module.cc @@ -15,6 +15,7 @@ #include "art/Framework/Principal/Run.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StatusG4.hh" using namespace std; diff --git a/Filters/src/FilterStatusG4_module.cc b/Filters/src/FilterStatusG4_module.cc index d845e7b748..2c8772ba20 100644 --- a/Filters/src/FilterStatusG4_module.cc +++ b/Filters/src/FilterStatusG4_module.cc @@ -14,6 +14,7 @@ #include "art/Framework/Principal/Run.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StatusG4.hh" namespace mu2e { diff --git a/Filters/src/FilterStepPointAngleVsTarget_module.cc b/Filters/src/FilterStepPointAngleVsTarget_module.cc index c6d666a351..d2b158a946 100644 --- a/Filters/src/FilterStepPointAngleVsTarget_module.cc +++ b/Filters/src/FilterStepPointAngleVsTarget_module.cc @@ -17,6 +17,7 @@ #include "art/Framework/Principal/Event.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" #include "MCDataProducts/inc/SimParticle.hh" diff --git a/Filters/src/FilterStepPointKinEnPDG_module.cc b/Filters/src/FilterStepPointKinEnPDG_module.cc index b1beb3e5b1..e8436b0d71 100644 --- a/Filters/src/FilterStepPointKinEnPDG_module.cc +++ b/Filters/src/FilterStepPointKinEnPDG_module.cc @@ -13,6 +13,7 @@ #include "art/Framework/Principal/Run.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" #include "GlobalConstantsService/inc/GlobalConstantsHandle.hh" diff --git a/Filters/src/FilterStepPointMomentum_module.cc b/Filters/src/FilterStepPointMomentum_module.cc index dec963e486..b92ce8df97 100644 --- a/Filters/src/FilterStepPointMomentum_module.cc +++ b/Filters/src/FilterStepPointMomentum_module.cc @@ -13,6 +13,7 @@ #include "art/Framework/Principal/Run.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" diff --git a/Filters/src/FilterStepPointPDG_module.cc b/Filters/src/FilterStepPointPDG_module.cc index fb438603d3..da8426dc82 100644 --- a/Filters/src/FilterStepPointPDG_module.cc +++ b/Filters/src/FilterStepPointPDG_module.cc @@ -16,6 +16,7 @@ #include "art/Framework/Principal/Event.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" #include "MCDataProducts/inc/SimParticle.hh" diff --git a/Filters/src/FilterStepPointPositionMomentum_module.cc b/Filters/src/FilterStepPointPositionMomentum_module.cc index e91f52c285..9a72fe8df3 100644 --- a/Filters/src/FilterStepPointPositionMomentum_module.cc +++ b/Filters/src/FilterStepPointPositionMomentum_module.cc @@ -16,6 +16,7 @@ #include "art/Framework/Principal/Event.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" #include "MCDataProducts/inc/SimParticle.hh" diff --git a/Filters/src/FilterStepPointPzVsTarget_module.cc b/Filters/src/FilterStepPointPzVsTarget_module.cc index c21e5f48fc..9fbb2bb2bc 100644 --- a/Filters/src/FilterStepPointPzVsTarget_module.cc +++ b/Filters/src/FilterStepPointPzVsTarget_module.cc @@ -17,6 +17,7 @@ #include "art/Framework/Principal/Event.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" #include "MCDataProducts/inc/SimParticle.hh" diff --git a/Filters/src/FilterStepPointReflection_module.cc b/Filters/src/FilterStepPointReflection_module.cc index bde7663ff8..35aff55926 100644 --- a/Filters/src/FilterStepPointReflection_module.cc +++ b/Filters/src/FilterStepPointReflection_module.cc @@ -16,6 +16,7 @@ #include "art/Framework/Principal/Handle.h" #include "canvas/Utilities/InputTag.h" #include "art/Framework/Core/ModuleMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" #include "DataProducts/inc/VirtualDetectorId.hh" diff --git a/Filters/src/SConscript b/Filters/src/SConscript index de930b2787..cb255c7d45 100644 --- a/Filters/src/SConscript +++ b/Filters/src/SConscript @@ -44,6 +44,7 @@ helper.make_plugins( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Filters/src/SelectStepPointsByTime_module.cc b/Filters/src/SelectStepPointsByTime_module.cc index 5242cad5fb..b156cbec20 100644 --- a/Filters/src/SelectStepPointsByTime_module.cc +++ b/Filters/src/SelectStepPointsByTime_module.cc @@ -18,6 +18,7 @@ #include "art/Framework/Principal/Handle.h" #include "art/Framework/Core/ModuleMacros.h" #include "canvas/Utilities/InputTag.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/StepPointMC.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" diff --git a/Filters/src/VetoIncorrectHits_module.cc b/Filters/src/VetoIncorrectHits_module.cc index 4e609d0159..d7e4e0f616 100644 --- a/Filters/src/VetoIncorrectHits_module.cc +++ b/Filters/src/VetoIncorrectHits_module.cc @@ -14,6 +14,7 @@ #include "art/Framework/Core/ModuleMacros.h" #include "CLHEP/Units/SystemOfUnits.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "Mu2eUtilities/inc/TwoLinePCA.hh" #include "TrackerGeom/inc/Tracker.hh" #include "MCDataProducts/inc/StepPointMCCollection.hh" diff --git a/GeneralUtilities/src/SConscript b/GeneralUtilities/src/SConscript index 1e0dc3e2d3..1ca9256a06 100644 --- a/GeneralUtilities/src/SConscript +++ b/GeneralUtilities/src/SConscript @@ -15,6 +15,7 @@ mainlib = helper.make_mainlib ( [ 'art_Persistency_Common', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/GeometryService/inc/GeometryService.hh b/GeometryService/inc/GeometryService.hh index e61106f471..ac279e5e2a 100644 --- a/GeometryService/inc/GeometryService.hh +++ b/GeometryService/inc/GeometryService.hh @@ -15,7 +15,7 @@ #include "fhiclcpp/ParameterSet.h" #include "art/Framework/Services/Registry/ActivityRegistry.h" #include "art/Framework/Services/Registry/ServiceHandle.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" #include "cetlib_except/exception.h" #include "ConfigTools/inc/SimpleConfig.hh" diff --git a/GeometryService/src/GeometryService_service.cc b/GeometryService/src/GeometryService_service.cc index 5915092314..04f0a199d5 100644 --- a/GeometryService/src/GeometryService_service.cc +++ b/GeometryService/src/GeometryService_service.cc @@ -11,6 +11,7 @@ // Framework include files #include "art/Persistency/Provenance/ModuleDescription.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "canvas/Persistency/Provenance/EventID.h" #include "canvas/Persistency/Provenance/Timestamp.h" #include "canvas/Persistency/Provenance/SubRunID.h" diff --git a/GeometryService/src/SConscript b/GeometryService/src/SConscript index 92d98176fb..514c888cd8 100644 --- a/GeometryService/src/SConscript +++ b/GeometryService/src/SConscript @@ -40,6 +40,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/GlobalConstantsService/inc/GlobalConstantsService.hh b/GlobalConstantsService/inc/GlobalConstantsService.hh index d6fc034413..ff4607f8cd 100644 --- a/GlobalConstantsService/inc/GlobalConstantsService.hh +++ b/GlobalConstantsService/inc/GlobalConstantsService.hh @@ -10,7 +10,7 @@ #include "fhiclcpp/ParameterSet.h" #include "art/Framework/Services/Registry/ActivityRegistry.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" #include "ConfigTools/inc/SimpleConfig.hh" #include "Mu2eInterfaces/inc/ConditionsEntity.hh" diff --git a/GlobalConstantsService/src/GlobalConstantsService_service.cc b/GlobalConstantsService/src/GlobalConstantsService_service.cc index d82178737c..b25c265fc5 100644 --- a/GlobalConstantsService/src/GlobalConstantsService_service.cc +++ b/GlobalConstantsService/src/GlobalConstantsService_service.cc @@ -2,6 +2,7 @@ // Need to have the main implementation in GlobalConstantsService.so // so that the link of GeomHandle will have no undefined references. // +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "GlobalConstantsService/inc/GlobalConstantsService.hh" DEFINE_ART_SERVICE(mu2e::GlobalConstantsService); diff --git a/GlobalConstantsService/src/SConscript b/GlobalConstantsService/src/SConscript index fad4d7e9e6..c89b8965e8 100644 --- a/GlobalConstantsService/src/SConscript +++ b/GlobalConstantsService/src/SConscript @@ -20,6 +20,7 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Services_Registry', 'HepPID', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/HelloWorld/src/SConscript b/HelloWorld/src/SConscript index 95903f9865..c450836fec 100644 --- a/HelloWorld/src/SConscript +++ b/HelloWorld/src/SConscript @@ -22,6 +22,7 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'boost_filesystem', diff --git a/Mu2eBTrk/src/SConscript b/Mu2eBTrk/src/SConscript index 4da29e2f52..1ef37ac71b 100644 --- a/Mu2eBTrk/src/SConscript +++ b/Mu2eBTrk/src/SConscript @@ -32,6 +32,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/Mu2eG4/src/ConstructEnvBox_tool.cc b/Mu2eG4/src/ConstructEnvBox_tool.cc index 5aa815fbf1..cc7c5b07c7 100644 --- a/Mu2eG4/src/ConstructEnvBox_tool.cc +++ b/Mu2eG4/src/ConstructEnvBox_tool.cc @@ -11,6 +11,7 @@ // #include "art/Utilities/ToolMacros.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes. diff --git a/Mu2eG4/src/ConstructEnvCalo01_tool.cc b/Mu2eG4/src/ConstructEnvCalo01_tool.cc index ed6bdaf4b0..fb75391770 100644 --- a/Mu2eG4/src/ConstructEnvCalo01_tool.cc +++ b/Mu2eG4/src/ConstructEnvCalo01_tool.cc @@ -11,6 +11,7 @@ // #include "art/Utilities/ToolMacros.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes. diff --git a/Mu2eG4/src/ConstructEnvMuCapture_tool.cc b/Mu2eG4/src/ConstructEnvMuCapture_tool.cc index e42bae244b..3d1b15e2dc 100644 --- a/Mu2eG4/src/ConstructEnvMuCapture_tool.cc +++ b/Mu2eG4/src/ConstructEnvMuCapture_tool.cc @@ -11,6 +11,7 @@ // #include "art/Utilities/ToolMacros.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes. diff --git a/Mu2eG4/src/ConstructEnvTube_tool.cc b/Mu2eG4/src/ConstructEnvTube_tool.cc index 1e7031df00..a7e4c22f7b 100644 --- a/Mu2eG4/src/ConstructEnvTube_tool.cc +++ b/Mu2eG4/src/ConstructEnvTube_tool.cc @@ -11,6 +11,7 @@ // #include "art/Utilities/ToolMacros.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes. diff --git a/Mu2eG4/src/ConstructTrackerDetail5.cc b/Mu2eG4/src/ConstructTrackerDetail5.cc index ca736c86e8..1689ff60dc 100644 --- a/Mu2eG4/src/ConstructTrackerDetail5.cc +++ b/Mu2eG4/src/ConstructTrackerDetail5.cc @@ -7,6 +7,7 @@ // David Norvil Brown (Louisville), November 2017 // +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "ConfigTools/inc/SimpleConfig.hh" #include "Mu2eG4Helper/inc/Mu2eG4Helper.hh" #include "GeometryService/inc/GeomHandle.hh" diff --git a/Mu2eG4/src/HelicalProtonAbsorber.cc b/Mu2eG4/src/HelicalProtonAbsorber.cc index ecbc1da7f7..3d3a14f6ee 100644 --- a/Mu2eG4/src/HelicalProtonAbsorber.cc +++ b/Mu2eG4/src/HelicalProtonAbsorber.cc @@ -8,6 +8,9 @@ // Notes: // Construct the Helical Proton Absorber +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + // C++ includes #include diff --git a/Mu2eG4/src/Mu2eG4Cuts.cc b/Mu2eG4/src/Mu2eG4Cuts.cc index f1d49528f9..fdedf8d1fb 100644 --- a/Mu2eG4/src/Mu2eG4Cuts.cc +++ b/Mu2eG4/src/Mu2eG4Cuts.cc @@ -5,6 +5,7 @@ #include #include #include +#include #include "cetlib_except/exception.h" #include "fhiclcpp/ParameterSet.h" diff --git a/Mu2eG4/src/Mu2eG4MTRunManager.cc b/Mu2eG4/src/Mu2eG4MTRunManager.cc index 2612f622da..5e10de77d6 100644 --- a/Mu2eG4/src/Mu2eG4MTRunManager.cc +++ b/Mu2eG4/src/Mu2eG4MTRunManager.cc @@ -11,6 +11,7 @@ //Framework includes #include "cetlib_except/exception.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" //Mu2e includes #include "Mu2eG4/inc/Mu2eG4MTRunManager.hh" diff --git a/Mu2eG4/src/Mu2eG4MT_module.cc b/Mu2eG4/src/Mu2eG4MT_module.cc index fa69cc1122..4a626f9004 100644 --- a/Mu2eG4/src/Mu2eG4MT_module.cc +++ b/Mu2eG4/src/Mu2eG4MT_module.cc @@ -43,6 +43,7 @@ #include "art/Framework/Services/Registry/ServiceHandle.h" #include "canvas/Utilities/InputTag.h" #include "art/Utilities/Globals.h" +#include "messagefacility/MessageLogger/MessageLogger.h" // Geant4 includes #include "Geant4/G4Run.hh" @@ -71,7 +72,7 @@ namespace { namespace tbb { template<> - struct tbb_hash_compare { + struct tbb::detail::d1::tbb_hash_compare { tbb_hash_compare() {} static size_t hash(std::thread::id tid) { std::ostringstream oss; diff --git a/Mu2eG4/src/Mu2eG4_module.cc b/Mu2eG4/src/Mu2eG4_module.cc index 9aaa90b0b8..ee1adda40e 100644 --- a/Mu2eG4/src/Mu2eG4_module.cc +++ b/Mu2eG4/src/Mu2eG4_module.cc @@ -7,6 +7,8 @@ // Mu2e includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "MCDataProducts/inc/GenParticleCollection.hh" #include "Mu2eHallGeom/inc/Mu2eHall.hh" #include "Mu2eG4/inc/WorldMaker.hh" diff --git a/Mu2eG4/src/Mu2eStudyWorld.cc b/Mu2eG4/src/Mu2eStudyWorld.cc index c2589496e8..1cb7b83aec 100644 --- a/Mu2eG4/src/Mu2eStudyWorld.cc +++ b/Mu2eG4/src/Mu2eStudyWorld.cc @@ -18,6 +18,7 @@ #include "messagefacility/MessageLogger/MessageLogger.h" #include "cetlib_except/exception.h" #include "art/Utilities/make_tool.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes #include "Mu2eG4Helper/inc/Mu2eG4Helper.hh" diff --git a/Mu2eG4/src/Mu2eUniverse.cc b/Mu2eG4/src/Mu2eUniverse.cc index 01c31e0ede..0d1166545d 100644 --- a/Mu2eG4/src/Mu2eUniverse.cc +++ b/Mu2eG4/src/Mu2eUniverse.cc @@ -14,6 +14,7 @@ // Framework includes #include "art/Framework/Services/Registry/ServiceHandle.h" #include "cetlib_except/exception.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes #include "Mu2eG4Helper/inc/Mu2eG4Helper.hh" diff --git a/Mu2eG4/src/Mu2eWorld.cc b/Mu2eG4/src/Mu2eWorld.cc index 6cb19ec49d..e38541db39 100644 --- a/Mu2eG4/src/Mu2eWorld.cc +++ b/Mu2eG4/src/Mu2eWorld.cc @@ -27,6 +27,7 @@ // Framework includes #include "messagefacility/MessageLogger/MessageLogger.h" #include "cetlib_except/exception.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes #include "ConfigTools/inc/checkForStale.hh" diff --git a/Mu2eG4/src/SConscript b/Mu2eG4/src/SConscript index d434c381e7..d09de67a56 100644 --- a/Mu2eG4/src/SConscript +++ b/Mu2eG4/src/SConscript @@ -252,6 +252,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'MF_MessageLogger', 'cetlib', 'cetlib_except', diff --git a/Mu2eG4/src/SensitiveDetectorHelper.cc b/Mu2eG4/src/SensitiveDetectorHelper.cc index 5db4bbe0f2..5e8b2cebf2 100644 --- a/Mu2eG4/src/SensitiveDetectorHelper.cc +++ b/Mu2eG4/src/SensitiveDetectorHelper.cc @@ -31,6 +31,7 @@ #include "art/Framework/Principal/Event.h" #include "art/Framework/Core/ProducesCollector.h" #include "art/Framework/Services/Registry/ServiceHandle.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // From G4 #include "Geant4/G4VSensitiveDetector.hh" diff --git a/Mu2eG4/src/WorldMaker.cc b/Mu2eG4/src/WorldMaker.cc index 6482a44e49..a8fc7e45a9 100644 --- a/Mu2eG4/src/WorldMaker.cc +++ b/Mu2eG4/src/WorldMaker.cc @@ -19,6 +19,8 @@ #include "Mu2eG4/inc/Mu2eStudyWorld.hh" #include "Mu2eG4/inc/Mu2eWorld.hh" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include diff --git a/Mu2eG4/src/constructCRV.cc b/Mu2eG4/src/constructCRV.cc index 86cf2c0be0..84efe174af 100644 --- a/Mu2eG4/src/constructCRV.cc +++ b/Mu2eG4/src/constructCRV.cc @@ -6,6 +6,8 @@ // // Notes: +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // clhep includes #include "CLHEP/Vector/ThreeVector.h" diff --git a/Mu2eG4/src/constructDS.cc b/Mu2eG4/src/constructDS.cc index bbfa7b1538..177820a66d 100644 --- a/Mu2eG4/src/constructDS.cc +++ b/Mu2eG4/src/constructDS.cc @@ -38,6 +38,8 @@ // CLHEP includes #include "CLHEP/Vector/ThreeVector.h" #include "CLHEP/Vector/TwoVector.h" +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" using namespace std; diff --git a/Mu2eG4/src/constructDiskCalorimeter.cc b/Mu2eG4/src/constructDiskCalorimeter.cc index e26b6afdf8..0f557558bf 100644 --- a/Mu2eG4/src/constructDiskCalorimeter.cc +++ b/Mu2eG4/src/constructDiskCalorimeter.cc @@ -59,6 +59,8 @@ #include "CLHEP/Units/SystemOfUnits.h" #include "CLHEP/Vector/TwoVector.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include #include #include diff --git a/Mu2eG4/src/constructExtMonFNAL.cc b/Mu2eG4/src/constructExtMonFNAL.cc index 13ef5390fd..1dc0048818 100644 --- a/Mu2eG4/src/constructExtMonFNAL.cc +++ b/Mu2eG4/src/constructExtMonFNAL.cc @@ -13,6 +13,8 @@ #include "Geant4/G4ExtrudedSolid.hh" #include "Mu2eG4Helper/inc/AntiLeakRegistry.hh" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include "GeometryService/inc/GeomHandle.hh" #include "GeometryService/inc/G4GeometryOptions.hh" #include "ProtonBeamDumpGeom/inc/ProtonBeamDump.hh" diff --git a/Mu2eG4/src/constructExtMonFNALBuilding.cc b/Mu2eG4/src/constructExtMonFNALBuilding.cc index 84e48b366b..8ed8f5bec2 100644 --- a/Mu2eG4/src/constructExtMonFNALBuilding.cc +++ b/Mu2eG4/src/constructExtMonFNALBuilding.cc @@ -32,6 +32,8 @@ #include "cetlib_except/exception.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include "GeometryService/inc/GeomHandle.hh" #include "ProtonBeamDumpGeom/inc/ProtonBeamDump.hh" #include "ExtinctionMonitorFNAL/Geometry/inc/ExtMonFNALBuilding.hh" diff --git a/Mu2eG4/src/constructMBS.cc b/Mu2eG4/src/constructMBS.cc index 5c7214519d..f24c87287d 100644 --- a/Mu2eG4/src/constructMBS.cc +++ b/Mu2eG4/src/constructMBS.cc @@ -21,6 +21,9 @@ // At the time of the latter modification, version 4 is default. Once // the design of the CRV and STM are finalized, version 5 will be default. +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + // clhep includes #include "CLHEP/Vector/ThreeVector.h" #include "CLHEP/Units/PhysicalConstants.h" diff --git a/Mu2eG4/src/constructMSTM.cc b/Mu2eG4/src/constructMSTM.cc index 5bf1c70ff1..ec5c7e4b6f 100644 --- a/Mu2eG4/src/constructMSTM.cc +++ b/Mu2eG4/src/constructMSTM.cc @@ -48,6 +48,9 @@ // CLHEP includes #include "CLHEP/Vector/ThreeVector.h" +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include #include #include diff --git a/Mu2eG4/src/constructPSEnclosure.cc b/Mu2eG4/src/constructPSEnclosure.cc index 79e4b2d61d..92480f4d70 100644 --- a/Mu2eG4/src/constructPSEnclosure.cc +++ b/Mu2eG4/src/constructPSEnclosure.cc @@ -4,6 +4,8 @@ #include "CLHEP/Vector/ThreeVector.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include "ProductionSolenoidGeom/inc/PSEnclosure.hh" #include "ProductionSolenoidGeom/inc/PSVacuum.hh" #include "GeometryService/inc/GeometryService.hh" diff --git a/Mu2eG4/src/constructPSShield.cc b/Mu2eG4/src/constructPSShield.cc index d26d33847f..7b86e4b56f 100644 --- a/Mu2eG4/src/constructPSShield.cc +++ b/Mu2eG4/src/constructPSShield.cc @@ -19,6 +19,8 @@ #include "Mu2eG4Helper/inc/AntiLeakRegistry.hh" #include "Mu2eG4Helper/inc/VolumeInfo.hh" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include "Mu2eG4/inc/findMaterialOrThrow.hh" #include "Mu2eG4/inc/finishNesting.hh" #include "Mu2eG4/inc/nestPolycone.hh" diff --git a/Mu2eG4/src/constructProtonAbsorber.cc b/Mu2eG4/src/constructProtonAbsorber.cc index 5c1c4f590b..331c772c57 100644 --- a/Mu2eG4/src/constructProtonAbsorber.cc +++ b/Mu2eG4/src/constructProtonAbsorber.cc @@ -16,6 +16,7 @@ // Framework includes #include "messagefacility/MessageLogger/MessageLogger.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes. #include "Mu2eG4/inc/constructProtonAbsorber.hh" diff --git a/Mu2eG4/src/constructProtonBeamDump.cc b/Mu2eG4/src/constructProtonBeamDump.cc index a685228f4a..b2c13b4d16 100644 --- a/Mu2eG4/src/constructProtonBeamDump.cc +++ b/Mu2eG4/src/constructProtonBeamDump.cc @@ -31,6 +31,8 @@ #include "cetlib_except/exception.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include "GeometryService/inc/G4GeometryOptions.hh" #include "GeometryService/inc/GeomHandle.hh" #include "ProtonBeamDumpGeom/inc/ProtonBeamDump.hh" diff --git a/Mu2eG4/src/constructSTM.cc b/Mu2eG4/src/constructSTM.cc index 47bf5882c2..017ae14132 100644 --- a/Mu2eG4/src/constructSTM.cc +++ b/Mu2eG4/src/constructSTM.cc @@ -12,6 +12,9 @@ #include "CLHEP/Vector/ThreeVector.h" #include "CLHEP/Units/PhysicalConstants.h" +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + // Mu2e includes. #include "Mu2eG4/inc/constructSTM.hh" diff --git a/Mu2eG4/src/constructStoppingTarget.cc b/Mu2eG4/src/constructStoppingTarget.cc index 2e796f60fa..19a482140a 100644 --- a/Mu2eG4/src/constructStoppingTarget.cc +++ b/Mu2eG4/src/constructStoppingTarget.cc @@ -17,6 +17,7 @@ // Framework includes #include "messagefacility/MessageLogger/MessageLogger.h" #include "cetlib_except/exception.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes #include "Mu2eG4/inc/constructStoppingTarget.hh" diff --git a/Mu2eG4/src/constructStudyEnv_v001.cc b/Mu2eG4/src/constructStudyEnv_v001.cc index 3e03a3854b..268fc30ab6 100644 --- a/Mu2eG4/src/constructStudyEnv_v001.cc +++ b/Mu2eG4/src/constructStudyEnv_v001.cc @@ -27,6 +27,9 @@ #include "Mu2eG4Helper/inc/Mu2eG4Helper.hh" #include "CLHEP/Units/SystemOfUnits.h" +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + using namespace std; namespace mu2e { diff --git a/Mu2eG4/src/constructTS.cc b/Mu2eG4/src/constructTS.cc index 7c40e3ce7b..9468a8d45c 100644 --- a/Mu2eG4/src/constructTS.cc +++ b/Mu2eG4/src/constructTS.cc @@ -22,6 +22,7 @@ // Framework includes #include "cetlib_except/exception.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes. #include "BeamlineGeom/inc/Collimator_TS1.hh" diff --git a/Mu2eG4/src/constructTSdA.cc b/Mu2eG4/src/constructTSdA.cc index fab974f018..f903d4ba50 100644 --- a/Mu2eG4/src/constructTSdA.cc +++ b/Mu2eG4/src/constructTSdA.cc @@ -9,6 +9,9 @@ // David Norvil Brown (the other one): rename to TSdA for consistency // with TDR, and update - May 2015. +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + // clhep includes #include "CLHEP/Vector/ThreeVector.h" #include "CLHEP/Units/PhysicalConstants.h" diff --git a/Mu2eG4/src/constructTargetPS.cc b/Mu2eG4/src/constructTargetPS.cc index e0d1e86044..6045e661f1 100644 --- a/Mu2eG4/src/constructTargetPS.cc +++ b/Mu2eG4/src/constructTargetPS.cc @@ -12,6 +12,9 @@ #include #include +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + // Mu2e includes. #include "BeamlineGeom/inc/Beamline.hh" #include "ProductionSolenoidGeom/inc/ProductionSolenoid.hh" diff --git a/Mu2eG4/src/constructTrackerv5.cc b/Mu2eG4/src/constructTrackerv5.cc index 2e4dfae385..877307e016 100644 --- a/Mu2eG4/src/constructTrackerv5.cc +++ b/Mu2eG4/src/constructTrackerv5.cc @@ -29,6 +29,7 @@ // Framework includes #include "cetlib_except/exception.h" #include "messagefacility/MessageLogger/MessageLogger.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // Mu2e includes #include "Mu2eG4Helper/inc/Mu2eG4Helper.hh" diff --git a/Mu2eG4/src/constructVirtualDetectors.cc b/Mu2eG4/src/constructVirtualDetectors.cc index ca7243f0fa..b3a1327c4f 100644 --- a/Mu2eG4/src/constructVirtualDetectors.cc +++ b/Mu2eG4/src/constructVirtualDetectors.cc @@ -8,6 +8,9 @@ #include #include +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + // Mu2e includes. #include "Mu2eG4/inc/constructVirtualDetectors.hh" diff --git a/Mu2eG4/src/constructVisualizationRegions.cc b/Mu2eG4/src/constructVisualizationRegions.cc index ffa55814b2..c57cd4dad5 100644 --- a/Mu2eG4/src/constructVisualizationRegions.cc +++ b/Mu2eG4/src/constructVisualizationRegions.cc @@ -21,6 +21,8 @@ #include "cetlib_except/exception.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include "BFieldGeom/inc/BFieldManager.hh" #include "GeometryService/inc/GeomHandle.hh" #include "GeometryService/inc/WorldG4.hh" diff --git a/Mu2eG4/src/constructWorldVolume.cc b/Mu2eG4/src/constructWorldVolume.cc index 5fde73cf75..44bfe6d504 100644 --- a/Mu2eG4/src/constructWorldVolume.cc +++ b/Mu2eG4/src/constructWorldVolume.cc @@ -5,6 +5,9 @@ // Original author KLG based on Mu2eWorld constructDirt // Updated by Andrei Gaponenko. +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + // Mu2e includes. #include "Mu2eG4/inc/constructWorldVolume.hh" #include "Mu2eG4Helper/inc/VolumeInfo.hh" diff --git a/Mu2eG4/src/finishNesting.cc b/Mu2eG4/src/finishNesting.cc index eac1f58195..1635f71ef0 100644 --- a/Mu2eG4/src/finishNesting.cc +++ b/Mu2eG4/src/finishNesting.cc @@ -9,6 +9,9 @@ #include #include +// art includes +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + // Mu2e includes #include "Mu2eG4/inc/finishNesting.hh" #include "Mu2eG4Helper/inc/Mu2eG4Helper.hh" diff --git a/Mu2eG4/src/generateFieldMap.cc b/Mu2eG4/src/generateFieldMap.cc index 0d3cd67452..5b8911882e 100644 --- a/Mu2eG4/src/generateFieldMap.cc +++ b/Mu2eG4/src/generateFieldMap.cc @@ -18,6 +18,7 @@ #include "art_root_io/TFileService.h" #include "art/Framework/Principal/Handle.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // G4 includes #include "Geant4/G4TransportationManager.hh" diff --git a/Mu2eG4Helper/inc/Mu2eG4Helper.hh b/Mu2eG4Helper/inc/Mu2eG4Helper.hh index 8ccbaa057e..478a83815f 100644 --- a/Mu2eG4Helper/inc/Mu2eG4Helper.hh +++ b/Mu2eG4Helper/inc/Mu2eG4Helper.hh @@ -17,7 +17,7 @@ // Framework include files #include "art/Framework/Services/Registry/ServiceHandle.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" #include "boost/regex.hpp" diff --git a/Mu2eG4Helper/src/Mu2eG4Helper_service.cc b/Mu2eG4Helper/src/Mu2eG4Helper_service.cc index 70c4d1b301..161e07e3fd 100644 --- a/Mu2eG4Helper/src/Mu2eG4Helper_service.cc +++ b/Mu2eG4Helper/src/Mu2eG4Helper_service.cc @@ -9,6 +9,7 @@ // Mu2e includes #include "Mu2eG4Helper/inc/Mu2eG4Helper.hh" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" using namespace std; diff --git a/Mu2eG4Helper/src/SConscript b/Mu2eG4Helper/src/SConscript index d4c8f168f7..1d2e1b49ba 100644 --- a/Mu2eG4Helper/src/SConscript +++ b/Mu2eG4Helper/src/SConscript @@ -29,6 +29,7 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'boost_filesystem', diff --git a/Mu2eUtilities/src/SConscript b/Mu2eUtilities/src/SConscript index 8ea4e9eee2..4c00671e88 100644 --- a/Mu2eUtilities/src/SConscript +++ b/Mu2eUtilities/src/SConscript @@ -43,6 +43,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService_ConditionsService_serv 'HepPDT', XERCESC_LIBS, 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'hep_concurrency', diff --git a/ParticleID/src/PIDLogL1D.cc b/ParticleID/src/PIDLogL1D.cc index 6781210d6c..dc19ca2575 100644 --- a/ParticleID/src/PIDLogL1D.cc +++ b/ParticleID/src/PIDLogL1D.cc @@ -5,6 +5,7 @@ #include #include #include +#include #include "fhiclcpp/types/Table.h" diff --git a/ParticleID/src/PIDLogLEp.cc b/ParticleID/src/PIDLogLEp.cc index a77896bf33..d8bfb57b20 100644 --- a/ParticleID/src/PIDLogLEp.cc +++ b/ParticleID/src/PIDLogLEp.cc @@ -5,6 +5,7 @@ #include #include #include +#include #include "fhiclcpp/types/Table.h" diff --git a/ParticleID/src/SConscript b/ParticleID/src/SConscript index 0e893a5065..e6fcf090d3 100644 --- a/ParticleID/src/SConscript +++ b/ParticleID/src/SConscript @@ -37,6 +37,7 @@ libs = [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Print/src/SConscript b/Print/src/SConscript index 7cf7efe7e5..984787512a 100644 --- a/Print/src/SConscript +++ b/Print/src/SConscript @@ -33,6 +33,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_GeometryService', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'Trajectory', diff --git a/ProditionsService/inc/ProditionsService.hh b/ProditionsService/inc/ProditionsService.hh index d4387ed7a2..4d32d57b5f 100644 --- a/ProditionsService/inc/ProditionsService.hh +++ b/ProditionsService/inc/ProditionsService.hh @@ -15,7 +15,7 @@ #include "fhiclcpp/types/OptionalSequence.h" #include "art/Framework/Services/Registry/ActivityRegistry.h" #include "art/Framework/Services/Registry/ServiceHandle.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" #include "cetlib_except/exception.h" #include "Mu2eInterfaces/inc/ProditionsEntity.hh" diff --git a/ProditionsService/src/ProditionsService_service.cc b/ProditionsService/src/ProditionsService_service.cc index 043a3d7ca8..4f6682c2bd 100644 --- a/ProditionsService/src/ProditionsService_service.cc +++ b/ProditionsService/src/ProditionsService_service.cc @@ -3,6 +3,7 @@ // #include #include +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "DbService/inc/DbService.hh" #include "GeometryService/inc/GeometryService.hh" #include "ProditionsService/inc/ProditionsService.hh" diff --git a/ProditionsService/src/SConscript b/ProditionsService/src/SConscript index 7e3db03eab..4e2a85b44d 100644 --- a/ProditionsService/src/SConscript +++ b/ProditionsService/src/SConscript @@ -53,6 +53,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'boost_filesystem', diff --git a/Sandbox/inc/BarService.hh b/Sandbox/inc/BarService.hh index 71a96cd186..d8e2d0a4ee 100644 --- a/Sandbox/inc/BarService.hh +++ b/Sandbox/inc/BarService.hh @@ -13,7 +13,7 @@ #include "art/Framework/Services/Registry/ActivityRegistry.h" #include "art/Framework/Services/Registry/ServiceHandle.h" #include "art/Framework/Principal/Run.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" namespace mu2e { diff --git a/Sandbox/inc/Bug01Service.hh b/Sandbox/inc/Bug01Service.hh index 2c0314112e..623d8b7fd0 100644 --- a/Sandbox/inc/Bug01Service.hh +++ b/Sandbox/inc/Bug01Service.hh @@ -12,7 +12,7 @@ #include "art/Framework/Services/Registry/ActivityRegistry.h" #include "art/Framework/Services/Registry/ServiceHandle.h" #include "art/Framework/Principal/Run.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" namespace mu2e { diff --git a/Sandbox/inc/FooService.hh b/Sandbox/inc/FooService.hh index f4323b67a8..5d42053c86 100644 --- a/Sandbox/inc/FooService.hh +++ b/Sandbox/inc/FooService.hh @@ -13,7 +13,7 @@ #include "art/Framework/Services/Registry/ActivityRegistry.h" #include "art/Framework/Services/Registry/ServiceHandle.h" #include "art/Framework/Principal/Run.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" namespace mu2e { diff --git a/Sandbox/inc/XBarService.hh b/Sandbox/inc/XBarService.hh index 0b1b26c2b6..619197db8d 100644 --- a/Sandbox/inc/XBarService.hh +++ b/Sandbox/inc/XBarService.hh @@ -16,7 +16,7 @@ #include "art/Framework/Services/Registry/ActivityRegistry.h" #include "art/Framework/Services/Registry/ServiceHandle.h" #include "art/Framework/Principal/Run.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" namespace mu2e { diff --git a/Sandbox/src/BarService_service.cc b/Sandbox/src/BarService_service.cc index 9f5d94862c..8180e5ec44 100644 --- a/Sandbox/src/BarService_service.cc +++ b/Sandbox/src/BarService_service.cc @@ -48,6 +48,7 @@ // Framework include files #include "canvas/Persistency/Provenance/RunID.h" #include "art/Framework/Services/Registry/ServiceHandle.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" using namespace std; diff --git a/Sandbox/src/BarTest_module.cc b/Sandbox/src/BarTest_module.cc index d78c51b6ba..2e49de46b1 100644 --- a/Sandbox/src/BarTest_module.cc +++ b/Sandbox/src/BarTest_module.cc @@ -11,6 +11,7 @@ #include "art/Framework/Core/EDAnalyzer.h" #include "art/Framework/Core/ModuleMacros.h" #include "art/Framework/Principal/Event.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // C++ includes. #include diff --git a/Sandbox/src/Bug01Service_service.cc b/Sandbox/src/Bug01Service_service.cc index 0acf27138d..3c05a106c8 100644 --- a/Sandbox/src/Bug01Service_service.cc +++ b/Sandbox/src/Bug01Service_service.cc @@ -11,6 +11,7 @@ #include "canvas/Persistency/Provenance/RunID.h" #include "art/Framework/Services/Registry/ServiceHandle.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "cetlib_except/exception.h" diff --git a/Sandbox/src/FooService_service.cc b/Sandbox/src/FooService_service.cc index 4408afd0cb..c90146909e 100644 --- a/Sandbox/src/FooService_service.cc +++ b/Sandbox/src/FooService_service.cc @@ -12,6 +12,7 @@ // Framework include files #include "canvas/Persistency/Provenance/RunID.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" using namespace std; diff --git a/Sandbox/src/FooTest_module.cc b/Sandbox/src/FooTest_module.cc index e171a7d2a8..4f9c5d04d2 100644 --- a/Sandbox/src/FooTest_module.cc +++ b/Sandbox/src/FooTest_module.cc @@ -11,6 +11,7 @@ #include "art/Framework/Core/EDAnalyzer.h" #include "art/Framework/Core/ModuleMacros.h" #include "art/Framework/Principal/Event.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // C++ includes. #include diff --git a/Sandbox/src/SConscript b/Sandbox/src/SConscript index c0f386bd90..7283a83d8f 100644 --- a/Sandbox/src/SConscript +++ b/Sandbox/src/SConscript @@ -34,6 +34,7 @@ common = [ 'mu2e_SeedService_SeedService_service', 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Sandbox/src/XBarService_service.cc b/Sandbox/src/XBarService_service.cc index b72e1d7422..1b167a2d32 100644 --- a/Sandbox/src/XBarService_service.cc +++ b/Sandbox/src/XBarService_service.cc @@ -16,6 +16,7 @@ // Framework include files #include "canvas/Persistency/Provenance/RunID.h" #include "art/Framework/Services/Registry/ServiceHandle.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" using namespace std; diff --git a/Sandbox/src/XBarTest_module.cc b/Sandbox/src/XBarTest_module.cc index faeacc8d96..ac6a49d66b 100644 --- a/Sandbox/src/XBarTest_module.cc +++ b/Sandbox/src/XBarTest_module.cc @@ -11,6 +11,7 @@ #include "art/Framework/Core/EDAnalyzer.h" #include "art/Framework/Core/ModuleMacros.h" #include "art/Framework/Principal/Event.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" // C++ includes. #include diff --git a/SeedService/inc/SeedService.hh b/SeedService/inc/SeedService.hh index c72c6eb4a2..f641f9c75f 100644 --- a/SeedService/inc/SeedService.hh +++ b/SeedService/inc/SeedService.hh @@ -98,7 +98,7 @@ // From art and its tool chain. #include "art/Framework/Core/detail/EngineCreator.h" #include "art/Framework/Services/Optional/RandomNumberGenerator.h" -#include "art/Framework/Services/Registry/ServiceMacros.h" +#include "art/Framework/Services/Registry/ServiceDeclarationMacros.h" #include "fhiclcpp/ParameterSet.h" #include diff --git a/SeedService/src/SConscript b/SeedService/src/SConscript index 85ab18b269..6792588b55 100644 --- a/SeedService/src/SConscript +++ b/SeedService/src/SConscript @@ -32,6 +32,7 @@ helper.make_plugin( 'SeedService_service.cc', 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/SeedService/src/SeedService_service.cc b/SeedService/src/SeedService_service.cc index f08cccf98d..6bf2200636 100644 --- a/SeedService/src/SeedService_service.cc +++ b/SeedService/src/SeedService_service.cc @@ -18,6 +18,7 @@ #include "art/Framework/Principal/Run.h" #include "art/Framework/Principal/SubRun.h" #include "art/Framework/Services/Registry/ActivityRegistry.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "art/Persistency/Provenance/ModuleContext.h" #include "art/Persistency/Provenance/ModuleDescription.h" #include "canvas/Persistency/Provenance/EventID.h" diff --git a/SimulationConditions/src/SConscript b/SimulationConditions/src/SConscript index 291810d3cf..2d00bed3fe 100644 --- a/SimulationConditions/src/SConscript +++ b/SimulationConditions/src/SConscript @@ -36,6 +36,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/SimulationConditions/src/SimBookkeeperCache.cc b/SimulationConditions/src/SimBookkeeperCache.cc index 78d27b897b..3e9d5cd4b7 100644 --- a/SimulationConditions/src/SimBookkeeperCache.cc +++ b/SimulationConditions/src/SimBookkeeperCache.cc @@ -2,6 +2,8 @@ // SimBookkeeperCache for ProditionsCache // +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" + #include "SimulationConditions/inc/SimBookkeeperCache.hh" namespace mu2e { diff --git a/Sources/src/SConscript b/Sources/src/SConscript index 48d06de5b0..44324312a1 100644 --- a/Sources/src/SConscript +++ b/Sources/src/SConscript @@ -36,6 +36,7 @@ mainlib = helper.make_mainlib(['mu2e_GlobalConstantsService', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'MF_MessageLogger', 'cetlib', 'cetlib_except', diff --git a/TEveEventDisplay/src/SConscript b/TEveEventDisplay/src/SConscript index 608b0287a7..846e946d20 100644 --- a/TEveEventDisplay/src/SConscript +++ b/TEveEventDisplay/src/SConscript @@ -42,7 +42,7 @@ userlibs = [ rootlibs, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -50,6 +50,8 @@ userlibs = [ rootlibs, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrackCaloMatching/src/SConscript b/TrackCaloMatching/src/SConscript index 46384ddb18..964b0bbf58 100644 --- a/TrackCaloMatching/src/SConscript +++ b/TrackCaloMatching/src/SConscript @@ -59,6 +59,7 @@ helper.make_plugins( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrackerAlignment/src/AlignTrackCollector_module.cc b/TrackerAlignment/src/AlignTrackCollector_module.cc index b8df1f33b6..9ab4451a26 100644 --- a/TrackerAlignment/src/AlignTrackCollector_module.cc +++ b/TrackerAlignment/src/AlignTrackCollector_module.cc @@ -40,6 +40,7 @@ #include "art/Framework/Principal/Event.h" #include "art/Framework/Principal/Handle.h" #include "art/Framework/Services/Registry/ServiceHandle.h" +#include "art/Framework/Services/Registry/ServiceDefinitionMacros.h" #include "art_root_io/TFileService.h" #include "TrackerConditions/inc/StrawResponse.hh" diff --git a/TrackerAlignment/src/SConscript b/TrackerAlignment/src/SConscript index 3661496fa2..7d5603c5ae 100644 --- a/TrackerAlignment/src/SConscript +++ b/TrackerAlignment/src/SConscript @@ -43,6 +43,7 @@ art_libs = [ other_libs = [ 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrackerConditions/src/SConscript b/TrackerConditions/src/SConscript index b88d31fb09..bb2263ed06 100644 --- a/TrackerConditions/src/SConscript +++ b/TrackerConditions/src/SConscript @@ -34,6 +34,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrackerMC/src/MakeStrawGasSteps_module.cc b/TrackerMC/src/MakeStrawGasSteps_module.cc index 5b6b4de99e..e7b1540da6 100644 --- a/TrackerMC/src/MakeStrawGasSteps_module.cc +++ b/TrackerMC/src/MakeStrawGasSteps_module.cc @@ -11,6 +11,7 @@ #include "cetlib_except/exception.h" #include "fhiclcpp/types/Atom.h" #include "canvas/Utilities/InputTag.h" +#include "messagefacility/MessageLogger/MessageLogger.h" #include "TrackerGeom/inc/Tracker.hh" #include "GeometryService/inc/GeomHandle.hh" diff --git a/TrackerMC/src/SConscript b/TrackerMC/src/SConscript index e2fc1dc861..b799fbc9f8 100644 --- a/TrackerMC/src/SConscript +++ b/TrackerMC/src/SConscript @@ -61,6 +61,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'BTrk_BField', diff --git a/TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc b/TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc index 12ed901e2d..9b92e4af71 100644 --- a/TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc +++ b/TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc @@ -15,6 +15,7 @@ #include "art_root_io/TFileService.h" #include "SeedService/inc/SeedService.hh" #include "cetlib_except/exception.h" +#include "messagefacility/MessageLogger/MessageLogger.h" // conditions #include "ProditionsService/inc/ProditionsHandle.hh" #include "ConditionsService/inc/ConditionsHandle.hh" diff --git a/Trigger/src/SConscript b/Trigger/src/SConscript index 020dbab021..0d91b6cf5a 100644 --- a/Trigger/src/SConscript +++ b/Trigger/src/SConscript @@ -59,6 +59,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrkDiag/src/SConscript b/TrkDiag/src/SConscript index 062ef637c7..5fb890653c 100644 --- a/TrkDiag/src/SConscript +++ b/TrkDiag/src/SConscript @@ -43,6 +43,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'Trajectory', diff --git a/TrkExt/src/SConscript b/TrkExt/src/SConscript index 92809fbad3..99c9bf3edc 100644 --- a/TrkExt/src/SConscript +++ b/TrkExt/src/SConscript @@ -38,6 +38,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_Mu2eBTrk', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/TrkFilters/src/SConscript b/TrkFilters/src/SConscript index e32fe24426..b2a89bb6b9 100644 --- a/TrkFilters/src/SConscript +++ b/TrkFilters/src/SConscript @@ -37,6 +37,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/TrkHitReco/src/SConscript b/TrkHitReco/src/SConscript index 24ecce0bcd..13f025d7fa 100755 --- a/TrkHitReco/src/SConscript +++ b/TrkHitReco/src/SConscript @@ -32,6 +32,7 @@ mainlib = helper.make_mainlib([ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/TrkHitReco/src/StrawHitReco_module.cc b/TrkHitReco/src/StrawHitReco_module.cc index 7751e689f1..dee651e44d 100644 --- a/TrkHitReco/src/StrawHitReco_module.cc +++ b/TrkHitReco/src/StrawHitReco_module.cc @@ -39,7 +39,7 @@ #include "TH1F.h" #include - +#include namespace mu2e { diff --git a/TrkPatRec/src/SConscript b/TrkPatRec/src/SConscript index e6d73ea7a7..67dcf6a68f 100644 --- a/TrkPatRec/src/SConscript +++ b/TrkPatRec/src/SConscript @@ -42,6 +42,7 @@ mainlib = helper.make_mainlib(['mu2e_Mu2eBTrk', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/TrkPatRec/src/TimeAndPhiClusterFinder_module.cc b/TrkPatRec/src/TimeAndPhiClusterFinder_module.cc index 787f6d876e..75ecd57958 100644 --- a/TrkPatRec/src/TimeAndPhiClusterFinder_module.cc +++ b/TrkPatRec/src/TimeAndPhiClusterFinder_module.cc @@ -28,7 +28,7 @@ #include "TrkPatRec/inc/TimeAndPhiClusterFinder_types.hh" #include - +#include namespace diff --git a/TrkReco/src/SConscript b/TrkReco/src/SConscript index f8d4009af9..3bf3f66ff2 100644 --- a/TrkReco/src/SConscript +++ b/TrkReco/src/SConscript @@ -40,6 +40,7 @@ mainlib = helper.make_mainlib ( [ 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'Trajectory', diff --git a/UtilityModules/src/SConscript b/UtilityModules/src/SConscript index cefb7531df..640be5b8df 100644 --- a/UtilityModules/src/SConscript +++ b/UtilityModules/src/SConscript @@ -27,6 +27,7 @@ common = [ 'mu2e_MCDataProducts', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Validation/src/SConscript b/Validation/src/SConscript index 56add5fc5d..c465f58b6c 100644 --- a/Validation/src/SConscript +++ b/Validation/src/SConscript @@ -62,6 +62,7 @@ helper.make_plugins( [ mainlib,'mu2e_Validation_root', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', rootlibs, diff --git a/scripts/build/python/sconstruct_helper.py b/scripts/build/python/sconstruct_helper.py index f9ef5b70c5..ee134b06d9 100644 --- a/scripts/build/python/sconstruct_helper.py +++ b/scripts/build/python/sconstruct_helper.py @@ -74,15 +74,15 @@ def cppPath(mu2eOpts): os.environ['CETLIB_EXCEPT_INC'], os.environ['BOOST_INC'], os.environ['CLHEP_INC'], - os.environ['CPPUNIT_DIR']+'/include', + # os.environ['CPPUNIT_DIR']+'/include', os.environ['HEPPDT_INC'], os.environ['ROOT_INC'], os.environ['XERCES_C_INC'], os.environ['TBB_INC'], - os.environ['MU2E_ARTDAQ_CORE_INC'], - os.environ['ARTDAQ_CORE_INC'], - os.environ['PCIE_LINUX_KERNEL_MODULE_INC'], - os.environ['TRACE_INC'], + # os.environ['MU2E_ARTDAQ_CORE_INC'], + # os.environ['ARTDAQ_CORE_INC'], + # os.environ['PCIE_LINUX_KERNEL_MODULE_INC'], + # os.environ['TRACE_INC'], os.environ['GSL_INC'], os.environ['POSTGRESQL_INC'] ] @@ -112,7 +112,7 @@ def libPath(mu2eOpts): os.environ['CETLIB_EXCEPT_LIB'], os.environ['BOOST_LIB'], os.environ['CLHEP_LIB_DIR'], - os.environ['CPPUNIT_DIR']+'/lib', + # os.environ['CPPUNIT_DIR']+'/lib', os.environ['HEPPDT_LIB'], os.environ['ROOTSYS']+'/lib', os.environ['XERCESCROOT']+'/lib', diff --git a/setup.sh b/setup.sh index 5f28afe0c5..fa95c00494 100644 --- a/setup.sh +++ b/setup.sh @@ -135,8 +135,8 @@ fi setup -B mu2e_artdaq_core v1_05_07 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} setup -B heppdt v03_04_02 -q${MU2E_UPS_QUALIFIERS} -setup -B BTrk v1_02_30 -q${MU2E_UPS_QUALIFIERS}:p383b -setup -B KinKal v00_01_05 -q${MU2E_UPS_QUALIFIERS}:p383b +setup -B KinKal v00_01_05a -q${MU2E_UPS_QUALIFIERS}:p392 +setup -B BTrk v1_02_31 -q${MU2E_UPS_QUALIFIERS}:p392 setup -B cry v1_7n -q${MU2E_UPS_QUALIFIERS} setup -B gsl v2_6a setup curl v7_64_1 From a452e1c9bd7e6bb37560a5c1045b9f842d9055bf Mon Sep 17 00:00:00 2001 From: Kyle Knoepfel Date: Wed, 24 Mar 2021 15:39:45 -0500 Subject: [PATCH 03/54] Second round rebase merges Adjust library dependencies. --- Analyses/src/SConscript | 3 +-- BFieldTest/src/SConscript | 3 +-- BTrkData/src/SConscript | 1 - CRVAnalysis/src/SConscript | 1 - CRVResponse/src/SConscript | 3 +-- CalPatRec/src/SConscript | 9 +++------ CaloCluster/src/SConscript | 6 ++---- CaloDiag/src/SConscript | 3 +-- CaloFilters/src/SConscript | 3 +-- CaloMC/src/SConscript | 6 ++---- CaloReco/src/SConscript | 6 ++---- CommonMC/src/SConscript | 6 ++---- Compression/src/SConscript | 3 +-- ConditionsService/src/SConscript | 1 - CosmicReco/src/SConscript | 6 ++---- CutAndCountAnalysis/src/SConscript | 6 ++---- DAQ/src/SConscript.sav | 6 ++---- DbService/src/SConscript | 3 +-- EventDisplay/src/SConscript | 3 +-- EventGenerator/src/SConscript | 6 ++---- EventMixing/src/SConscript | 6 ++---- ExtinctionMonitorFNAL/Analyses/src/SConscript | 6 ++---- ExtinctionMonitorFNAL/Digitization/src/SConscript | 2 -- ExtinctionMonitorFNAL/Reconstruction/src/SConscript | 3 +-- ExtinctionMonitorFNAL/TruthAlgs/src/SConscript | 1 - ExtinctionMonitorFNAL/Utilities/src/SConscript | 1 - Filters/src/SConscript | 3 +-- GeneralUtilities/src/SConscript | 1 - GeometryService/src/SConscript | 2 -- GlobalConstantsService/src/SConscript | 2 -- HelloWorld/src/SConscript | 1 - MCDataProducts/src/SConscript | 1 - Mu2eBTrk/src/SConscript | 8 +++----- Mu2eG4/src/SConscript | 7 +++---- Mu2eG4Helper/src/SConscript | 2 -- Mu2eUtilities/src/SConscript | 2 +- ParticleID/src/SConscript | 4 ++-- Print/artProductSizes/SConscript | 2 +- Print/src/SConscript | 6 ++---- ProditionsService/src/SConscript | 3 +-- RecoDataProducts/src/SConscript | 2 -- Sandbox/src/SConscript | 6 ------ SeedService/src/SConscript | 2 -- SimulationConditions/src/SConscript | 1 - Sources/src/SConscript | 4 +--- TEveEventDisplay/src/SConscript | 10 ++++------ TrackCaloMatching/src/SConscript | 4 +--- TrackerAlignment/src/SConscript | 3 +-- TrackerConditions/src/SConscript | 1 - TrackerGeom/src/SConscript | 1 - TrackerMC/src/SConscript | 6 ++---- Trigger/src/SConscript | 3 +-- TrkDiag/src/SConscript | 6 ++---- TrkExt/src/SConscript | 6 ++---- TrkFilters/src/SConscript | 6 ++---- TrkHitReco/src/SConscript | 8 ++++---- TrkPatRec/src/SConscript | 8 ++++---- TrkReco/src/SConscript | 8 +++----- UtilityModules/src/SConscript | 2 -- Validation/src/SConscript | 7 +++---- 60 files changed, 76 insertions(+), 165 deletions(-) diff --git a/Analyses/src/SConscript b/Analyses/src/SConscript index d843701463..83a332ef3c 100644 --- a/Analyses/src/SConscript +++ b/Analyses/src/SConscript @@ -49,7 +49,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -67,7 +67,6 @@ helper.make_plugins( [ mainlib, extrarootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', 'pthread', 'hep_concurrency', 'DTCInterface', diff --git a/BFieldTest/src/SConscript b/BFieldTest/src/SConscript index b0873a0bd3..1fc806f1cb 100644 --- a/BFieldTest/src/SConscript +++ b/BFieldTest/src/SConscript @@ -20,7 +20,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Persistency_Common', 'art_Persistency_Provenance', 'art_Utilities', @@ -33,7 +33,6 @@ helper.make_plugins( [ 'CLHEP', rootlibs, 'boost_filesystem', - 'boost_system', # 'pthread', ] ) diff --git a/BTrkData/src/SConscript b/BTrkData/src/SConscript index 0670ad6ddf..d8f108c4e0 100644 --- a/BTrkData/src/SConscript +++ b/BTrkData/src/SConscript @@ -24,7 +24,6 @@ mainlib = helper.make_mainlib ( [ 'cetlib', 'cetlib_except', 'CLHEP', - 'boost_system', ] ) diff --git a/CRVAnalysis/src/SConscript b/CRVAnalysis/src/SConscript index 81e579bce4..29a4b1184f 100644 --- a/CRVAnalysis/src/SConscript +++ b/CRVAnalysis/src/SConscript @@ -40,7 +40,6 @@ mainlib = helper.make_mainlib ( [ 'CLHEP', 'art_Persistency_Provenance', 'art_Utilities', 'canvas', - 'boost_system', 'cetlib', 'cetlib_except', 'Core'] diff --git a/CRVResponse/src/SConscript b/CRVResponse/src/SConscript index bb3b46cccb..dd32f925fe 100644 --- a/CRVResponse/src/SConscript +++ b/CRVResponse/src/SConscript @@ -46,7 +46,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -61,7 +61,6 @@ helper.make_plugins( [ mainlib, 'HepPDT', rootlibs, 'boost_filesystem', - 'boost_system', ] ) # this tells emacs to view this file in python mode. diff --git a/CalPatRec/src/SConscript b/CalPatRec/src/SConscript index e704ba6da2..3f97ba456d 100644 --- a/CalPatRec/src/SConscript +++ b/CalPatRec/src/SConscript @@ -39,7 +39,7 @@ mainlib = helper.make_mainlib( [ 'mu2e_TrkDiag', 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -53,7 +53,6 @@ mainlib = helper.make_mainlib( [ 'mu2e_TrkDiag', extrarootlibs, 'CLHEP', 'xerces-c', - 'boost_system', ] ) helper.make_plugins( [ mainlib, @@ -78,7 +77,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -93,7 +92,6 @@ helper.make_plugins( [ mainlib, extrarootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', ] ) helper.make_dict_and_map( [ mainlib, @@ -117,7 +115,7 @@ helper.make_dict_and_map( [ mainlib, 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -130,7 +128,6 @@ helper.make_dict_and_map( [ mainlib, extrarootlibs, 'CLHEP', 'xerces-c', - 'boost_system', ] ) # This tells emacs to view this file in python mode. diff --git a/CaloCluster/src/SConscript b/CaloCluster/src/SConscript index d48bc2a362..cfe1afec56 100644 --- a/CaloCluster/src/SConscript +++ b/CaloCluster/src/SConscript @@ -30,7 +30,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Persistency_Provenance', 'canvas', 'art_Framework_Services_Optional_RandomNumberGenerator_service', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', 'art_Framework_Principal', @@ -42,7 +42,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'cetlib_except', 'CLHEP', rootlibs, - 'boost_system' ] ) helper.make_plugins( [ mainlib, @@ -58,7 +57,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -69,7 +68,6 @@ helper.make_plugins( [ mainlib, 'cetlib_except', 'CLHEP', 'boost_filesystem', - 'boost_system', rootlibs ], ) diff --git a/CaloDiag/src/SConscript b/CaloDiag/src/SConscript index d843701463..83a332ef3c 100644 --- a/CaloDiag/src/SConscript +++ b/CaloDiag/src/SConscript @@ -49,7 +49,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -67,7 +67,6 @@ helper.make_plugins( [ mainlib, extrarootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', 'pthread', 'hep_concurrency', 'DTCInterface', diff --git a/CaloFilters/src/SConscript b/CaloFilters/src/SConscript index bcf1564555..2dda131404 100644 --- a/CaloFilters/src/SConscript +++ b/CaloFilters/src/SConscript @@ -46,7 +46,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -64,7 +64,6 @@ helper.make_plugins( [ mainlib, extrarootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', ] ) # this tells emacs to view this file in python mode. diff --git a/CaloMC/src/SConscript b/CaloMC/src/SConscript index c7cb2f62d8..405ddf86ba 100644 --- a/CaloMC/src/SConscript +++ b/CaloMC/src/SConscript @@ -33,7 +33,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Persistency_Provenance', 'canvas', 'art_Framework_Services_Optional_RandomNumberGenerator_service', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', 'art_Framework_Principal', @@ -44,7 +44,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'cetlib_except', 'CLHEP', rootlibs, - 'boost_system', 'Minuit' ] ) @@ -62,7 +61,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -74,7 +73,6 @@ helper.make_plugins( [ mainlib, 'CLHEP', 'HepPDT', 'boost_filesystem', - 'boost_system', rootlibs #needed for reco hit fitting ], ) diff --git a/CaloReco/src/SConscript b/CaloReco/src/SConscript index 8d20178ce4..12638c7d7d 100644 --- a/CaloReco/src/SConscript +++ b/CaloReco/src/SConscript @@ -26,7 +26,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Persistency_Provenance', 'canvas', 'art_Framework_Services_Optional_RandomNumberGenerator_service', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', 'art_Framework_Principal', @@ -38,7 +38,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'cetlib_except', 'CLHEP', rootlibs, - 'boost_system', 'Minuit' ] ) @@ -55,7 +54,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -66,7 +65,6 @@ helper.make_plugins( [ mainlib, 'cetlib_except', 'CLHEP', 'boost_filesystem', - 'boost_system', rootlibs ], ) diff --git a/CommonMC/src/SConscript b/CommonMC/src/SConscript index 5f9bbddeb0..44db93812a 100644 --- a/CommonMC/src/SConscript +++ b/CommonMC/src/SConscript @@ -30,7 +30,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_TrackerConditions', 'art_Persistency_Provenance', 'art_Persistency_Common', 'art_Framework_Services_Optional_RandomNumberGenerator_service', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', 'art_Framework_Principal', @@ -43,7 +43,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_TrackerConditions', 'cetlib_except', 'CLHEP', rootlibs, - 'boost_system', ] ) helper.make_plugins( [ mainlib, @@ -68,7 +67,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -81,7 +80,6 @@ helper.make_plugins( [ mainlib, 'CLHEP', 'HepPDT', 'boost_filesystem', - 'boost_system', rootlibs, 'xerces-c', # only needed for MakeStereoHits_module.cc 'Minuit' # Needed for BetaTauPitch_module.cc and ReadStrawCluster_module.cc diff --git a/Compression/src/SConscript b/Compression/src/SConscript index 922c16cbed..92dd93361f 100644 --- a/Compression/src/SConscript +++ b/Compression/src/SConscript @@ -32,7 +32,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Persistency_Common', 'art_Persistency_Provenance', 'art_Utilities', @@ -46,7 +46,6 @@ helper.make_plugins( [ 'HepPDT', rootlibs, 'boost_filesystem', - 'boost_system', 'hep_concurrency', 'xerces-c', 'pthread' diff --git a/ConditionsService/src/SConscript b/ConditionsService/src/SConscript index ac1d77423b..c027062190 100644 --- a/ConditionsService/src/SConscript +++ b/ConditionsService/src/SConscript @@ -41,7 +41,6 @@ helper.make_plugins( [ mainlib, 'cetlib', 'cetlib_except', 'boost_filesystem', - 'boost_system', ] ) diff --git a/CosmicReco/src/SConscript b/CosmicReco/src/SConscript index 0b214a9652..fe653a63d9 100644 --- a/CosmicReco/src/SConscript +++ b/CosmicReco/src/SConscript @@ -34,7 +34,7 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -48,7 +48,6 @@ mainlib = helper.make_mainlib ( [ 'CLHEP', 'HepPDT', 'xerces-c', - 'boost_system', extrarootlibs, ] ) @@ -77,7 +76,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -92,7 +91,6 @@ helper.make_plugins( [ rootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', 'pthread', extrarootlibs diff --git a/CutAndCountAnalysis/src/SConscript b/CutAndCountAnalysis/src/SConscript index 13cdb00bf7..c4562f73bd 100644 --- a/CutAndCountAnalysis/src/SConscript +++ b/CutAndCountAnalysis/src/SConscript @@ -42,7 +42,7 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -59,7 +59,6 @@ mainlib = helper.make_mainlib ( [ rootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', ] ) @@ -91,7 +90,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -107,7 +106,6 @@ helper.make_plugins( [ mainlib, rootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', ] ) # this tells emacs to view this file in python mode. diff --git a/DAQ/src/SConscript.sav b/DAQ/src/SConscript.sav index 5f65518592..c9b6d2c217 100644 --- a/DAQ/src/SConscript.sav +++ b/DAQ/src/SConscript.sav @@ -27,7 +27,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Persistency_Provenance', 'art_Persistency_Common', 'art_Framework_Services_Optional_RandomNumberGenerator_service', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', 'art_Framework_Principal', @@ -40,7 +40,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'cetlib_except', 'CLHEP', rootlibs, - 'boost_system' ] ) helper.make_plugins( [ mainlib, @@ -62,7 +61,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -75,7 +74,6 @@ helper.make_plugins( [ mainlib, 'CLHEP', 'HepPDT', 'boost_filesystem', - 'boost_system', rootlibs, 'xerces-c', # only needed for MakeStereoHits_module.cc 'Minuit', # Needed for BetaTauPitch_module.cc and ReadStrawCluster_module.cc diff --git a/DbService/src/SConscript b/DbService/src/SConscript index 030cfff554..fe9e6d0981 100644 --- a/DbService/src/SConscript +++ b/DbService/src/SConscript @@ -28,7 +28,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -40,7 +40,6 @@ helper.make_plugins( [ mainlib, 'cetlib', 'cetlib_except', 'boost_filesystem', - 'boost_system', ] ) BINLIBS = [ mainlib, 'mu2e_DbTables' , 'cetlib', 'cetlib_except', "pq" ] diff --git a/EventDisplay/src/SConscript b/EventDisplay/src/SConscript index f62a4133ff..c1f0396e90 100644 --- a/EventDisplay/src/SConscript +++ b/EventDisplay/src/SConscript @@ -36,7 +36,7 @@ userlibs = [ rootlibs, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -52,7 +52,6 @@ userlibs = [ rootlibs, 'HepPID', 'Core', 'boost_filesystem', - 'boost_system' ] diff --git a/EventGenerator/src/SConscript b/EventGenerator/src/SConscript index a49495f4a5..90557e7368 100644 --- a/EventGenerator/src/SConscript +++ b/EventGenerator/src/SConscript @@ -36,7 +36,7 @@ mainlib = helper.make_mainlib ( [ 'art_Persistency_Common', 'art_Framework_Services_Registry', 'art_Framework_Services_Optional_RandomNumberGenerator_service', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Framework_Principal', 'art_Framework_Core', @@ -52,7 +52,6 @@ mainlib = helper.make_mainlib ( [ 'HepPDT', 'HepPID', rootlibs, - 'boost_system', 'gsl', ], [],['-I' + cryinc, '-L' + crylib] ) @@ -76,7 +75,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -91,7 +90,6 @@ helper.make_plugins( [ mainlib, 'HepPID', rootlibs, 'boost_filesystem', - 'boost_system', 'gsl', 'CRY', ], diff --git a/EventMixing/src/SConscript b/EventMixing/src/SConscript index 388215805d..c79ecf5f19 100644 --- a/EventMixing/src/SConscript +++ b/EventMixing/src/SConscript @@ -18,7 +18,7 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Framework_IO_ProductMix', 'art_root_io', @@ -33,7 +33,6 @@ mainlib = helper.make_mainlib ( [ 'cetlib_except', 'hep_concurrency', 'boost_filesystem', - 'boost_system', 'Core', # dependence on gVersionCheck, reportedly due to some bug upstream ] ) @@ -47,7 +46,7 @@ helper.make_plugins ( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Framework_IO_ProductMix', 'art_root_io', @@ -65,7 +64,6 @@ helper.make_plugins ( [ mainlib, 'Hist', 'Core', 'boost_filesystem', - 'boost_system', 'pthread' ] ) diff --git a/ExtinctionMonitorFNAL/Analyses/src/SConscript b/ExtinctionMonitorFNAL/Analyses/src/SConscript index 05905aabf2..49bfca0d2d 100644 --- a/ExtinctionMonitorFNAL/Analyses/src/SConscript +++ b/ExtinctionMonitorFNAL/Analyses/src/SConscript @@ -20,7 +20,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Persistency_Provenance', 'art_Persistency_Common', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Framework_Principal', 'art_Framework_Core', @@ -30,7 +30,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'cetlib_except', 'CLHEP', rootlibs, - 'boost_system', ] ) helper.make_plugins( [ mainlib, @@ -49,7 +48,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -63,7 +62,6 @@ helper.make_plugins( [ mainlib, 'CLHEP', rootlibs, 'boost_filesystem', - 'boost_system', 'hep_concurrency', ] ) diff --git a/ExtinctionMonitorFNAL/Digitization/src/SConscript b/ExtinctionMonitorFNAL/Digitization/src/SConscript index 0e654fb84b..807d0cca90 100644 --- a/ExtinctionMonitorFNAL/Digitization/src/SConscript +++ b/ExtinctionMonitorFNAL/Digitization/src/SConscript @@ -34,7 +34,6 @@ mainlib = helper.make_mainlib ( [ 'cetlib_except', 'CLHEP', 'Core', - 'boost_system', ] ) helper.make_plugins( [ mainlib, @@ -65,7 +64,6 @@ helper.make_plugins( [ mainlib, 'HepPID', 'Core', 'boost_filesystem', - 'boost_system', ] ) diff --git a/ExtinctionMonitorFNAL/Reconstruction/src/SConscript b/ExtinctionMonitorFNAL/Reconstruction/src/SConscript index e418f1737b..e13b60bf26 100644 --- a/ExtinctionMonitorFNAL/Reconstruction/src/SConscript +++ b/ExtinctionMonitorFNAL/Reconstruction/src/SConscript @@ -25,7 +25,7 @@ my_libs=['mu2e_ExtinctionMonitorFNAL_Geometry', mainlib = helper.make_mainlib ( my_libs ) helper.make_plugins( [ mainlib, my_libs, 'mu2e_Mu2eInterfaces', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', 'art_Framework_Core', @@ -33,7 +33,6 @@ helper.make_plugins( [ mainlib, my_libs, 'fhiclcpp', 'fhiclcpp_types', 'boost_filesystem', - 'boost_system', 'Hist', 'Core' ] ) diff --git a/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript b/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript index 511b149451..ec165e4a34 100644 --- a/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript +++ b/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript @@ -27,7 +27,6 @@ helper.make_plugins ( [ 'mu2e_Mu2eUtilities', rootlibs, 'CLHEP', 'boost_filesystem', - 'boost_system', ] ) # This tells emacs to view this file in python mode. diff --git a/ExtinctionMonitorFNAL/Utilities/src/SConscript b/ExtinctionMonitorFNAL/Utilities/src/SConscript index c48c89ea52..51eaaac1e0 100644 --- a/ExtinctionMonitorFNAL/Utilities/src/SConscript +++ b/ExtinctionMonitorFNAL/Utilities/src/SConscript @@ -26,7 +26,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ExtinctionMonitorFNAL_Geometry', 'HepPDT', 'HepPID', 'Core', - 'boost_system' ] ) # This tells emacs to view this file in python mode. diff --git a/Filters/src/SConscript b/Filters/src/SConscript index cb255c7d45..efa91aecaa 100644 --- a/Filters/src/SConscript +++ b/Filters/src/SConscript @@ -36,7 +36,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -53,7 +53,6 @@ helper.make_plugins( [ 'General', rootlibs, 'boost_filesystem', - 'boost_system', 'hep_concurrency', 'xerces-c', 'pthread' diff --git a/GeneralUtilities/src/SConscript b/GeneralUtilities/src/SConscript index 1ca9256a06..822c0e9f6d 100644 --- a/GeneralUtilities/src/SConscript +++ b/GeneralUtilities/src/SConscript @@ -21,7 +21,6 @@ mainlib = helper.make_mainlib ( [ 'art_Persistency_Common', 'CLHEP', 'boost_regex', 'boost_filesystem', - 'boost_system', ] ) diff --git a/GeometryService/src/SConscript b/GeometryService/src/SConscript index 514c888cd8..1c35b4dcee 100644 --- a/GeometryService/src/SConscript +++ b/GeometryService/src/SConscript @@ -46,7 +46,6 @@ mainlib = helper.make_mainlib ( [ 'CLHEP', 'boost_iostreams', 'boost_regex', - 'boost_system', 'Core' ] ) @@ -76,7 +75,6 @@ helper.make_plugins( [ 'CLHEP', 'Core', 'boost_filesystem', - 'boost_system', ] ) helper.make_dict_and_map( [ diff --git a/GlobalConstantsService/src/SConscript b/GlobalConstantsService/src/SConscript index c89b8965e8..77dcc5d262 100644 --- a/GlobalConstantsService/src/SConscript +++ b/GlobalConstantsService/src/SConscript @@ -24,7 +24,6 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Services_Registry', 'cetlib', 'cetlib_except', 'CLHEP', - 'boost_system', ] ) helper.make_plugins( [ mainlib, @@ -32,7 +31,6 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'boost_filesystem', - 'boost_system', ] ) # This tells emacs to view this file in python mode. diff --git a/HelloWorld/src/SConscript b/HelloWorld/src/SConscript index c450836fec..a9c26e4354 100644 --- a/HelloWorld/src/SConscript +++ b/HelloWorld/src/SConscript @@ -26,7 +26,6 @@ helper.make_plugins( [ mainlib, 'cetlib', 'cetlib_except', 'boost_filesystem', - 'boost_system', 'Core', ] ) diff --git a/MCDataProducts/src/SConscript b/MCDataProducts/src/SConscript index b46d49ad47..c140b08252 100644 --- a/MCDataProducts/src/SConscript +++ b/MCDataProducts/src/SConscript @@ -26,7 +26,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_GeometryService', 'cetlib', 'cetlib_except', 'CLHEP', - 'boost_system', 'Core' ] ) diff --git a/Mu2eBTrk/src/SConscript b/Mu2eBTrk/src/SConscript index 1ef37ac71b..3e97c4580d 100644 --- a/Mu2eBTrk/src/SConscript +++ b/Mu2eBTrk/src/SConscript @@ -25,7 +25,7 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -39,8 +39,7 @@ mainlib = helper.make_mainlib ( [ 'CLHEP', 'HepPDT', 'HepPID', - 'xerces-c', - 'boost_system', + 'xerces-c' ] ) # Fixme: split into link lists for each module. @@ -58,7 +57,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -73,7 +72,6 @@ helper.make_plugins( [ rootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', ] ) diff --git a/Mu2eG4/src/SConscript b/Mu2eG4/src/SConscript index d09de67a56..5076e9c004 100644 --- a/Mu2eG4/src/SConscript +++ b/Mu2eG4/src/SConscript @@ -245,7 +245,7 @@ mainlib = helper.make_mainlib ( [ 'art_Persistency_Provenance', 'art_Persistency_Common', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Framework_Principal', 'art_Framework_Core', @@ -263,7 +263,6 @@ mainlib = helper.make_mainlib ( [ 'CLHEP', 'Hist', 'Tree', 'Core', 'boost_regex', - 'boost_system', 'tbb', 'pthread', 'libcryptopp', @@ -286,7 +285,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -294,6 +293,7 @@ helper.make_plugins( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', G4LIBS, @@ -302,7 +302,6 @@ helper.make_plugins( [ 'CLHEP', 'Tree', 'Core', 'boost_filesystem', - 'boost_system', 'tbb', 'pthread', 'libcryptopp', diff --git a/Mu2eG4Helper/src/SConscript b/Mu2eG4Helper/src/SConscript index 1d2e1b49ba..2410fd65a6 100644 --- a/Mu2eG4Helper/src/SConscript +++ b/Mu2eG4Helper/src/SConscript @@ -19,7 +19,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_GeometryService', 'cetlib', 'cetlib_except', 'Core', - 'boost_system' ] ) helper.make_plugins( [ mainlib, @@ -34,7 +33,6 @@ helper.make_plugins( [ mainlib, 'cetlib_except', 'boost_filesystem', 'boost_regex', - 'boost_system', 'Core', ] ) diff --git a/Mu2eUtilities/src/SConscript b/Mu2eUtilities/src/SConscript index 4c00671e88..c0252a9c8f 100644 --- a/Mu2eUtilities/src/SConscript +++ b/Mu2eUtilities/src/SConscript @@ -31,7 +31,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService_ConditionsService_serv 'art_Persistency_Common', 'art_Persistency_Provenance', 'art_Framework_Services_Optional_RandomNumberGenerator_service', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', 'art_Framework_Principal', diff --git a/ParticleID/src/SConscript b/ParticleID/src/SConscript index e6fcf090d3..918cedd137 100644 --- a/ParticleID/src/SConscript +++ b/ParticleID/src/SConscript @@ -29,7 +29,7 @@ libs = [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -38,13 +38,13 @@ libs = [ 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', rootlibs, 'Minuit', 'boost_filesystem', - 'boost_system', 'pthread' ] diff --git a/Print/artProductSizes/SConscript b/Print/artProductSizes/SConscript index 367392b97f..c6fb3ec761 100644 --- a/Print/artProductSizes/SConscript +++ b/Print/artProductSizes/SConscript @@ -9,7 +9,7 @@ helper=mu2e_helper(env) rootlibs = env['ROOTLIBS'] # Boost libraries need for this executable only. -boostlibs = [ 'boost_filesystem', 'boost_iostreams', 'boost_system' ] +boostlibs = [ 'boost_filesystem', 'boost_iostreams' ] target = 'artProductSizes' diff --git a/Print/src/SConscript b/Print/src/SConscript index 984787512a..18351495bc 100644 --- a/Print/src/SConscript +++ b/Print/src/SConscript @@ -26,7 +26,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_GeometryService', 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -42,7 +42,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_GeometryService', 'CLHEP', 'HepPDT', 'boost_filesystem', - 'boost_system' ] ) @@ -57,7 +56,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Persistency_Provenance', 'art_Persistency_Common', 'art_Utilities', @@ -72,7 +71,6 @@ helper.make_plugins( [ mainlib, rootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', ] ) # this tells emacs to view this file in python mode. diff --git a/ProditionsService/src/SConscript b/ProditionsService/src/SConscript index 4e2a85b44d..3d15229e20 100644 --- a/ProditionsService/src/SConscript +++ b/ProditionsService/src/SConscript @@ -45,7 +45,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -57,7 +57,6 @@ helper.make_plugins( [ mainlib, 'cetlib', 'cetlib_except', 'boost_filesystem', - 'boost_system', 'pthread', 'xerces-c' ] ) diff --git a/RecoDataProducts/src/SConscript b/RecoDataProducts/src/SConscript index aaed484111..6dd62331ee 100644 --- a/RecoDataProducts/src/SConscript +++ b/RecoDataProducts/src/SConscript @@ -39,7 +39,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_DataProducts', 'CLHEP', 'Hist', 'Core', - 'boost_system' ] ) helper.make_dict_and_map( [ mainlib, @@ -63,7 +62,6 @@ helper.make_dict_and_map( [ mainlib, 'Core', 'art_Persistency_Common', 'art_Utilities', - 'boost_system' ], [ '-fvar-tracking-assignments-toggle'] ) diff --git a/Sandbox/src/SConscript b/Sandbox/src/SConscript index 7283a83d8f..f6b891dd0b 100644 --- a/Sandbox/src/SConscript +++ b/Sandbox/src/SConscript @@ -40,7 +40,6 @@ common = [ 'mu2e_SeedService_SeedService_service', 'CLHEP', 'Core', 'boost_filesystem', - 'boost_system', ] services = [ 'BarService_service.cc', @@ -61,7 +60,6 @@ helper.make_plugin( 'FooService_service.cc', 'canvas', 'fhiclcpp', 'boost_filesystem', - 'boost_system', 'Core' ], ) @@ -78,7 +76,6 @@ helper.make_plugin( 'BarService_service.cc', 'cetlib', 'cetlib_except', 'boost_filesystem', - 'boost_system', 'Core' ], ) @@ -95,7 +92,6 @@ helper.make_plugin( 'XBarService_service.cc', 'cetlib', 'cetlib_except', 'boost_filesystem', - 'boost_system', 'Core' ], ) @@ -112,7 +108,6 @@ helper.make_plugin( 'Bug01Service_service.cc', 'cetlib', 'cetlib_except', 'boost_filesystem', - 'boost_system', 'Core' ], ) @@ -149,7 +144,6 @@ helper.make_plugins( [ mainlib, 'CLHEP', 'Core', 'boost_filesystem', - 'boost_system', 'tbb', 'hep_concurrency' ], diff --git a/SeedService/src/SConscript b/SeedService/src/SConscript index 6792588b55..05b64195b3 100644 --- a/SeedService/src/SConscript +++ b/SeedService/src/SConscript @@ -38,7 +38,6 @@ helper.make_plugin( 'SeedService_service.cc', 'CLHEP', 'Core', 'boost_filesystem', - 'boost_system', ] ) helper.make_plugins( [ @@ -59,7 +58,6 @@ helper.make_plugins( [ 'CLHEP', 'Core', 'boost_filesystem', - 'boost_system', ], [ 'SeedService_service.cc', ], ) diff --git a/SimulationConditions/src/SConscript b/SimulationConditions/src/SConscript index 2d00bed3fe..80fb90cf42 100644 --- a/SimulationConditions/src/SConscript +++ b/SimulationConditions/src/SConscript @@ -41,7 +41,6 @@ mainlib = helper.make_mainlib ( [ 'cetlib_except', 'CLHEP', 'MathCore', - 'boost_system', rootlibs ] ) diff --git a/Sources/src/SConscript b/Sources/src/SConscript index 44324312a1..8bc32c8e01 100644 --- a/Sources/src/SConscript +++ b/Sources/src/SConscript @@ -29,7 +29,7 @@ mainlib = helper.make_mainlib(['mu2e_GlobalConstantsService', 'art_Persistency_Common', 'art_Framework_Services_Registry', 'art_Framework_Services_Optional_RandomNumberGenerator_service', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Framework_Principal', 'art_Framework_Core', @@ -43,7 +43,6 @@ mainlib = helper.make_mainlib(['mu2e_GlobalConstantsService', 'CLHEP', 'HepPDT', 'HepPID', - 'boost_system', 'gsl', ] ) @@ -65,7 +64,6 @@ helper.make_plugins( [ mainlib, 'CLHEP', 'Core', 'boost_filesystem', - 'boost_system', 'mu2e_GeometryService', 'mu2e_SeedService_SeedService_service', 'mu2e_CalorimeterGeom', diff --git a/TEveEventDisplay/src/SConscript b/TEveEventDisplay/src/SConscript index 846e946d20..0f8c94b104 100644 --- a/TEveEventDisplay/src/SConscript +++ b/TEveEventDisplay/src/SConscript @@ -17,14 +17,14 @@ babarlibs = env['BABARLIBS'] rootlibs = env['ROOTLIBS'] extrarootlibs = [ 'Geom', 'Geom', 'GeomPainter', 'Ged', 'Graf3d', 'Eve','EG', 'RGL','Gui', "Gdml" , "Core", "Rint"] -userlibs = [ rootlibs, +userlibs = [ rootlibs, extrarootlibs, babarlibs, 'mu2e_DataProducts', 'mu2e_Mu2eBTrk', - 'mu2e_TrkReco', + 'mu2e_TrkReco', 'mu2e_BTrkData', - 'mu2e_Mu2eUtilities', + 'mu2e_Mu2eUtilities', 'mu2e_MCDataProducts', 'mu2e_RecoDataProducts', 'mu2e_GlobalConstantsService_GlobalConstantsService_service', @@ -63,7 +63,7 @@ userlibs = [ rootlibs, ] -# when using ClassDef, tell the build to include the +# when using ClassDef, tell the build to include the # dictionary in the mainlib helper.classDef(True) @@ -79,5 +79,3 @@ helper.make_plugins( [ 'mu2e_TEveEventDisplay',userlibs ] ) # Local Variables: # mode:python # End: - - diff --git a/TrackCaloMatching/src/SConscript b/TrackCaloMatching/src/SConscript index 964b0bbf58..1e81071619 100644 --- a/TrackCaloMatching/src/SConscript +++ b/TrackCaloMatching/src/SConscript @@ -32,7 +32,6 @@ mainlib = helper.make_mainlib ( [ 'CLHEP', 'cetlib', 'cetlib_except', - 'boost_system' ] ) helper.make_plugins( [ @@ -51,7 +50,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -66,7 +65,6 @@ helper.make_plugins( [ rootlibs, extrarootlibs, 'boost_filesystem', - 'boost_system', ] ) diff --git a/TrackerAlignment/src/SConscript b/TrackerAlignment/src/SConscript index 7d5603c5ae..35ac03adeb 100644 --- a/TrackerAlignment/src/SConscript +++ b/TrackerAlignment/src/SConscript @@ -33,7 +33,7 @@ art_libs = [ 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -52,7 +52,6 @@ other_libs = [ 'pthread', - 'boost_system', 'boost_filesystem', 'boost_iostreams', 'boost_math_c99' diff --git a/TrackerConditions/src/SConscript b/TrackerConditions/src/SConscript index bb2263ed06..784b7dbd7a 100644 --- a/TrackerConditions/src/SConscript +++ b/TrackerConditions/src/SConscript @@ -39,7 +39,6 @@ mainlib = helper.make_mainlib ( [ 'cetlib_except', 'CLHEP', 'MathCore', - 'boost_system', rootlibs ] ) diff --git a/TrackerGeom/src/SConscript b/TrackerGeom/src/SConscript index f1b46f3a7f..0a7b4d225f 100644 --- a/TrackerGeom/src/SConscript +++ b/TrackerGeom/src/SConscript @@ -15,7 +15,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_DataProducts', 'mu2e_Mu2eInterfaces', 'cetlib_except', 'CLHEP', - 'boost_system', 'Core' ] ) diff --git a/TrackerMC/src/SConscript b/TrackerMC/src/SConscript index b799fbc9f8..ba5708e91a 100644 --- a/TrackerMC/src/SConscript +++ b/TrackerMC/src/SConscript @@ -21,7 +21,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_TrackerConditions', 'mu2e_DataProducts', 'art_Persistency_Provenance', 'art_Persistency_Common', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', 'art_Utilities', @@ -30,7 +30,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_TrackerConditions', 'cetlib_except', 'CLHEP', rootlibs, - 'boost_system', rootlibs ] ) @@ -53,7 +52,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -68,7 +67,6 @@ helper.make_plugins( [ mainlib, 'CLHEP', 'HepPDT', 'boost_filesystem', - 'boost_system', rootlibs, 'pthread' ] ) diff --git a/Trigger/src/SConscript b/Trigger/src/SConscript index 0d91b6cf5a..ec9c854f2d 100644 --- a/Trigger/src/SConscript +++ b/Trigger/src/SConscript @@ -49,7 +49,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', # 'art_Framework_Services_System', 'art_Framework_Services_System_TriggerNamesService_service', @@ -69,7 +69,6 @@ helper.make_plugins( [ mainlib, extrarootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', 'hep_concurrency', ] ) diff --git a/TrkDiag/src/SConscript b/TrkDiag/src/SConscript index 5fb890653c..3ca299ccd4 100644 --- a/TrkDiag/src/SConscript +++ b/TrkDiag/src/SConscript @@ -36,7 +36,7 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -54,7 +54,6 @@ mainlib = helper.make_mainlib ( [ 'HepPID', 'xerces-c', 'boost_filesystem', - 'boost_system', 'hep_concurrency', ] ) @@ -89,7 +88,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Framework_Services_System_TriggerNamesService_service', 'art_Persistency_Common', @@ -108,7 +107,6 @@ helper.make_plugins( [ rootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', 'hep_concurrency', 'pthread' ] ) diff --git a/TrkExt/src/SConscript b/TrkExt/src/SConscript index 99c9bf3edc..477cedf18b 100644 --- a/TrkExt/src/SConscript +++ b/TrkExt/src/SConscript @@ -31,7 +31,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_Mu2eBTrk', 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -43,7 +43,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_Mu2eBTrk', 'cetlib_except', rootlibs, 'CLHEP', - 'boost_system', ] ) helper.make_plugins( [ mainlib, @@ -62,7 +61,7 @@ helper.make_plugins( [ mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -75,7 +74,6 @@ helper.make_plugins( [ mainlib, 'CLHEP', rootlibs, 'boost_filesystem', - 'boost_system', ] ) # This tells emacs to view this file in python mode. diff --git a/TrkFilters/src/SConscript b/TrkFilters/src/SConscript index b2a89bb6b9..8011f437d4 100644 --- a/TrkFilters/src/SConscript +++ b/TrkFilters/src/SConscript @@ -30,7 +30,7 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -44,7 +44,6 @@ mainlib = helper.make_mainlib ( [ 'CLHEP', 'HepPDT', 'xerces-c', - 'boost_system', ] ) # Fixme: split into link lists for each module. @@ -67,7 +66,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -83,7 +82,6 @@ helper.make_plugins( [ 'General', rootlibs, 'boost_filesystem', - 'boost_system', ] ) diff --git a/TrkHitReco/src/SConscript b/TrkHitReco/src/SConscript index 13f025d7fa..894069da6d 100755 --- a/TrkHitReco/src/SConscript +++ b/TrkHitReco/src/SConscript @@ -24,7 +24,7 @@ mainlib = helper.make_mainlib([ 'mu2e_GlobalConstantsService', 'mu2e_DataProducts', 'mu2e_GeneralUtilities', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', 'art_Framework_Principal', @@ -36,7 +36,6 @@ mainlib = helper.make_mainlib([ 'cetlib', 'cetlib_except', rootlibs, - 'boost_system' ]) helper.make_plugins([mainlib, @@ -58,18 +57,19 @@ helper.make_plugins([mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Persistency_Common', 'art_Persistency_Provenance', 'art_Utilities', 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', 'boost_filesystem', - 'boost_system', rootlibs, 'TMVA', 'xerces-c', # only needed for MakeStereoHits_module.cc diff --git a/TrkPatRec/src/SConscript b/TrkPatRec/src/SConscript index 67dcf6a68f..3ee796ba88 100644 --- a/TrkPatRec/src/SConscript +++ b/TrkPatRec/src/SConscript @@ -35,7 +35,7 @@ mainlib = helper.make_mainlib(['mu2e_Mu2eBTrk', 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -47,7 +47,6 @@ mainlib = helper.make_mainlib(['mu2e_Mu2eBTrk', 'cetlib_except', rootlibs, 'CLHEP', - 'boost_system', ]) helper.make_plugins([mainlib, @@ -75,7 +74,7 @@ helper.make_plugins([mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -83,6 +82,8 @@ helper.make_plugins([mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', @@ -90,7 +91,6 @@ helper.make_plugins([mainlib, extrarootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', 'pthread' ]) diff --git a/TrkReco/src/SConscript b/TrkReco/src/SConscript index 3bf3f66ff2..028b1df630 100644 --- a/TrkReco/src/SConscript +++ b/TrkReco/src/SConscript @@ -33,7 +33,7 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -49,7 +49,6 @@ mainlib = helper.make_mainlib ( [ 'CLHEP', 'HepPDT', 'xerces-c', - 'boost_system', ] ) # Fixme: split into link lists for each module. @@ -75,7 +74,7 @@ helper.make_plugins( [ 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -83,6 +82,7 @@ helper.make_plugins( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', 'cetlib', 'cetlib_except', 'CLHEP', @@ -90,7 +90,6 @@ helper.make_plugins( [ rootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', ] ) # Fixme: do I need all of babarlibs below? @@ -104,7 +103,6 @@ helper.make_dict_and_map( [ 'cetlib_except', 'CLHEP', 'Core', - 'boost_system' ] ) diff --git a/UtilityModules/src/SConscript b/UtilityModules/src/SConscript index 640be5b8df..b2e6a31f46 100644 --- a/UtilityModules/src/SConscript +++ b/UtilityModules/src/SConscript @@ -33,7 +33,6 @@ common = [ 'mu2e_MCDataProducts', 'CLHEP', 'Core', 'boost_filesystem', - 'boost_system', ] @@ -68,7 +67,6 @@ helper.make_plugins( [ mainlib, 'CLHEP', 'Core', 'boost_filesystem', - 'boost_system', ] ) diff --git a/Validation/src/SConscript b/Validation/src/SConscript index c465f58b6c..26caae7ac7 100644 --- a/Validation/src/SConscript +++ b/Validation/src/SConscript @@ -27,7 +27,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_Validation_root', 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -39,7 +39,6 @@ mainlib = helper.make_mainlib ( [ 'mu2e_Validation_root', 'General', rootlibs, 'CLHEP', - 'boost_system' ] ) @@ -55,7 +54,7 @@ helper.make_plugins( [ mainlib,'mu2e_Validation_root', 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', @@ -63,11 +62,11 @@ helper.make_plugins( [ mainlib,'mu2e_Validation_root', 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, 'CLHEP', - 'boost_system', 'boost_filesystem' ] ) From ba6e5add3ec0bf5a6544e2619cac22208367a47a Mon Sep 17 00:00:00 2001 From: macndev Date: Thu, 8 Apr 2021 18:43:29 -0500 Subject: [PATCH 04/54] Third round of rebase merges working area with hacks --- Analyses/src/SConscript | 6 ++++-- BFieldTest/src/SConscript | 1 + CRVFilters/src/SConscript | 1 + CRVResponse/src/SConscript | 1 + CalPatRec/src/SConscript | 2 ++ CaloCluster/src/SConscript | 3 +++ CaloDiag/src/SConscript | 4 +++- CaloFilters/src/SConscript | 1 + CaloMC/src/SConscript | 3 +++ CaloReco/src/SConscript | 3 +++ CommonMC/src/SConscript | 2 ++ Compression/src/SConscript | 1 + ConditionsService/src/SConscript | 1 + CosmicReco/src/SConscript | 3 +++ CutAndCountAnalysis/src/SConscript | 3 +++ DbService/src/SConscript | 1 + EventDisplay/src/SConscript | 1 + EventGenerator/src/SConscript | 3 +++ EventMixing/src/SConscript | 3 +++ ExtinctionMonitorFNAL/Analyses/src/SConscript | 1 + ExtinctionMonitorFNAL/Digitization/src/SConscript | 1 + ExtinctionMonitorFNAL/Reconstruction/src/SConscript | 1 + ExtinctionMonitorFNAL/TruthAlgs/src/SConscript | 1 + ExtinctionMonitorFNAL/Utilities/src/SConscript | 1 + Filters/src/SConscript | 1 + GeneralUtilities/src/SConscript | 1 + GeometryService/src/SConscript | 2 ++ GlobalConstantsService/src/SConscript | 1 + HelloWorld/src/SConscript | 1 + Mu2eBTrk/src/SConscript | 1 + Mu2eG4/src/SConscript | 1 + Mu2eG4Helper/src/SConscript | 1 + Mu2eUtilities/src/SConscript | 1 + Print/src/SConscript | 3 +++ ProditionsService/src/SConscript | 1 + Sandbox/src/SConscript | 1 + SeedService/src/SConscript | 1 + SimulationConditions/src/SConscript | 1 + Sources/src/SConscript | 3 +++ TrackCaloMatching/src/SConscript | 1 + TrackerAlignment/src/SConscript | 1 + TrackerConditions/src/SConscript | 1 + TrackerMC/src/SConscript | 1 + Trigger/src/SConscript | 1 + TrkDiag/src/SConscript | 3 +++ TrkExt/src/SConscript | 1 + TrkFilters/src/SConscript | 1 + TrkHitReco/src/SConscript | 1 + TrkPatRec/src/SConscript | 1 + TrkReco/src/SConscript | 2 ++ UtilityModules/src/SConscript | 7 ++++++- setup.sh | 1 + 52 files changed, 86 insertions(+), 4 deletions(-) diff --git a/Analyses/src/SConscript b/Analyses/src/SConscript index 83a332ef3c..c4c4d6281d 100644 --- a/Analyses/src/SConscript +++ b/Analyses/src/SConscript @@ -15,7 +15,8 @@ babarlibs = env['BABARLIBS'] extrarootlibs = [ 'Geom' ] -mainlib = helper.make_mainlib ( [] ) +mainlib = helper.make_mainlib ( ['fhiclcpp_types', + 'tbb',] ) helper.make_plugins( [ mainlib, 'mu2e_TrkExt', @@ -58,6 +59,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', @@ -70,7 +72,7 @@ helper.make_plugins( [ mainlib, 'pthread', 'hep_concurrency', 'DTCInterface', - 'mu2e-artdaq-core_Overlays' + # 'mu2e-artdaq-core_Overlays' ] ) # this tells emacs to view this file in python mode. diff --git a/BFieldTest/src/SConscript b/BFieldTest/src/SConscript index 1fc806f1cb..02ddb53bda 100644 --- a/BFieldTest/src/SConscript +++ b/BFieldTest/src/SConscript @@ -28,6 +28,7 @@ helper.make_plugins( [ 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CRVFilters/src/SConscript b/CRVFilters/src/SConscript index 2a446e2cc5..d7e3b9614e 100644 --- a/CRVFilters/src/SConscript +++ b/CRVFilters/src/SConscript @@ -22,6 +22,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, diff --git a/CRVResponse/src/SConscript b/CRVResponse/src/SConscript index dd32f925fe..11ef905dbe 100644 --- a/CRVResponse/src/SConscript +++ b/CRVResponse/src/SConscript @@ -55,6 +55,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CalPatRec/src/SConscript b/CalPatRec/src/SConscript index 3f97ba456d..3a5ea27898 100644 --- a/CalPatRec/src/SConscript +++ b/CalPatRec/src/SConscript @@ -122,6 +122,8 @@ helper.make_dict_and_map( [ mainlib, 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, diff --git a/CaloCluster/src/SConscript b/CaloCluster/src/SConscript index cfe1afec56..a635a699bc 100644 --- a/CaloCluster/src/SConscript +++ b/CaloCluster/src/SConscript @@ -38,6 +38,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Utilities', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', @@ -64,6 +65,8 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CaloDiag/src/SConscript b/CaloDiag/src/SConscript index 83a332ef3c..3161d0f6ac 100644 --- a/CaloDiag/src/SConscript +++ b/CaloDiag/src/SConscript @@ -15,7 +15,8 @@ babarlibs = env['BABARLIBS'] extrarootlibs = [ 'Geom' ] -mainlib = helper.make_mainlib ( [] ) +mainlib = helper.make_mainlib ( ['fhiclcpp_types', + 'tbb',] ) helper.make_plugins( [ mainlib, 'mu2e_TrkExt', @@ -58,6 +59,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CaloFilters/src/SConscript b/CaloFilters/src/SConscript index 2dda131404..d1b0e9283a 100644 --- a/CaloFilters/src/SConscript +++ b/CaloFilters/src/SConscript @@ -55,6 +55,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CaloMC/src/SConscript b/CaloMC/src/SConscript index 405ddf86ba..d8fb16b30a 100644 --- a/CaloMC/src/SConscript +++ b/CaloMC/src/SConscript @@ -40,6 +40,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Framework_Core', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', @@ -68,6 +69,8 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CaloReco/src/SConscript b/CaloReco/src/SConscript index 12638c7d7d..bac8f68963 100644 --- a/CaloReco/src/SConscript +++ b/CaloReco/src/SConscript @@ -34,6 +34,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Utilities', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', @@ -61,6 +62,8 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CommonMC/src/SConscript b/CommonMC/src/SConscript index 44db93812a..0641745086 100644 --- a/CommonMC/src/SConscript +++ b/CommonMC/src/SConscript @@ -75,6 +75,8 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Compression/src/SConscript b/Compression/src/SConscript index 92dd93361f..30b086798e 100644 --- a/Compression/src/SConscript +++ b/Compression/src/SConscript @@ -40,6 +40,7 @@ helper.make_plugins( [ 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/ConditionsService/src/SConscript b/ConditionsService/src/SConscript index c027062190..9ad9201d3b 100644 --- a/ConditionsService/src/SConscript +++ b/ConditionsService/src/SConscript @@ -37,6 +37,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'canvas', 'cetlib', 'cetlib_except', diff --git a/CosmicReco/src/SConscript b/CosmicReco/src/SConscript index fe653a63d9..90a1e2b1c1 100644 --- a/CosmicReco/src/SConscript +++ b/CosmicReco/src/SConscript @@ -42,6 +42,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, @@ -84,6 +85,8 @@ helper.make_plugins( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/CutAndCountAnalysis/src/SConscript b/CutAndCountAnalysis/src/SConscript index c4562f73bd..67f9a199dd 100644 --- a/CutAndCountAnalysis/src/SConscript +++ b/CutAndCountAnalysis/src/SConscript @@ -51,6 +51,7 @@ mainlib = helper.make_mainlib ( [ 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', @@ -98,6 +99,8 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/DbService/src/SConscript b/DbService/src/SConscript index fe9e6d0981..d1170c78cc 100644 --- a/DbService/src/SConscript +++ b/DbService/src/SConscript @@ -37,6 +37,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'boost_filesystem', diff --git a/EventDisplay/src/SConscript b/EventDisplay/src/SConscript index c1f0396e90..0e68728ca5 100644 --- a/EventDisplay/src/SConscript +++ b/EventDisplay/src/SConscript @@ -45,6 +45,7 @@ userlibs = [ rootlibs, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/EventGenerator/src/SConscript b/EventGenerator/src/SConscript index 90557e7368..106b78edf2 100644 --- a/EventGenerator/src/SConscript +++ b/EventGenerator/src/SConscript @@ -45,6 +45,7 @@ mainlib = helper.make_mainlib ( [ 'CRY', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'MF_MessageLogger', 'cetlib', 'cetlib_except', @@ -83,6 +84,8 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/EventMixing/src/SConscript b/EventMixing/src/SConscript index c79ecf5f19..e31493048f 100644 --- a/EventMixing/src/SConscript +++ b/EventMixing/src/SConscript @@ -29,6 +29,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'hep_concurrency', @@ -57,6 +58,8 @@ helper.make_plugins ( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'hep_concurrency', diff --git a/ExtinctionMonitorFNAL/Analyses/src/SConscript b/ExtinctionMonitorFNAL/Analyses/src/SConscript index 49bfca0d2d..98731b9ea3 100644 --- a/ExtinctionMonitorFNAL/Analyses/src/SConscript +++ b/ExtinctionMonitorFNAL/Analyses/src/SConscript @@ -57,6 +57,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/ExtinctionMonitorFNAL/Digitization/src/SConscript b/ExtinctionMonitorFNAL/Digitization/src/SConscript index 807d0cca90..8bd15494d8 100644 --- a/ExtinctionMonitorFNAL/Digitization/src/SConscript +++ b/ExtinctionMonitorFNAL/Digitization/src/SConscript @@ -30,6 +30,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/ExtinctionMonitorFNAL/Reconstruction/src/SConscript b/ExtinctionMonitorFNAL/Reconstruction/src/SConscript index e13b60bf26..2d2a74998e 100644 --- a/ExtinctionMonitorFNAL/Reconstruction/src/SConscript +++ b/ExtinctionMonitorFNAL/Reconstruction/src/SConscript @@ -32,6 +32,7 @@ helper.make_plugins( [ mainlib, my_libs, 'art_Framework_Principal', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'boost_filesystem', 'Hist', 'Core' diff --git a/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript b/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript index ec165e4a34..8fc66aeabb 100644 --- a/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript +++ b/ExtinctionMonitorFNAL/TruthAlgs/src/SConscript @@ -22,6 +22,7 @@ helper.make_plugins ( [ 'mu2e_Mu2eUtilities', 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, diff --git a/ExtinctionMonitorFNAL/Utilities/src/SConscript b/ExtinctionMonitorFNAL/Utilities/src/SConscript index 51eaaac1e0..ba63f38fa2 100644 --- a/ExtinctionMonitorFNAL/Utilities/src/SConscript +++ b/ExtinctionMonitorFNAL/Utilities/src/SConscript @@ -20,6 +20,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ExtinctionMonitorFNAL_Geometry', 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Filters/src/SConscript b/Filters/src/SConscript index efa91aecaa..c8c6675f06 100644 --- a/Filters/src/SConscript +++ b/Filters/src/SConscript @@ -45,6 +45,7 @@ helper.make_plugins( [ 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/GeneralUtilities/src/SConscript b/GeneralUtilities/src/SConscript index 822c0e9f6d..07a9d62c8b 100644 --- a/GeneralUtilities/src/SConscript +++ b/GeneralUtilities/src/SConscript @@ -16,6 +16,7 @@ mainlib = helper.make_mainlib ( [ 'art_Persistency_Common', 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/GeometryService/src/SConscript b/GeometryService/src/SConscript index 1c35b4dcee..83c85d6646 100644 --- a/GeometryService/src/SConscript +++ b/GeometryService/src/SConscript @@ -70,6 +70,8 @@ helper.make_plugins( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/GlobalConstantsService/src/SConscript b/GlobalConstantsService/src/SConscript index 77dcc5d262..789b8ca2d6 100644 --- a/GlobalConstantsService/src/SConscript +++ b/GlobalConstantsService/src/SConscript @@ -21,6 +21,7 @@ mainlib = helper.make_mainlib ( [ 'art_Framework_Services_Registry', 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/HelloWorld/src/SConscript b/HelloWorld/src/SConscript index a9c26e4354..d871fc6fd4 100644 --- a/HelloWorld/src/SConscript +++ b/HelloWorld/src/SConscript @@ -23,6 +23,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'boost_filesystem', diff --git a/Mu2eBTrk/src/SConscript b/Mu2eBTrk/src/SConscript index 3e97c4580d..0579d79d55 100644 --- a/Mu2eBTrk/src/SConscript +++ b/Mu2eBTrk/src/SConscript @@ -33,6 +33,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, diff --git a/Mu2eG4/src/SConscript b/Mu2eG4/src/SConscript index 5076e9c004..7056198dd2 100644 --- a/Mu2eG4/src/SConscript +++ b/Mu2eG4/src/SConscript @@ -294,6 +294,7 @@ helper.make_plugins( [ 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', G4LIBS, diff --git a/Mu2eG4Helper/src/SConscript b/Mu2eG4Helper/src/SConscript index 2410fd65a6..d7dab089d6 100644 --- a/Mu2eG4Helper/src/SConscript +++ b/Mu2eG4Helper/src/SConscript @@ -29,6 +29,7 @@ helper.make_plugins( [ mainlib, 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'boost_filesystem', diff --git a/Mu2eUtilities/src/SConscript b/Mu2eUtilities/src/SConscript index c0252a9c8f..42f8342b4d 100644 --- a/Mu2eUtilities/src/SConscript +++ b/Mu2eUtilities/src/SConscript @@ -44,6 +44,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService_ConditionsService_serv XERCESC_LIBS, 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'hep_concurrency', diff --git a/Print/src/SConscript b/Print/src/SConscript index 18351495bc..c173ce8754 100644 --- a/Print/src/SConscript +++ b/Print/src/SConscript @@ -34,6 +34,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_GeometryService', 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'Trajectory', @@ -63,6 +64,8 @@ helper.make_plugins( [ mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/ProditionsService/src/SConscript b/ProditionsService/src/SConscript index 3d15229e20..affd8428d2 100644 --- a/ProditionsService/src/SConscript +++ b/ProditionsService/src/SConscript @@ -54,6 +54,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'boost_filesystem', diff --git a/Sandbox/src/SConscript b/Sandbox/src/SConscript index f6b891dd0b..c8f71ab135 100644 --- a/Sandbox/src/SConscript +++ b/Sandbox/src/SConscript @@ -35,6 +35,7 @@ common = [ 'mu2e_SeedService_SeedService_service', 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/SeedService/src/SConscript b/SeedService/src/SConscript index 05b64195b3..75333408da 100644 --- a/SeedService/src/SConscript +++ b/SeedService/src/SConscript @@ -33,6 +33,7 @@ helper.make_plugin( 'SeedService_service.cc', 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/SimulationConditions/src/SConscript b/SimulationConditions/src/SConscript index 80fb90cf42..908c644759 100644 --- a/SimulationConditions/src/SConscript +++ b/SimulationConditions/src/SConscript @@ -37,6 +37,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/Sources/src/SConscript b/Sources/src/SConscript index 8bc32c8e01..017a45b154 100644 --- a/Sources/src/SConscript +++ b/Sources/src/SConscript @@ -37,6 +37,7 @@ mainlib = helper.make_mainlib(['mu2e_GlobalConstantsService', 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'MF_MessageLogger', 'cetlib', 'cetlib_except', @@ -59,6 +60,8 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrackCaloMatching/src/SConscript b/TrackCaloMatching/src/SConscript index 1e81071619..e67c8261ba 100644 --- a/TrackCaloMatching/src/SConscript +++ b/TrackCaloMatching/src/SConscript @@ -59,6 +59,7 @@ helper.make_plugins( [ 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrackerAlignment/src/SConscript b/TrackerAlignment/src/SConscript index 35ac03adeb..1fa2d46fcd 100644 --- a/TrackerAlignment/src/SConscript +++ b/TrackerAlignment/src/SConscript @@ -44,6 +44,7 @@ other_libs = [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrackerConditions/src/SConscript b/TrackerConditions/src/SConscript index 784b7dbd7a..2848d41e02 100644 --- a/TrackerConditions/src/SConscript +++ b/TrackerConditions/src/SConscript @@ -35,6 +35,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrackerMC/src/SConscript b/TrackerMC/src/SConscript index ba5708e91a..a52d9d1a5d 100644 --- a/TrackerMC/src/SConscript +++ b/TrackerMC/src/SConscript @@ -61,6 +61,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'BTrk_BField', diff --git a/Trigger/src/SConscript b/Trigger/src/SConscript index ec9c854f2d..866420ba5c 100644 --- a/Trigger/src/SConscript +++ b/Trigger/src/SConscript @@ -60,6 +60,7 @@ helper.make_plugins( [ mainlib, 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrkDiag/src/SConscript b/TrkDiag/src/SConscript index 3ca299ccd4..1f194ffdaf 100644 --- a/TrkDiag/src/SConscript +++ b/TrkDiag/src/SConscript @@ -44,6 +44,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'Trajectory', @@ -97,6 +98,8 @@ helper.make_plugins( [ 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/TrkExt/src/SConscript b/TrkExt/src/SConscript index 477cedf18b..f147d3f0bf 100644 --- a/TrkExt/src/SConscript +++ b/TrkExt/src/SConscript @@ -39,6 +39,7 @@ mainlib = helper.make_mainlib ( [ 'mu2e_Mu2eBTrk', 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, diff --git a/TrkFilters/src/SConscript b/TrkFilters/src/SConscript index 8011f437d4..8a8db1e234 100644 --- a/TrkFilters/src/SConscript +++ b/TrkFilters/src/SConscript @@ -38,6 +38,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, diff --git a/TrkHitReco/src/SConscript b/TrkHitReco/src/SConscript index 894069da6d..e41d3ac54f 100755 --- a/TrkHitReco/src/SConscript +++ b/TrkHitReco/src/SConscript @@ -33,6 +33,7 @@ mainlib = helper.make_mainlib([ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, diff --git a/TrkPatRec/src/SConscript b/TrkPatRec/src/SConscript index 3ee796ba88..16c58c83f5 100644 --- a/TrkPatRec/src/SConscript +++ b/TrkPatRec/src/SConscript @@ -43,6 +43,7 @@ mainlib = helper.make_mainlib(['mu2e_Mu2eBTrk', 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', rootlibs, diff --git a/TrkReco/src/SConscript b/TrkReco/src/SConscript index 028b1df630..a523d481fa 100644 --- a/TrkReco/src/SConscript +++ b/TrkReco/src/SConscript @@ -41,6 +41,7 @@ mainlib = helper.make_mainlib ( [ 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'Trajectory', @@ -83,6 +84,7 @@ helper.make_plugins( [ 'MF_MessageLogger', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/UtilityModules/src/SConscript b/UtilityModules/src/SConscript index b2e6a31f46..897a17a4ad 100644 --- a/UtilityModules/src/SConscript +++ b/UtilityModules/src/SConscript @@ -28,6 +28,7 @@ common = [ 'mu2e_MCDataProducts', 'canvas', 'fhiclcpp', 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', @@ -36,7 +37,9 @@ common = [ 'mu2e_MCDataProducts', ] -mainlib = helper.make_mainlib ( [ 'MF_MessageLogger' +mainlib = helper.make_mainlib ( [ 'MF_MessageLogger', + 'fhiclcpp_types', + 'tbb', ] ) # Each service requires a custom link list so make them one at a time. @@ -62,6 +65,8 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', diff --git a/setup.sh b/setup.sh index fa95c00494..aea87c66f3 100644 --- a/setup.sh +++ b/setup.sh @@ -135,6 +135,7 @@ fi setup -B mu2e_artdaq_core v1_05_07 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} setup -B heppdt v03_04_02 -q${MU2E_UPS_QUALIFIERS} +setup cetpkgsupport setup -B KinKal v00_01_05a -q${MU2E_UPS_QUALIFIERS}:p392 setup -B BTrk v1_02_31 -q${MU2E_UPS_QUALIFIERS}:p392 setup -B cry v1_7n -q${MU2E_UPS_QUALIFIERS} From c4331c95e1b4eabbbe759d62bdc47f8dd0d554b2 Mon Sep 17 00:00:00 2001 From: macndev Date: Fri, 9 Apr 2021 13:10:02 -0500 Subject: [PATCH 05/54] undoing the hacks around MADC and friends --- .../src/{FragmentAna_module.cc.sav => FragmentAna_module.cc} | 0 Analyses/src/SConscript | 2 +- DAQ/src/{SConscript.sav => SConscript} | 4 ++++ 3 files changed, 5 insertions(+), 1 deletion(-) rename Analyses/src/{FragmentAna_module.cc.sav => FragmentAna_module.cc} (100%) rename DAQ/src/{SConscript.sav => SConscript} (95%) diff --git a/Analyses/src/FragmentAna_module.cc.sav b/Analyses/src/FragmentAna_module.cc similarity index 100% rename from Analyses/src/FragmentAna_module.cc.sav rename to Analyses/src/FragmentAna_module.cc diff --git a/Analyses/src/SConscript b/Analyses/src/SConscript index c4c4d6281d..3161d0f6ac 100644 --- a/Analyses/src/SConscript +++ b/Analyses/src/SConscript @@ -72,7 +72,7 @@ helper.make_plugins( [ mainlib, 'pthread', 'hep_concurrency', 'DTCInterface', - # 'mu2e-artdaq-core_Overlays' + 'mu2e-artdaq-core_Overlays' ] ) # this tells emacs to view this file in python mode. diff --git a/DAQ/src/SConscript.sav b/DAQ/src/SConscript similarity index 95% rename from DAQ/src/SConscript.sav rename to DAQ/src/SConscript index c9b6d2c217..84138782f7 100644 --- a/DAQ/src/SConscript.sav +++ b/DAQ/src/SConscript @@ -36,6 +36,8 @@ mainlib = helper.make_mainlib ( [ 'mu2e_ConditionsService', 'art_Utilities', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', @@ -69,6 +71,8 @@ helper.make_plugins( [ mainlib, 'art_Utilities', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', From c7b638f98471e30643d4de3b77f2ef799c471145 Mon Sep 17 00:00:00 2001 From: macndev Date: Sun, 11 Apr 2021 16:52:18 -0500 Subject: [PATCH 06/54] second rebase changes --- Mu2eKinKal/src/SConscript | 9 ++++++--- scripts/build/python/sconstruct_helper.py | 12 ++++++------ 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/Mu2eKinKal/src/SConscript b/Mu2eKinKal/src/SConscript index 58f07200eb..e1329f37b7 100644 --- a/Mu2eKinKal/src/SConscript +++ b/Mu2eKinKal/src/SConscript @@ -32,13 +32,15 @@ mainlib = helper.make_mainlib([ 'art_Framework_Core', 'art_Framework_Principal', 'art_Framework_Services_Registry', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_root_io_tfile_support', 'art_Persistency_Provenance', 'art_Persistency_Common', 'art_Utilities', 'canvas', 'fhiclcpp', + 'fhiclcpp_types', + 'tbb', 'cetlib', 'cetlib_except', 'Fit', @@ -72,7 +74,7 @@ helper.make_plugins([mainlib, 'art_Framework_Principal', 'art_Framework_Services_Registry', 'art_root_io_tfile_support', - 'art_root_io_TFileService_service', + 'art_root_io_TFileService', 'art_Framework_Services_Optional_RandomNumberGenerator_service', 'art_Persistency_Common', 'art_Persistency_Provenance', @@ -80,6 +82,8 @@ helper.make_plugins([mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', + 'fhiclcpp_types' + 'tbb', 'cetlib', 'cetlib_except', 'CLHEP', @@ -93,7 +97,6 @@ helper.make_plugins([mainlib, extrarootlibs, 'xerces-c', 'boost_filesystem', - 'boost_system', 'pthread' ]) diff --git a/scripts/build/python/sconstruct_helper.py b/scripts/build/python/sconstruct_helper.py index ee134b06d9..f9ef5b70c5 100644 --- a/scripts/build/python/sconstruct_helper.py +++ b/scripts/build/python/sconstruct_helper.py @@ -74,15 +74,15 @@ def cppPath(mu2eOpts): os.environ['CETLIB_EXCEPT_INC'], os.environ['BOOST_INC'], os.environ['CLHEP_INC'], - # os.environ['CPPUNIT_DIR']+'/include', + os.environ['CPPUNIT_DIR']+'/include', os.environ['HEPPDT_INC'], os.environ['ROOT_INC'], os.environ['XERCES_C_INC'], os.environ['TBB_INC'], - # os.environ['MU2E_ARTDAQ_CORE_INC'], - # os.environ['ARTDAQ_CORE_INC'], - # os.environ['PCIE_LINUX_KERNEL_MODULE_INC'], - # os.environ['TRACE_INC'], + os.environ['MU2E_ARTDAQ_CORE_INC'], + os.environ['ARTDAQ_CORE_INC'], + os.environ['PCIE_LINUX_KERNEL_MODULE_INC'], + os.environ['TRACE_INC'], os.environ['GSL_INC'], os.environ['POSTGRESQL_INC'] ] @@ -112,7 +112,7 @@ def libPath(mu2eOpts): os.environ['CETLIB_EXCEPT_LIB'], os.environ['BOOST_LIB'], os.environ['CLHEP_LIB_DIR'], - # os.environ['CPPUNIT_DIR']+'/lib', + os.environ['CPPUNIT_DIR']+'/lib', os.environ['HEPPDT_LIB'], os.environ['ROOTSYS']+'/lib', os.environ['XERCESCROOT']+'/lib', From 08cdc99a8abfca7268bfa50fecb8b77a503eb86c Mon Sep 17 00:00:00 2001 From: macndev Date: Tue, 13 Apr 2021 12:34:44 -0500 Subject: [PATCH 07/54] bug fixes, CPPUNIT and KinKal typo --- Mu2eKinKal/src/SConscript | 2 +- scripts/build/python/sconstruct_helper.py | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Mu2eKinKal/src/SConscript b/Mu2eKinKal/src/SConscript index e1329f37b7..8de3329e6d 100644 --- a/Mu2eKinKal/src/SConscript +++ b/Mu2eKinKal/src/SConscript @@ -82,7 +82,7 @@ helper.make_plugins([mainlib, 'canvas', 'MF_MessageLogger', 'fhiclcpp', - 'fhiclcpp_types' + 'fhiclcpp_types', 'tbb', 'cetlib', 'cetlib_except', diff --git a/scripts/build/python/sconstruct_helper.py b/scripts/build/python/sconstruct_helper.py index f9ef5b70c5..695b64d855 100644 --- a/scripts/build/python/sconstruct_helper.py +++ b/scripts/build/python/sconstruct_helper.py @@ -74,7 +74,6 @@ def cppPath(mu2eOpts): os.environ['CETLIB_EXCEPT_INC'], os.environ['BOOST_INC'], os.environ['CLHEP_INC'], - os.environ['CPPUNIT_DIR']+'/include', os.environ['HEPPDT_INC'], os.environ['ROOT_INC'], os.environ['XERCES_C_INC'], @@ -112,7 +111,6 @@ def libPath(mu2eOpts): os.environ['CETLIB_EXCEPT_LIB'], os.environ['BOOST_LIB'], os.environ['CLHEP_LIB_DIR'], - os.environ['CPPUNIT_DIR']+'/lib', os.environ['HEPPDT_LIB'], os.environ['ROOTSYS']+'/lib', os.environ['XERCESCROOT']+'/lib', From 6eab9e9feeaa403e8358f12ba4f082a25081f8c8 Mon Sep 17 00:00:00 2001 From: macndev Date: Wed, 14 Apr 2021 17:39:08 -0500 Subject: [PATCH 08/54] change .mu2e ENVSET to p004 --- .muse | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.muse b/.muse index 7725999410..7507d150a1 100644 --- a/.muse +++ b/.muse @@ -1,5 +1,5 @@ # prefer to build with this environment -ENVSET p003 +ENVSET p004 # add these to python path PYTHONPATH TrackerAlignment/scripts PYTHONPATH Trigger/python From 8b13356954e88748c6aa49b1ac422304fd4fc58f Mon Sep 17 00:00:00 2001 From: macndev Date: Fri, 7 May 2021 13:02:12 -0500 Subject: [PATCH 09/54] setup.sh tag changes --- setup.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/setup.sh b/setup.sh index aea87c66f3..9a71214741 100644 --- a/setup.sh +++ b/setup.sh @@ -101,7 +101,7 @@ build=$($MU2E_BASE_RELEASE/buildopts --build) # and is therefore different from the value shown in # SETUP_ environment vars, or by the "ups active" command. export MU2E_UPS_QUALIFIERS=+e20:+${build} -export MU2E_ART_SQUALIFIER=s107 +export MU2E_ART_SQUALIFIER=s108 MU2E_G4_GRAPHICS_QUALIFIER='' if [[ $($MU2E_BASE_RELEASE/buildopts --g4vis) == qt ]]; then @@ -121,8 +121,8 @@ fi export MU2E_G4_EXTRA_QUALIFIER='' # Setup the framework and its dependent products -setup -B art v3_08_00 -q${MU2E_UPS_QUALIFIERS} -setup -B art_root_io v1_07_00 -q${MU2E_UPS_QUALIFIERS} +setup -B art v3_09_00 -q${MU2E_UPS_QUALIFIERS} +setup -B art_root_io v1_08_00 -q${MU2E_UPS_QUALIFIERS} # Geant4 and its cross-section files. if [[ $($MU2E_BASE_RELEASE/buildopts --trigger) == "off" ]]; then @@ -132,7 +132,7 @@ else fi # Get access to raw data formats. -setup -B mu2e_artdaq_core v1_05_07 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} +setup -B mu2e_artdaq_core v1_05_10 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} setup -B heppdt v03_04_02 -q${MU2E_UPS_QUALIFIERS} setup cetpkgsupport From ee17f97e6c77675a5beb4cd032fba42110f234be Mon Sep 17 00:00:00 2001 From: gianipez Date: Sun, 18 Apr 2021 14:35:14 -0500 Subject: [PATCH 10/54] updates --- DAQ/fcl/prolog_trigger.fcl | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/DAQ/fcl/prolog_trigger.fcl b/DAQ/fcl/prolog_trigger.fcl index 3e660908bb..64b9b8d4e6 100644 --- a/DAQ/fcl/prolog_trigger.fcl +++ b/DAQ/fcl/prolog_trigger.fcl @@ -34,7 +34,7 @@ DAQ : { # bufferSize : 1000 } - makeSD: + makeSDOld: { module_type: StrawAndCaloDigisFromFragments diagLevel: 0 @@ -46,6 +46,14 @@ DAQ : { caloTag : "daq:calo" } + makeSD: + { + module_type: StrawRecoFromFragments + diagLevel : 0 + useTrkADC : 0 + trkTag : "daq:trk" + } + CaloDigiMaker: { module_type : CaloRecoFromFragments @@ -62,6 +70,8 @@ DAQ : { deltaTPulses : 5. pulseRatioMax : 1.1 pulseRatioMin : 0.9 + # hitEDepMax : 80. + hitEDepMax : 1000. # for testing } CrvDigi: From 94a1e0f50e0199ac2910382b54629121b894e5af Mon Sep 17 00:00:00 2001 From: gianipez Date: Tue, 20 Apr 2021 10:44:25 -0500 Subject: [PATCH 11/54] style --- DAQ/src/CaloRecoFromFragments_module.cc | 4 ++++ DAQ/src/StrawRecoFromFragments_module.cc | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/DAQ/src/CaloRecoFromFragments_module.cc b/DAQ/src/CaloRecoFromFragments_module.cc index 4a084240e5..2665e3e50c 100644 --- a/DAQ/src/CaloRecoFromFragments_module.cc +++ b/DAQ/src/CaloRecoFromFragments_module.cc @@ -88,6 +88,10 @@ void art::CaloRecoFromFragments::produce(Event& event) { return; } numCalFrags = calFragments->size(); + if (diagLevel_ > 1) { + std::cout << "[CaloRecoFromFragments::produce] found "<< numCalFrags <<" Calorimeter fragments" + << std::endl; + } for (size_t idx = 0; idx < numCalFrags; ++idx) { auto size = ((*calFragments)[idx]).sizeBytes(); // * sizeof(artdaq::RawDataType); totalSize += size; diff --git a/DAQ/src/StrawRecoFromFragments_module.cc b/DAQ/src/StrawRecoFromFragments_module.cc index 564d6e480b..c368cee2b9 100644 --- a/DAQ/src/StrawRecoFromFragments_module.cc +++ b/DAQ/src/StrawRecoFromFragments_module.cc @@ -212,7 +212,7 @@ void art::StrawRecoFromFragmnets::analyze_tracker_( mu2e::StrawId sid(trkDataPair.first->StrawIndex); mu2e::TrkTypes::TDCValues tdc = {trkDataPair.first->TDC0(), trkDataPair.first->TDC1()}; mu2e::TrkTypes::TOTValues tot = {trkDataPair.first->TOT0, trkDataPair.first->TOT1}; - mu2e::TrkTypes::ADCValue pmp = trkDataPair.first->PMP; + mu2e::TrkTypes::ADCValue pmp = trkDataPair.first->PMP; // Fill the StrawDigiCollection straw_digis->emplace_back(sid, tdc, tot, pmp); From 98cdf31d83e936dc356c207d9eb6ebe46860085a Mon Sep 17 00:00:00 2001 From: Eric Flumerfelt Date: Tue, 20 Apr 2021 10:50:45 -0500 Subject: [PATCH 12/54] Update putBlockInEvent to correctly fill in DTC subsystem --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 9455c39953..03bdb92f4f 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -220,14 +220,13 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { uint8_t& DTCId, uint8_t Subsys); void printHeader(DataBlockHeader const& headerDataBlock); - void putBlockInEvent(DTCLib::DTC_Event& currentEvent, uint8_t dtcID, + void putBlockInEvent(DTCLib::DTC_Event& currentEvent, uint8_t dtcID, DTCLib::DTC_Subsystem subsys, DTCLib::DTC_DataBlock thisBlock) { auto subEvt = currentEvent.GetSubEventByDTCID(dtcID); if (subEvt == nullptr) { DTCLib::DTC_SubEvent newSubEvt; newSubEvt.SetEventWindowTag(currentEvent.GetEventWindowTag()); - auto hdrPtr = newSubEvt.GetHeader(); - hdrPtr->source_dtc_id = dtcID; + newSubEvt.SetSourceDTC(dtcID, subsys); newSubEvt.AddDataBlock(thisBlock); currentEvent.AddSubEvent(newSubEvt); @@ -453,7 +452,7 @@ void ArtBinaryPacketsFromDigis::fillTrackerDataStream(DTCLib::DTC_Event& current } } } - putBlockInEvent(currentEvent, dtcID, thisBlock); + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Tracker, thisBlock); } void ArtBinaryPacketsFromDigis::fillTrackerDMABlocks(DTCLib::DTC_Event& currentEvent, @@ -936,7 +935,7 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterDataStream(DTCLib::DTC_Event& cur } // end loop over the calorimeterHitReadoutPacketVector } - putBlockInEvent(currentEvent, dtcID, thisBlock); + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Calorimeter, thisBlock); } //-------------------------------------------------------------------------------- @@ -1245,7 +1244,7 @@ void ArtBinaryPacketsFromDigis::fillCrvDataStream(DTCLib::DTC_Event& currentEven pos += sizeof(CRVHitReadoutPacket); } - putBlockInEvent(currentEvent, dtcID, thisBlock); + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_CRV, thisBlock); } } // namespace mu2e From 35900bfc78969d70d73a499544a93eaa040f1d7e Mon Sep 17 00:00:00 2001 From: Eric Flumerfelt Date: Wed, 28 Apr 2021 10:05:24 -0500 Subject: [PATCH 13/54] Only put blocks in event when they have hits --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 03bdb92f4f..739ce09769 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -451,8 +451,8 @@ void ArtBinaryPacketsFromDigis::fillTrackerDataStream(DTCLib::DTC_Event& current pos += sizeof(TrackerADCPacket) * num_packets; } } + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Tracker, thisBlock); } - putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Tracker, thisBlock); } void ArtBinaryPacketsFromDigis::fillTrackerDMABlocks(DTCLib::DTC_Event& currentEvent, @@ -933,9 +933,8 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterDataStream(DTCLib::DTC_Event& cur waveform_size); pos += waveform_size; } // end loop over the calorimeterHitReadoutPacketVector + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Calorimeter, thisBlock); } - - putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Calorimeter, thisBlock); } //-------------------------------------------------------------------------------- @@ -1244,7 +1243,9 @@ void ArtBinaryPacketsFromDigis::fillCrvDataStream(DTCLib::DTC_Event& currentEven pos += sizeof(CRVHitReadoutPacket); } - putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_CRV, thisBlock); + if (hitCount > 0) { + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_CRV, thisBlock); + } } } // namespace mu2e From e9e80331056cdf70f11f856b3a7a079712a187f0 Mon Sep 17 00:00:00 2001 From: Eric Flumerfelt Date: Fri, 30 Apr 2021 11:08:53 -0500 Subject: [PATCH 14/54] Use subsystem to get correct SubEvent --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 739ce09769..66b7f43ae5 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -222,7 +222,7 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { void putBlockInEvent(DTCLib::DTC_Event& currentEvent, uint8_t dtcID, DTCLib::DTC_Subsystem subsys, DTCLib::DTC_DataBlock thisBlock) { - auto subEvt = currentEvent.GetSubEventByDTCID(dtcID); + auto subEvt = currentEvent.GetSubEventByDTCID(dtcID, subsys); if (subEvt == nullptr) { DTCLib::DTC_SubEvent newSubEvt; newSubEvt.SetEventWindowTag(currentEvent.GetEventWindowTag()); From e749c5de011a497f3892bc13c76ca5663b2a4209 Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 30 Apr 2021 14:12:14 -0500 Subject: [PATCH 15/54] updates --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 66b7f43ae5..585b9a92af 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -184,7 +184,7 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { // 172 rocs * 8 crystals per roc => 1376 // Note: the highest crystal ID in the old simulation was 1355 const size_t number_of_calo_rocs = 172; - const size_t number_of_crystals_per_roc = 8; + const size_t number_of_crystals_per_roc = 10; const size_t number_of_calo_rocs_per_dtc = 6; //-------------------------------------------------------------------------------- @@ -701,7 +701,9 @@ void ArtBinaryPacketsFromDigis::processCalorimeterData(art::Event& evt, uint64_t fillCalorimeterHeaderDataPacket(CD, headerData, eventNum); CaloDataPacket caloData; fillCalorimeterDataPacket(CD, caloData); - + if (_diagLevel > 1) { + printCalorimeterData(caloData); + } tmpCaloDataBlockList.push_back( std::pair(headerData, caloData)); } @@ -726,6 +728,11 @@ void ArtBinaryPacketsFromDigis::processCalorimeterData(art::Event& evt, uint64_t for (size_t curHitIdx = 0; curHitIdx < tmpCaloDataBlockList.size(); curHitIdx++) { if (tmpCaloDataBlockList[curHitIdx].first.s.DTCID == dtcID && tmpCaloDataBlockList[curHitIdx].first.s.LinkID == rocID) { + + if (_diagLevel > 1) { + std::cout << "[ArtBinaryPacketsFromDigis::processCalorimeterData ] filling Hit from DTCID = "<< (int)dtcID + << " ROCID = " << (int)rocID << std::endl; + } if (is_first) { is_first = false; caloDataBlocks.push_back(tmpCaloDataBlockList[curHitIdx]); @@ -1014,7 +1021,7 @@ void ArtBinaryPacketsFromDigis::processTrackerData(art::Event& evt, uint64_t& ev // ROC ID, counting from 0 across all DTCs (for the tracker) // uint8_t localROCID = panel; - uint8_t globalROCID = (plane * 6) + panel; + uint8_t globalROCID = (plane * 6) + panel;// strawId().uniquePanel() would provide the ROCID uint8_t thisDTCID = static_cast(globalROCID / number_of_rocs_per_dtc); if (panel == rocID && thisDTCID == dtcID) { trackerData.back().second.emplace_back(); From 7363b94bfc9b5cc8832aa92287fbfafae1e01f84 Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 16:35:23 -0500 Subject: [PATCH 16/54] new module to fetch the data --- DAQ/src/PrefetchDAQData_module.cc | 169 ++++++++++++++++++++++++++++++ 1 file changed, 169 insertions(+) create mode 100644 DAQ/src/PrefetchDAQData_module.cc diff --git a/DAQ/src/PrefetchDAQData_module.cc b/DAQ/src/PrefetchDAQData_module.cc new file mode 100644 index 0000000000..18243c2e82 --- /dev/null +++ b/DAQ/src/PrefetchDAQData_module.cc @@ -0,0 +1,169 @@ +// framework +#include "art/Framework/Principal/Event.h" +#include "fhiclcpp/ParameterSet.h" +#include "art/Framework/Principal/Handle.h" +#include "art/Framework/Core/EDProducer.h" +#include "art/Framework/Core/ModuleMacros.h" +#include "art_root_io/TFileService.h" + +// data +#include "RecoDataProducts/inc/CaloDigi.hh" +#include "RecoDataProducts/inc/StrawDigi.hh" + +// DAQ data +//#include "mu2e-artdaq-core/Overlays/FragmentType.hh" +//#include "mu2e-artdaq-core/Overlays/TrackerFragment.hh" +#include + + +namespace mu2e { + + class PrefetchDAQData : public art::EDProducer { + + protected: + + public: + explicit PrefetchDAQData(fhicl::ParameterSet const&); + virtual ~PrefetchDAQData(); + virtual void beginJob(); + virtual void produce( art::Event& e); + + void fake_access(const CaloDigi& Digi); + void fake_access(const StrawDigi& Digi); + void fake_access(const artdaq::Fragment& Frag); + + private: + + bool findData(const art::Event& e); + // control flags + int _debugLevel; + int _fetchCaloDigis; + int _fetchStrawDigis; + int _fetchCaloFragments; + int _fetchTrkFragments; + + art::InputTag _cdTag; + art::InputTag _sdTag; + art::InputTag _cfTag; + art::InputTag _tfTag; + // cache of event objects + const CaloDigiCollection* _cdcol; + const StrawDigiCollection* _sdcol; + const artdaq::Fragments* _cfcol; + const artdaq::Fragments* _tfcol; + int _eventNum; + }; + + //----------------------------------------------------------------------------- + PrefetchDAQData::PrefetchDAQData(fhicl::ParameterSet const& pset): + art::EDProducer(pset), + _debugLevel (pset.get ("debugLevel")), + _fetchCaloDigis (pset.get ("fetchCaloDigis" )), + _fetchStrawDigis (pset.get ("fetchStrawDigis")), + _fetchCaloFragments(pset.get ("fetchCaloFragments")), + _fetchTrkFragments (pset.get ("fetchTrkFragments")), + _cdTag (pset.get("caloDigiCollectionTag")), + _sdTag (pset.get("strawDigiCollectionTag")), + _cfTag (pset.get("caloFragmentTag")), + _tfTag (pset.get("trkFragmentTag")) + {} + + PrefetchDAQData::~PrefetchDAQData() { + } + +//----------------------------------------------------------------------------- + void PrefetchDAQData::beginJob() { + } + +//----------------------------------------------------------------------------- + void PrefetchDAQData::fake_access(const CaloDigi& Hit) { + } + +//----------------------------------------------------------------------------- + void PrefetchDAQData::fake_access(const StrawDigi& X) { + } +//----------------------------------------------------------------------------- + void PrefetchDAQData::fake_access(const artdaq::Fragment& Frag) { + } + +//----------------------------------------------------------------------------- + bool PrefetchDAQData::findData(const art::Event& evt){ + _cdcol = 0; + _sdcol = 0; + _cfcol = 0; + _tfcol = 0; + + if (_fetchCaloDigis) { + auto cdH = evt.getValidHandle(_cdTag); + _cdcol = cdH.product(); + } + + if (_fetchTrkFragments) { + auto tfH = evt.getValidHandle(_tfTag); + _tfcol = tfH.product(); + } + + if (_fetchCaloFragments) { + auto cfH = evt.getValidHandle(_cfTag); + _cfcol = cfH.product(); + } + + if (_fetchStrawDigis) { + auto sdH = evt.getValidHandle(_sdTag); + _sdcol = sdH.product(); + } +//----------------------------------------------------------------------------- +// prefetch data +//----------------------------------------------------------------------------- + if (_cdcol) { + int ncd = _cdcol->size(); + for(int i=0;iat(i); + fake_access(cd); + } + } + + if (_sdcol) { + int nsd = _sdcol->size(); + for(int i=0;iat(i); + fake_access(sdigi); + } + } + + if (_cfcol) { + int ncf = _cfcol->size(); + for(int i=0;iat(i); + fake_access(frag); + } + } + if (_tfcol) { + int ntf = _tfcol->size(); + for(int i=0;iat(i); + fake_access(frag); + } + } + + return true; + } + +//----------------------------------------------------------------------------- + void PrefetchDAQData::produce(art::Event& Event) { + + _eventNum = Event.event(); + + if (_debugLevel > 0) printf("[PrefetchDAQData::produce] event number: %10i\n",_eventNum); + + findData(Event); + } + +//------------------------------------------------------------------------------ +// Part of the magic that makes this class a module. +DEFINE_ART_MODULE(PrefetchDAQData) + +} + + + From 46407d62aadc49de61f4ed764490658e0e3dbd92 Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 16:35:48 -0500 Subject: [PATCH 17/54] fixed a few bugs --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 54 ++++++++++----------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 585b9a92af..b4c34d47ae 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -150,16 +150,16 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { std::vector> tsTable; size_t _timestampOffset; - int _includeTracker; - int _includeCalorimeter; - int _includeCrv; + int _includeTracker; + int _includeCalorimeter; + int _includeCrv; - int _includeDMAHeaders; + int _includeDMAHeaders; // Set to 1 to save packet data to a binary file - int _generateBinaryFile; + int _generateBinaryFile; - std::string _outputFile; + std::string _outputFile; std::ofstream outputStream; //-------------------------------------------------------------------------------- @@ -180,11 +180,10 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { //-------------------------------------------------------------------------------- // CALORIEMTER ROC/DTC INFO //-------------------------------------------------------------------------------- - // 6 rocs per DTC => 27 DTCs - // 172 rocs * 8 crystals per roc => 1376 - // Note: the highest crystal ID in the old simulation was 1355 - const size_t number_of_calo_rocs = 172; - const size_t number_of_crystals_per_roc = 10; + // 6 rocs per DTC => 23 DTCs + // 136 rocs * 10 crystals per roc => 1348 + const size_t number_of_calo_rocs = 136; + const size_t number_of_crystals_per_roc = 10; const size_t number_of_calo_rocs_per_dtc = 6; //-------------------------------------------------------------------------------- @@ -375,16 +374,16 @@ void ArtBinaryPacketsFromDigis::printCalorimeterData(CaloDataPacket const& caloD for (size_t i = 0; i < nHits; ++i) { CalorimeterHitReadoutPacket const& hit = caloData.hitPacketVec[i]; - printf("[ArtBinaryPacketsFromDigis::printCaloData] hit : %i \n", (int)i); - printf("[ArtBinaryPacketsFromDigis::printCaloData] ChannelNumber : %i \n", + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t hit : %i \n", (int)i); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t ChannelNumber : %i \n", (int)hit.ChannelNumber); - printf("[ArtBinaryPacketsFromDigis::printCaloData] DIRACA : %i \n", (int)hit.DIRACA); - printf("[ArtBinaryPacketsFromDigis::printCaloData] DIRACB : %i \n", (int)hit.DIRACB); - printf("[ArtBinaryPacketsFromDigis::printCaloData] ErrorFlags : %i \n", (int)hit.ErrorFlags); - printf("[ArtBinaryPacketsFromDigis::printCaloData] Time : %i \n", (int)hit.Time); - printf("[ArtBinaryPacketsFromDigis::printCaloData] NumberOfSamples : %i \n", + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t DIRACA : %i \n", (int)hit.DIRACA); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t DIRACB : %i \n", (int)hit.DIRACB); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t ErrorFlags : %i \n", (int)hit.ErrorFlags); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t Time : %i \n", (int)hit.Time); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t NumberOfSamples : %i \n", (int)hit.NumberOfSamples); - printf("[ArtBinaryPacketsFromDigis::printCaloData] IndexOfMaxDigitizerSample : %i \n", + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t IndexOfMaxDigitizerSample : %i \n", (int)hit.IndexOfMaxDigitizerSample); } } @@ -714,7 +713,7 @@ void ArtBinaryPacketsFromDigis::processCalorimeterData(art::Event& evt, uint64_t << tmpCaloDataBlockList.size() << std::endl; } - uint8_t max_dtc_id = number_of_calo_rocs / number_of_calo_rocs_per_dtc - 1; + uint8_t max_dtc_id = number_of_calo_rocs / number_of_calo_rocs_per_dtc; if (number_of_calo_rocs % number_of_calo_rocs_per_dtc > 0) { max_dtc_id += 1; } @@ -731,7 +730,8 @@ void ArtBinaryPacketsFromDigis::processCalorimeterData(art::Event& evt, uint64_t if (_diagLevel > 1) { std::cout << "[ArtBinaryPacketsFromDigis::processCalorimeterData ] filling Hit from DTCID = "<< (int)dtcID - << " ROCID = " << (int)rocID << std::endl; + << " ROCID = " << (int)rocID + << std::endl; } if (is_first) { is_first = false; @@ -792,10 +792,10 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterDataPacket(const CaloDigi& CD, CalorimeterBoardID ccBoardID; // ROC ID, counting from 0, across all (for the calorimeter) - size_t crystalId = _calorimeter->caloIDMapper().crystalIDFromSiPMID(CD.SiPMID()); + size_t crystalId = _calorimeter->caloIDMapper().crystalIDFromSiPMID(CD.SiPMID()); size_t globalROCID = crystalId / number_of_crystals_per_roc; - ccBoardID.BoardID = globalROCID % number_of_calo_rocs_per_dtc; + ccBoardID.BoardID = globalROCID % number_of_calo_rocs_per_dtc; ccBoardID.ChannelStatusFlagsA = 0; ccBoardID.ChannelStatusFlagsB = 0; ccBoardID.unused = 0; @@ -960,10 +960,10 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterHeaderDataPacket(const CaloDigi& HeaderData.s.PacketType = 5; // PacketType::Dataheader; // ROC ID, counting from 0, across all (for the calorimeter) - size_t crystalId = _calorimeter->caloIDMapper().crystalIDFromSiPMID(CD.SiPMID()); + size_t crystalId = _calorimeter->caloIDMapper().crystalIDFromSiPMID(CD.SiPMID()); size_t globalROCID = crystalId / number_of_crystals_per_roc; - HeaderData.s.LinkID = globalROCID % number_of_rocs_per_dtc; // currently unknown. FIXME! + HeaderData.s.LinkID = globalROCID % number_of_calo_rocs_per_dtc; // currently unknown. FIXME! HeaderData.s.SubsystemID = DTCLib::DTC_Subsystem_Calorimeter; HeaderData.s.Valid = 1; // Word 2 @@ -979,7 +979,7 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterHeaderDataPacket(const CaloDigi& HeaderData.s.Status = 0; // 0 corresponds to "TimeStamp had valid data" HeaderData.s.Version = format_version; // Word 7 - HeaderData.s.DTCID = static_cast(globalROCID / number_of_rocs_per_dtc); + HeaderData.s.DTCID = static_cast(globalROCID / number_of_calo_rocs_per_dtc); uint8_t evbMode = 0; // ask Eric HeaderData.s.EventWindowMode = evbMode; } @@ -996,7 +996,7 @@ void ArtBinaryPacketsFromDigis::processTrackerData(art::Event& evt, uint64_t& ev tracker_data_block_list_t tmpTrackerData; - uint8_t max_dtc_id = number_of_rocs / number_of_rocs_per_dtc - 1; + uint8_t max_dtc_id = number_of_rocs / number_of_rocs_per_dtc; if (number_of_rocs % number_of_rocs_per_dtc > 0) { max_dtc_id += 1; } From 6cab82ed611259e100b7bdc528d54ce4db74963b Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 16:37:09 -0500 Subject: [PATCH 18/54] changed location --- DAQ/src/FragmentAna_module.cc | 345 ++++++++++++++++++++++++++++++++++ 1 file changed, 345 insertions(+) create mode 100644 DAQ/src/FragmentAna_module.cc diff --git a/DAQ/src/FragmentAna_module.cc b/DAQ/src/FragmentAna_module.cc new file mode 100644 index 0000000000..225e54f79d --- /dev/null +++ b/DAQ/src/FragmentAna_module.cc @@ -0,0 +1,345 @@ +// ====================================================================== +// +// StrawAndCaloDigisFromFragments_plugin: Add tracker/cal data products to the event +// +// ====================================================================== + +// ROOT includes +#include "TH1F.h" +//#include "TFolder.h" + +#include "art/Framework/Core/EDAnalyzer.h" +#include "art/Framework/Core/ModuleMacros.h" +#include "art/Framework/Principal/Event.h" +#include "art/Framework/Principal/Handle.h" +#include "art/Framework/Services/Registry/ServiceHandle.h" +#include "art_root_io/TFileDirectory.h" +#include "art_root_io/TFileService.h" +#include "fhiclcpp/ParameterSet.h" +#include "mu2e-artdaq-core/Overlays/CalorimeterFragment.hh" +#include "mu2e-artdaq-core/Overlays/FragmentType.hh" +#include "mu2e-artdaq-core/Overlays/TrackerFragment.hh" + +#include + +// Mu2e includes +#include "DataProducts/inc/StrawId.hh" +#include "DataProducts/inc/TrkTypes.hh" + +#include +#include +#include + +// ====================================================================== +namespace mu2e { + +class FragmentAna : public art::EDAnalyzer { + +public: + struct Config { + fhicl::Atom diagLevel{fhicl::Name("diagLevel"), fhicl::Comment("diagnostic level")}; + fhicl::Atom parseCAL{fhicl::Name("parseCAL"), fhicl::Comment("parseCAL")}; + fhicl::Atom parseTRK{fhicl::Name("parseTRK"), fhicl::Comment("parseTRK")}; + fhicl::Atom caloTag{fhicl::Name("caloTag"), fhicl::Comment("caloTag")}; + fhicl::Atom trkTag{fhicl::Name("trkTag"), fhicl::Comment("trkTag")}; + }; + + explicit FragmentAna(const art::EDAnalyzer::Table& config); + virtual ~FragmentAna() {} + + virtual void beginJob() override; + virtual void endJob() override; + + virtual void analyze(const art::Event& e) override; + +private: + void analyze_tracker_(const artdaq::Fragment& f); + void analyze_calorimeter_(const artdaq::Fragment& f); + + int diagLevel_; + + int parseCAL_; + int parseTRK_; + + art::InputTag trkFragmentsTag_; + art::InputTag caloFragmentsTag_; + + TH1F* _hTrkNFragment; + TH1F* _hTrkStrawId; + TH1F* _hTrkTDC[4]; + TH1F* _hTrkTOT; + TH1F* _hTrkPMP; + TH1F* _hTrkMeanADC; + TH1F* _hTrkMaxADC; + TH1F* _hTrkWfSize; + + TH1F* _hCalNFragment; + TH1F* _hCalROId; + TH1F* _hCalT0; + TH1F* _hCalPeakPos; + TH1F* _hCalWfSize; +}; + +// ====================================================================== + +FragmentAna::FragmentAna(const art::EDAnalyzer::Table& config) : + art::EDAnalyzer{config}, diagLevel_(config().diagLevel()), parseCAL_(config().parseCAL()), + parseTRK_(config().parseTRK()), trkFragmentsTag_(config().trkTag()), + caloFragmentsTag_(config().caloTag()) {} + +//-------------------------------------------------------------------------------- +// create the histograms +//-------------------------------------------------------------------------------- +void FragmentAna::beginJob() { + art::ServiceHandle tfs; + + art::TFileDirectory calDir = tfs->mkdir("calorimeter"); + art::TFileDirectory trkDir = tfs->mkdir("tracker"); + + _hTrkNFragment = trkDir.make("hTrkNFragment", "n fragments from the tracker; nTrkFragments", + 1000, 0., 10000.); + _hTrkStrawId = + trkDir.make("hTrkStrawId", "trk fragment strawId; strawId", 20000, 0., 20000.); + _hTrkTDC[0] = trkDir.make("hTrkTDC0", "trk fragment TDC0; TDC[0]", 264, 0., 264000); + _hTrkTDC[1] = trkDir.make("hTrkTDC1", "trk fragment TDC1; TDC[1]", 264, 0., 264000); + _hTrkTDC[2] = trkDir.make("hTrkTDCMean", "trk fragment average TDC; (TDC[0]+TDC[1])/2", + 2000, 0., 20000.); + _hTrkTDC[3] = trkDir.make("hTrkTDCDelta", "trk fragment delta TDC; TDC[1]-TDC[0]", 220, + -100., 10000.); + _hTrkTOT = + trkDir.make("hTrkTOT", "trk fragment average TOT; (TOT[0]+TOT[1])/2", 100, 0., 200.); + _hTrkPMP = trkDir.make("hTrkPOP", "trk fragment average PMP; PMP", 100, 0., 200.); + _hTrkMeanADC = trkDir.make("hTrkMeanADC", "trk fragment Mean ADC; ", 250, 0., 2500.); + _hTrkMaxADC = trkDir.make("hTrkMaxADC", "trk fragment Max ADC; Max_ADC", 250, 0., 2500.); + _hTrkWfSize = trkDir.make("hTrkWfSize", "trk fragment waveform size; trkFragment_wf_size", + 20, 0., 20.); + + _hCalNFragment = calDir.make( + "hCalNFragment", "n fragments from the calorimeter; nCalFragments", 400, 0., 400.); + _hCalROId = + calDir.make("hCalROId", "calo fragment roId; calFragment_roId", 4000, 0., 4000.); + _hCalT0 = calDir.make("hCalT0", "calo fragment t0; calFragment_t0 [ns]", 200, 0., 2000.); + _hCalPeakPos = + calDir.make("hCalPeakPos", "calo fragment peakPos; calFragment_peakPos", 100, 0., 100.); + _hCalWfSize = calDir.make("hCalWfSize", "calo fragment waveform size; calFragment_wf_size", + 100, 0., 100.); +} + +void FragmentAna::endJob() {} + +//-------------------------------------------------------------------------------- +void FragmentAna::analyze(const art::Event& event) { + art::EventNumber_t eventNumber = event.event(); + + art::Handle trkFragments, calFragments; + size_t numTrkFrags(0), numCalFrags(0); + if (parseTRK_) { + event.getByLabel(trkFragmentsTag_, trkFragments); + if (!trkFragments.isValid()) { + return; + } + numTrkFrags = trkFragments->size(); + _hTrkNFragment->Fill(numTrkFrags); + } + if (parseCAL_) { + event.getByLabel(caloFragmentsTag_, calFragments); + if (!calFragments.isValid()) { + return; + } + numCalFrags = calFragments->size(); + _hCalNFragment->Fill(numCalFrags); + } + + if (diagLevel_ > 1) { + std::cout << std::dec << "Producer: Run " << event.run() << ", subrun " << event.subRun() + << ", event " << eventNumber << " has " << std::endl; + std::cout << numTrkFrags << " TRK fragments, and "; + std::cout << numCalFrags << " CAL fragments." << std::endl; + + size_t totalSize = 0; + for (size_t idx = 0; idx < numTrkFrags; ++idx) { + auto size = ((*trkFragments)[idx]).size(); // * sizeof(artdaq::RawDataType); + totalSize += size; + // std::cout << "\tTRK Fragment " << idx << " has size " << size << std::endl; + } + for (size_t idx = 0; idx < numCalFrags; ++idx) { + auto size = ((*calFragments)[idx]).size(); // * sizeof(artdaq::RawDataType); + totalSize += size; + // std::cout << "\tCAL Fragment " << idx << " has size " << size << std::endl; + } + totalSize *= sizeof(artdaq::RawDataType); + + std::cout << "\tTotal Size: " << (int)totalSize << " bytes." << std::endl; + } + std::string curMode = "TRK"; + + // Loop over the TRK and CAL fragments + for (size_t idx = 0; idx < numTrkFrags + numCalFrags; ++idx) { + + auto curHandle = trkFragments; + size_t curIdx = idx; + if (idx >= numTrkFrags) { + curIdx = idx - numTrkFrags; + curHandle = calFragments; + } + const auto& fragment((*curHandle)[curIdx]); + + if (idx < numTrkFrags) { + analyze_tracker_(fragment); + } else { + analyze_calorimeter_(fragment); + } + } + if (diagLevel_ > 0) { + std::cout << "mu2e::FragmentAna::produce exiting eventNumber=" << (int)(event.event()) + << " / timestamp=" << (int)eventNumber << std::endl; + } +} + +void FragmentAna::analyze_tracker_(const artdaq::Fragment& f) { + mu2e::TrackerFragment cc(f); + + if (diagLevel_ > 1) { + std::cout << std::endl; + std::cout << "ArtFragment: "; + std::cout << "\tBlock Count: " << std::dec << cc.block_count() << std::endl; + std::cout << "\tByte Count: " << f.dataSizeBytes() << std::endl; + std::cout << std::endl; + std::cout << "\t" + << "====== Example Block Sizes ======" << std::endl; + for (size_t i = 0; i < 10; i++) { + if (i < cc.block_count()) { + std::cout << "\t" << i << "\t" << cc.blockSizeBytes(i) << std::endl; + } + } + std::cout << "\t" + << "=========================" << std::endl; + } + + for (size_t curBlockIdx = 0; curBlockIdx < cc.block_count(); curBlockIdx++) { + + auto block = cc.dataAtBlockIndex(curBlockIdx); + if (block == nullptr) { + mf::LogError("FragmentAna") << "Unable to retrieve header from block " << curBlockIdx << "!" + << std::endl; + continue; + } + auto hdr = block->GetHeader(); + + // Parse phyiscs information from TRK packets + if (hdr.GetPacketCount() > 0 && parseTRK_ > 0) { + + // Create the StrawDigi data products + auto trkDataVec = cc.GetTrackerData(curBlockIdx); + if (trkDataVec.empty()) { + mf::LogError("FragmentAna") << "Error retrieving Tracker data from DataBlock " + << curBlockIdx << "! Aborting processing of this block!"; + continue; + } + + for (auto& trkDataPair : trkDataVec) { + mu2e::StrawId sid(trkDataPair.first->StrawIndex); + mu2e::TrkTypes::TDCValues tdc = {trkDataPair.first->TDC0(), trkDataPair.first->TDC1()}; + mu2e::TrkTypes::TOTValues tot = {trkDataPair.first->TOT0, trkDataPair.first->TOT1}; + mu2e::TrkTypes::ADCValue pmp = trkDataPair.first->PMP; + int sum{0}; + unsigned short maxadc{0}; + for (auto adc : trkDataPair.second) { + sum += adc; + maxadc = std::max(maxadc, adc); + } + // Fill the StrawDigiCollection + _hTrkStrawId->Fill(sid.asUint16()); + _hTrkTDC[0]->Fill(tdc[0]); + _hTrkTDC[1]->Fill(tdc[1]); + _hTrkTDC[2]->Fill((tdc[0] + tdc[1]) / 2.); + _hTrkTDC[3]->Fill(tdc[1] - tdc[0]); + _hTrkTOT->Fill((tot[0] + tot[1]) / 2.); + _hTrkPMP->Fill(pmp); + int mean = (trkDataPair.second.size() != 0) ? sum / trkDataPair.second.size() : -1.; + _hTrkMeanADC->Fill(mean); + _hTrkMaxADC->Fill(maxadc); + _hTrkWfSize->Fill(trkDataPair.second.size()); + } + } + } + + cc.ClearUpgradedPackets(); +} + +void FragmentAna::analyze_calorimeter_(const artdaq::Fragment& f) { + mu2e::CalorimeterFragment cc(f); + + if (diagLevel_ > 1) { + std::cout << std::endl; + std::cout << "ArtFragment: "; + std::cout << "\tBlock Count: " << std::dec << cc.block_count() << std::endl; + std::cout << "\tByte Count: " << f.dataSizeBytes() << std::endl; + std::cout << std::endl; + std::cout << "\t" + << "====== Example Block Sizes ======" << std::endl; + for (size_t i = 0; i < 10; i++) { + if (i < cc.block_count()) { + std::cout << "\t" << i << "\t" << cc.blockSizeBytes(i) << std::endl; + } + } + std::cout << "\t" + << "=========================" << std::endl; + } + + for (size_t curBlockIdx = 0; curBlockIdx < cc.block_count(); curBlockIdx++) { + + auto block = cc.dataAtBlockIndex(curBlockIdx); + if (block == nullptr) { + mf::LogError("FragmentAna") << "Unable to retrieve header from block " << curBlockIdx << "!" + << std::endl; + continue; + } + auto hdr = block->GetHeader(); + + if (hdr.GetPacketCount() > 0 && + parseCAL_ > 0) { // Parse phyiscs information from CAL packets + + auto calData = cc.GetCalorimeterData(curBlockIdx); + if (calData == nullptr) { + mf::LogError("FragmentAna") << "Error retrieving Calorimeter data from block " + << curBlockIdx << "! Aborting processing of this block!"; + continue; + } + + if (diagLevel_ > 0) { + std::cout << "[StrawAndCaloDigiFromFragments] NEW CALDATA: NumberOfHits " + << calData->NumberOfHits << std::endl; + } + + auto hits = cc.GetCalorimeterHits(curBlockIdx); + + bool err = false; + for (auto& hit : hits) { + + // Fill the CaloDigiCollection + + // IMPORTANT NOTE: we don't have a final + // mapping yet so for the moment, the BoardID field (described in docdb 4914) is just a + // placeholder. Because we still need to know which crystal a hit belongs to, we are + // temporarily storing the 4-bit apdID and 12-bit crystalID in the Reserved DIRAC A slot. + // Also, note that until we have an actual map, channel index does not actually correspond + // to the physical readout channel on a ROC. + + uint16_t crystalID = hit.first.DIRACB & 0x0FFF; + uint16_t roId = hit.first.DIRACB >> 12; + _hCalROId->Fill(crystalID * 2 + roId); + _hCalT0->Fill(hit.first.Time); + _hCalPeakPos->Fill(hit.first.IndexOfMaxDigitizerSample); + _hCalWfSize->Fill(hit.second.size()); + + } // End loop over readout channels in DataBlock + if (err) + continue; + } + } +} + +} // end namespace mu2e + +DEFINE_ART_MODULE(mu2e::FragmentAna); From 39912430fb0f4e3fce9b499078fb9e6283331ce1 Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 18:20:11 -0500 Subject: [PATCH 19/54] udpates --- ups_install/install.sh | 5 +++-- ups_install/installTableFile.sh | 6 ++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ups_install/install.sh b/ups_install/install.sh index 8171f32c17..862bc66f38 100644 --- a/ups_install/install.sh +++ b/ups_install/install.sh @@ -7,10 +7,11 @@ # export COMPILER_CODE=e20 -export DEBUG_LEVEL=prof +export ${MU2E_SETUP_BUILDOPTS} +export DEBUG_LEVEL=${build} export PACKAGE_NAME=offline export PACKAGE_SOURCE=${MU2E_BASE_RELEASE} -export PACKAGE_VERSION=v09_11_02 +export PACKAGE_VERSION=v09_11_03 # Check that the installation directoy has been defined. if [ "${PRODUCTS_INSTALL}" = '' ];then diff --git a/ups_install/installTableFile.sh b/ups_install/installTableFile.sh index 47ea0911b3..2032ed7c52 100755 --- a/ups_install/installTableFile.sh +++ b/ups_install/installTableFile.sh @@ -15,6 +15,7 @@ destination_file=$1 art_ver=`ups active | awk '$1 == "art" {print $2}'` heppdt_ver=`ups active | awk '$1 == "heppdt" {print $2}'` btrk_ver=`ups active | awk '$1 == "BTrk" {print $2}'` +kinkal_ver=`ups active | awk '$1 == "KinKal" {print $2}'` xerces_ver=`ups active | awk '$1 == "xerces_c" {print $2}'` mu2e_artdaq_core_ver=`ups active | awk '$1 == "mu2e_artdaq_core" {print $2}'` @@ -57,6 +58,7 @@ Qualifiers = "${qualifiers_value}:debug" envSet (MU2E_UPS_QUALIFIERS, +${mu2e_ups_qualifiers}:+debug ) setupRequired( art ${art_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( BTrk ${btrk_ver} -q +${mu2e_ups_qualifiers}:+debug:+p383b ) + setupRequired( KinKal ${kinkal_ver} -q +${mu2e_ups_qualifiers}:+debug:+p383b ) setupRequired( heppdt ${heppdt_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( xerces_c ${xerces_ver} -q +${mu2e_ups_qualifiers}:+debug ) @@ -71,6 +73,7 @@ Qualifiers = "${qualifiers_value}:prof" envSet (MU2E_UPS_QUALIFIERS, +\${mu2e_ups_qualifiers}:+prof ) setupRequired( art ${art_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( BTrk ${btrk_ver} -q +${mu2e_ups_qualifiers}:+prof:+p383b ) + setupRequired( KinKal ${kinkal_ver} -q +${mu2e_ups_qualifiers}:+prof:+p383b ) setupRequired( heppdt ${heppdt_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( xerces_c ${xerces_ver} -q +${mu2e_ups_qualifiers}:+prof ) @@ -85,6 +88,7 @@ Qualifiers = "${qualifiers_value}:trig:debug" envSet (MU2E_UPS_QUALIFIERS, +${mu2e_ups_qualifiers}:+debug ) setupRequired( art ${art_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( BTrk ${btrk_ver} -q +${mu2e_ups_qualifiers}:+debug:+p383b ) + setupRequired( KinKal ${kinkal_ver} -q +${mu2e_ups_qualifiers}:+debug:+p383b ) setupRequired( heppdt ${heppdt_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( xerces_c ${xerces_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( mu2e_artdaq_core ${mu2e_artdaq_core_ver} -q ${mu2e_ups_qualifiers}:+${MU2E_ART_SQUALIFIER}:+debug ) @@ -100,6 +104,7 @@ Qualifiers = "${qualifiers_value}:trig:prof" envSet (MU2E_UPS_QUALIFIERS, +\${mu2e_ups_qualifiers}:+prof ) setupRequired( art ${art_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( BTrk ${btrk_ver} -q +${mu2e_ups_qualifiers}:+prof:+p383b ) + setupRequired( KinKal ${kinkal_ver} -q +${mu2e_ups_qualifiers}:+prof:+p383b ) setupRequired( heppdt ${heppdt_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( xerces_c ${xerces_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( mu2e_artdaq_core ${mu2e_artdaq_core_ver} -q ${mu2e_ups_qualifiers}:+${MU2E_ART_SQUALIFIER}:+prof ) @@ -133,6 +138,7 @@ EOF unset art_ver unset heppdt_ver unset btrk_ver +unset kinkal_ver unset xerces_ver unset mu2e_artdaq_core_ver unset qualifiers_value From 68a3ab56e54eef723a88bb313aa8ffc182167948 Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 18:21:02 -0500 Subject: [PATCH 20/54] renamed --- Analyses/src/FragmentAna_module.cc | 344 ----------------------------- 1 file changed, 344 deletions(-) delete mode 100644 Analyses/src/FragmentAna_module.cc diff --git a/Analyses/src/FragmentAna_module.cc b/Analyses/src/FragmentAna_module.cc deleted file mode 100644 index 4c289d915f..0000000000 --- a/Analyses/src/FragmentAna_module.cc +++ /dev/null @@ -1,344 +0,0 @@ -// ====================================================================== -// -// StrawAndCaloDigisFromFragments_plugin: Add tracker/cal data products to the event -// -// ====================================================================== - -// ROOT includes -#include "TH1F.h" -//#include "TFolder.h" - -#include "art/Framework/Core/EDAnalyzer.h" -#include "art/Framework/Core/ModuleMacros.h" -#include "art/Framework/Principal/Event.h" -#include "art/Framework/Principal/Handle.h" -#include "art/Framework/Services/Registry/ServiceHandle.h" -#include "art_root_io/TFileDirectory.h" -#include "art_root_io/TFileService.h" -#include "fhiclcpp/ParameterSet.h" -#include "mu2e-artdaq-core/Overlays/CalorimeterFragment.hh" -#include "mu2e-artdaq-core/Overlays/FragmentType.hh" -#include "mu2e-artdaq-core/Overlays/TrackerFragment.hh" - -#include - -// Mu2e includes -#include "DataProducts/inc/StrawId.hh" -#include "DataProducts/inc/TrkTypes.hh" - -#include -#include -#include - -// ====================================================================== -namespace mu2e { - -class FragmentAna : public art::EDAnalyzer { - -public: - struct Config { - fhicl::Atom diagLevel{fhicl::Name("diagLevel"), fhicl::Comment("diagnostic level")}; - fhicl::Atom parseCAL{fhicl::Name("parseCAL"), fhicl::Comment("parseCAL")}; - fhicl::Atom parseTRK{fhicl::Name("parseTRK"), fhicl::Comment("parseTRK")}; - fhicl::Atom caloTag{fhicl::Name("caloTag"), fhicl::Comment("caloTag")}; - fhicl::Atom trkTag{fhicl::Name("trkTag"), fhicl::Comment("trkTag")}; - }; - - explicit FragmentAna(const art::EDAnalyzer::Table& config); - virtual ~FragmentAna() {} - - virtual void beginJob() override; - virtual void endJob() override; - - virtual void analyze(const art::Event& e) override; - -private: - void analyze_tracker_(const artdaq::Fragment& f); - void analyze_calorimeter_(const artdaq::Fragment& f); - - int diagLevel_; - - int parseCAL_; - int parseTRK_; - - art::InputTag trkFragmentsTag_; - art::InputTag caloFragmentsTag_; - - TH1F* _hTrkNFragment; - TH1F* _hTrkStrawId; - TH1F* _hTrkTDC[4]; - TH1F* _hTrkTOT; - TH1F* _hTrkPMP; - TH1F* _hTrkMeanADC; - TH1F* _hTrkMaxADC; - TH1F* _hTrkWfSize; - - TH1F* _hCalNFragment; - TH1F* _hCalROId; - TH1F* _hCalT0; - TH1F* _hCalPeakPos; - TH1F* _hCalWfSize; -}; - -// ====================================================================== - -FragmentAna::FragmentAna(const art::EDAnalyzer::Table& config) : - art::EDAnalyzer{config}, diagLevel_(config().diagLevel()), parseCAL_(config().parseCAL()), - parseTRK_(config().parseTRK()), trkFragmentsTag_(config().trkTag()), - caloFragmentsTag_(config().caloTag()) {} - -//-------------------------------------------------------------------------------- -// create the histograms -//-------------------------------------------------------------------------------- -void FragmentAna::beginJob() { - art::ServiceHandle tfs; - - art::TFileDirectory calDir = tfs->mkdir("calorimeter"); - art::TFileDirectory trkDir = tfs->mkdir("tracker"); - - _hTrkNFragment = trkDir.make("hTrkNFragment", "n fragments from the tracker; nTrkFragments", - 1000, 0., 10000.); - _hTrkStrawId = - trkDir.make("hTrkStrawId", "trk fragment strawId; strawId", 20000, 0., 20000.); - _hTrkTDC[0] = trkDir.make("hTrkTDC0", "trk fragment TDC0; TDC[0]", 264, 0., 264000); - _hTrkTDC[1] = trkDir.make("hTrkTDC1", "trk fragment TDC1; TDC[1]", 264, 0., 264000); - _hTrkTDC[2] = trkDir.make("hTrkTDCMean", "trk fragment average TDC; (TDC[0]+TDC[1])/2", - 2000, 0., 20000.); - _hTrkTDC[3] = trkDir.make("hTrkTDCDelta", "trk fragment delta TDC; TDC[1]-TDC[0]", 220, - -100., 10000.); - _hTrkTOT = - trkDir.make("hTrkTOT", "trk fragment average TOT; (TOT[0]+TOT[1])/2", 100, 0., 200.); - _hTrkPMP = trkDir.make("hTrkPOP", "trk fragment average PMP; PMP", 100, 0., 200.); - _hTrkMeanADC = trkDir.make("hTrkMeanADC", "trk fragment Mean ADC; ", 250, 0., 2500.); - _hTrkMaxADC = trkDir.make("hTrkMaxADC", "trk fragment Max ADC; Max_ADC", 250, 0., 2500.); - _hTrkWfSize = trkDir.make("hTrkWfSize", "trk fragment waveform size; trkFragment_wf_size", - 20, 0., 20.); - - _hCalNFragment = calDir.make( - "hCalNFragment", "n fragments from the calorimeter; nCalFragments", 400, 0., 400.); - _hCalROId = - calDir.make("hCalROId", "calo fragment roId; calFragment_roId", 4000, 0., 4000.); - _hCalT0 = calDir.make("hCalT0", "calo fragment t0; calFragment_t0 [ns]", 200, 0., 2000.); - _hCalPeakPos = - calDir.make("hCalPeakPos", "calo fragment peakPos; calFragment_peakPos", 100, 0., 100.); - _hCalWfSize = calDir.make("hCalWfSize", "calo fragment waveform size; calFragment_wf_size", - 100, 0., 100.); -} - -void FragmentAna::endJob() {} - -//-------------------------------------------------------------------------------- -void FragmentAna::analyze(const art::Event& event) { - art::EventNumber_t eventNumber = event.event(); - - art::Handle trkFragments, calFragments; - size_t numTrkFrags(0), numCalFrags(0); - if (parseTRK_) { - event.getByLabel(trkFragmentsTag_, trkFragments); - if (!trkFragments.isValid()) { - return; - } - numTrkFrags = trkFragments->size(); - _hTrkNFragment->Fill(numTrkFrags); - } - if (parseCAL_) { - event.getByLabel(caloFragmentsTag_, calFragments); - if (!calFragments.isValid()) { - return; - } - numCalFrags = calFragments->size(); - _hCalNFragment->Fill(numCalFrags); - } - - if (diagLevel_ > 1) { - std::cout << std::dec << "Producer: Run " << event.run() << ", subrun " << event.subRun() - << ", event " << eventNumber << " has " << std::endl; - std::cout << numTrkFrags << " TRK fragments, and "; - std::cout << numCalFrags << " CAL fragments." << std::endl; - - size_t totalSize = 0; - for (size_t idx = 0; idx < numTrkFrags; ++idx) { - auto size = ((*trkFragments)[idx]).size(); // * sizeof(artdaq::RawDataType); - totalSize += size; - // std::cout << "\tTRK Fragment " << idx << " has size " << size << std::endl; - } - for (size_t idx = 0; idx < numCalFrags; ++idx) { - auto size = ((*calFragments)[idx]).size(); // * sizeof(artdaq::RawDataType); - totalSize += size; - // std::cout << "\tCAL Fragment " << idx << " has size " << size << std::endl; - } - totalSize *= sizeof(artdaq::RawDataType); - - std::cout << "\tTotal Size: " << (int)totalSize << " bytes." << std::endl; - } - std::string curMode = "TRK"; - - // Loop over the TRK and CAL fragments - for (size_t idx = 0; idx < numTrkFrags + numCalFrags; ++idx) { - - auto curHandle = trkFragments; - size_t curIdx = idx; - if (idx >= numTrkFrags) { - curIdx = idx - numTrkFrags; - curHandle = calFragments; - } - const auto& fragment((*curHandle)[curIdx]); - - if (idx < numTrkFrags) { - analyze_tracker_(fragment); - } else { - analyze_calorimeter_(fragment); - } - } - if (diagLevel_ > 0) { - std::cout << "mu2e::FragmentAna::produce exiting eventNumber=" << (int)(event.event()) - << " / timestamp=" << (int)eventNumber << std::endl; - } -} - -void FragmentAna::analyze_tracker_(const artdaq::Fragment& f) { - mu2e::TrackerFragment cc(f); - - if (diagLevel_ > 1) { - std::cout << std::endl; - std::cout << "ArtFragment: "; - std::cout << "\tBlock Count: " << std::dec << cc.block_count() << std::endl; - std::cout << "\tByte Count: " << f.dataSizeBytes() << std::endl; - std::cout << std::endl; - std::cout << "\t" - << "====== Example Block Sizes ======" << std::endl; - for (size_t i = 0; i < 10; i++) { - if (i < cc.block_count()) { - std::cout << "\t" << i << "\t" << cc.blockSizeBytes(i) << std::endl; - } - } - std::cout << "\t" - << "=========================" << std::endl; - } - - for (size_t curBlockIdx = 0; curBlockIdx < cc.block_count(); curBlockIdx++) { - - auto block = cc.dataAtBlockIndex(curBlockIdx); - if (block == nullptr) { - mf::LogError("FragmentAna") << "Unable to retrieve header from block " << curBlockIdx << "!" - << std::endl; - continue; - } - auto hdr = block->GetHeader(); - - // Parse phyiscs information from TRK packets - if (hdr.GetPacketCount() > 0 && parseTRK_ > 0) { - - // Create the StrawDigi data products - auto trkDataVec = cc.GetTrackerData(curBlockIdx); - if (trkDataVec.empty()) { - mf::LogError("FragmentAna") << "Error retrieving Tracker data from DataBlock " - << curBlockIdx << "! Aborting processing of this block!"; - continue; - } - - for (auto& trkDataPair : trkDataVec) { - mu2e::StrawId sid(trkDataPair.first->StrawIndex); - mu2e::TrkTypes::TDCValues tdc = {trkDataPair.first->TDC0(), trkDataPair.first->TDC1()}; - mu2e::TrkTypes::TOTValues tot = {trkDataPair.first->TOT0, trkDataPair.first->TOT1}; - mu2e::TrkTypes::ADCValue pmp = trkDataPair.first->PMP; - int sum{0}; - unsigned short maxadc{0}; - for (auto adc : trkDataPair.second) { - sum += adc; - maxadc = std::max(maxadc, adc); - } - // Fill the StrawDigiCollection - _hTrkStrawId->Fill(sid.asUint16()); - _hTrkTDC[0]->Fill(tdc[0]); - _hTrkTDC[1]->Fill(tdc[1]); - _hTrkTDC[2]->Fill((tdc[0] + tdc[1]) / 2.); - _hTrkTDC[3]->Fill(tdc[1] - tdc[0]); - _hTrkTOT->Fill((tot[0] + tot[1]) / 2.); - _hTrkPMP->Fill(pmp); - int mean = (trkDataPair.second.size() != 0) ? sum / trkDataPair.second.size() : -1.; - _hTrkMeanADC->Fill(mean); - _hTrkMaxADC->Fill(maxadc); - _hTrkWfSize->Fill(trkDataPair.second.size()); - } - } - } - - cc.ClearUpgradedPackets(); -} - -void FragmentAna::analyze_calorimeter_(const artdaq::Fragment& f) { - mu2e::CalorimeterFragment cc(f); - - if (diagLevel_ > 1) { - std::cout << std::endl; - std::cout << "ArtFragment: "; - std::cout << "\tBlock Count: " << std::dec << cc.block_count() << std::endl; - std::cout << "\tByte Count: " << f.dataSizeBytes() << std::endl; - std::cout << std::endl; - std::cout << "\t" - << "====== Example Block Sizes ======" << std::endl; - for (size_t i = 0; i < 10; i++) { - if (i < cc.block_count()) { - std::cout << "\t" << i << "\t" << cc.blockSizeBytes(i) << std::endl; - } - } - std::cout << "\t" - << "=========================" << std::endl; - } - - for (size_t curBlockIdx = 0; curBlockIdx < cc.block_count(); curBlockIdx++) { - - auto block = cc.dataAtBlockIndex(curBlockIdx); - if (block == nullptr) { - mf::LogError("FragmentAna") << "Unable to retrieve header from block " << curBlockIdx << "!" - << std::endl; - continue; - } - auto hdr = block->GetHeader(); - - if (hdr.GetPacketCount() > 0 && - parseCAL_ > 0) { // Parse phyiscs information from CAL packets - - auto calData = cc.GetCalorimeterData(curBlockIdx); - if (calData == nullptr) { - mf::LogError("FragmentAna") << "Error retrieving Calorimeter data from block " - << curBlockIdx << "! Aborting processing of this block!"; - continue; - } - - if (diagLevel_ > 0) { - std::cout << "[StrawAndCaloDigiFromFragments] NEW CALDATA: NumberOfHits " - << calData->NumberOfHits << std::endl; - } - - auto hits = cc.GetCalorimeterHits(curBlockIdx); - - bool err = false; - for (auto& hit : hits) { - - // Fill the CaloDigiCollection - - // IMPORTANT NOTE: we don't have a final - // mapping yet so for the moment, the BoardID field (described in docdb 4914) is just a - // placeholder. Because we still need to know which crystal a hit belongs to, we are - // temporarily storing the 4-bit apdID and 12-bit crystalID in the Reserved DIRAC A slot. - // Also, note that until we have an actual map, channel index does not actually correspond - // to the physical readout channel on a ROC. - uint16_t crystalID = hit.first.DIRACB & 0x0FFF; - uint16_t roId = hit.first.DIRACB >> 12; - _hCalROId->Fill(crystalID * 2 + roId); - _hCalT0->Fill(hit.first.Time); - _hCalPeakPos->Fill(hit.first.IndexOfMaxDigitizerSample); - _hCalWfSize->Fill(hit.second.size()); - - } // End loop over readout channels in DataBlock - if (err) - continue; - } - } -} - -} // end namespace mu2e - -DEFINE_ART_MODULE(mu2e::FragmentAna); From ea1696cc9f895ad81606dcaadffbbbc2713e3d49 Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 7 May 2021 11:03:56 -0500 Subject: [PATCH 21/54] cleanup --- DAQ/src/CaloHitsFromFragments_module.cc | 5 ++++- DAQ/src/CaloRecoFromFragments_module.cc | 18 +++++++++--------- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/DAQ/src/CaloHitsFromFragments_module.cc b/DAQ/src/CaloHitsFromFragments_module.cc index d27d37512d..1a7c838991 100644 --- a/DAQ/src/CaloHitsFromFragments_module.cc +++ b/DAQ/src/CaloHitsFromFragments_module.cc @@ -27,6 +27,8 @@ #include #include #include +#include +#include namespace art { class CaloHitsFromFragments; @@ -132,7 +134,7 @@ void art::CaloHitsFromFragments::addPulse(uint16_t& crystalID, float& time, floa } } if (addNewHit) { - pulseMap_[crystalID].push_back(CrystalInfo(crystalID, 1, time, eDep)); + pulseMap_[crystalID].emplace_back(mu2e::CaloHit(crystalID, 1, time, eDep)); } } @@ -149,6 +151,7 @@ art::CaloHitsFromFragments::CaloHitsFromFragments(const art::EDProducer::Table 0) { - std::cout << "[StrawAndCaloDigiFromFragments] NEW CALDATA: NumberOfHits " + std::cout << "[CaloRecoFromFragments] NEW CALDATA: NumberOfHits " << calData->NumberOfHits << std::endl; } @@ -213,25 +213,25 @@ void art::CaloRecoFromFragments::analyze_calorimeter_( } if (diagLevel_ > 0) { - std::cout << "[StrawAndCaloDigiFromFragments] calo hit " << hitIdx << std::endl; - std::cout << "[StrawAndCaloDigiFromFragments] \tChNumber " + std::cout << "[CaloRecoFromFragments] calo hit " << hitIdx << std::endl; + std::cout << "[CaloRecoFromFragments] \tChNumber " << (int)hits[hitIdx].first.ChannelNumber << std::endl; - std::cout << "[StrawAndCaloDigiFromFragments] \tDIRACA " + std::cout << "[CaloRecoFromFragments] \tDIRACA " << (int)hits[hitIdx].first.DIRACA << std::endl; - std::cout << "[StrawAndCaloDigiFromFragments] \tDIRACB " + std::cout << "[CaloRecoFromFragments] \tDIRACB " << (int)hits[hitIdx].first.DIRACB << std::endl; - std::cout << "[StrawAndCaloDigiFromFragments] \tErrorFlags " + std::cout << "[CaloRecoFromFragments] \tErrorFlags " << (int)hits[hitIdx].first.ErrorFlags << std::endl; - std::cout << "[StrawAndCaloDigiFromFragments] \tTime " + std::cout << "[CaloRecoFromFragments] \tTime " << (int)hits[hitIdx].first.Time << std::endl; - std::cout << "[StrawAndCaloDigiFromFragments] \tNSamples " + std::cout << "[CaloRecoFromFragments] \tNSamples " << (int)hits[hitIdx].first.NumberOfSamples << std::endl; - std::cout << "[StrawAndCaloDigiFromFragments] \tIndexMax " + std::cout << "[CaloRecoFromFragments] \tIndexMax " << (int)hits[hitIdx].first.IndexOfMaxDigitizerSample << std::endl; } From 8dbc367fbed8a9e006d131c06c0d7c702533eaef Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 7 May 2021 11:04:22 -0500 Subject: [PATCH 22/54] added condition for reading or not the waveform from the fragment --- DAQ/src/StrawRecoFromFragments_module.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DAQ/src/StrawRecoFromFragments_module.cc b/DAQ/src/StrawRecoFromFragments_module.cc index c368cee2b9..0067946c17 100644 --- a/DAQ/src/StrawRecoFromFragments_module.cc +++ b/DAQ/src/StrawRecoFromFragments_module.cc @@ -199,7 +199,7 @@ void art::StrawRecoFromFragmnets::analyze_tracker_( if (hdr.GetPacketCount() > 0 ) { // Create the StrawDigi data products - auto trkDataVec = cc.GetTrackerData(curBlockIdx); + auto trkDataVec = cc.GetTrackerData(curBlockIdx, useTrkADC_); if (trkDataVec.empty()) { mf::LogError("StrawRecoFromFragmnets") << "Error retrieving Tracker data from DataBlock " << curBlockIdx From 91271dbbbd6806dba97d935a7b707c02dd5a41da Mon Sep 17 00:00:00 2001 From: macndev Date: Thu, 13 May 2021 12:52:30 -0500 Subject: [PATCH 23/54] art v3_09 compatibility changes; deprecations, parameter set, and DAQ MADC fixes --- Analyses/src/CollectionSizeAnalyzer_module.cc | 6 ++--- Analyses/src/DiskCal00_module.cc | 3 +-- Analyses/src/GenEventCountReader_module.cc | 3 +-- Analyses/src/PointerCheck_module.cc | 24 +++++++------------ Analyses/src/ReadBack_module.cc | 3 +-- Analyses/src/ReadCaloDigi_module.cc | 3 +-- Analyses/src/SimParticleCheck00_module.cc | 3 +-- CalPatRec/src/MergePatRec_module.cc | 8 +++---- CaloCluster/src/CaloClusterFast_module.cc | 3 +-- .../src/CaloProtoClusterMaker_module.cc | 5 ++-- CaloDiag/src/CaloNeutron_module.cc | 11 ++++----- CaloFilters/src/FilterEcalNNTrigger_module.cc | 3 +-- CommonMC/src/GenerateCosmicTimes_module.cc | 3 +-- CommonMC/src/GenerateMuonLife_module.cc | 3 +-- CommonMC/src/GenerateProtonTimes_module.cc | 3 +-- CommonMC/src/SelectRecoMC_module.cc | 6 ++--- DAQ/src/CaloHitsFromFragments_module.cc | 2 +- EventGenerator/src/GenEventCounter_module.cc | 3 +-- Filters/src/RecoMomFilter_module.cc | 3 +-- GeneralUtilities/src/ParameterSetFromFile.cc | 5 ++-- Mu2eUtilities/src/SimParticleParentGetter.cc | 6 ++--- Print/src/BkgClusterPrinter.cc | 3 +-- Print/src/BkgQualPrinter.cc | 3 +-- Print/src/CaloClusterPrinter.cc | 3 +-- Print/src/CaloDigiPrinter.cc | 3 +-- Print/src/CaloHitPrinter.cc | 3 +-- Print/src/CaloRecoDigiPrinter.cc | 3 +-- Print/src/CaloShowerStepPrinter.cc | 3 +-- Print/src/ComboHitPrinter.cc | 3 +-- Print/src/CrvCoincidenceClusterPrinter.cc | 3 +-- Print/src/CrvDigiMCPrinter.cc | 3 +-- Print/src/CrvDigiPrinter.cc | 3 +-- Print/src/CrvRecoPulsePrinter.cc | 3 +-- Print/src/CrvStepPrinter.cc | 3 +-- Print/src/GenParticlePrinter.cc | 3 +-- Print/src/KalRepPrinter.cc | 3 +-- Print/src/KalSeedPrinter.cc | 3 +-- Print/src/MCTrajectoryPrinter.cc | 3 +-- Print/src/PhysicalVolumePrinter.cc | 3 +-- Print/src/PrimaryParticlePrinter.cc | 3 +-- Print/src/SimParticlePrinter.cc | 3 +-- Print/src/SimParticlePtrPrinter.cc | 3 +-- Print/src/SimParticleTimeMapPrinter.cc | 3 +-- Print/src/StatusG4Printer.cc | 3 +-- Print/src/StepPointMCPrinter.cc | 3 +-- Print/src/StrawDigiADCWaveformPrinter.cc | 3 +-- Print/src/StrawDigiMCPrinter.cc | 3 +-- Print/src/StrawDigiPrinter.cc | 3 +-- Print/src/StrawGasStepPrinter.cc | 3 +-- Print/src/StrawHitFlagPrinter.cc | 3 +-- Print/src/StrawHitPrinter.cc | 3 +-- Print/src/TimeClusterPrinter.cc | 3 +-- Print/src/TrackClusterMatchPrinter.cc | 3 +-- Print/src/TrackSummaryPrinter.cc | 3 +-- Print/src/TriggerResultsPrinter.cc | 3 +-- Print/src/TrkCaloIntersectPrinter.cc | 3 +-- RecoDataProducts/src/ComboHit.cc | 3 +-- TrackerMC/src/MakeStrawGasSteps_module.cc | 3 +-- .../src/StrawDigisFromStrawGasSteps_module.cc | 3 +-- TrkDiag/src/TrackAnalysisReco_module.cc | 3 +-- .../src/TimeAndPhiClusterFinder_module.cc | 2 +- TrkPatRec/src/TimeClusterFinder_module.cc | 2 +- Validation/fcl/ceSimReco.fcl | 4 ++-- Validation/src/ValKalSeed.cc | 6 ++--- Validation/src/Validation_module.cc | 3 +-- 65 files changed, 86 insertions(+), 157 deletions(-) diff --git a/Analyses/src/CollectionSizeAnalyzer_module.cc b/Analyses/src/CollectionSizeAnalyzer_module.cc index 26f825897e..df1e5b4c22 100644 --- a/Analyses/src/CollectionSizeAnalyzer_module.cc +++ b/Analyses/src/CollectionSizeAnalyzer_module.cc @@ -113,8 +113,7 @@ namespace mu2e { //================================================================ void CollectionSizeAnalyzer::doStepPoints(const art::Event& event) { - std::vector > stepHandles; - event.getManyByType(stepHandles); + std::vector > stepHandles = event.getMany(); for(const auto& c: stepHandles) { const std::string cn = getCollectionName(c); hStepPointSize_->Fill(cn.c_str(), double(c->size())); @@ -126,8 +125,7 @@ namespace mu2e { //================================================================ void CollectionSizeAnalyzer::doSimParticles(const art::Event& event) { - std::vector > stepHandles; - event.getManyByType(stepHandles); + std::vector > stepHandles = event.getMany(); for(const auto& c: stepHandles) { const std::string cn = getCollectionName(c); hSimParticleDistLin_->Fill(cn.c_str(), double(c->size()), 1.); diff --git a/Analyses/src/DiskCal00_module.cc b/Analyses/src/DiskCal00_module.cc index 2998b25d17..95a8877b25 100644 --- a/Analyses/src/DiskCal00_module.cc +++ b/Analyses/src/DiskCal00_module.cc @@ -236,8 +236,7 @@ namespace mu2e { void DiskCal00::simCheck(const art::Event& event) { typedef std::vector< art::Handle > HandleVector; - HandleVector allSims; - event.getManyByType(allSims); + HandleVector allSims = event.getMany(); cout << "Size: " << allSims.size() << endl; for ( HandleVector::const_iterator i=allSims.begin(), e=allSims.end(); i != e; ++i ){ diff --git a/Analyses/src/GenEventCountReader_module.cc b/Analyses/src/GenEventCountReader_module.cc index 40b8138ebf..3363b00048 100644 --- a/Analyses/src/GenEventCountReader_module.cc +++ b/Analyses/src/GenEventCountReader_module.cc @@ -59,8 +59,7 @@ namespace mu2e { void GenEventCountReader::endSubRun(const art::SubRun& sr) { // We expect exactly one object of type GenEventCount per SubRun. - std::vector > hh; - sr.getManyByType(hh); + std::vector > hh = sr.getMany(); if(hh.size() > 1) { std::ostringstream os; os<<"GenEventCountReader: multiple GenEventCount objects found in " diff --git a/Analyses/src/PointerCheck_module.cc b/Analyses/src/PointerCheck_module.cc index f2a8816fd4..3a30272025 100644 --- a/Analyses/src/PointerCheck_module.cc +++ b/Analyses/src/PointerCheck_module.cc @@ -149,8 +149,7 @@ namespace mu2e { //================================================================ void PointerCheck::analyze(art::Event const& event) { - std::vector< art::Handle > vah_sp; - event.getManyByType(vah_sp); + std::vector< art::Handle > vah_sp = event.getMany(); for (auto const & ah : vah_sp) { if(!excludedCollection(*ah.provenance(),_SPtags)) { printProvenance(*ah.provenance()); @@ -158,8 +157,7 @@ namespace mu2e { } // endif excluded } // loop over handles - std::vector< art::Handle > vah_st; - event.getManyByType(vah_st); + std::vector< art::Handle > vah_st = event.getMany(); for (auto const & ah : vah_st) { if(!excludedCollection(*ah.provenance(),_SPMCtags)) { printProvenance(*ah.provenance()); @@ -167,8 +165,7 @@ namespace mu2e { } // endif excluded } // loop over handles - std::vector< art::Handle > vah_tr; - event.getManyByType(vah_tr); + std::vector< art::Handle > vah_tr = event.getMany(); for (auto const & ah : vah_tr) { if(!excludedCollection(*ah.provenance(),_trajtags)) { printProvenance(*ah.provenance()); @@ -176,8 +173,7 @@ namespace mu2e { } // endif excluded } // loop over handles - std::vector< art::Handle > vah_pp; - event.getManyByType(vah_pp); + std::vector< art::Handle > vah_pp = event.getMany(); for (auto const & ah : vah_pp) { if(!excludedCollection(*ah.provenance(),_trajtags)) { printProvenance(*ah.provenance()); @@ -185,8 +181,7 @@ namespace mu2e { } // endif excluded } // loop over handles - std::vector< art::Handle > vah_sd; - event.getManyByType(vah_sd); + std::vector< art::Handle > vah_sd = event.getMany(); for (auto const & ah : vah_sd) { if(!excludedCollection(*ah.provenance(),_trkDMCtags)) { printProvenance(*ah.provenance()); @@ -194,8 +189,7 @@ namespace mu2e { } // endif excluded } // loop over handles - std::vector< art::Handle > vah_cd; - event.getManyByType(vah_cd); + std::vector< art::Handle > vah_cd = event.getMany(); for (auto const & ah : vah_cd) { if(!excludedCollection(*ah.provenance(),_calDMCtags)) { printProvenance(*ah.provenance()); @@ -203,8 +197,7 @@ namespace mu2e { } // endif excluded } // loop over handles std::cout << "Startgin shower steps" << std::endl; - std::vector< art::Handle > vah_cs; - event.getManyByType(vah_cs); + std::vector< art::Handle > vah_cs = event.getMany(); for (auto const & ah : vah_cs) { if(!excludedCollection(*ah.provenance(),_calCSStags)) { printProvenance(*ah.provenance()); @@ -213,8 +206,7 @@ namespace mu2e { } // loop over handles std::cout << "Starting crvMC" << std::endl; - std::vector< art::Handle > vah_cm; - event.getManyByType(vah_cm); + std::vector< art::Handle > vah_cm = event.getMany(); for (auto const & ah : vah_cm) { if(!excludedCollection(*ah.provenance(),_crvDMCtags)) { printProvenance(*ah.provenance()); diff --git a/Analyses/src/ReadBack_module.cc b/Analyses/src/ReadBack_module.cc index 06beaea973..f085b86a7d 100644 --- a/Analyses/src/ReadBack_module.cc +++ b/Analyses/src/ReadBack_module.cc @@ -383,8 +383,7 @@ namespace mu2e { // These selectors will select data products with the given instance name, and ignore all other fields of the product ID. art::ProductInstanceNameSelector getCrystalSteps(_calorimeterStepPoints); - HandleVector crystalStepsHandles; - event.getMany( getCrystalSteps, crystalStepsHandles); + HandleVector crystalStepsHandles = event.getMany(getCrystalSteps); //Calorimeter shower MC art::Handle caloShowerSimHandle; diff --git a/Analyses/src/ReadCaloDigi_module.cc b/Analyses/src/ReadCaloDigi_module.cc index 320b80787b..95ada7131c 100644 --- a/Analyses/src/ReadCaloDigi_module.cc +++ b/Analyses/src/ReadCaloDigi_module.cc @@ -450,10 +450,9 @@ namespace mu2e { //Handle to VD steps art::ProductInstanceNameSelector selector_vdhits("virtualdetector"); - StepMCHandleVector vdStepsHandleVec; art::Handle *vdStepsHandle; const StepPointMCCollection *vdHits; - event.getMany(selector_vdhits, vdStepsHandleVec); + StepMCHandleVector vdStepsHandleVec = event.getMany(selector_vdhits); //Handle to tracks collection diff --git a/Analyses/src/SimParticleCheck00_module.cc b/Analyses/src/SimParticleCheck00_module.cc index 26465a8094..419e4d57f6 100644 --- a/Analyses/src/SimParticleCheck00_module.cc +++ b/Analyses/src/SimParticleCheck00_module.cc @@ -80,8 +80,7 @@ namespace mu2e { void SimParticleCheck00::analyze(const art::Event& event) { typedef std::vector< art::Handle > HandleVector; - HandleVector allSims; - event.getManyByType(allSims); + HandleVector allSims = event.getMany(); _hNCollections->Fill(allSims.size()); diff --git a/CalPatRec/src/MergePatRec_module.cc b/CalPatRec/src/MergePatRec_module.cc index 03cde4038d..93f7e2c4ba 100644 --- a/CalPatRec/src/MergePatRec_module.cc +++ b/CalPatRec/src/MergePatRec_module.cc @@ -268,11 +268,11 @@ namespace mu2e { if (_debugLevel > 0) ObjectDumpUtils::printEventHeader(&AnEvent,"MergePatRec::produce"); - AnEvent.getByToken(_tprToken, htpr); - AnEvent.getByToken(_cprToken, hcpr); + htpr = AnEvent.getHandle(_tprToken); + hcpr = AnEvent.getHandle(_cprToken); - AnEvent.getByToken(_stprToken, hstpr); - AnEvent.getByToken(_scprToken, hscpr); + hstpr = AnEvent.getHandle(_stprToken); + hscpr = AnEvent.getHandle(_scprToken); _data.event = &AnEvent; _data.list_of_kreps_tpr = nullptr; diff --git a/CaloCluster/src/CaloClusterFast_module.cc b/CaloCluster/src/CaloClusterFast_module.cc index 5778c14c6c..8c003ab5a7 100644 --- a/CaloCluster/src/CaloClusterFast_module.cc +++ b/CaloCluster/src/CaloClusterFast_module.cc @@ -71,8 +71,7 @@ namespace mu2e { void CaloClusterFast::produce(art::Event& event) { - art::Handle caloHitsHandle; - event.getByToken(caloCrystalToken_, caloHitsHandle); + art::Handle caloHitsHandle = event.getHandle(caloCrystalToken_); auto caloClusters = std::make_unique(); makeClusters(*caloClusters,caloHitsHandle); diff --git a/CaloCluster/src/CaloProtoClusterMaker_module.cc b/CaloCluster/src/CaloProtoClusterMaker_module.cc index 3e90fd22a9..75dce45b2d 100644 --- a/CaloCluster/src/CaloProtoClusterMaker_module.cc +++ b/CaloCluster/src/CaloProtoClusterMaker_module.cc @@ -105,9 +105,8 @@ namespace mu2e { if( !(geom->hasElement()) ) return; // Get handles to calorimeter crystal hits - art::Handle CaloHitsHandle; - bool const success = event.getByToken(caloCrystalToken_, CaloHitsHandle); - if (!success) return; + art::Handle CaloHitsHandle = event.getHandle(caloCrystalToken_); + if ( ! CaloHitsHandle ) return; // Create a new CaloCluster collection and fill it auto caloProtoClustersMain = std::make_unique(); diff --git a/CaloDiag/src/CaloNeutron_module.cc b/CaloDiag/src/CaloNeutron_module.cc index b0a1a8e32e..bf44be16cb 100644 --- a/CaloDiag/src/CaloNeutron_module.cc +++ b/CaloDiag/src/CaloNeutron_module.cc @@ -208,8 +208,7 @@ namespace mu2e { void CaloNeutron::endSubRun(const art::SubRun& sr) { - std::vector > hh; - sr.getManyByType(hh); + std::vector > hh = sr.getMany(); if(hh.size() > 1) { @@ -268,10 +267,10 @@ namespace mu2e { // Get the StepPointMCs from the event. HandleVector crystalStepsHandles, ROStepsHandles,ROCardStepsHandles,CrateStepsHandles; - event.getMany( getCrystalSteps, crystalStepsHandles); - event.getMany( getROSteps, ROStepsHandles); - event.getMany( getROCardSteps, ROCardStepsHandles); - event.getMany( getCrateSteps, CrateStepsHandles); + crystalStepsHandles = event.getMany(getCrystalSteps); + ROStepsHandles = event.getMany(getROSteps); + ROCardStepsHandles = event.getMany(getROCardSteps); + CrateStepsHandles = event.getMany(getCrateSteps); diff --git a/CaloFilters/src/FilterEcalNNTrigger_module.cc b/CaloFilters/src/FilterEcalNNTrigger_module.cc index a66461cbbc..325704522b 100644 --- a/CaloFilters/src/FilterEcalNNTrigger_module.cc +++ b/CaloFilters/src/FilterEcalNNTrigger_module.cc @@ -72,8 +72,7 @@ namespace mu2e { bool FilterEcalNNTrigger::filter(art::Event& event) { - art::Handle caloClustersHandle; - event.getByToken(caloClusterToken_, caloClustersHandle); + art::Handle caloClustersHandle = event.getHandle(caloClusterToken_); auto trigInfo = std::make_unique(); bool retval = filterClusters(caloClustersHandle, *trigInfo); diff --git a/CommonMC/src/GenerateCosmicTimes_module.cc b/CommonMC/src/GenerateCosmicTimes_module.cc index 25d57bb926..b4db91ff2f 100644 --- a/CommonMC/src/GenerateCosmicTimes_module.cc +++ b/CommonMC/src/GenerateCosmicTimes_module.cc @@ -161,8 +161,7 @@ namespace mu2e { // Generate and record offsets for all primaries - std::vector > colls; - event.getManyByType(colls); + std::vector > colls = event.getMany(); for(const auto& ih : colls) { for(const auto& iter : *ih) { if(iter.second.isPrimary()) { diff --git a/CommonMC/src/GenerateMuonLife_module.cc b/CommonMC/src/GenerateMuonLife_module.cc index 5eeb6efeee..9c351f32e5 100644 --- a/CommonMC/src/GenerateMuonLife_module.cc +++ b/CommonMC/src/GenerateMuonLife_module.cc @@ -115,8 +115,7 @@ namespace mu2e { res->insert(inmap->begin(),inmap->end()); } - std::vector > colls; - event.getManyByType(colls); + std::vector > colls = event.getMany(); // Generate and record offsets for all primaries for(const auto& ih : colls) { diff --git a/CommonMC/src/GenerateProtonTimes_module.cc b/CommonMC/src/GenerateProtonTimes_module.cc index a3c7b5c19a..a48be8ba98 100644 --- a/CommonMC/src/GenerateProtonTimes_module.cc +++ b/CommonMC/src/GenerateProtonTimes_module.cc @@ -162,8 +162,7 @@ namespace mu2e { res->insert(inmap->begin(),inmap->end()); } - std::vector > colls; - event.getManyByType(colls); + std::vector > colls = event.getMany(); art::Handle ftmHandle; if (!fixedTime_.empty()) event.getByLabel(fixedTime_, ftmHandle); diff --git a/CommonMC/src/SelectRecoMC_module.cc b/CommonMC/src/SelectRecoMC_module.cc index 8ea1a21926..611a1c8f70 100644 --- a/CommonMC/src/SelectRecoMC_module.cc +++ b/CommonMC/src/SelectRecoMC_module.cc @@ -349,8 +349,7 @@ namespace mu2e { for (auto const& ksc : _kscs) { // get all products from this art::ModuleLabelSelector kscsel(ksc); - std::vector< art::Handle > seedhs; - event.getMany(kscsel, seedhs); + std::vector< art::Handle > seedhs = event.getMany(kscsel); if(_debug > 1) std::cout << "Found " << seedhs.size() << " collections from module " << ksc << std::endl; // loop over the KalSeeds and the hits inside them for(auto const& seedh : seedhs) { @@ -392,8 +391,7 @@ namespace mu2e { for (auto const& hsc : _hscs) { // get all products from this art::ModuleLabelSelector hscsel(hsc); - std::vector< art::Handle > seedhs; - event.getMany(hscsel, seedhs); + std::vector< art::Handle > seedhs = event.getMany(hscsel); if(_debug > 1) std::cout << "Found " << seedhs.size() << " collections from module " << hsc << std::endl; // loop over the HelixSeeds and the hits inside them for(auto const& seedh : seedhs) { diff --git a/DAQ/src/CaloHitsFromFragments_module.cc b/DAQ/src/CaloHitsFromFragments_module.cc index 1a7c838991..7d71a98131 100644 --- a/DAQ/src/CaloHitsFromFragments_module.cc +++ b/DAQ/src/CaloHitsFromFragments_module.cc @@ -134,7 +134,7 @@ void art::CaloHitsFromFragments::addPulse(uint16_t& crystalID, float& time, floa } } if (addNewHit) { - pulseMap_[crystalID].emplace_back(mu2e::CaloHit(crystalID, 1, time, eDep)); + pulseMap_[crystalID].push_back(CrystalInfo(crystalID, 1, time, eDep)); } } diff --git a/EventGenerator/src/GenEventCounter_module.cc b/EventGenerator/src/GenEventCounter_module.cc index 04e40fad36..177a3f7f4a 100644 --- a/EventGenerator/src/GenEventCounter_module.cc +++ b/EventGenerator/src/GenEventCounter_module.cc @@ -53,8 +53,7 @@ namespace mu2e { // The intention is to have at most one object of type // GenEventCount per SubRun. Throw here if such an // object is already in SubRun. - std::vector > hh; - sr.getManyByType(hh); + std::vector > hh = sr.getMany(); if(!hh.empty()) { std::ostringstream os; os<<"GenEventCounter: refusing to write event count in " diff --git a/Filters/src/RecoMomFilter_module.cc b/Filters/src/RecoMomFilter_module.cc index 54767a6945..7682268de2 100644 --- a/Filters/src/RecoMomFilter_module.cc +++ b/Filters/src/RecoMomFilter_module.cc @@ -59,8 +59,7 @@ namespace mu2e { bool RecoMomFilter::filter(art::Event& event) { - std::vector > colls; - event.getManyByType(colls); + std::vector > colls = event.getMany(); std::vector moduleNames; for (size_t i=0;i<_trkTags.size();i++){ diff --git a/GeneralUtilities/src/ParameterSetFromFile.cc b/GeneralUtilities/src/ParameterSetFromFile.cc index a02368f8fc..82770d08a5 100644 --- a/GeneralUtilities/src/ParameterSetFromFile.cc +++ b/GeneralUtilities/src/ParameterSetFromFile.cc @@ -20,9 +20,8 @@ ParameterSetFromFile( std::string const& fileName ): { cet::filepath_lookup policy("FHICL_FILE_PATH"); - fhicl::intermediate_table tbl; - fhicl::parse_document(_fileName, policy, tbl); - fhicl::make_ParameterSet(tbl, _pSet); + fhicl::intermediate_table tbl = fhicl::parse_document(_fileName, policy); + _pSet = fhicl::ParameterSet::make(tbl); } diff --git a/Mu2eUtilities/src/SimParticleParentGetter.cc b/Mu2eUtilities/src/SimParticleParentGetter.cc index 71ccbe0e77..ebe9a77fb2 100644 --- a/Mu2eUtilities/src/SimParticleParentGetter.cc +++ b/Mu2eUtilities/src/SimParticleParentGetter.cc @@ -44,16 +44,14 @@ namespace mu2e { if(stepPointMap_.empty()) { // need to load the associations typedef std::vector > StepPointHandles; - StepPointHandles stepPointResults; - evt_->getManyByType(stepPointResults); + StepPointHandles stepPointResults = evt_->getMany(); if (stepPointResults.empty() ) { //no associations with StepPoints. Trying with simparticle end points if (simParticleMap_.empty()) { //need to load the associations typedef std::vector > SimParticleHandles; - SimParticleHandles simParticleResults; - evt_->getManyByType(simParticleResults); + SimParticleHandles simParticleResults = evt_->getMany(); for(SimParticleHandles::const_iterator h = simParticleResults.begin(); h != simParticleResults.end(); ++h) { AGDEBUG("In loop over simParticleHandles"); diff --git a/Print/src/BkgClusterPrinter.cc b/Print/src/BkgClusterPrinter.cc index f66b1ee249..c2c8735661 100644 --- a/Print/src/BkgClusterPrinter.cc +++ b/Print/src/BkgClusterPrinter.cc @@ -10,8 +10,7 @@ mu2e::BkgClusterPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/BkgQualPrinter.cc b/Print/src/BkgQualPrinter.cc index cc84ebb236..b80deb95d5 100644 --- a/Print/src/BkgQualPrinter.cc +++ b/Print/src/BkgQualPrinter.cc @@ -10,8 +10,7 @@ mu2e::BkgQualPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CaloClusterPrinter.cc b/Print/src/CaloClusterPrinter.cc index f476ff80b1..ea6a3455bb 100644 --- a/Print/src/CaloClusterPrinter.cc +++ b/Print/src/CaloClusterPrinter.cc @@ -10,8 +10,7 @@ mu2e::CaloClusterPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CaloDigiPrinter.cc b/Print/src/CaloDigiPrinter.cc index 1ca998b337..b59a21e8c6 100644 --- a/Print/src/CaloDigiPrinter.cc +++ b/Print/src/CaloDigiPrinter.cc @@ -10,8 +10,7 @@ mu2e::CaloDigiPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CaloHitPrinter.cc b/Print/src/CaloHitPrinter.cc index a42f922e3d..0a59d44fd5 100644 --- a/Print/src/CaloHitPrinter.cc +++ b/Print/src/CaloHitPrinter.cc @@ -10,8 +10,7 @@ mu2e::CaloHitPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CaloRecoDigiPrinter.cc b/Print/src/CaloRecoDigiPrinter.cc index 7e53c731db..87f88e405d 100644 --- a/Print/src/CaloRecoDigiPrinter.cc +++ b/Print/src/CaloRecoDigiPrinter.cc @@ -10,8 +10,7 @@ mu2e::CaloRecoDigiPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CaloShowerStepPrinter.cc b/Print/src/CaloShowerStepPrinter.cc index d8b07169d1..b7473c75e1 100644 --- a/Print/src/CaloShowerStepPrinter.cc +++ b/Print/src/CaloShowerStepPrinter.cc @@ -10,8 +10,7 @@ mu2e::CaloShowerStepPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/ComboHitPrinter.cc b/Print/src/ComboHitPrinter.cc index 5a26cb5ec4..b0a477989a 100644 --- a/Print/src/ComboHitPrinter.cc +++ b/Print/src/ComboHitPrinter.cc @@ -10,8 +10,7 @@ mu2e::ComboHitPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CrvCoincidenceClusterPrinter.cc b/Print/src/CrvCoincidenceClusterPrinter.cc index 6e06b92806..8ce01b7982 100644 --- a/Print/src/CrvCoincidenceClusterPrinter.cc +++ b/Print/src/CrvCoincidenceClusterPrinter.cc @@ -10,8 +10,7 @@ mu2e::CrvCoincidenceClusterPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CrvDigiMCPrinter.cc b/Print/src/CrvDigiMCPrinter.cc index 13ab79dc83..444381d31c 100644 --- a/Print/src/CrvDigiMCPrinter.cc +++ b/Print/src/CrvDigiMCPrinter.cc @@ -10,8 +10,7 @@ mu2e::CrvDigiMCPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CrvDigiPrinter.cc b/Print/src/CrvDigiPrinter.cc index 6ffd2bb8cc..c51d0eb13c 100644 --- a/Print/src/CrvDigiPrinter.cc +++ b/Print/src/CrvDigiPrinter.cc @@ -10,8 +10,7 @@ mu2e::CrvDigiPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CrvRecoPulsePrinter.cc b/Print/src/CrvRecoPulsePrinter.cc index 17a5817a2e..113c97e514 100644 --- a/Print/src/CrvRecoPulsePrinter.cc +++ b/Print/src/CrvRecoPulsePrinter.cc @@ -10,8 +10,7 @@ mu2e::CrvRecoPulsePrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/CrvStepPrinter.cc b/Print/src/CrvStepPrinter.cc index 2e52321a92..3b6f8c96a4 100644 --- a/Print/src/CrvStepPrinter.cc +++ b/Print/src/CrvStepPrinter.cc @@ -10,8 +10,7 @@ mu2e::CrvStepPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/GenParticlePrinter.cc b/Print/src/GenParticlePrinter.cc index 1d4238ccf2..bca8d55d5f 100644 --- a/Print/src/GenParticlePrinter.cc +++ b/Print/src/GenParticlePrinter.cc @@ -10,8 +10,7 @@ mu2e::GenParticlePrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/KalRepPrinter.cc b/Print/src/KalRepPrinter.cc index 2c3e3b06b8..730826ee6a 100644 --- a/Print/src/KalRepPrinter.cc +++ b/Print/src/KalRepPrinter.cc @@ -19,8 +19,7 @@ mu2e::KalRepPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/KalSeedPrinter.cc b/Print/src/KalSeedPrinter.cc index e751bfd8d7..de9205e636 100644 --- a/Print/src/KalSeedPrinter.cc +++ b/Print/src/KalSeedPrinter.cc @@ -11,8 +11,7 @@ mu2e::KalSeedPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/MCTrajectoryPrinter.cc b/Print/src/MCTrajectoryPrinter.cc index 0d25feeee5..ad314c285c 100644 --- a/Print/src/MCTrajectoryPrinter.cc +++ b/Print/src/MCTrajectoryPrinter.cc @@ -10,8 +10,7 @@ mu2e::MCTrajectoryPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/PhysicalVolumePrinter.cc b/Print/src/PhysicalVolumePrinter.cc index 9d9c15529d..d9bacf6f4d 100644 --- a/Print/src/PhysicalVolumePrinter.cc +++ b/Print/src/PhysicalVolumePrinter.cc @@ -10,8 +10,7 @@ mu2e::PhysicalVolumePrinter::PrintSubRun(art::SubRun const& subrun, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - subrun.getManyByType(vah); + std::vector< art::Handle > vah = subrun.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/PrimaryParticlePrinter.cc b/Print/src/PrimaryParticlePrinter.cc index 11544e0df0..3b4b673a50 100644 --- a/Print/src/PrimaryParticlePrinter.cc +++ b/Print/src/PrimaryParticlePrinter.cc @@ -11,8 +11,7 @@ mu2e::PrimaryParticlePrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/SimParticlePrinter.cc b/Print/src/SimParticlePrinter.cc index d50d2f2718..26b1792aea 100644 --- a/Print/src/SimParticlePrinter.cc +++ b/Print/src/SimParticlePrinter.cc @@ -10,8 +10,7 @@ mu2e::SimParticlePrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/SimParticlePtrPrinter.cc b/Print/src/SimParticlePtrPrinter.cc index 83d47cdac6..6bf495e291 100644 --- a/Print/src/SimParticlePtrPrinter.cc +++ b/Print/src/SimParticlePtrPrinter.cc @@ -10,8 +10,7 @@ mu2e::SimParticlePtrPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/SimParticleTimeMapPrinter.cc b/Print/src/SimParticleTimeMapPrinter.cc index 3a7cd94225..1ea046fb50 100644 --- a/Print/src/SimParticleTimeMapPrinter.cc +++ b/Print/src/SimParticleTimeMapPrinter.cc @@ -10,8 +10,7 @@ mu2e::SimParticleTimeMapPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/StatusG4Printer.cc b/Print/src/StatusG4Printer.cc index 4405023114..90b11a02a9 100644 --- a/Print/src/StatusG4Printer.cc +++ b/Print/src/StatusG4Printer.cc @@ -10,8 +10,7 @@ mu2e::StatusG4Printer::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/StepPointMCPrinter.cc b/Print/src/StepPointMCPrinter.cc index f61758fb57..da9c059594 100644 --- a/Print/src/StepPointMCPrinter.cc +++ b/Print/src/StepPointMCPrinter.cc @@ -10,8 +10,7 @@ mu2e::StepPointMCPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/StrawDigiADCWaveformPrinter.cc b/Print/src/StrawDigiADCWaveformPrinter.cc index bc07b1169f..f904eb46ba 100644 --- a/Print/src/StrawDigiADCWaveformPrinter.cc +++ b/Print/src/StrawDigiADCWaveformPrinter.cc @@ -10,8 +10,7 @@ mu2e::StrawDigiADCWaveformPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/StrawDigiMCPrinter.cc b/Print/src/StrawDigiMCPrinter.cc index 685ca76323..5878e064ae 100644 --- a/Print/src/StrawDigiMCPrinter.cc +++ b/Print/src/StrawDigiMCPrinter.cc @@ -10,8 +10,7 @@ mu2e::StrawDigiMCPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/StrawDigiPrinter.cc b/Print/src/StrawDigiPrinter.cc index d97753575e..6b5e196be3 100644 --- a/Print/src/StrawDigiPrinter.cc +++ b/Print/src/StrawDigiPrinter.cc @@ -10,8 +10,7 @@ mu2e::StrawDigiPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/StrawGasStepPrinter.cc b/Print/src/StrawGasStepPrinter.cc index 3393f243bd..1c6848259a 100644 --- a/Print/src/StrawGasStepPrinter.cc +++ b/Print/src/StrawGasStepPrinter.cc @@ -10,8 +10,7 @@ mu2e::StrawGasStepPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/StrawHitFlagPrinter.cc b/Print/src/StrawHitFlagPrinter.cc index 22c0499353..e0307fc99f 100644 --- a/Print/src/StrawHitFlagPrinter.cc +++ b/Print/src/StrawHitFlagPrinter.cc @@ -10,8 +10,7 @@ mu2e::StrawHitFlagPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/StrawHitPrinter.cc b/Print/src/StrawHitPrinter.cc index aaadab15ce..6b8dcca7ce 100644 --- a/Print/src/StrawHitPrinter.cc +++ b/Print/src/StrawHitPrinter.cc @@ -10,8 +10,7 @@ mu2e::StrawHitPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/TimeClusterPrinter.cc b/Print/src/TimeClusterPrinter.cc index fdff85d002..061b116296 100644 --- a/Print/src/TimeClusterPrinter.cc +++ b/Print/src/TimeClusterPrinter.cc @@ -10,8 +10,7 @@ mu2e::TimeClusterPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/TrackClusterMatchPrinter.cc b/Print/src/TrackClusterMatchPrinter.cc index fcce8fbf23..5c47334ffd 100644 --- a/Print/src/TrackClusterMatchPrinter.cc +++ b/Print/src/TrackClusterMatchPrinter.cc @@ -10,8 +10,7 @@ mu2e::TrackClusterMatchPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/TrackSummaryPrinter.cc b/Print/src/TrackSummaryPrinter.cc index 5629006b8a..6081ed6ed1 100644 --- a/Print/src/TrackSummaryPrinter.cc +++ b/Print/src/TrackSummaryPrinter.cc @@ -9,8 +9,7 @@ mu2e::TrackSummaryPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/TriggerResultsPrinter.cc b/Print/src/TriggerResultsPrinter.cc index a9e8054eb0..765f778d7e 100644 --- a/Print/src/TriggerResultsPrinter.cc +++ b/Print/src/TriggerResultsPrinter.cc @@ -12,8 +12,7 @@ mu2e::TriggerResultsPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/Print/src/TrkCaloIntersectPrinter.cc b/Print/src/TrkCaloIntersectPrinter.cc index cf790629d6..d05478c304 100644 --- a/Print/src/TrkCaloIntersectPrinter.cc +++ b/Print/src/TrkCaloIntersectPrinter.cc @@ -10,8 +10,7 @@ mu2e::TrkCaloIntersectPrinter::Print(art::Event const& event, if(verbose()<1) return; if(tags().empty()) { // if a list of instances not specified, print all instances - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) Print(ah); } else { // print requested instances diff --git a/RecoDataProducts/src/ComboHit.cc b/RecoDataProducts/src/ComboHit.cc index 40a324038b..93b628aefa 100644 --- a/RecoDataProducts/src/ComboHit.cc +++ b/RecoDataProducts/src/ComboHit.cc @@ -58,9 +58,8 @@ namespace mu2e { void ComboHitCollection::setParentHandle(art::Event const& event, art::Handle& phandle) const { // set the handle to an invalid state in case we find no such phandle = art::Handle(); - vector > all_handles; + vector > all_handles = event.getMany(); // exhaustive search is fast enough - event.getManyByType(all_handles); for (auto const& handle : all_handles) { if(_parent == handle.id()){ phandle = handle; diff --git a/TrackerMC/src/MakeStrawGasSteps_module.cc b/TrackerMC/src/MakeStrawGasSteps_module.cc index e7b1540da6..dd9a880056 100644 --- a/TrackerMC/src/MakeStrawGasSteps_module.cc +++ b/TrackerMC/src/MakeStrawGasSteps_module.cc @@ -215,8 +215,7 @@ namespace mu2e { auto StrawGasStepCollectionGetter = event.productGetter(StrawGasStepCollectionPID); // Get all of the tracker StepPointMC collections from the event: // This selector will select only data products with the given instance name. - SPMCCHV stepsHandles; - event.getMany( _selector, stepsHandles); + SPMCCHV stepsHandles = event.getMany( _selector); // const Tracker& tracker = *GeomHandle(); // Informational message on the first event. if ( _firstEvent && _debug>0 ) { diff --git a/TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc b/TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc index 9b92e4af71..d3ad5e1e3c 100644 --- a/TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc +++ b/TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc @@ -538,8 +538,7 @@ namespace mu2e { art::Event const& event, StrawClusterMap & hmap){ // Get all of the tracker StrawGasStep collections from the event: typedef vector< art::Handle > HandleVector; - HandleVector stepsHandles; - event.getMany( _selector, stepsHandles); + HandleVector stepsHandles = event.getMany( _selector); // Informational message on the first event. if ( _firstEvent ) { mf::LogInfo log(_messageCategory); diff --git a/TrkDiag/src/TrackAnalysisReco_module.cc b/TrkDiag/src/TrackAnalysisReco_module.cc index 6bdb2138fe..f07041a9d0 100644 --- a/TrkDiag/src/TrackAnalysisReco_module.cc +++ b/TrkDiag/src/TrackAnalysisReco_module.cc @@ -765,8 +765,7 @@ namespace mu2e { template std::vector > TrackAnalysisReco::createSpecialBranch(const art::Event& event, const std::string& branchname, std::vector >& handles, TI& infostruct, const std::string& selection) { - std::vector > outputHandles; - event.getManyByType(handles); + std::vector > outputHandles = event.getMany(); if (handles.size()>0) { std::vector labels; for (const auto& i_handle : handles) { diff --git a/TrkPatRec/src/TimeAndPhiClusterFinder_module.cc b/TrkPatRec/src/TimeAndPhiClusterFinder_module.cc index 75ecd57958..7a170e70ee 100644 --- a/TrkPatRec/src/TimeAndPhiClusterFinder_module.cc +++ b/TrkPatRec/src/TimeAndPhiClusterFinder_module.cc @@ -221,7 +221,7 @@ namespace mu2e { chcol_ = chH.product(); art::Handle ccH{}; - if (usecc_) {event.getByToken(ccToken_, ccH);} + if (usecc_) {ccH = event.getHandle(ccToken_);} if (testflag_) { diff --git a/TrkPatRec/src/TimeClusterFinder_module.cc b/TrkPatRec/src/TimeClusterFinder_module.cc index 5ecb2df878..13e89d4a49 100644 --- a/TrkPatRec/src/TimeClusterFinder_module.cc +++ b/TrkPatRec/src/TimeClusterFinder_module.cc @@ -224,7 +224,7 @@ namespace mu2e { art::Handle ccH{}; // need to cache for later Ptr creation if(_usecc){ - event.getByToken(_ccToken, ccH); + ccH = event.getHandle(_ccToken); _cccol = ccH.product(); } diff --git a/Validation/fcl/ceSimReco.fcl b/Validation/fcl/ceSimReco.fcl index ea8bd208d3..22781cb1c2 100644 --- a/Validation/fcl/ceSimReco.fcl +++ b/Validation/fcl/ceSimReco.fcl @@ -99,9 +99,9 @@ services.scheduler.wantSummary: true services.TimeTracker.printSummary: true # histogram file -services.TFileService.fileName: "/dev/null" +services.TFileService.fileName: "/mu2e/data2/users/macndev/val_art3_09/nts.owner.val-ceSimReco309.dsconf.seq.root" # art file -outputs.Output.fileName : "mcs.owner.val-ceSimReco.dsconf.seq.art" +outputs.Output.fileName : "/mu2e/data2/users/macndev/val_art3_09/mcs.owner.val-ceSimReco309.dsconf.seq.art" # run 1h by default source.maxEvents: 5000 diff --git a/Validation/src/ValKalSeed.cc b/Validation/src/ValKalSeed.cc index 955949ae53..b191bbecf2 100644 --- a/Validation/src/ValKalSeed.cc +++ b/Validation/src/ValKalSeed.cc @@ -190,8 +190,7 @@ double mu2e::ValKalSeed::mcTrkP(art::Event const& event) { // this will be the simparticle numbers which belong to the conv ele std::vector cea; - std::vector< art::Handle > vah; - event.getManyByType(vah); + std::vector< art::Handle > vah = event.getMany(); for (auto const & ah : vah) { // loop over all SimParticle coll auto const& simpcoll = *ah; //SimParticleCollection for(auto sp : simpcoll) { // loop over SimParticles @@ -210,8 +209,7 @@ double mu2e::ValKalSeed::mcTrkP(art::Event const& event) { CLHEP::Hep3Vector pv; - std::vector< art::Handle > vah2; - event.getManyByType(vah2); + std::vector< art::Handle > vah2 = event.getMany(); for (auto const & ah : vah2) { // loop over SPMC colls if(ah.provenance()->productInstanceName()=="virtualdetector") { auto const& spmccoll = *ah; //StepPointMCCollection diff --git a/Validation/src/Validation_module.cc b/Validation/src/Validation_module.cc index 7b1a2a17dc..978db21f6e 100644 --- a/Validation/src/Validation_module.cc +++ b/Validation/src/Validation_module.cc @@ -173,8 +173,7 @@ int mu2e::Validation::analyzeProduct( art::Event const& event) { // get all instances of products of type T - std::vector> vah; - event.getManyByType(vah); + std::vector> vah = event.getMany(); std::string name; // loop over the list of instances of products of this type From 0236ddf0f944d91bb1b38171d2aa4c50cb8e0b5a Mon Sep 17 00:00:00 2001 From: gianipez Date: Sun, 18 Apr 2021 14:34:24 -0500 Subject: [PATCH 24/54] updates --- DAQ/src/CaloHitsFromFragments_module.cc | 105 ++++++++++++++---------- 1 file changed, 63 insertions(+), 42 deletions(-) diff --git a/DAQ/src/CaloHitsFromFragments_module.cc b/DAQ/src/CaloHitsFromFragments_module.cc index d27d37512d..dcffac5948 100644 --- a/DAQ/src/CaloHitsFromFragments_module.cc +++ b/DAQ/src/CaloHitsFromFragments_module.cc @@ -63,6 +63,9 @@ class art::CaloHitsFromFragments : public EDProducer { fhicl::Name("pulseRatioMin"), fhicl::Comment("Min of the ratio between two SiPM pulses coupled to the same crystal " "within the time-gate")}; + fhicl::Atom hitEDepMax{ + fhicl::Name("hitEDepMax"), + fhicl::Comment("Maximum hit energy in MeV (to reject saturated pulses)")}; }; // --- C'tor/d'tor: @@ -79,22 +82,24 @@ class art::CaloHitsFromFragments : public EDProducer { std::unique_ptr const& calo_hits, std::unique_ptr const& caphri_hits); - void addPulse(uint16_t& crystalID, float& time, float& eDep); + void addPulse(uint16_t& crystalID, float& time, float& eDep, + std::unique_ptrconst& hits_calo, + std::unique_ptrconst& hits_caphri); int diagLevel_; art::InputTag caloFragmentsTag_; float digiSampling_; - float deltaTPulses_, pulseRatioMax_, pulseRatioMin_; + float deltaTPulses_, pulseRatioMax_, pulseRatioMin_, hitEDepMax_; const int hexShiftPrint = 7; - std::unordered_map> - pulseMap_; // Temporary hack until the Calorimeter channel map is finialized + std::unordered_map> pulseMap_; // Temporary hack until the Calorimeter channel map is finialized mu2e::CaloDAQUtilities caloDAQUtil_; std::array peakADC2MeV_; - std::array caphriCrystalID_; + std::array timeCalib_; + std::array caphriCrystalID_; }; // ====================================================================== @@ -108,6 +113,7 @@ void art::CaloHitsFromFragments::beginRun(art::Run& Run) { // NOW FILLING THE ARRAY WITH A DUMMY VALUE for (size_t i = 0; i < peakADC2MeV_.size(); ++i) { peakADC2MeV_[i] = 0.0461333; + timeCalib_ [i] = 0.; } // FIX ME! @@ -116,34 +122,62 @@ void art::CaloHitsFromFragments::beginRun(art::Run& Run) { caphriCrystalID_ = {623, 624, 595, 596}; } -void art::CaloHitsFromFragments::addPulse(uint16_t& crystalID, float& time, float& eDep) { +void art::CaloHitsFromFragments::addPulse(uint16_t& crystalID, float& time, float& eDep, + std::unique_ptrconst & hits_calo, + std::unique_ptrconst & hits_caphri) { bool addNewHit(true); + bool isCaphri = std::find(caphriCrystalID_.begin(), caphriCrystalID_.end(), crystalID) != + caphriCrystalID_.end(); + size_t counter(0); for (auto& pulse : pulseMap_[crystalID]) { - // search if there is a hit matching in time and eDep - if ((std::fabs(pulse._time - time) < deltaTPulses_) && (eDep / pulse._eDep <= pulseRatioMax_) && - (eDep / pulse._eDep >= pulseRatioMin_)) { - // combine the pulses - pulse._time = (pulse._time + time) / 2.; - pulse._eDep = (pulse._eDep + eDep) / 2.; - pulse._nSiPM += 1; - addNewHit = false; + ++counter; + if (std::fabs(pulse.time() - time) < deltaTPulses_){ + if( (eDep / pulse.energyDep() <= pulseRatioMax_) && + (eDep / pulse.energyDep() >= pulseRatioMin_) ) { + // combine the pulses + pulse.setTime ( (pulse.time() + time) / 2.);//probably not necessary + pulse.setEDep ( (pulse.energyDep() + eDep) / 2.); + pulse.setNSiPMs( pulse.nSiPMs()+ 1); + addNewHit = false; + }else if (eDep > pulse.energyDep()) { + pulse.setTime (time);//probably not necessary + pulse.setEDep (eDep); + addNewHit = false; + } + + //move the pulse in the final collection + if (isCaphri){ + hits_caphri->emplace_back(std::move(pulse)); + }else{ + hits_calo->emplace_back(std::move(pulse)); + } break; } } if (addNewHit) { - pulseMap_[crystalID].push_back(CrystalInfo(crystalID, 1, time, eDep)); - } + pulseMap_[crystalID].emplace_back(mu2e::CaloHit(crystalID, 1, time, eDep)); + }// else if (counter>0){ + // std::list::const_iterator it=pulseMap_[crystalID].begin(); + // std::advance(it, counter); + // pulseMap_[crystalID].erase(it); + // } } art::CaloHitsFromFragments::CaloHitsFromFragments(const art::EDProducer::Table& config) : - art::EDProducer{config}, diagLevel_(config().diagLevel()), - caloFragmentsTag_(config().caloTag()), digiSampling_(config().digiSampling()), - deltaTPulses_(config().deltaTPulses()), pulseRatioMax_(config().pulseRatioMax()), - pulseRatioMin_(config().pulseRatioMin()), caloDAQUtil_("CaloHitsFromFragments") { - produces(); - produces("caphri"); -} + art::EDProducer{config}, diagLevel_(config().diagLevel()), + caloFragmentsTag_(config().caloTag()), + digiSampling_ (config().digiSampling()), + deltaTPulses_ (config().deltaTPulses()), + pulseRatioMax_ (config().pulseRatioMax()), + pulseRatioMin_ (config().pulseRatioMin()), + hitEDepMax_ (config().hitEDepMax()), + caloDAQUtil_ ("CaloHitsFromFragments") + { + pulseMap_.reserve(4000); + produces(); + produces("caphri"); + } // ---------------------------------------------------------------------- @@ -281,14 +315,16 @@ void art::CaloHitsFromFragments::analyze_calorimeter_( caloDAQUtil_.getSiPMID(hits[hitIdx].first); // hits[hitIdx].first.DIRACB >> 12; size_t peakIndex = hits[hitIdx].first.IndexOfMaxDigitizerSample; - float eDep(0); + float eDep(0); if (hits[hitIdx].first.IndexOfMaxDigitizerSample < hits[hitIdx].second.size()) { eDep = hits[hitIdx].second.at(peakIndex) * peakADC2MeV_[sipmID]; } - float time = hits[hitIdx].first.Time + peakIndex * digiSampling_; - - addPulse(crystalID, time, eDep); + float time = hits[hitIdx].first.Time + peakIndex * digiSampling_ + timeCalib_[sipmID]; + //FIX ME! WE NEED TO CHECK IF TEH PULSE IS SATURATED HERE + if (eDep < hitEDepMax_){ + addPulse(crystalID, time, eDep, calo_hits, caphri_hits); + } if (diagLevel_ > 1) { // Until we have the final mapping, the BoardID is just a placeholder // adc_t BoardId = cc.DBC_BoardID(pos,channelIdx); @@ -299,21 +335,6 @@ void art::CaloHitsFromFragments::analyze_calorimeter_( } // End loop over readout channels in DataBlock - // now create the CaloHitCollection - for (auto& crystal : pulseMap_) { - bool isCaphri = std::find(caphriCrystalID_.begin(), caphriCrystalID_.end(), crystal.first) != - caphriCrystalID_.end(); - for (auto& crystalInfo : crystal.second) { - if (isCaphri) { - caphri_hits->emplace_back(crystal.first, crystalInfo._nSiPM, crystalInfo._time, - crystalInfo._eDep); - } else { - calo_hits->emplace_back(crystal.first, crystalInfo._nSiPM, crystalInfo._time, - crystalInfo._eDep); - } - } - } - if (err) continue; } From ce50de618c8d24be60104d0a15c0e3335f609668 Mon Sep 17 00:00:00 2001 From: gianipez Date: Sun, 18 Apr 2021 14:34:52 -0500 Subject: [PATCH 25/54] added some accessors --- RecoDataProducts/inc/CaloHit.hh | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/RecoDataProducts/inc/CaloHit.hh b/RecoDataProducts/inc/CaloHit.hh index d441ddaba6..c8311cd39c 100644 --- a/RecoDataProducts/inc/CaloHit.hh +++ b/RecoDataProducts/inc/CaloHit.hh @@ -27,16 +27,20 @@ namespace mu2e { eDepErr_(0),timeErr_(0) {} - int crystalID () const { return crystalId_; } - int nSiPMs () const { return nSiPMs_;} - float time () const { return time_;} - float timeErr () const { return timeErr_;} - float energyDep () const { return eDep_;} - float energyDepErr () const { return eDepErr_;} - float energyDepTot () const { return eDep_*nSiPMs_;} + int crystalID () const { return crystalId_; } + int nSiPMs () const { return nSiPMs_;} + float time () const { return time_;} + float timeErr () const { return timeErr_;} + float energyDep () const { return eDep_;} + float energyDepErr () const { return eDepErr_;} + float energyDepTot () const { return eDep_*nSiPMs_;} float energyDepTotErr() const { return eDepErr_*nSiPMs_;} const std::vector>& recoCaloDigis () const { return recoCaloDigis_;} + void setCrystalID (int ID) { crystalId_ = ID; } + void setNSiPMs (int N) { nSiPMs_ = N; } + void setTime (float T) { time_ = T; } + void setEDep (float E) { eDep_ = E; } private: int crystalId_; From f073896b53f2d2d60c94e9eef39f76f09da6f8ef Mon Sep 17 00:00:00 2001 From: gianipez Date: Sun, 18 Apr 2021 14:35:14 -0500 Subject: [PATCH 26/54] updates --- DAQ/fcl/prolog_trigger.fcl | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/DAQ/fcl/prolog_trigger.fcl b/DAQ/fcl/prolog_trigger.fcl index 03b2890c6b..21e4b7582e 100644 --- a/DAQ/fcl/prolog_trigger.fcl +++ b/DAQ/fcl/prolog_trigger.fcl @@ -34,7 +34,7 @@ DAQ : { # bufferSize : 1000 } - makeSD: + makeSDOld: { module_type: StrawAndCaloDigisFromFragments diagLevel: 0 @@ -46,6 +46,14 @@ DAQ : { caloTag : "daq:calo" } + makeSD: + { + module_type: StrawRecoFromFragments + diagLevel : 0 + useTrkADC : 0 + trkTag : "daq:trk" + } + CaloDigiMaker: { module_type : CaloRecoFromFragments @@ -62,6 +70,8 @@ DAQ : { deltaTPulses : 5. pulseRatioMax : 1.1 pulseRatioMin : 0.9 + # hitEDepMax : 80. + hitEDepMax : 1000. # for testing } CrvDigi: From cb0539e12b908a75b22236bf06f5d1e619bb7485 Mon Sep 17 00:00:00 2001 From: gianipez Date: Tue, 20 Apr 2021 10:44:25 -0500 Subject: [PATCH 27/54] style --- DAQ/src/CaloRecoFromFragments_module.cc | 4 ++++ DAQ/src/StrawRecoFromFragments_module.cc | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/DAQ/src/CaloRecoFromFragments_module.cc b/DAQ/src/CaloRecoFromFragments_module.cc index 5deca11d47..a5052ede2e 100644 --- a/DAQ/src/CaloRecoFromFragments_module.cc +++ b/DAQ/src/CaloRecoFromFragments_module.cc @@ -96,6 +96,10 @@ void art::CaloRecoFromFragments::produce(Event& event) { } numCalFrags = calFragments->size(); + if (diagLevel_ > 1) { + std::cout << "[CaloRecoFromFragments::produce] found "<< numCalFrags <<" Calorimeter fragments" + << std::endl; + } for (size_t idx = 0; idx < numCalFrags; ++idx) { auto size = ((*calFragments)[idx]).sizeBytes(); // * sizeof(artdaq::RawDataType); totalSize += size; diff --git a/DAQ/src/StrawRecoFromFragments_module.cc b/DAQ/src/StrawRecoFromFragments_module.cc index 564d6e480b..c368cee2b9 100644 --- a/DAQ/src/StrawRecoFromFragments_module.cc +++ b/DAQ/src/StrawRecoFromFragments_module.cc @@ -212,7 +212,7 @@ void art::StrawRecoFromFragmnets::analyze_tracker_( mu2e::StrawId sid(trkDataPair.first->StrawIndex); mu2e::TrkTypes::TDCValues tdc = {trkDataPair.first->TDC0(), trkDataPair.first->TDC1()}; mu2e::TrkTypes::TOTValues tot = {trkDataPair.first->TOT0, trkDataPair.first->TOT1}; - mu2e::TrkTypes::ADCValue pmp = trkDataPair.first->PMP; + mu2e::TrkTypes::ADCValue pmp = trkDataPair.first->PMP; // Fill the StrawDigiCollection straw_digis->emplace_back(sid, tdc, tot, pmp); From 2058143e277957456935e986acb32f9219185a59 Mon Sep 17 00:00:00 2001 From: Eric Flumerfelt Date: Tue, 20 Apr 2021 10:50:45 -0500 Subject: [PATCH 28/54] Update putBlockInEvent to correctly fill in DTC subsystem --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 9072ef2a81..e658dca239 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -226,14 +226,13 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { uint8_t& DTCId, uint8_t Subsys); void printHeader(DataBlockHeader const& headerDataBlock); - void putBlockInEvent(DTCLib::DTC_Event& currentEvent, uint8_t dtcID, + void putBlockInEvent(DTCLib::DTC_Event& currentEvent, uint8_t dtcID, DTCLib::DTC_Subsystem subsys, DTCLib::DTC_DataBlock thisBlock) { auto subEvt = currentEvent.GetSubEventByDTCID(dtcID); if (subEvt == nullptr) { DTCLib::DTC_SubEvent newSubEvt; newSubEvt.SetEventWindowTag(currentEvent.GetEventWindowTag()); - auto hdrPtr = newSubEvt.GetHeader(); - hdrPtr->source_dtc_id = dtcID; + newSubEvt.SetSourceDTC(dtcID, subsys); newSubEvt.AddDataBlock(thisBlock); currentEvent.AddSubEvent(newSubEvt); @@ -469,7 +468,7 @@ void ArtBinaryPacketsFromDigis::fillTrackerDataStream(DTCLib::DTC_Event& current } } } - putBlockInEvent(currentEvent, dtcID, thisBlock); + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Tracker, thisBlock); } void ArtBinaryPacketsFromDigis::fillTrackerDMABlocks(DTCLib::DTC_Event& currentEvent, @@ -976,7 +975,7 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterDataStream(DTCLib::DTC_Event& cur } // end loop over the calorimeterHitReadoutPacketVector } - putBlockInEvent(currentEvent, dtcID, thisBlock); + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Calorimeter, thisBlock); } //-------------------------------------------------------------------------------- @@ -1300,7 +1299,7 @@ void ArtBinaryPacketsFromDigis::fillCrvDataStream(DTCLib::DTC_Event& currentEven pos += sizeof(CRVHitReadoutPacket); } - putBlockInEvent(currentEvent, dtcID, thisBlock); + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_CRV, thisBlock); } } // namespace mu2e From 7db213b9d918fd452bcb7f266f90f99a6bce6f63 Mon Sep 17 00:00:00 2001 From: Eric Flumerfelt Date: Wed, 28 Apr 2021 10:05:24 -0500 Subject: [PATCH 29/54] Only put blocks in event when they have hits --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index e658dca239..008ad82152 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -467,8 +467,8 @@ void ArtBinaryPacketsFromDigis::fillTrackerDataStream(DTCLib::DTC_Event& current pos += sizeof(TrackerADCPacket) * num_packets; } } + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Tracker, thisBlock); } - putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Tracker, thisBlock); } void ArtBinaryPacketsFromDigis::fillTrackerDMABlocks(DTCLib::DTC_Event& currentEvent, @@ -973,9 +973,8 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterDataStream(DTCLib::DTC_Event& cur waveform_size); pos += waveform_size; } // end loop over the calorimeterHitReadoutPacketVector + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Calorimeter, thisBlock); } - - putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_Calorimeter, thisBlock); } //-------------------------------------------------------------------------------- @@ -1299,7 +1298,9 @@ void ArtBinaryPacketsFromDigis::fillCrvDataStream(DTCLib::DTC_Event& currentEven pos += sizeof(CRVHitReadoutPacket); } - putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_CRV, thisBlock); + if (hitCount > 0) { + putBlockInEvent(currentEvent, dtcID, DTCLib::DTC_Subsystem_CRV, thisBlock); + } } } // namespace mu2e From 24b6c3d2608e8ff67e587315e68f5a383e426b2b Mon Sep 17 00:00:00 2001 From: Eric Flumerfelt Date: Fri, 30 Apr 2021 11:08:53 -0500 Subject: [PATCH 30/54] Use subsystem to get correct SubEvent --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 008ad82152..8306780852 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -228,7 +228,7 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { void putBlockInEvent(DTCLib::DTC_Event& currentEvent, uint8_t dtcID, DTCLib::DTC_Subsystem subsys, DTCLib::DTC_DataBlock thisBlock) { - auto subEvt = currentEvent.GetSubEventByDTCID(dtcID); + auto subEvt = currentEvent.GetSubEventByDTCID(dtcID, subsys); if (subEvt == nullptr) { DTCLib::DTC_SubEvent newSubEvt; newSubEvt.SetEventWindowTag(currentEvent.GetEventWindowTag()); From 6d954165f606e1691a3e06be310232d226fa39fe Mon Sep 17 00:00:00 2001 From: Eric Flumerfelt Date: Fri, 30 Apr 2021 11:23:03 -0500 Subject: [PATCH 31/54] Update mu2e_artdaq_core dependency --- setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.sh b/setup.sh index 88d86aa635..51b5c6d705 100644 --- a/setup.sh +++ b/setup.sh @@ -132,7 +132,7 @@ else fi # Get access to raw data formats. -setup -B mu2e_artdaq_core v1_05_06b -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} +setup -B mu2e_artdaq_core v1_05_09 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} setup -B heppdt v03_04_02 -q${MU2E_UPS_QUALIFIERS} setup -B BTrk v1_02_30 -q${MU2E_UPS_QUALIFIERS}:p383b From d2f99ccf49b0469dbb23f189e620e6dbc6928c91 Mon Sep 17 00:00:00 2001 From: Gianantonio Pezzullo Date: Thu, 13 May 2021 22:10:19 -0500 Subject: [PATCH 32/54] rebased --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 99 +++++++++------------ 1 file changed, 42 insertions(+), 57 deletions(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 8306780852..7150ce47f1 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -152,20 +152,18 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { std::vector> tsTable; size_t _timestampOffset; - int _includeTracker; - int _includeCalorimeter; - int _includeCrv; - - int _includeDMAHeaders; + int _includeTracker; + int _includeCalorimeter; + int _includeCrv; + int _includeDMAHeaders; // -- include proditions handling - //mu2e::ProditionsHandle _calodaqconds_h; ProditionsHandle _calodaqconds_h; // Set to 1 to save packet data to a binary file - int _generateBinaryFile; + int _generateBinaryFile; - std::string _outputFile; + std::string _outputFile; std::ofstream outputStream; //-------------------------------------------------------------------------------- @@ -189,8 +187,8 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { // 6 rocs per DTC => 27 DTCs // 172 rocs * 8 crystals per roc => 1376 // Note: the highest crystal ID in the old simulation was 1355 - const size_t number_of_calo_rocs = 172; - const size_t number_of_crystals_per_roc = 8; + const size_t number_of_calo_rocs = 136; + const size_t number_of_crystals_per_roc = 10; const size_t number_of_calo_rocs_per_dtc = 6; //-------------------------------------------------------------------------------- @@ -261,19 +259,11 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { //-------------------------------------------------------------------------------- // methods used to handle the calorimeter data //-------------------------------------------------------------------------------- - // void fillCalorimeterDataPacket(const CaloDigi& SD, CaloDataPacket& caloData); - - //void fillCalorimeterDataPacket(mu2e::CaloDAQMap const& calodaqconds, - // const CaloDigi& SD, CaloDataPacket& caloData); void fillCalorimeterDataPacket(CaloDAQMap const& calodaqconds, const CaloDigi& SD, CaloDataPacket& caloData); void addCaloHitToCaloPacket(calo_data_block_t& dataBlock, CaloDataPacket& caloData); - //void fillCalorimeterHeaderDataPacket(const CaloDigi& SD, DataBlockHeader& HeaderData, - // uint64_t& EventNum); - - void fillCalorimeterHeaderDataPacket(CaloDAQMap const& calodaqconds, const CaloDigi& SD, DataBlockHeader& HeaderData, uint64_t& EventNum); @@ -391,16 +381,16 @@ void ArtBinaryPacketsFromDigis::printCalorimeterData(CaloDataPacket const& caloD for (size_t i = 0; i < nHits; ++i) { CalorimeterHitReadoutPacket const& hit = caloData.hitPacketVec[i]; - printf("[ArtBinaryPacketsFromDigis::printCaloData] hit : %i \n", (int)i); - printf("[ArtBinaryPacketsFromDigis::printCaloData] ChannelNumber : %i \n", + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t hit : %i \n", (int)i); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t ChannelNumber : %i \n", (int)hit.ChannelNumber); - printf("[ArtBinaryPacketsFromDigis::printCaloData] DIRACA : %i \n", (int)hit.DIRACA); - printf("[ArtBinaryPacketsFromDigis::printCaloData] DIRACB : %i \n", (int)hit.DIRACB); - printf("[ArtBinaryPacketsFromDigis::printCaloData] ErrorFlags : %i \n", (int)hit.ErrorFlags); - printf("[ArtBinaryPacketsFromDigis::printCaloData] Time : %i \n", (int)hit.Time); - printf("[ArtBinaryPacketsFromDigis::printCaloData] NumberOfSamples : %i \n", + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t DIRACA : %i \n", (int)hit.DIRACA); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t DIRACB : %i \n", (int)hit.DIRACB); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t ErrorFlags : %i \n", (int)hit.ErrorFlags); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t Time : %i \n", (int)hit.Time); + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t NumberOfSamples : %i \n", (int)hit.NumberOfSamples); - printf("[ArtBinaryPacketsFromDigis::printCaloData] IndexOfMaxDigitizerSample : %i \n", + printf("[ArtBinaryPacketsFromDigis::printCaloData]\t IndexOfMaxDigitizerSample : %i \n", (int)hit.IndexOfMaxDigitizerSample); } } @@ -706,20 +696,20 @@ void ArtBinaryPacketsFromDigis::processCalorimeterData(art::Event& evt, uint64_t calo_data_block_list_t& caloDataBlocks) { auto const& cdH = evt.getValidHandle(_cdtoken); const CaloDigiCollection& hits_CD(*cdH); + CaloDAQMap const& calodaqconds = _calodaqconds_h.get(evt.id()); // Get calo daq cond calo_data_block_list_t tmpCaloDataBlockList; - for (size_t i = 0; i < hits_CD.size(); ++i) { // Loop on Digi - CaloDigi const& CD = hits_CD.at(i); // Get Digi #i - - //mu2e::CaloDAQMap const& calodaqconds = _calodaqconds_h.get(evt.id()); // Get calo daq cond - CaloDAQMap const& calodaqconds = _calodaqconds_h.get(evt.id()); // Get calo daq cond + for (size_t i = 0; i < hits_CD.size(); ++i) { + CaloDigi const& CD = hits_CD.at(i); // Fill struct with info for current hit DataBlockHeader headerData; fillCalorimeterHeaderDataPacket(calodaqconds, CD, headerData, eventNum); CaloDataPacket caloData; fillCalorimeterDataPacket(calodaqconds, CD, caloData); - + if (_diagLevel > 1) { + printCalorimeterData(caloData); + } tmpCaloDataBlockList.push_back( std::pair(headerData, caloData)); } @@ -730,7 +720,7 @@ void ArtBinaryPacketsFromDigis::processCalorimeterData(art::Event& evt, uint64_t << tmpCaloDataBlockList.size() << std::endl; } - uint8_t max_dtc_id = number_of_calo_rocs / number_of_calo_rocs_per_dtc - 1; + uint8_t max_dtc_id = number_of_calo_rocs / number_of_calo_rocs_per_dtc; if (number_of_calo_rocs % number_of_calo_rocs_per_dtc > 0) { max_dtc_id += 1; } @@ -744,6 +734,11 @@ void ArtBinaryPacketsFromDigis::processCalorimeterData(art::Event& evt, uint64_t for (size_t curHitIdx = 0; curHitIdx < tmpCaloDataBlockList.size(); curHitIdx++) { if (tmpCaloDataBlockList[curHitIdx].first.s.DTCID == dtcID && tmpCaloDataBlockList[curHitIdx].first.s.LinkID == rocID) { + + if (_diagLevel > 1) { + std::cout << "[ArtBinaryPacketsFromDigis::processCalorimeterData ] filling Hit from DTCID = "<< (int)dtcID + << " ROCID = " << (int)rocID << std::endl; + } if (is_first) { is_first = false; caloDataBlocks.push_back(tmpCaloDataBlockList[curHitIdx]); @@ -797,9 +792,6 @@ void ArtBinaryPacketsFromDigis::fillHeaderByteAndPacketCounts(calo_data_block_t& //-------------------------------------------------------------------------------- // crate a caloPacket from the digi //-------------------------------------------------------------------------------- -//void ArtBinaryPacketsFromDigis::fillCalorimeterDataPacket(mu2e::CaloDAQMap const& calodaqconds, -// const CaloDigi& CD, -// CaloDataPacket& CaloData) { void ArtBinaryPacketsFromDigis::fillCalorimeterDataPacket(CaloDAQMap const& calodaqconds, const CaloDigi& CD, CaloDataPacket& CaloData) { @@ -810,15 +802,15 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterDataPacket(CaloDAQMap const& calo // Change # 1: get roid and cryID from Digi //========================================= - uint16_t roId = CD.SiPMID(); - uint16_t crystalId = roId/2; + uint16_t roId = CD.SiPMID(); + uint16_t crystalId = _calorimeter->caloIDMapper().crystalIDFromSiPMID(roId); if( _diagLevel==1) printf( "...FromDigis: cryId %d roId %d \n",crystalId,roId); //========================================================================================= // Change # 2: get packetId from DMAP and roId to extract: Dirac#, Chan# and Dettype // For the moment (wait OTSDAQ) define BoardId as consecutive with Dirac# and 6 Diracs=1DTC //========================================================================================= - uint16_t packetId = calodaqconds.caloRoIdToPacketId(roId); + uint16_t packetId = calodaqconds.caloRoIdToPacketId(roId); uint16_t globalROCID = (packetId & (0x00FF)); uint16_t DiracChannel = (packetId & (0x1F00)) >> 8; uint16_t DetType = (packetId & (0xE000)) >> 13; @@ -826,26 +818,24 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterDataPacket(CaloDAQMap const& calo if( _diagLevel==1) printf( "..FromDigis: DTYPE %d ROCID %d CHAN %d \n",DetType,globalROCID,DiracChannel); if( _diagLevel==1 && DetType==1) printf("Caphri \n"); - ccBoardID.BoardID = globalROCID % number_of_calo_rocs_per_dtc; + ccBoardID.BoardID = globalROCID % number_of_calo_rocs_per_dtc; ccBoardID.ChannelStatusFlagsA = 0; ccBoardID.ChannelStatusFlagsB = 0; - ccBoardID.unused = 0; + ccBoardID.unused = 0; CaloData.boardID = ccBoardID; CalorimeterHitReadoutPacket hitPacket; - // hitPacket.ChannelNumber = CD.SiPMID(); // previous version .... hitPacket.ChannelNumber = DiracChannel; // modified as it should be in the packet - hitPacket.DIRACA = packetId; //Change-5 - hitPacket.DIRACB = (((CD.SiPMID() % 2) << 12) | (crystalId)); // this is useless for the moment .. can be a test - - hitPacket.ErrorFlags = 0; - hitPacket.Time = CD.t0(); + hitPacket.DIRACA = packetId; //Change-5 + hitPacket.DIRACB = (((CD.SiPMID() % 2) << 12) | (crystalId)); // this is useless for the moment .. can be a test + hitPacket.ErrorFlags = 0; + hitPacket.Time = CD.t0(); std::vector theWaveform; for (size_t i = 0; i < CD.waveform().size(); ++i) { theWaveform.push_back((adc_t)CD.waveform().at(i)); } - hitPacket.NumberOfSamples = theWaveform.size(); + hitPacket.NumberOfSamples = theWaveform.size(); hitPacket.IndexOfMaxDigitizerSample = waveformMaximumIndex(theWaveform); CaloData.hitPacketVec.push_back(hitPacket); @@ -980,11 +970,6 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterDataStream(DTCLib::DTC_Event& cur //-------------------------------------------------------------------------------- // create the header for the caloPacket //-------------------------------------------------------------------------------- -//void ArtBinaryPacketsFromDigis::fillCalorimeterHeaderDataPacket(mu2e::CaloDAQMap const& calodaqconds, -// const CaloDigi& CD, -// DataBlockHeader& HeaderData, -// uint64_t& EventNum) { - void ArtBinaryPacketsFromDigis::fillCalorimeterHeaderDataPacket(CaloDAQMap const& calodaqconds, const CaloDigi& CD, DataBlockHeader& HeaderData, @@ -1008,7 +993,7 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterHeaderDataPacket(CaloDAQMap const // ---------------------------------------------------------------- if( _diagLevel==1 && DetType == 1) printf(" CAPHRI !!! \n"); - HeaderData.s.LinkID = globalROCID % number_of_rocs_per_dtc;// from ROCID call it now LinkID + HeaderData.s.LinkID = globalROCID % number_of_calo_rocs_per_dtc;// from ROCID call it now LinkID HeaderData.s.SubsystemID = DTCLib::DTC_Subsystem_Calorimeter; HeaderData.s.Valid = 1; @@ -1025,7 +1010,7 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterHeaderDataPacket(CaloDAQMap const HeaderData.s.Status = 0; // 0 corresponds to "TimeStamp had valid data" HeaderData.s.Version = format_version; // Word 7 - HeaderData.s.DTCID = static_cast(globalROCID / number_of_rocs_per_dtc); + HeaderData.s.DTCID = static_cast(globalROCID / number_of_calo_rocs_per_dtc); uint8_t evbMode = 0; // ask Eric HeaderData.s.EventWindowMode = evbMode; if( _diagLevel==1) printf(" >>FromDigi-Header: Dtyp Dirac# Link-DTC DTC %d %d %d %d \n", @@ -1044,7 +1029,7 @@ void ArtBinaryPacketsFromDigis::processTrackerData(art::Event& evt, uint64_t& ev tracker_data_block_list_t tmpTrackerData; - uint8_t max_dtc_id = number_of_rocs / number_of_rocs_per_dtc - 1; + uint8_t max_dtc_id = number_of_rocs / number_of_rocs_per_dtc; if (number_of_rocs % number_of_rocs_per_dtc > 0) { max_dtc_id += 1; } @@ -1069,7 +1054,7 @@ void ArtBinaryPacketsFromDigis::processTrackerData(art::Event& evt, uint64_t& ev // ROC ID, counting from 0 across all DTCs (for the tracker) // uint8_t localROCID = panel; - uint8_t globalROCID = (plane * 6) + panel; + uint8_t globalROCID = (plane * 6) + panel;// strawId().uniquePanel() would provide the ROCID uint8_t thisDTCID = static_cast(globalROCID / number_of_rocs_per_dtc); if (panel == rocID && thisDTCID == dtcID) { trackerData.back().second.emplace_back(); From d49398f445d6f53b9be58ed5ec3a463cafc61d6f Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 16:35:23 -0500 Subject: [PATCH 33/54] new module to fetch the data --- DAQ/src/PrefetchDAQData_module.cc | 169 ++++++++++++++++++++++++++++++ 1 file changed, 169 insertions(+) create mode 100644 DAQ/src/PrefetchDAQData_module.cc diff --git a/DAQ/src/PrefetchDAQData_module.cc b/DAQ/src/PrefetchDAQData_module.cc new file mode 100644 index 0000000000..18243c2e82 --- /dev/null +++ b/DAQ/src/PrefetchDAQData_module.cc @@ -0,0 +1,169 @@ +// framework +#include "art/Framework/Principal/Event.h" +#include "fhiclcpp/ParameterSet.h" +#include "art/Framework/Principal/Handle.h" +#include "art/Framework/Core/EDProducer.h" +#include "art/Framework/Core/ModuleMacros.h" +#include "art_root_io/TFileService.h" + +// data +#include "RecoDataProducts/inc/CaloDigi.hh" +#include "RecoDataProducts/inc/StrawDigi.hh" + +// DAQ data +//#include "mu2e-artdaq-core/Overlays/FragmentType.hh" +//#include "mu2e-artdaq-core/Overlays/TrackerFragment.hh" +#include + + +namespace mu2e { + + class PrefetchDAQData : public art::EDProducer { + + protected: + + public: + explicit PrefetchDAQData(fhicl::ParameterSet const&); + virtual ~PrefetchDAQData(); + virtual void beginJob(); + virtual void produce( art::Event& e); + + void fake_access(const CaloDigi& Digi); + void fake_access(const StrawDigi& Digi); + void fake_access(const artdaq::Fragment& Frag); + + private: + + bool findData(const art::Event& e); + // control flags + int _debugLevel; + int _fetchCaloDigis; + int _fetchStrawDigis; + int _fetchCaloFragments; + int _fetchTrkFragments; + + art::InputTag _cdTag; + art::InputTag _sdTag; + art::InputTag _cfTag; + art::InputTag _tfTag; + // cache of event objects + const CaloDigiCollection* _cdcol; + const StrawDigiCollection* _sdcol; + const artdaq::Fragments* _cfcol; + const artdaq::Fragments* _tfcol; + int _eventNum; + }; + + //----------------------------------------------------------------------------- + PrefetchDAQData::PrefetchDAQData(fhicl::ParameterSet const& pset): + art::EDProducer(pset), + _debugLevel (pset.get ("debugLevel")), + _fetchCaloDigis (pset.get ("fetchCaloDigis" )), + _fetchStrawDigis (pset.get ("fetchStrawDigis")), + _fetchCaloFragments(pset.get ("fetchCaloFragments")), + _fetchTrkFragments (pset.get ("fetchTrkFragments")), + _cdTag (pset.get("caloDigiCollectionTag")), + _sdTag (pset.get("strawDigiCollectionTag")), + _cfTag (pset.get("caloFragmentTag")), + _tfTag (pset.get("trkFragmentTag")) + {} + + PrefetchDAQData::~PrefetchDAQData() { + } + +//----------------------------------------------------------------------------- + void PrefetchDAQData::beginJob() { + } + +//----------------------------------------------------------------------------- + void PrefetchDAQData::fake_access(const CaloDigi& Hit) { + } + +//----------------------------------------------------------------------------- + void PrefetchDAQData::fake_access(const StrawDigi& X) { + } +//----------------------------------------------------------------------------- + void PrefetchDAQData::fake_access(const artdaq::Fragment& Frag) { + } + +//----------------------------------------------------------------------------- + bool PrefetchDAQData::findData(const art::Event& evt){ + _cdcol = 0; + _sdcol = 0; + _cfcol = 0; + _tfcol = 0; + + if (_fetchCaloDigis) { + auto cdH = evt.getValidHandle(_cdTag); + _cdcol = cdH.product(); + } + + if (_fetchTrkFragments) { + auto tfH = evt.getValidHandle(_tfTag); + _tfcol = tfH.product(); + } + + if (_fetchCaloFragments) { + auto cfH = evt.getValidHandle(_cfTag); + _cfcol = cfH.product(); + } + + if (_fetchStrawDigis) { + auto sdH = evt.getValidHandle(_sdTag); + _sdcol = sdH.product(); + } +//----------------------------------------------------------------------------- +// prefetch data +//----------------------------------------------------------------------------- + if (_cdcol) { + int ncd = _cdcol->size(); + for(int i=0;iat(i); + fake_access(cd); + } + } + + if (_sdcol) { + int nsd = _sdcol->size(); + for(int i=0;iat(i); + fake_access(sdigi); + } + } + + if (_cfcol) { + int ncf = _cfcol->size(); + for(int i=0;iat(i); + fake_access(frag); + } + } + if (_tfcol) { + int ntf = _tfcol->size(); + for(int i=0;iat(i); + fake_access(frag); + } + } + + return true; + } + +//----------------------------------------------------------------------------- + void PrefetchDAQData::produce(art::Event& Event) { + + _eventNum = Event.event(); + + if (_debugLevel > 0) printf("[PrefetchDAQData::produce] event number: %10i\n",_eventNum); + + findData(Event); + } + +//------------------------------------------------------------------------------ +// Part of the magic that makes this class a module. +DEFINE_ART_MODULE(PrefetchDAQData) + +} + + + From 3b63f5f40493f6eecdcfd9745fe8c6cfd2ffec8d Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 16:35:48 -0500 Subject: [PATCH 34/54] fixed a few bugs --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 7150ce47f1..a75e0d62bb 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -184,9 +184,8 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { //-------------------------------------------------------------------------------- // CALORIEMTER ROC/DTC INFO //-------------------------------------------------------------------------------- - // 6 rocs per DTC => 27 DTCs - // 172 rocs * 8 crystals per roc => 1376 - // Note: the highest crystal ID in the old simulation was 1355 + // 6 rocs per DTC => 23 DTCs + // 136 rocs * 10 crystals per roc => 1348 const size_t number_of_calo_rocs = 136; const size_t number_of_crystals_per_roc = 10; const size_t number_of_calo_rocs_per_dtc = 6; @@ -737,7 +736,8 @@ void ArtBinaryPacketsFromDigis::processCalorimeterData(art::Event& evt, uint64_t if (_diagLevel > 1) { std::cout << "[ArtBinaryPacketsFromDigis::processCalorimeterData ] filling Hit from DTCID = "<< (int)dtcID - << " ROCID = " << (int)rocID << std::endl; + << " ROCID = " << (int)rocID + << std::endl; } if (is_first) { is_first = false; From e93004d0198dd5963d16bb0c7df6664807e69c9f Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 16:37:09 -0500 Subject: [PATCH 35/54] changed location --- DAQ/src/FragmentAna_module.cc | 345 ++++++++++++++++++++++++++++++++++ 1 file changed, 345 insertions(+) create mode 100644 DAQ/src/FragmentAna_module.cc diff --git a/DAQ/src/FragmentAna_module.cc b/DAQ/src/FragmentAna_module.cc new file mode 100644 index 0000000000..225e54f79d --- /dev/null +++ b/DAQ/src/FragmentAna_module.cc @@ -0,0 +1,345 @@ +// ====================================================================== +// +// StrawAndCaloDigisFromFragments_plugin: Add tracker/cal data products to the event +// +// ====================================================================== + +// ROOT includes +#include "TH1F.h" +//#include "TFolder.h" + +#include "art/Framework/Core/EDAnalyzer.h" +#include "art/Framework/Core/ModuleMacros.h" +#include "art/Framework/Principal/Event.h" +#include "art/Framework/Principal/Handle.h" +#include "art/Framework/Services/Registry/ServiceHandle.h" +#include "art_root_io/TFileDirectory.h" +#include "art_root_io/TFileService.h" +#include "fhiclcpp/ParameterSet.h" +#include "mu2e-artdaq-core/Overlays/CalorimeterFragment.hh" +#include "mu2e-artdaq-core/Overlays/FragmentType.hh" +#include "mu2e-artdaq-core/Overlays/TrackerFragment.hh" + +#include + +// Mu2e includes +#include "DataProducts/inc/StrawId.hh" +#include "DataProducts/inc/TrkTypes.hh" + +#include +#include +#include + +// ====================================================================== +namespace mu2e { + +class FragmentAna : public art::EDAnalyzer { + +public: + struct Config { + fhicl::Atom diagLevel{fhicl::Name("diagLevel"), fhicl::Comment("diagnostic level")}; + fhicl::Atom parseCAL{fhicl::Name("parseCAL"), fhicl::Comment("parseCAL")}; + fhicl::Atom parseTRK{fhicl::Name("parseTRK"), fhicl::Comment("parseTRK")}; + fhicl::Atom caloTag{fhicl::Name("caloTag"), fhicl::Comment("caloTag")}; + fhicl::Atom trkTag{fhicl::Name("trkTag"), fhicl::Comment("trkTag")}; + }; + + explicit FragmentAna(const art::EDAnalyzer::Table& config); + virtual ~FragmentAna() {} + + virtual void beginJob() override; + virtual void endJob() override; + + virtual void analyze(const art::Event& e) override; + +private: + void analyze_tracker_(const artdaq::Fragment& f); + void analyze_calorimeter_(const artdaq::Fragment& f); + + int diagLevel_; + + int parseCAL_; + int parseTRK_; + + art::InputTag trkFragmentsTag_; + art::InputTag caloFragmentsTag_; + + TH1F* _hTrkNFragment; + TH1F* _hTrkStrawId; + TH1F* _hTrkTDC[4]; + TH1F* _hTrkTOT; + TH1F* _hTrkPMP; + TH1F* _hTrkMeanADC; + TH1F* _hTrkMaxADC; + TH1F* _hTrkWfSize; + + TH1F* _hCalNFragment; + TH1F* _hCalROId; + TH1F* _hCalT0; + TH1F* _hCalPeakPos; + TH1F* _hCalWfSize; +}; + +// ====================================================================== + +FragmentAna::FragmentAna(const art::EDAnalyzer::Table& config) : + art::EDAnalyzer{config}, diagLevel_(config().diagLevel()), parseCAL_(config().parseCAL()), + parseTRK_(config().parseTRK()), trkFragmentsTag_(config().trkTag()), + caloFragmentsTag_(config().caloTag()) {} + +//-------------------------------------------------------------------------------- +// create the histograms +//-------------------------------------------------------------------------------- +void FragmentAna::beginJob() { + art::ServiceHandle tfs; + + art::TFileDirectory calDir = tfs->mkdir("calorimeter"); + art::TFileDirectory trkDir = tfs->mkdir("tracker"); + + _hTrkNFragment = trkDir.make("hTrkNFragment", "n fragments from the tracker; nTrkFragments", + 1000, 0., 10000.); + _hTrkStrawId = + trkDir.make("hTrkStrawId", "trk fragment strawId; strawId", 20000, 0., 20000.); + _hTrkTDC[0] = trkDir.make("hTrkTDC0", "trk fragment TDC0; TDC[0]", 264, 0., 264000); + _hTrkTDC[1] = trkDir.make("hTrkTDC1", "trk fragment TDC1; TDC[1]", 264, 0., 264000); + _hTrkTDC[2] = trkDir.make("hTrkTDCMean", "trk fragment average TDC; (TDC[0]+TDC[1])/2", + 2000, 0., 20000.); + _hTrkTDC[3] = trkDir.make("hTrkTDCDelta", "trk fragment delta TDC; TDC[1]-TDC[0]", 220, + -100., 10000.); + _hTrkTOT = + trkDir.make("hTrkTOT", "trk fragment average TOT; (TOT[0]+TOT[1])/2", 100, 0., 200.); + _hTrkPMP = trkDir.make("hTrkPOP", "trk fragment average PMP; PMP", 100, 0., 200.); + _hTrkMeanADC = trkDir.make("hTrkMeanADC", "trk fragment Mean ADC; ", 250, 0., 2500.); + _hTrkMaxADC = trkDir.make("hTrkMaxADC", "trk fragment Max ADC; Max_ADC", 250, 0., 2500.); + _hTrkWfSize = trkDir.make("hTrkWfSize", "trk fragment waveform size; trkFragment_wf_size", + 20, 0., 20.); + + _hCalNFragment = calDir.make( + "hCalNFragment", "n fragments from the calorimeter; nCalFragments", 400, 0., 400.); + _hCalROId = + calDir.make("hCalROId", "calo fragment roId; calFragment_roId", 4000, 0., 4000.); + _hCalT0 = calDir.make("hCalT0", "calo fragment t0; calFragment_t0 [ns]", 200, 0., 2000.); + _hCalPeakPos = + calDir.make("hCalPeakPos", "calo fragment peakPos; calFragment_peakPos", 100, 0., 100.); + _hCalWfSize = calDir.make("hCalWfSize", "calo fragment waveform size; calFragment_wf_size", + 100, 0., 100.); +} + +void FragmentAna::endJob() {} + +//-------------------------------------------------------------------------------- +void FragmentAna::analyze(const art::Event& event) { + art::EventNumber_t eventNumber = event.event(); + + art::Handle trkFragments, calFragments; + size_t numTrkFrags(0), numCalFrags(0); + if (parseTRK_) { + event.getByLabel(trkFragmentsTag_, trkFragments); + if (!trkFragments.isValid()) { + return; + } + numTrkFrags = trkFragments->size(); + _hTrkNFragment->Fill(numTrkFrags); + } + if (parseCAL_) { + event.getByLabel(caloFragmentsTag_, calFragments); + if (!calFragments.isValid()) { + return; + } + numCalFrags = calFragments->size(); + _hCalNFragment->Fill(numCalFrags); + } + + if (diagLevel_ > 1) { + std::cout << std::dec << "Producer: Run " << event.run() << ", subrun " << event.subRun() + << ", event " << eventNumber << " has " << std::endl; + std::cout << numTrkFrags << " TRK fragments, and "; + std::cout << numCalFrags << " CAL fragments." << std::endl; + + size_t totalSize = 0; + for (size_t idx = 0; idx < numTrkFrags; ++idx) { + auto size = ((*trkFragments)[idx]).size(); // * sizeof(artdaq::RawDataType); + totalSize += size; + // std::cout << "\tTRK Fragment " << idx << " has size " << size << std::endl; + } + for (size_t idx = 0; idx < numCalFrags; ++idx) { + auto size = ((*calFragments)[idx]).size(); // * sizeof(artdaq::RawDataType); + totalSize += size; + // std::cout << "\tCAL Fragment " << idx << " has size " << size << std::endl; + } + totalSize *= sizeof(artdaq::RawDataType); + + std::cout << "\tTotal Size: " << (int)totalSize << " bytes." << std::endl; + } + std::string curMode = "TRK"; + + // Loop over the TRK and CAL fragments + for (size_t idx = 0; idx < numTrkFrags + numCalFrags; ++idx) { + + auto curHandle = trkFragments; + size_t curIdx = idx; + if (idx >= numTrkFrags) { + curIdx = idx - numTrkFrags; + curHandle = calFragments; + } + const auto& fragment((*curHandle)[curIdx]); + + if (idx < numTrkFrags) { + analyze_tracker_(fragment); + } else { + analyze_calorimeter_(fragment); + } + } + if (diagLevel_ > 0) { + std::cout << "mu2e::FragmentAna::produce exiting eventNumber=" << (int)(event.event()) + << " / timestamp=" << (int)eventNumber << std::endl; + } +} + +void FragmentAna::analyze_tracker_(const artdaq::Fragment& f) { + mu2e::TrackerFragment cc(f); + + if (diagLevel_ > 1) { + std::cout << std::endl; + std::cout << "ArtFragment: "; + std::cout << "\tBlock Count: " << std::dec << cc.block_count() << std::endl; + std::cout << "\tByte Count: " << f.dataSizeBytes() << std::endl; + std::cout << std::endl; + std::cout << "\t" + << "====== Example Block Sizes ======" << std::endl; + for (size_t i = 0; i < 10; i++) { + if (i < cc.block_count()) { + std::cout << "\t" << i << "\t" << cc.blockSizeBytes(i) << std::endl; + } + } + std::cout << "\t" + << "=========================" << std::endl; + } + + for (size_t curBlockIdx = 0; curBlockIdx < cc.block_count(); curBlockIdx++) { + + auto block = cc.dataAtBlockIndex(curBlockIdx); + if (block == nullptr) { + mf::LogError("FragmentAna") << "Unable to retrieve header from block " << curBlockIdx << "!" + << std::endl; + continue; + } + auto hdr = block->GetHeader(); + + // Parse phyiscs information from TRK packets + if (hdr.GetPacketCount() > 0 && parseTRK_ > 0) { + + // Create the StrawDigi data products + auto trkDataVec = cc.GetTrackerData(curBlockIdx); + if (trkDataVec.empty()) { + mf::LogError("FragmentAna") << "Error retrieving Tracker data from DataBlock " + << curBlockIdx << "! Aborting processing of this block!"; + continue; + } + + for (auto& trkDataPair : trkDataVec) { + mu2e::StrawId sid(trkDataPair.first->StrawIndex); + mu2e::TrkTypes::TDCValues tdc = {trkDataPair.first->TDC0(), trkDataPair.first->TDC1()}; + mu2e::TrkTypes::TOTValues tot = {trkDataPair.first->TOT0, trkDataPair.first->TOT1}; + mu2e::TrkTypes::ADCValue pmp = trkDataPair.first->PMP; + int sum{0}; + unsigned short maxadc{0}; + for (auto adc : trkDataPair.second) { + sum += adc; + maxadc = std::max(maxadc, adc); + } + // Fill the StrawDigiCollection + _hTrkStrawId->Fill(sid.asUint16()); + _hTrkTDC[0]->Fill(tdc[0]); + _hTrkTDC[1]->Fill(tdc[1]); + _hTrkTDC[2]->Fill((tdc[0] + tdc[1]) / 2.); + _hTrkTDC[3]->Fill(tdc[1] - tdc[0]); + _hTrkTOT->Fill((tot[0] + tot[1]) / 2.); + _hTrkPMP->Fill(pmp); + int mean = (trkDataPair.second.size() != 0) ? sum / trkDataPair.second.size() : -1.; + _hTrkMeanADC->Fill(mean); + _hTrkMaxADC->Fill(maxadc); + _hTrkWfSize->Fill(trkDataPair.second.size()); + } + } + } + + cc.ClearUpgradedPackets(); +} + +void FragmentAna::analyze_calorimeter_(const artdaq::Fragment& f) { + mu2e::CalorimeterFragment cc(f); + + if (diagLevel_ > 1) { + std::cout << std::endl; + std::cout << "ArtFragment: "; + std::cout << "\tBlock Count: " << std::dec << cc.block_count() << std::endl; + std::cout << "\tByte Count: " << f.dataSizeBytes() << std::endl; + std::cout << std::endl; + std::cout << "\t" + << "====== Example Block Sizes ======" << std::endl; + for (size_t i = 0; i < 10; i++) { + if (i < cc.block_count()) { + std::cout << "\t" << i << "\t" << cc.blockSizeBytes(i) << std::endl; + } + } + std::cout << "\t" + << "=========================" << std::endl; + } + + for (size_t curBlockIdx = 0; curBlockIdx < cc.block_count(); curBlockIdx++) { + + auto block = cc.dataAtBlockIndex(curBlockIdx); + if (block == nullptr) { + mf::LogError("FragmentAna") << "Unable to retrieve header from block " << curBlockIdx << "!" + << std::endl; + continue; + } + auto hdr = block->GetHeader(); + + if (hdr.GetPacketCount() > 0 && + parseCAL_ > 0) { // Parse phyiscs information from CAL packets + + auto calData = cc.GetCalorimeterData(curBlockIdx); + if (calData == nullptr) { + mf::LogError("FragmentAna") << "Error retrieving Calorimeter data from block " + << curBlockIdx << "! Aborting processing of this block!"; + continue; + } + + if (diagLevel_ > 0) { + std::cout << "[StrawAndCaloDigiFromFragments] NEW CALDATA: NumberOfHits " + << calData->NumberOfHits << std::endl; + } + + auto hits = cc.GetCalorimeterHits(curBlockIdx); + + bool err = false; + for (auto& hit : hits) { + + // Fill the CaloDigiCollection + + // IMPORTANT NOTE: we don't have a final + // mapping yet so for the moment, the BoardID field (described in docdb 4914) is just a + // placeholder. Because we still need to know which crystal a hit belongs to, we are + // temporarily storing the 4-bit apdID and 12-bit crystalID in the Reserved DIRAC A slot. + // Also, note that until we have an actual map, channel index does not actually correspond + // to the physical readout channel on a ROC. + + uint16_t crystalID = hit.first.DIRACB & 0x0FFF; + uint16_t roId = hit.first.DIRACB >> 12; + _hCalROId->Fill(crystalID * 2 + roId); + _hCalT0->Fill(hit.first.Time); + _hCalPeakPos->Fill(hit.first.IndexOfMaxDigitizerSample); + _hCalWfSize->Fill(hit.second.size()); + + } // End loop over readout channels in DataBlock + if (err) + continue; + } + } +} + +} // end namespace mu2e + +DEFINE_ART_MODULE(mu2e::FragmentAna); From 116ab9f51f389b2e0f86becc5fd1d5797f703bc1 Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 18:20:11 -0500 Subject: [PATCH 36/54] udpates --- ups_install/install.sh | 5 +++-- ups_install/installTableFile.sh | 6 ++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ups_install/install.sh b/ups_install/install.sh index 8171f32c17..862bc66f38 100644 --- a/ups_install/install.sh +++ b/ups_install/install.sh @@ -7,10 +7,11 @@ # export COMPILER_CODE=e20 -export DEBUG_LEVEL=prof +export ${MU2E_SETUP_BUILDOPTS} +export DEBUG_LEVEL=${build} export PACKAGE_NAME=offline export PACKAGE_SOURCE=${MU2E_BASE_RELEASE} -export PACKAGE_VERSION=v09_11_02 +export PACKAGE_VERSION=v09_11_03 # Check that the installation directoy has been defined. if [ "${PRODUCTS_INSTALL}" = '' ];then diff --git a/ups_install/installTableFile.sh b/ups_install/installTableFile.sh index 47ea0911b3..2032ed7c52 100755 --- a/ups_install/installTableFile.sh +++ b/ups_install/installTableFile.sh @@ -15,6 +15,7 @@ destination_file=$1 art_ver=`ups active | awk '$1 == "art" {print $2}'` heppdt_ver=`ups active | awk '$1 == "heppdt" {print $2}'` btrk_ver=`ups active | awk '$1 == "BTrk" {print $2}'` +kinkal_ver=`ups active | awk '$1 == "KinKal" {print $2}'` xerces_ver=`ups active | awk '$1 == "xerces_c" {print $2}'` mu2e_artdaq_core_ver=`ups active | awk '$1 == "mu2e_artdaq_core" {print $2}'` @@ -57,6 +58,7 @@ Qualifiers = "${qualifiers_value}:debug" envSet (MU2E_UPS_QUALIFIERS, +${mu2e_ups_qualifiers}:+debug ) setupRequired( art ${art_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( BTrk ${btrk_ver} -q +${mu2e_ups_qualifiers}:+debug:+p383b ) + setupRequired( KinKal ${kinkal_ver} -q +${mu2e_ups_qualifiers}:+debug:+p383b ) setupRequired( heppdt ${heppdt_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( xerces_c ${xerces_ver} -q +${mu2e_ups_qualifiers}:+debug ) @@ -71,6 +73,7 @@ Qualifiers = "${qualifiers_value}:prof" envSet (MU2E_UPS_QUALIFIERS, +\${mu2e_ups_qualifiers}:+prof ) setupRequired( art ${art_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( BTrk ${btrk_ver} -q +${mu2e_ups_qualifiers}:+prof:+p383b ) + setupRequired( KinKal ${kinkal_ver} -q +${mu2e_ups_qualifiers}:+prof:+p383b ) setupRequired( heppdt ${heppdt_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( xerces_c ${xerces_ver} -q +${mu2e_ups_qualifiers}:+prof ) @@ -85,6 +88,7 @@ Qualifiers = "${qualifiers_value}:trig:debug" envSet (MU2E_UPS_QUALIFIERS, +${mu2e_ups_qualifiers}:+debug ) setupRequired( art ${art_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( BTrk ${btrk_ver} -q +${mu2e_ups_qualifiers}:+debug:+p383b ) + setupRequired( KinKal ${kinkal_ver} -q +${mu2e_ups_qualifiers}:+debug:+p383b ) setupRequired( heppdt ${heppdt_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( xerces_c ${xerces_ver} -q +${mu2e_ups_qualifiers}:+debug ) setupRequired( mu2e_artdaq_core ${mu2e_artdaq_core_ver} -q ${mu2e_ups_qualifiers}:+${MU2E_ART_SQUALIFIER}:+debug ) @@ -100,6 +104,7 @@ Qualifiers = "${qualifiers_value}:trig:prof" envSet (MU2E_UPS_QUALIFIERS, +\${mu2e_ups_qualifiers}:+prof ) setupRequired( art ${art_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( BTrk ${btrk_ver} -q +${mu2e_ups_qualifiers}:+prof:+p383b ) + setupRequired( KinKal ${kinkal_ver} -q +${mu2e_ups_qualifiers}:+prof:+p383b ) setupRequired( heppdt ${heppdt_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( xerces_c ${xerces_ver} -q +${mu2e_ups_qualifiers}:+prof ) setupRequired( mu2e_artdaq_core ${mu2e_artdaq_core_ver} -q ${mu2e_ups_qualifiers}:+${MU2E_ART_SQUALIFIER}:+prof ) @@ -133,6 +138,7 @@ EOF unset art_ver unset heppdt_ver unset btrk_ver +unset kinkal_ver unset xerces_ver unset mu2e_artdaq_core_ver unset qualifiers_value From 6a40d580f31e9c7c571e969824563ac6abf353b2 Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 18:21:02 -0500 Subject: [PATCH 37/54] renamed --- Analyses/src/FragmentAna_module.cc | 344 ----------------------------- 1 file changed, 344 deletions(-) delete mode 100644 Analyses/src/FragmentAna_module.cc diff --git a/Analyses/src/FragmentAna_module.cc b/Analyses/src/FragmentAna_module.cc deleted file mode 100644 index 4c289d915f..0000000000 --- a/Analyses/src/FragmentAna_module.cc +++ /dev/null @@ -1,344 +0,0 @@ -// ====================================================================== -// -// StrawAndCaloDigisFromFragments_plugin: Add tracker/cal data products to the event -// -// ====================================================================== - -// ROOT includes -#include "TH1F.h" -//#include "TFolder.h" - -#include "art/Framework/Core/EDAnalyzer.h" -#include "art/Framework/Core/ModuleMacros.h" -#include "art/Framework/Principal/Event.h" -#include "art/Framework/Principal/Handle.h" -#include "art/Framework/Services/Registry/ServiceHandle.h" -#include "art_root_io/TFileDirectory.h" -#include "art_root_io/TFileService.h" -#include "fhiclcpp/ParameterSet.h" -#include "mu2e-artdaq-core/Overlays/CalorimeterFragment.hh" -#include "mu2e-artdaq-core/Overlays/FragmentType.hh" -#include "mu2e-artdaq-core/Overlays/TrackerFragment.hh" - -#include - -// Mu2e includes -#include "DataProducts/inc/StrawId.hh" -#include "DataProducts/inc/TrkTypes.hh" - -#include -#include -#include - -// ====================================================================== -namespace mu2e { - -class FragmentAna : public art::EDAnalyzer { - -public: - struct Config { - fhicl::Atom diagLevel{fhicl::Name("diagLevel"), fhicl::Comment("diagnostic level")}; - fhicl::Atom parseCAL{fhicl::Name("parseCAL"), fhicl::Comment("parseCAL")}; - fhicl::Atom parseTRK{fhicl::Name("parseTRK"), fhicl::Comment("parseTRK")}; - fhicl::Atom caloTag{fhicl::Name("caloTag"), fhicl::Comment("caloTag")}; - fhicl::Atom trkTag{fhicl::Name("trkTag"), fhicl::Comment("trkTag")}; - }; - - explicit FragmentAna(const art::EDAnalyzer::Table& config); - virtual ~FragmentAna() {} - - virtual void beginJob() override; - virtual void endJob() override; - - virtual void analyze(const art::Event& e) override; - -private: - void analyze_tracker_(const artdaq::Fragment& f); - void analyze_calorimeter_(const artdaq::Fragment& f); - - int diagLevel_; - - int parseCAL_; - int parseTRK_; - - art::InputTag trkFragmentsTag_; - art::InputTag caloFragmentsTag_; - - TH1F* _hTrkNFragment; - TH1F* _hTrkStrawId; - TH1F* _hTrkTDC[4]; - TH1F* _hTrkTOT; - TH1F* _hTrkPMP; - TH1F* _hTrkMeanADC; - TH1F* _hTrkMaxADC; - TH1F* _hTrkWfSize; - - TH1F* _hCalNFragment; - TH1F* _hCalROId; - TH1F* _hCalT0; - TH1F* _hCalPeakPos; - TH1F* _hCalWfSize; -}; - -// ====================================================================== - -FragmentAna::FragmentAna(const art::EDAnalyzer::Table& config) : - art::EDAnalyzer{config}, diagLevel_(config().diagLevel()), parseCAL_(config().parseCAL()), - parseTRK_(config().parseTRK()), trkFragmentsTag_(config().trkTag()), - caloFragmentsTag_(config().caloTag()) {} - -//-------------------------------------------------------------------------------- -// create the histograms -//-------------------------------------------------------------------------------- -void FragmentAna::beginJob() { - art::ServiceHandle tfs; - - art::TFileDirectory calDir = tfs->mkdir("calorimeter"); - art::TFileDirectory trkDir = tfs->mkdir("tracker"); - - _hTrkNFragment = trkDir.make("hTrkNFragment", "n fragments from the tracker; nTrkFragments", - 1000, 0., 10000.); - _hTrkStrawId = - trkDir.make("hTrkStrawId", "trk fragment strawId; strawId", 20000, 0., 20000.); - _hTrkTDC[0] = trkDir.make("hTrkTDC0", "trk fragment TDC0; TDC[0]", 264, 0., 264000); - _hTrkTDC[1] = trkDir.make("hTrkTDC1", "trk fragment TDC1; TDC[1]", 264, 0., 264000); - _hTrkTDC[2] = trkDir.make("hTrkTDCMean", "trk fragment average TDC; (TDC[0]+TDC[1])/2", - 2000, 0., 20000.); - _hTrkTDC[3] = trkDir.make("hTrkTDCDelta", "trk fragment delta TDC; TDC[1]-TDC[0]", 220, - -100., 10000.); - _hTrkTOT = - trkDir.make("hTrkTOT", "trk fragment average TOT; (TOT[0]+TOT[1])/2", 100, 0., 200.); - _hTrkPMP = trkDir.make("hTrkPOP", "trk fragment average PMP; PMP", 100, 0., 200.); - _hTrkMeanADC = trkDir.make("hTrkMeanADC", "trk fragment Mean ADC; ", 250, 0., 2500.); - _hTrkMaxADC = trkDir.make("hTrkMaxADC", "trk fragment Max ADC; Max_ADC", 250, 0., 2500.); - _hTrkWfSize = trkDir.make("hTrkWfSize", "trk fragment waveform size; trkFragment_wf_size", - 20, 0., 20.); - - _hCalNFragment = calDir.make( - "hCalNFragment", "n fragments from the calorimeter; nCalFragments", 400, 0., 400.); - _hCalROId = - calDir.make("hCalROId", "calo fragment roId; calFragment_roId", 4000, 0., 4000.); - _hCalT0 = calDir.make("hCalT0", "calo fragment t0; calFragment_t0 [ns]", 200, 0., 2000.); - _hCalPeakPos = - calDir.make("hCalPeakPos", "calo fragment peakPos; calFragment_peakPos", 100, 0., 100.); - _hCalWfSize = calDir.make("hCalWfSize", "calo fragment waveform size; calFragment_wf_size", - 100, 0., 100.); -} - -void FragmentAna::endJob() {} - -//-------------------------------------------------------------------------------- -void FragmentAna::analyze(const art::Event& event) { - art::EventNumber_t eventNumber = event.event(); - - art::Handle trkFragments, calFragments; - size_t numTrkFrags(0), numCalFrags(0); - if (parseTRK_) { - event.getByLabel(trkFragmentsTag_, trkFragments); - if (!trkFragments.isValid()) { - return; - } - numTrkFrags = trkFragments->size(); - _hTrkNFragment->Fill(numTrkFrags); - } - if (parseCAL_) { - event.getByLabel(caloFragmentsTag_, calFragments); - if (!calFragments.isValid()) { - return; - } - numCalFrags = calFragments->size(); - _hCalNFragment->Fill(numCalFrags); - } - - if (diagLevel_ > 1) { - std::cout << std::dec << "Producer: Run " << event.run() << ", subrun " << event.subRun() - << ", event " << eventNumber << " has " << std::endl; - std::cout << numTrkFrags << " TRK fragments, and "; - std::cout << numCalFrags << " CAL fragments." << std::endl; - - size_t totalSize = 0; - for (size_t idx = 0; idx < numTrkFrags; ++idx) { - auto size = ((*trkFragments)[idx]).size(); // * sizeof(artdaq::RawDataType); - totalSize += size; - // std::cout << "\tTRK Fragment " << idx << " has size " << size << std::endl; - } - for (size_t idx = 0; idx < numCalFrags; ++idx) { - auto size = ((*calFragments)[idx]).size(); // * sizeof(artdaq::RawDataType); - totalSize += size; - // std::cout << "\tCAL Fragment " << idx << " has size " << size << std::endl; - } - totalSize *= sizeof(artdaq::RawDataType); - - std::cout << "\tTotal Size: " << (int)totalSize << " bytes." << std::endl; - } - std::string curMode = "TRK"; - - // Loop over the TRK and CAL fragments - for (size_t idx = 0; idx < numTrkFrags + numCalFrags; ++idx) { - - auto curHandle = trkFragments; - size_t curIdx = idx; - if (idx >= numTrkFrags) { - curIdx = idx - numTrkFrags; - curHandle = calFragments; - } - const auto& fragment((*curHandle)[curIdx]); - - if (idx < numTrkFrags) { - analyze_tracker_(fragment); - } else { - analyze_calorimeter_(fragment); - } - } - if (diagLevel_ > 0) { - std::cout << "mu2e::FragmentAna::produce exiting eventNumber=" << (int)(event.event()) - << " / timestamp=" << (int)eventNumber << std::endl; - } -} - -void FragmentAna::analyze_tracker_(const artdaq::Fragment& f) { - mu2e::TrackerFragment cc(f); - - if (diagLevel_ > 1) { - std::cout << std::endl; - std::cout << "ArtFragment: "; - std::cout << "\tBlock Count: " << std::dec << cc.block_count() << std::endl; - std::cout << "\tByte Count: " << f.dataSizeBytes() << std::endl; - std::cout << std::endl; - std::cout << "\t" - << "====== Example Block Sizes ======" << std::endl; - for (size_t i = 0; i < 10; i++) { - if (i < cc.block_count()) { - std::cout << "\t" << i << "\t" << cc.blockSizeBytes(i) << std::endl; - } - } - std::cout << "\t" - << "=========================" << std::endl; - } - - for (size_t curBlockIdx = 0; curBlockIdx < cc.block_count(); curBlockIdx++) { - - auto block = cc.dataAtBlockIndex(curBlockIdx); - if (block == nullptr) { - mf::LogError("FragmentAna") << "Unable to retrieve header from block " << curBlockIdx << "!" - << std::endl; - continue; - } - auto hdr = block->GetHeader(); - - // Parse phyiscs information from TRK packets - if (hdr.GetPacketCount() > 0 && parseTRK_ > 0) { - - // Create the StrawDigi data products - auto trkDataVec = cc.GetTrackerData(curBlockIdx); - if (trkDataVec.empty()) { - mf::LogError("FragmentAna") << "Error retrieving Tracker data from DataBlock " - << curBlockIdx << "! Aborting processing of this block!"; - continue; - } - - for (auto& trkDataPair : trkDataVec) { - mu2e::StrawId sid(trkDataPair.first->StrawIndex); - mu2e::TrkTypes::TDCValues tdc = {trkDataPair.first->TDC0(), trkDataPair.first->TDC1()}; - mu2e::TrkTypes::TOTValues tot = {trkDataPair.first->TOT0, trkDataPair.first->TOT1}; - mu2e::TrkTypes::ADCValue pmp = trkDataPair.first->PMP; - int sum{0}; - unsigned short maxadc{0}; - for (auto adc : trkDataPair.second) { - sum += adc; - maxadc = std::max(maxadc, adc); - } - // Fill the StrawDigiCollection - _hTrkStrawId->Fill(sid.asUint16()); - _hTrkTDC[0]->Fill(tdc[0]); - _hTrkTDC[1]->Fill(tdc[1]); - _hTrkTDC[2]->Fill((tdc[0] + tdc[1]) / 2.); - _hTrkTDC[3]->Fill(tdc[1] - tdc[0]); - _hTrkTOT->Fill((tot[0] + tot[1]) / 2.); - _hTrkPMP->Fill(pmp); - int mean = (trkDataPair.second.size() != 0) ? sum / trkDataPair.second.size() : -1.; - _hTrkMeanADC->Fill(mean); - _hTrkMaxADC->Fill(maxadc); - _hTrkWfSize->Fill(trkDataPair.second.size()); - } - } - } - - cc.ClearUpgradedPackets(); -} - -void FragmentAna::analyze_calorimeter_(const artdaq::Fragment& f) { - mu2e::CalorimeterFragment cc(f); - - if (diagLevel_ > 1) { - std::cout << std::endl; - std::cout << "ArtFragment: "; - std::cout << "\tBlock Count: " << std::dec << cc.block_count() << std::endl; - std::cout << "\tByte Count: " << f.dataSizeBytes() << std::endl; - std::cout << std::endl; - std::cout << "\t" - << "====== Example Block Sizes ======" << std::endl; - for (size_t i = 0; i < 10; i++) { - if (i < cc.block_count()) { - std::cout << "\t" << i << "\t" << cc.blockSizeBytes(i) << std::endl; - } - } - std::cout << "\t" - << "=========================" << std::endl; - } - - for (size_t curBlockIdx = 0; curBlockIdx < cc.block_count(); curBlockIdx++) { - - auto block = cc.dataAtBlockIndex(curBlockIdx); - if (block == nullptr) { - mf::LogError("FragmentAna") << "Unable to retrieve header from block " << curBlockIdx << "!" - << std::endl; - continue; - } - auto hdr = block->GetHeader(); - - if (hdr.GetPacketCount() > 0 && - parseCAL_ > 0) { // Parse phyiscs information from CAL packets - - auto calData = cc.GetCalorimeterData(curBlockIdx); - if (calData == nullptr) { - mf::LogError("FragmentAna") << "Error retrieving Calorimeter data from block " - << curBlockIdx << "! Aborting processing of this block!"; - continue; - } - - if (diagLevel_ > 0) { - std::cout << "[StrawAndCaloDigiFromFragments] NEW CALDATA: NumberOfHits " - << calData->NumberOfHits << std::endl; - } - - auto hits = cc.GetCalorimeterHits(curBlockIdx); - - bool err = false; - for (auto& hit : hits) { - - // Fill the CaloDigiCollection - - // IMPORTANT NOTE: we don't have a final - // mapping yet so for the moment, the BoardID field (described in docdb 4914) is just a - // placeholder. Because we still need to know which crystal a hit belongs to, we are - // temporarily storing the 4-bit apdID and 12-bit crystalID in the Reserved DIRAC A slot. - // Also, note that until we have an actual map, channel index does not actually correspond - // to the physical readout channel on a ROC. - uint16_t crystalID = hit.first.DIRACB & 0x0FFF; - uint16_t roId = hit.first.DIRACB >> 12; - _hCalROId->Fill(crystalID * 2 + roId); - _hCalT0->Fill(hit.first.Time); - _hCalPeakPos->Fill(hit.first.IndexOfMaxDigitizerSample); - _hCalWfSize->Fill(hit.second.size()); - - } // End loop over readout channels in DataBlock - if (err) - continue; - } - } -} - -} // end namespace mu2e - -DEFINE_ART_MODULE(mu2e::FragmentAna); From 0ac07232ce59c97aa28c1d2c4f07c48e8168bf22 Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 7 May 2021 11:03:56 -0500 Subject: [PATCH 38/54] cleanup --- DAQ/src/CaloHitsFromFragments_module.cc | 9 ++++----- DAQ/src/CaloRecoFromFragments_module.cc | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/DAQ/src/CaloHitsFromFragments_module.cc b/DAQ/src/CaloHitsFromFragments_module.cc index dcffac5948..c497fc8816 100644 --- a/DAQ/src/CaloHitsFromFragments_module.cc +++ b/DAQ/src/CaloHitsFromFragments_module.cc @@ -27,6 +27,8 @@ #include #include #include +#include +#include namespace art { class CaloHitsFromFragments; @@ -157,11 +159,7 @@ void art::CaloHitsFromFragments::addPulse(uint16_t& crystalID, float& time, floa } if (addNewHit) { pulseMap_[crystalID].emplace_back(mu2e::CaloHit(crystalID, 1, time, eDep)); - }// else if (counter>0){ - // std::list::const_iterator it=pulseMap_[crystalID].begin(); - // std::advance(it, counter); - // pulseMap_[crystalID].erase(it); - // } + } } art::CaloHitsFromFragments::CaloHitsFromFragments(const art::EDProducer::Table& config) : @@ -183,6 +181,7 @@ art::CaloHitsFromFragments::CaloHitsFromFragments(const art::EDProducer::Table 0) { - std::cout << "[StrawAndCaloDigiFromFragments] NEW CALDATA: NumberOfHits " + std::cout << "[CaloRecoFromFragments] NEW CALDATA: NumberOfHits " << calData->NumberOfHits << std::endl; } From 4348e9fb12b9fdefd69471a2c1c0a28732a90def Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 7 May 2021 11:04:22 -0500 Subject: [PATCH 39/54] added condition for reading or not the waveform from the fragment --- DAQ/src/StrawRecoFromFragments_module.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DAQ/src/StrawRecoFromFragments_module.cc b/DAQ/src/StrawRecoFromFragments_module.cc index c368cee2b9..0067946c17 100644 --- a/DAQ/src/StrawRecoFromFragments_module.cc +++ b/DAQ/src/StrawRecoFromFragments_module.cc @@ -199,7 +199,7 @@ void art::StrawRecoFromFragmnets::analyze_tracker_( if (hdr.GetPacketCount() > 0 ) { // Create the StrawDigi data products - auto trkDataVec = cc.GetTrackerData(curBlockIdx); + auto trkDataVec = cc.GetTrackerData(curBlockIdx, useTrkADC_); if (trkDataVec.empty()) { mf::LogError("StrawRecoFromFragmnets") << "Error retrieving Tracker data from DataBlock " << curBlockIdx From 470539d937c4c270125a80abe799f939643af3d5 Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 7 May 2021 13:16:04 -0500 Subject: [PATCH 40/54] small updates --- DAQ/test/generateBinaryFromDigi.fcl | 14 ++++++++++- DAQ/test/generateDigiFromFragment.fcl | 35 +++++++++++++++++++++++++-- 2 files changed, 46 insertions(+), 3 deletions(-) diff --git a/DAQ/test/generateBinaryFromDigi.fcl b/DAQ/test/generateBinaryFromDigi.fcl index 1250f8b076..17961eaccd 100644 --- a/DAQ/test/generateBinaryFromDigi.fcl +++ b/DAQ/test/generateBinaryFromDigi.fcl @@ -43,10 +43,20 @@ physics : { digisTag : CaloDigiMaker } + + readFragments : { + module_type : FragmentAna + diagLevel : 0 + parseCAL : 1 + parseTRK : 1 + caloTag : "daq:calo" + trkTag : "daq:trk" + } } t1 : [ binaryOutput ] - e1 : [ readSD, readCD ] + #e1 : [ readSD, readCD ] + e1 : [ readSD, readCD, readFragments ] trigger_paths : [t1] end_paths : [e1] @@ -57,3 +67,5 @@ physics.producers.binaryOutput.includeTracker : 1 physics.producers.binaryOutput.includeCalorimeter : 1 physics.producers.binaryOutput.outputFile : "DTC_packets.bin" services.TFileService.fileName : "generateBinaryFromDigi_test.root" + +# physics.producers.binaryOutput.diagLevel : 10 \ No newline at end of file diff --git a/DAQ/test/generateDigiFromFragment.fcl b/DAQ/test/generateDigiFromFragment.fcl index 66817449d5..2738e6e9ef 100644 --- a/DAQ/test/generateDigiFromFragment.fcl +++ b/DAQ/test/generateDigiFromFragment.fcl @@ -7,6 +7,9 @@ #include "fcl/minimalMessageService.fcl" #include "fcl/standardServices.fcl" #include "DAQ/fcl/prolog_trigger.fcl" + +#include "CaloCluster/fcl/prolog_trigger.fcl" + process_name : FragmentToDigi source : { @@ -24,15 +27,38 @@ services : @local::Services.Reco physics : { producers : { + fetchData: + { + module_type : PrefetchDAQData + debugLevel : 0 + fetchCaloDigis : 0 + fetchStrawDigis : 0 + fetchCaloFragments : 1 + fetchTrkFragments : 1 + caloDigiCollectionTag : "notNow" + strawDigiCollectionTag : "notNow" + caloFragmentTag : "daq:calo" + trkFragmentTag : "daq:trk" + } + makeSD: { @table::DAQ.producers.makeSD } + CaloDigiMaker: + { + @table::DAQ.producers.CaloDigiMaker + } + CaloHitMaker: { @table::DAQ.producers.CaloHitMaker } + CaloClusterFast: + { + @table::CaloClusterTrigger.producers.CaloClusterFast + } } analyzers : { @@ -47,8 +73,10 @@ physics : { } # t1 : [ makeSD ] - t1 : [ makeSD, CaloHitMaker ] - e1 : [ readFragments, outfile ] + # t1 : [ fetchData, makeSD , CaloDigiMaker, CaloHitMaker, CaloClusterFast] + t1 : [ fetchData, makeSD , CaloHitMaker, CaloClusterFast] + #e1 : [ outfile, readFragments] + e1 : [] trigger_paths : [t1] end_paths : [e1] @@ -76,3 +104,6 @@ services.TimeTracker : { } } services.scheduler.wantSummary: true +physics.producers.makeSD.useTrkADC : 0 +#physics.producers.makeSD.diagLevel : 10 +#physics.producers.CaloDigiMaker.diagLevel : 10 From 1b347e030249fd17b35e7beb5c383b6190522dff Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 7 May 2021 13:16:28 -0500 Subject: [PATCH 41/54] changed mu2e_artdaq_core version --- setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.sh b/setup.sh index 51b5c6d705..cf416be129 100644 --- a/setup.sh +++ b/setup.sh @@ -132,7 +132,7 @@ else fi # Get access to raw data formats. -setup -B mu2e_artdaq_core v1_05_09 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} +setup -B mu2e_artdaq_core v1_05_10 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} setup -B heppdt v03_04_02 -q${MU2E_UPS_QUALIFIERS} setup -B BTrk v1_02_30 -q${MU2E_UPS_QUALIFIERS}:p383b From 71f228602f43491f59d10b8d308f3bc085ddf3e9 Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 7 May 2021 13:17:00 -0500 Subject: [PATCH 42/54] using a faster access to the calorimter fragment --- DAQ/src/CaloHitsFromFragments_module.cc | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/DAQ/src/CaloHitsFromFragments_module.cc b/DAQ/src/CaloHitsFromFragments_module.cc index c497fc8816..b8a0c415c2 100644 --- a/DAQ/src/CaloHitsFromFragments_module.cc +++ b/DAQ/src/CaloHitsFromFragments_module.cc @@ -284,7 +284,7 @@ void art::CaloHitsFromFragments::analyze_calorimeter_( << std::endl; } - auto hits = cc.GetCalorimeterHits(curBlockIdx); + auto hits = cc.GetCalorimeterHitsForTrigger(curBlockIdx); bool err = false; for (size_t hitIdx = 0; hitIdx < calData->NumberOfHits; hitIdx++) { @@ -314,10 +314,11 @@ void art::CaloHitsFromFragments::analyze_calorimeter_( caloDAQUtil_.getSiPMID(hits[hitIdx].first); // hits[hitIdx].first.DIRACB >> 12; size_t peakIndex = hits[hitIdx].first.IndexOfMaxDigitizerSample; - float eDep(0); - if (hits[hitIdx].first.IndexOfMaxDigitizerSample < hits[hitIdx].second.size()) { - eDep = hits[hitIdx].second.at(peakIndex) * peakADC2MeV_[sipmID]; - } + // float eDep(0); + // if (hits[hitIdx].first.IndexOfMaxDigitizerSample < hits[hitIdx].second.size()) { + // eDep = hits[hitIdx].second.at(peakIndex) * peakADC2MeV_[sipmID]; + float eDep = hits[hitIdx].second * peakADC2MeV_[sipmID]; + // } float time = hits[hitIdx].first.Time + peakIndex * digiSampling_ + timeCalib_[sipmID]; //FIX ME! WE NEED TO CHECK IF TEH PULSE IS SATURATED HERE From f552cfcf131a7d94440efdf5bb786b92e839ad20 Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 7 May 2021 15:18:54 -0500 Subject: [PATCH 43/54] new mu2e_artdaq_core version --- setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.sh b/setup.sh index cf416be129..f17ac9ad76 100644 --- a/setup.sh +++ b/setup.sh @@ -132,7 +132,7 @@ else fi # Get access to raw data formats. -setup -B mu2e_artdaq_core v1_05_10 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} +setup -B mu2e_artdaq_core v1_05_09_01 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} setup -B heppdt v03_04_02 -q${MU2E_UPS_QUALIFIERS} setup -B BTrk v1_02_30 -q${MU2E_UPS_QUALIFIERS}:p383b From 4b442d89d1f650996bd4493a0d2ad3af5a42b6a2 Mon Sep 17 00:00:00 2001 From: gianipez Date: Fri, 7 May 2021 15:25:53 -0500 Subject: [PATCH 44/54] updates for being compatible with artdaq v1_05_09_01 --- DAQ/inc/CaloDAQUtilities.hh | 2 +- DAQ/src/CaloDAQUtilities.cc | 19 ++++++++++--------- DAQ/src/CaloHitsFromFragments_module.cc | 4 ++-- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/DAQ/inc/CaloDAQUtilities.hh b/DAQ/inc/CaloDAQUtilities.hh index 0db9bdd4ac..865c98c6b0 100644 --- a/DAQ/inc/CaloDAQUtilities.hh +++ b/DAQ/inc/CaloDAQUtilities.hh @@ -33,7 +33,7 @@ namespace mu2e { void printWaveform(std::vector& Pulse); - void printAllHitInfo(int CrystalID, int SiPMID, DTCLib::DTC_DataHeaderPacket &Header, CalorimeterFragment::CalorimeterHitReadoutPacket& Hit, std::vector& Pulse); + void printAllHitInfo(int CrystalID, int SiPMID, DTCLib::DTC_DataHeaderPacket &Header, CalorimeterFragment::CalorimeterHitReadoutPacket& Hit, uint16_t& PulseMax); private: std::string moduleName_; diff --git a/DAQ/src/CaloDAQUtilities.cc b/DAQ/src/CaloDAQUtilities.cc index de23d8b197..85e6b80ce9 100644 --- a/DAQ/src/CaloDAQUtilities.cc +++ b/DAQ/src/CaloDAQUtilities.cc @@ -77,13 +77,13 @@ namespace mu2e { void CaloDAQUtilities::printAllHitInfo(int CrystalID, int SiPMID, DTCLib::DTC_DataHeaderPacket &Header, - CalorimeterFragment::CalorimeterHitReadoutPacket& Hit, std::vector& Pulse){ + CalorimeterFragment::CalorimeterHitReadoutPacket& Hit, uint16_t& PulseMax){ std::cout << "Crystal ID: " << CrystalID << std::endl; std::cout << "SiPM ID: " << SiPMID << std::endl; std::cout << "Time: " << (int)Hit.Time << std::endl; std::cout << "NumSamples: " << (int)Hit.NumberOfSamples << std::endl; - printWaveform(Pulse); + //printWaveform(Pulse); // Text format: timestamp crystalID roID time nsamples samples... // Example: 1 201 402 660 18 0 0 0 0 1 17 51 81 91 83 68 60 58 52 42 33 23 16 @@ -91,13 +91,14 @@ namespace mu2e { std::cout << CrystalID << " "; std::cout << SiPMID << " "; std::cout << Hit.Time << " "; - std::cout << Pulse.size() << " "; - for (size_t i = 0; i < Pulse.size(); i++) { - std::cout << Pulse[i]; - if (i < Pulse.size() - 1) { - std::cout << " "; - } - } + std::cout << PulseMax << " "; + // std::cout << Pulse.size() << " "; + // for (size_t i = 0; i < Pulse.size(); i++) { + // std::cout << Pulse[i]; + // if (i < Pulse.size() - 1) { + // std::cout << " "; + // } + // } std::cout << std::endl; } diff --git a/DAQ/src/CaloHitsFromFragments_module.cc b/DAQ/src/CaloHitsFromFragments_module.cc index b8a0c415c2..0ee35f0a0a 100644 --- a/DAQ/src/CaloHitsFromFragments_module.cc +++ b/DAQ/src/CaloHitsFromFragments_module.cc @@ -329,8 +329,8 @@ void art::CaloHitsFromFragments::analyze_calorimeter_( // Until we have the final mapping, the BoardID is just a placeholder // adc_t BoardId = cc.DBC_BoardID(pos,channelIdx); - caloDAQUtil_.printAllHitInfo(crystalID, sipmID, hdr, hits[hitIdx].first, - hits[hitIdx].second); + caloDAQUtil_.printAllHitInfo(crystalID, sipmID, hdr, hits[hitIdx].first, + hits[hitIdx].second); } // End debug output } // End loop over readout channels in DataBlock From b5e8974d86f75ffd93faeeba2defe110e909300e Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 16:35:48 -0500 Subject: [PATCH 45/54] fixed a few bugs --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index a75e0d62bb..6b9f0231f0 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -157,8 +157,7 @@ class ArtBinaryPacketsFromDigis : public art::EDProducer { int _includeCrv; int _includeDMAHeaders; - // -- include proditions handling - + // -- include proditions handling ProditionsHandle _calodaqconds_h; // Set to 1 to save packet data to a binary file int _generateBinaryFile; @@ -798,7 +797,6 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterDataPacket(CaloDAQMap const& calo CaloData.dataPacket.NumberOfHits = 1; CalorimeterBoardID ccBoardID; - // Change # 1: get roid and cryID from Digi //========================================= @@ -993,10 +991,9 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterHeaderDataPacket(CaloDAQMap const // ---------------------------------------------------------------- if( _diagLevel==1 && DetType == 1) printf(" CAPHRI !!! \n"); - HeaderData.s.LinkID = globalROCID % number_of_calo_rocs_per_dtc;// from ROCID call it now LinkID - + HeaderData.s.LinkID = globalROCID % number_of_calo_rocs_per_dtc;// from ROCID call it now LinkID HeaderData.s.SubsystemID = DTCLib::DTC_Subsystem_Calorimeter; - HeaderData.s.Valid = 1; + HeaderData.s.Valid = 1; // Word 2 HeaderData.s.PacketCount = 1; // NEEDS TO BE INCREASED EVERY TIME A NEW HIT IS ADDED! // Word 3 From 633d3d0f8643a887edb9f4bc9a7872610acca4b8 Mon Sep 17 00:00:00 2001 From: gianipez Date: Thu, 6 May 2021 16:35:48 -0500 Subject: [PATCH 46/54] fixed a few bugs --- DAQ/src/ArtBinaryPacketsFromDigis_module.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc index 6b9f0231f0..243bc090ef 100644 --- a/DAQ/src/ArtBinaryPacketsFromDigis_module.cc +++ b/DAQ/src/ArtBinaryPacketsFromDigis_module.cc @@ -985,7 +985,7 @@ void ArtBinaryPacketsFromDigis::fillCalorimeterHeaderDataPacket(CaloDAQMap const // --------------------------------------------------------------- size_t roId = CD.SiPMID(); // size_t globalROCID = crystalId / number_of_crystals_per_roc; - uint16_t packetId = calodaqconds.caloRoIdToPacketId(roId); + uint16_t packetId = calodaqconds.caloRoIdToPacketId(roId); uint16_t globalROCID = (packetId & (0x00FF)); uint16_t DetType = (packetId & (0xE000)) >> 13; // ---------------------------------------------------------------- From 369b4736b2f85558244f4eb63acb87d1adec39ba Mon Sep 17 00:00:00 2001 From: gianipez Date: Wed, 12 May 2021 08:43:41 -0500 Subject: [PATCH 47/54] small improvments --- Trigger/src/DigiFilter_module.cc | 18 +++++++++--------- Trigger/src/MergeTriggerInfo_module.cc | 2 +- Trigger/src/PrescaleEvent_module.cc | 16 +++++++--------- 3 files changed, 17 insertions(+), 19 deletions(-) diff --git a/Trigger/src/DigiFilter_module.cc b/Trigger/src/DigiFilter_module.cc index 56b55ed05b..b2be1095fd 100644 --- a/Trigger/src/DigiFilter_module.cc +++ b/Trigger/src/DigiFilter_module.cc @@ -14,7 +14,7 @@ #include "RecoDataProducts/inc/StrawDigiCollection.hh" #include "RecoDataProducts/inc/CaloDigi.hh" #include "RecoDataProducts/inc/CaloDigi.hh" -#include "RecoDataProducts/inc/TriggerInfo.hh" +// #include "RecoDataProducts/inc/TriggerInfo.hh" // c++ #include #include @@ -36,7 +36,7 @@ namespace mu2e art::InputTag _cdTag; bool _useSD; //flag for using the StrawDigi bool _useCD; //flag for using the CaloDigi - std::string _trigPath; + // std::string _trigPath; //list of the parameters used to perform the filtering int _minnsd; //minimum number of StrawDigi required @@ -56,7 +56,7 @@ namespace mu2e _cdTag (pset.get("caloDigiCollection")), _useSD (pset.get("useStrawDigi")), _useCD (pset.get("useCaloDigi")), - _trigPath (pset.get("triggerPath")), + // _trigPath (pset.get("triggerPath")), _minnsd (pset.get("minNStrawDigi")), _maxnsd (pset.get("maxNStrawDigi")), _minncd (pset.get("minNCaloDigi")), @@ -65,12 +65,12 @@ namespace mu2e _debug (pset.get("debugLevel",0)), _nevt(0), _npass(0) { - produces(); + // produces(); } bool DigiFilter::filter(art::Event& event){ // create output - unique_ptr triginfo(new TriggerInfo); + // unique_ptr triginfo(new TriggerInfo); ++_nevt; bool retval(false), retvalSD(false), retvalCD(false); // preset to fail // find the collection @@ -117,16 +117,16 @@ namespace mu2e if (retval){ ++_npass; - if (retvalSD) triginfo->_triggerBits.merge(TriggerFlag::strawDigis); - if (retvalCD) triginfo->_triggerBits.merge(TriggerFlag::caloDigis ); - triginfo->_triggerPath = _trigPath; + // if (retvalSD) triginfo->_triggerBits.merge(TriggerFlag::strawDigis); + // if (retvalCD) triginfo->_triggerBits.merge(TriggerFlag::caloDigis ); + // triginfo->_triggerPath = _trigPath; if(_debug > 1){ cout << moduleDescription().moduleLabel() << " passed event " << event.id() << endl; } } - event.put(std::move(triginfo)); + // event.put(std::move(triginfo)); return retval; } diff --git a/Trigger/src/MergeTriggerInfo_module.cc b/Trigger/src/MergeTriggerInfo_module.cc index 3fc5fff978..86b5cec98a 100644 --- a/Trigger/src/MergeTriggerInfo_module.cc +++ b/Trigger/src/MergeTriggerInfo_module.cc @@ -59,7 +59,7 @@ namespace mu2e { std::cout << "["<push_back(trigInfo); } diff --git a/Trigger/src/PrescaleEvent_module.cc b/Trigger/src/PrescaleEvent_module.cc index 8b69dd9381..ea0f9241e4 100644 --- a/Trigger/src/PrescaleEvent_module.cc +++ b/Trigger/src/PrescaleEvent_module.cc @@ -16,7 +16,7 @@ #include "canvas/Utilities/InputTag.h" #include "fhiclcpp/ParameterSet.h" #include "messagefacility/MessageLogger/MessageLogger.h" -#include "RecoDataProducts/inc/TriggerInfo.hh" +// #include "RecoDataProducts/inc/TriggerInfo.hh" #include #include @@ -47,7 +47,7 @@ namespace mu2e uint32_t nPrescale_; bool useFilteredEvts_; int _debug; - TriggerFlag _trigFlag; + // TriggerFlag _trigFlag; std::string _trigPath; unsigned _nevt, _npass; @@ -58,16 +58,15 @@ namespace mu2e nPrescale_ (p.get("nPrescale")), useFilteredEvts_(p.get ("useFilteredEvents",false)), _debug (p.get ("debugLevel",0)), - _trigFlag (p.get >("triggerFlag")), + // _trigFlag (p.get >("triggerFlag")), _trigPath (p.get("triggerPath")), _nevt(0), _npass(0) { - produces(); + // produces(); } inline bool PrescaleEvent::filter(art::Event & e) { - std::unique_ptr trigInfo(new TriggerInfo); ++_nevt; bool retval(false); bool condition = e.event() % nPrescale_ == 0; @@ -75,12 +74,11 @@ namespace mu2e if(condition) { ++_npass; - // trigInfo->_triggerBits.merge(TriggerFlag::prescaleRandom); - trigInfo->_triggerBits.merge(_trigFlag); - trigInfo->_triggerPath = _trigPath; + // trigInfo->_triggerBits.merge(_trigFlag); + // trigInfo->_triggerPath = _trigPath; retval = true; } - e.put(std::move(trigInfo)); + // e.put(std::move(trigInfo)); return retval; } From a367645aa5bb5655e51c0d0a16779d9fce8fadd4 Mon Sep 17 00:00:00 2001 From: gianipez Date: Wed, 12 May 2021 08:43:55 -0500 Subject: [PATCH 48/54] clean up --- TrkFilters/fcl/prolog_trigger.fcl | 100 +++++++++++++++--------------- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/TrkFilters/fcl/prolog_trigger.fcl b/TrkFilters/fcl/prolog_trigger.fcl index 4c6a5a7b08..f18a416ddc 100644 --- a/TrkFilters/fcl/prolog_trigger.fcl +++ b/TrkFilters/fcl/prolog_trigger.fcl @@ -1658,11 +1658,11 @@ TrkFilters : { # sequences for different trigger paths. Early triggers are prescaled sequences : { # #trkpatrec tracking - tprTimeClusterDeM : [ tprTimeClusterDeMEventPrescale, tprTimeClusterDeMSDCountFilter, + tprTimeClusterDeM : [ tprTimeClusterDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprTimeClusterDeMTCFilter ] - tprTimeClusterDeP : [ tprTimeClusterDePEventPrescale, tprTimeClusterDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprTimeClusterDeP : [ tprTimeClusterDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprTimeClusterDePTCFilter ] @@ -1671,99 +1671,99 @@ TrkFilters : { # tprHelixDeP : [ tprDePHelixEventPrescale, tprDePHelixSDCountFilter, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, # TTtimeClusterFinder, tprHelixDePTCFilter, TThelixFinder, TTHelixMergerDeP, tprHelixDePHSFilter ] - tprSeedDeM : [ tprSeedDeMEventPrescale, tprSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprSeedDeM : [ tprSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprSeedDeMTCFilter, TThelixFinder, TTHelixMergerDeM, tprSeedDeMHSFilter, TTKSFDeM, tprSeedDeMTSFilter, tprSeedDeMTriggerInfoMerger ] - tprSeedDeP : [ tprSeedDePEventPrescale, tprSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprSeedDeP : [ tprSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprSeedDePTCFilter, TThelixFinder,TTHelixMergerDeP, tprSeedDePHSFilter, TTKSFDeP, tprSeedDePTSFilter, tprSeedDePTriggerInfoMerger ] - tprLowPSeedDeM : [ tprLowPSeedDeMEventPrescale, tprLowPSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprLowPSeedDeM : [ tprLowPSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprLowPSeedDeMTCFilter, TThelixFinder, TTHelixMergerDeM, tprLowPSeedDeMHSFilter, TTKSFDeM, tprLowPSeedDeMTSFilter, tprLowPSeedDeMTriggerInfoMerger ] - tprLowPSeedDeP : [ tprLowPSeedDePEventPrescale, tprLowPSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprLowPSeedDeP : [ tprLowPSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprLowPSeedDePTCFilter, TThelixFinder,TTHelixMergerDeP, tprLowPSeedDePHSFilter, TTKSFDeP, tprLowPSeedDePTSFilter, tprLowPSeedDePTriggerInfoMerger ] - tprCosmicSeedDeM : [ tprCosmicSeedDeMEventPrescale, tprCosmicSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprCosmicSeedDeM : [ tprCosmicSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprCosmicSeedDeMTCFilter, TThelixFinder, TTHelixMergerDeM, tprCosmicSeedDeMHSFilter, TTKSFDeM, tprCosmicSeedDeMTSFilter, tprCosmicSeedDeMTriggerInfoMerger ] - tprCosmicSeedDeP : [ tprCosmicSeedDePEventPrescale, tprCosmicSeedDePSDCountFilter, @sequence::CaloClusterTrigger.Reco, + tprCosmicSeedDeP : [ tprCosmicSeedDePEventPrescale, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprCosmicSeedDePTCFilter, TThelixFinder,TTHelixMergerDeP, tprCosmicSeedDePHSFilter, TTKSFDeP, tprCosmicSeedDePTSFilter, tprCosmicSeedDePTriggerInfoMerger ] - tprCosmicHelixDeM : [ tprCosmicHelixDeMEventPrescale, tprCosmicHelixDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprCosmicHelixDeM : [ tprCosmicHelixDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprCosmicHelixDeMTCFilter, TThelixFinder, TTHelixMergerDeM, tprCosmicHelixDeMHSFilter, tprCosmicHelixDeMTriggerInfoMerger ] - tprCosmicHelixDeP : [ tprCosmicHelixDePEventPrescale, tprCosmicHelixDePSDCountFilter, @sequence::CaloClusterTrigger.Reco, + tprCosmicHelixDeP : [ tprCosmicHelixDePEventPrescale, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprCosmicHelixDePTCFilter, TThelixFinder,TTHelixMergerDeP, tprCosmicHelixDePHSFilter, tprCosmicHelixDePTriggerInfoMerger ] - tprCosmicHelixUeM : [ tprCosmicHelixUeMEventPrescale, tprCosmicHelixUeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprCosmicHelixUeM : [ tprCosmicHelixUeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprCosmicHelixUeMTCFilter, TThelixFinder, TTHelixMergerUeM, tprCosmicHelixUeMHSFilter, tprCosmicHelixUeMTriggerInfoMerger ] - tprCosmicHelixUeP : [ tprCosmicHelixUePEventPrescale, tprCosmicHelixUePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprCosmicHelixUeP : [ tprCosmicHelixUePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprCosmicHelixUePTCFilter, TThelixFinder,TTHelixMergerUeP, tprCosmicHelixUePHSFilter, tprCosmicHelixUePTriggerInfoMerger ] # sequences that use a collection of combohits filtered using the calorimeter cluster info - tprSeedUCCDeM : [ tprSeedUCCDeMEventPrescale, tprSeedUCCDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprSeedUCCDeM : [ tprSeedUCCDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHitsUCC, TTtimeClusterFinderUCC, tprSeedUCCDeMTCFilter, TThelixFinderUCC, TTHelixUCCMergerDeM, tprSeedUCCDeMHSFilter, TTKSFUCCDeM, tprSeedUCCDeMTSFilter, tprSeedUCCDeMTriggerInfoMerger ] - tprSeedUCCDeP : [ tprSeedUCCDePEventPrescale, tprSeedUCCDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprSeedUCCDeP : [ tprSeedUCCDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHitsUCC, TTtimeClusterFinderUCC, tprSeedUCCDePTCFilter, TThelixFinderUCC, TTHelixUCCMergerDeP, tprSeedUCCDePHSFilter, TTKSFUCCDeP, tprSeedUCCDePTSFilter, tprSeedUCCDeMTriggerInfoMerger ] # calibration with DIO-Michel form Inner Proton Absorber - tprHelixCalibIPADeM : [ tprHelixCalibIPADeMEventPrescale, tprHelixCalibIPADeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprHelixCalibIPADeM : [ tprHelixCalibIPADeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprHelixCalibIPADeMTCFilter, TThelixFinder, TTHelixMergerDeM, tprHelixCalibIPADeMHSFilter, tprHelixCalibIPADeMTriggerInfoMerger ] # beam monitoring using the e- from the DIO in the IPA - tprHelixIPADeM : [ tprHelixIPADeMEventPrescale, tprHelixIPADeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprHelixIPADeM : [ tprHelixIPADeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprHelixIPADeMTCFilter, TThelixFinder, TTHelixMergerDeM, tprHelixIPADeMHSFilter, tprHelixIPADeMTriggerInfoMerger ] #calo-seeded tracking - cprSeedDeM : [ cprSeedDeMEventPrescale, cprSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprSeedDeM : [ cprSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprSeedDeMTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeM, cprSeedDeMHSFilter, TTCalSeedFitDem, cprSeedDeMTSFilter, cprSeedDeMTriggerInfoMerger ] - cprSeedDeP : [ cprSeedDePEventPrescale, cprSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprSeedDeP : [ cprSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprSeedDePTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeP, cprSeedDePHSFilter, TTCalSeedFitDep, cprSeedDePTSFilter, cprSeedDePTriggerInfoMerger ] - cprLowPSeedDeM : [ cprLowPSeedDeMEventPrescale, cprLowPSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprLowPSeedDeM : [ cprLowPSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprLowPSeedDeMTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeM, cprLowPSeedDeMHSFilter, TTCalSeedFitDem, cprLowPSeedDeMTSFilter, cprLowPSeedDeMTriggerInfoMerger ] - cprLowPSeedDeP : [ cprLowPSeedDePEventPrescale, cprLowPSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprLowPSeedDeP : [ cprLowPSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprLowPSeedDePTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeP, cprLowPSeedDePHSFilter, TTCalSeedFitDep, cprLowPSeedDePTSFilter, cprLowPSeedDePTriggerInfoMerger ] - cprCosmicSeedDeM : [ cprCosmicSeedDeMEventPrescale, cprCosmicSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprCosmicSeedDeM : [ cprCosmicSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprCosmicSeedDeMTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeM, cprCosmicSeedDeMHSFilter, TTCalSeedFitDem, cprCosmicSeedDeMTSFilter, cprCosmicSeedDeMTriggerInfoMerger ] - cprCosmicSeedDeP : [ cprCosmicSeedDePEventPrescale, cprCosmicSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprCosmicSeedDeP : [ cprCosmicSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprCosmicSeedDePTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeP, cprCosmicSeedDePHSFilter, TTCalSeedFitDep, cprCosmicSeedDePTSFilter, cprCosmicSeedDePTriggerInfoMerger ] - cprCosmicHelixDeM : [ cprCosmicHelixDeMEventPrescale, cprCosmicHelixDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprCosmicHelixDeM : [ cprCosmicHelixDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprCosmicHelixDeMTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeM, cprCosmicHelixDeMHSFilter, cprCosmicHelixDeMTriggerInfoMerger ] - cprCosmicHelixDeP : [ cprCosmicHelixDePEventPrescale, cprCosmicHelixDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprCosmicHelixDeP : [ cprCosmicHelixDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprCosmicHelixDePTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeP, cprCosmicHelixDePHSFilter, cprCosmicHelixDePTriggerInfoMerger ] - cprSeedUCCDeM : [ cprSeedUCCDeMEventPrescale, cprSeedUCCDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprSeedUCCDeM : [ cprSeedUCCDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHitsUCC, TTCalTimePeakFinderUCC, cprSeedUCCDeMTCFilter, TTCalHelixFinderUCCDe, TTCalHelixUCCMergerDeM, cprSeedUCCDeMHSFilter, TTCalSeedFitUCCDem, cprSeedUCCDeMTSFilter, cprSeedUCCDeMTriggerInfoMerger ] - cprSeedUCCDeP : [ cprSeedUCCDePEventPrescale, cprSeedUCCDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprSeedUCCDeP : [ cprSeedUCCDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHitsUCC, TTCalTimePeakFinderUCC, cprSeedUCCDePTCFilter, TTCalHelixFinderUCCDe, TTCalHelixUCCMergerDeP, cprSeedUCCDePHSFilter, TTCalSeedFitUCCDep, cprSeedUCCDePTSFilter, cprSeedUCCDePTriggerInfoMerger ] @@ -1777,102 +1777,102 @@ TrkFilters : { # sequences for doing timing tests - tprSeedDeMTiming0 : [ tprSeedDeMEventPrescale, tprSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprSeedDeMTiming0 : [ tprSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprSeedDeMTCFilter, TThelixFinder, TTHelixMergerDeM, tprSeedDeMHSFilter, TTKSFDeM, tprSeedDeMTriggerInfoMerger ] - tprSeedDeMTiming1 : [ tprSeedDeMEventPrescale, tprSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprSeedDeMTiming1 : [ tprSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprSeedDeMTCFilter, TThelixFinder, TTHelixMergerDeM ] - tprSeedDeMTiming2 : [ tprSeedDeMEventPrescale, tprSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprSeedDeMTiming2 : [ tprSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder ] - tprSeedDePTiming0 : [ tprSeedDePEventPrescale, tprSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprSeedDePTiming0 : [ tprSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprSeedDePTCFilter, TThelixFinder, TTHelixMergerDeP, tprSeedDePHSFilter, TTKSFDeP, tprSeedDePTriggerInfoMerger ] - tprSeedDePTiming1 : [ tprSeedDePEventPrescale, tprSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprSeedDePTiming1 : [ tprSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprSeedDePTCFilter, TThelixFinder, TTHelixMergerDeP ] - tprSeedDePTiming2 : [ tprSeedDePEventPrescale, tprSeedDePSDCountFilter, @sequence::CaloClusterTrigger.Reco, + tprSeedDePTiming2 : [ tprSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder ] - cprSeedDeMTiming0 : [ cprSeedDeMEventPrescale, cprSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprSeedDeMTiming0 : [ cprSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprSeedDeMTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeM, cprSeedDeMHSFilter, TTCalSeedFitDem, cprSeedDeMTriggerInfoMerger ] - cprSeedDeMTiming1 : [ cprSeedDeMEventPrescale, cprSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprSeedDeMTiming1 : [ cprSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprSeedDeMTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeM ] - cprSeedDeMTiming2 : [ cprSeedDeMEventPrescale, cprSeedDeMSDCountFilter, @sequence::CaloClusterTrigger.Reco, + cprSeedDeMTiming2 : [ cprSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder ] - cprSeedDePTiming0 : [ cprSeedDePEventPrescale, cprSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprSeedDePTiming0 : [ cprSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprSeedDePTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeP, cprSeedDePHSFilter, TTCalSeedFitDep, cprSeedDePTriggerInfoMerger ] - cprSeedDePTiming1 : [ cprSeedDePEventPrescale, cprSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprSeedDePTiming1 : [ cprSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprSeedDePTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeP ] - cprSeedDePTiming2 : [ cprSeedDePEventPrescale, cprSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprSeedDePTiming2 : [ cprSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder ] - tprLowPSeedDeMTiming0 : [ tprLowPSeedDeMEventPrescale, tprLowPSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprLowPSeedDeMTiming0 : [ tprLowPSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprLowPSeedDeMTCFilter, TThelixFinder, TTHelixMergerDeM, tprLowPSeedDeMHSFilter, TTKSFDeM, tprLowPSeedDeMPrescale, tprLowPSeedDeMTriggerInfoMerger ] - tprLowPSeedDeMTiming1 : [ tprLowPSeedDeMEventPrescale, tprLowPSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprLowPSeedDeMTiming1 : [ tprLowPSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprLowPSeedDeMTCFilter, TThelixFinder, TTHelixMergerDeM, tprLowPSeedDeMPrescale ] - tprLowPSeedDeMTiming2 : [ tprLowPSeedDeMEventPrescale, tprLowPSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprLowPSeedDeMTiming2 : [ tprLowPSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprLowPSeedDeMPrescale ] - tprLowPSeedDePTiming0 : [ tprLowPSeedDePEventPrescale, tprLowPSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprLowPSeedDePTiming0 : [ tprLowPSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprLowPSeedDePTCFilter, TThelixFinder, TTHelixMergerDeP, tprLowPSeedDePHSFilter, TTKSFDeP, tprLowPSeedDePTriggerInfoMerger ] - tprLowPSeedDePTiming1 : [ tprLowPSeedDePEventPrescale, tprLowPSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprLowPSeedDePTiming1 : [ tprLowPSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprLowPSeedDePTCFilter, TThelixFinder, TTHelixMergerDeP, tprLowPSeedDePPrescale ] - tprLowPSeedDePTiming2 : [ tprLowPSeedDePEventPrescale, tprLowPSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + tprLowPSeedDePTiming2 : [ tprLowPSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTtimeClusterFinder, tprLowPSeedDePPrescale ] - cprLowPSeedDeMTiming0 : [ cprLowPSeedDeMEventPrescale, cprLowPSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprLowPSeedDeMTiming0 : [ cprLowPSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprLowPSeedDeMTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeM, cprLowPSeedDeMHSFilter, TTCalSeedFitDem, cprLowPSeedDeMTriggerInfoMerger ] - cprLowPSeedDeMTiming1 : [ cprLowPSeedDeMEventPrescale, cprLowPSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprLowPSeedDeMTiming1 : [ cprLowPSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprLowPSeedDeMTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeM] - cprLowPSeedDeMTiming2 : [ cprLowPSeedDeMEventPrescale, cprLowPSeedDeMSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprLowPSeedDeMTiming2 : [ cprLowPSeedDeMEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder] - cprLowPSeedDePTiming0 : [ cprLowPSeedDePEventPrescale, cprLowPSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprLowPSeedDePTiming0 : [ cprLowPSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprLowPSeedDePTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeP, cprLowPSeedDePHSFilter, TTCalSeedFitDep, cprLowPSeedDePTriggerInfoMerger ] - cprLowPSeedDePTiming1 : [ cprLowPSeedDePEventPrescale, cprLowPSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprLowPSeedDePTiming1 : [ cprLowPSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder, cprLowPSeedDePTCFilter, TTCalHelixFinderDe, TTCalHelixMergerDeP ] - cprLowPSeedDePTiming2 : [ cprLowPSeedDePEventPrescale, cprLowPSeedDePSDCountFilter, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, + cprLowPSeedDePTiming2 : [ cprLowPSeedDePEventPrescale, @sequence::CaloHitRecoTrigger.prepareHits, @sequence::CaloClusterTrigger.Reco, @sequence::TrkHitRecoTrigger.sequences.TTprepareHits, TTCalTimePeakFinder ] From 15f429d5ee1c1278068fb444efd07560df54971a Mon Sep 17 00:00:00 2001 From: macndev Date: Tue, 18 May 2021 14:37:39 -0500 Subject: [PATCH 49/54] KinKal tag change and last deprecation fix --- Trigger/src/MergeTriggerInfo_module.cc | 2 +- setup.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Trigger/src/MergeTriggerInfo_module.cc b/Trigger/src/MergeTriggerInfo_module.cc index 86b5cec98a..054db1fe63 100644 --- a/Trigger/src/MergeTriggerInfo_module.cc +++ b/Trigger/src/MergeTriggerInfo_module.cc @@ -53,7 +53,7 @@ namespace mu2e { // art::ModuleLabelSelector(""));// && // art::ProcessNameSelector("*")); std::vector > list_of_triggerInfo; - event.getMany(selector, list_of_triggerInfo); + event.getMany(selector); if(_debug > 0){ std::cout << "["< Date: Tue, 18 May 2021 16:43:30 -0400 Subject: [PATCH 50/54] Update ceSimReco.fcl --- Validation/fcl/ceSimReco.fcl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Validation/fcl/ceSimReco.fcl b/Validation/fcl/ceSimReco.fcl index 91ec897b36..6ac2a2eaa2 100644 --- a/Validation/fcl/ceSimReco.fcl +++ b/Validation/fcl/ceSimReco.fcl @@ -99,9 +99,9 @@ services.scheduler.wantSummary: true services.TimeTracker.printSummary: true # histogram file -services.TFileService.fileName: "/mu2e/data2/users/macndev/val_art3_09/nts.owner.val-ceSimReco309.dsconf.seq.root" +services.TFileService.fileName: "/dev/null" # art file -outputs.Output.fileName : "/mu2e/data2/users/macndev/val_art3_09/mcs.owner.val-ceSimReco309.dsconf.seq.art" +outputs.Output.fileName : "mcs.owner.val-ceSimReco.dsconf.seq.art" # run 1h by default source.maxEvents: 5000 From 8ae778fdcc76800ee2bdb34977f025716fc784bf Mon Sep 17 00:00:00 2001 From: macndev <49133885+macndev@users.noreply.github.com> Date: Wed, 19 May 2021 16:34:52 -0400 Subject: [PATCH 51/54] Update .muse envset to p007 --- .muse | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.muse b/.muse index b0d87ea214..c66426d7d4 100644 --- a/.muse +++ b/.muse @@ -1,5 +1,5 @@ # prefer to build with this environment -ENVSET p005 +ENVSET p007 # add these to python path PYTHONPATH TrackerAlignment/scripts PYTHONPATH Trigger/python From a1983c32df93ef85537134357689ac0bbc9bf3ad Mon Sep 17 00:00:00 2001 From: macndev Date: Fri, 28 May 2021 13:26:39 -0500 Subject: [PATCH 52/54] tag changes for art v3_09_01 --- setup.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/setup.sh b/setup.sh index c4d64590ad..8e93c0f27b 100644 --- a/setup.sh +++ b/setup.sh @@ -101,7 +101,7 @@ build=$($MU2E_BASE_RELEASE/buildopts --build) # and is therefore different from the value shown in # SETUP_ environment vars, or by the "ups active" command. export MU2E_UPS_QUALIFIERS=+e20:+${build} -export MU2E_ART_SQUALIFIER=s108 +export MU2E_ART_SQUALIFIER=s109 MU2E_G4_GRAPHICS_QUALIFIER='' if [[ $($MU2E_BASE_RELEASE/buildopts --g4vis) == qt ]]; then @@ -121,8 +121,8 @@ fi export MU2E_G4_EXTRA_QUALIFIER='' # Setup the framework and its dependent products -setup -B art v3_09_00 -q${MU2E_UPS_QUALIFIERS} -setup -B art_root_io v1_08_00 -q${MU2E_UPS_QUALIFIERS} +setup -B art v3_09_01 -q${MU2E_UPS_QUALIFIERS} +setup -B art_root_io v1_08_01 -q${MU2E_UPS_QUALIFIERS} # Geant4 and its cross-section files. if [[ $($MU2E_BASE_RELEASE/buildopts --trigger) == "off" ]]; then @@ -132,12 +132,12 @@ else fi # Get access to raw data formats. -setup -B mu2e_artdaq_core v1_05_09_01 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} +setup -B mu2e_artdaq_core v1_06_01 -q${MU2E_UPS_QUALIFIERS}:+${MU2E_ART_SQUALIFIER} setup -B heppdt v03_04_02 -q${MU2E_UPS_QUALIFIERS} setup cetpkgsupport -setup -B KinKal v00_01_06a -q${MU2E_UPS_QUALIFIERS}:p392 -setup -B BTrk v1_02_31 -q${MU2E_UPS_QUALIFIERS}:p392 +setup -B KinKal v00_01_06b -q${MU2E_UPS_QUALIFIERS}:p392 +setup -B BTrk v1_02_32 -q${MU2E_UPS_QUALIFIERS}:p392 setup -B cry v1_7n -q${MU2E_UPS_QUALIFIERS} setup -B gsl v2_6a setup curl v7_64_1 From 7b5c9331918d36e3a72a73ebc180863633e557d2 Mon Sep 17 00:00:00 2001 From: macndev Date: Fri, 28 May 2021 14:40:33 -0500 Subject: [PATCH 53/54] .muse envset increment --- .muse | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.muse b/.muse index c66426d7d4..4e520ab6ad 100644 --- a/.muse +++ b/.muse @@ -1,5 +1,5 @@ # prefer to build with this environment -ENVSET p007 +ENVSET p008 # add these to python path PYTHONPATH TrackerAlignment/scripts PYTHONPATH Trigger/python From 14d91da92dff1e13b224d0aa0f06747b41397ad2 Mon Sep 17 00:00:00 2001 From: macndev Date: Fri, 28 May 2021 15:05:36 -0500 Subject: [PATCH 54/54] rename of GenEventCountReader --- {Analyses => CommonMC}/src/GenEventCountReader_module.cc | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename {Analyses => CommonMC}/src/GenEventCountReader_module.cc (100%) diff --git a/Analyses/src/GenEventCountReader_module.cc b/CommonMC/src/GenEventCountReader_module.cc similarity index 100% rename from Analyses/src/GenEventCountReader_module.cc rename to CommonMC/src/GenEventCountReader_module.cc