Replies: 5 comments 48 replies
-
|
应为： enum class FuncPages
{
//...
};
//...
...snip...FuncPages current_func_page = FuncPages::xxxx |
Beta Was this translation helpful? Give feedback.
-
|
那也要用 |
Beta Was this translation helpful? Give feedback.
-
|
所以 |
Beta Was this translation helpful? Give feedback.
-
|
在你定义两个 |
Beta Was this translation helpful? Give feedback.
-
这个没考虑过，感谢提醒！我会尝试以合适的方法更改我的习惯。
当Workspace没有任何活动的页面(Funcpages)时会切换到此处。当然，发生这种情况基本上是页面发生了崩溃，NULLPAGE的情况不会超过一个事件循环（毕竟如果崩溃被检测程序要么修复要么就直接退出了）。
两个.. 都不是作用域内？不应该是两个都作用产生冲突了吗？ |
Beta Was this translation helpful? Give feedback.
-
|
什么啊。 enum SomeEnum
{
some_value
};
enum SomeOtherEnum
{
some_value
// ^~~~~~~~~~ <-----error: redeclaration
}; |
Beta Was this translation helpful? Give feedback.
-
|
main.cpp |
Beta Was this translation helpful? Give feedback.
-
class RootWindowU : public QWidget
{
Q_OBJECT
public:
RootWindowU();
private:
Ui::RootWindowW ui_rw;
FUNCPAGES_POINTER funcPages_pointer;
bool reloadStyleSheet();
void changePage();
};那么大一个Q_OBJECT，wtf is that?????? |
Beta Was this translation helpful? Give feedback.
-
|
这是一个宏，启用相关QT功能。具体您可以自行搜索。 |
Beta Was this translation helpful? Give feedback.
-
if (ui_rw.pb_tabbar_onlineSearcher->isChecked())
call_page = FUNCPAGES_ENUM::OnlineSearcher;
else if (ui_rw.pb_tabbar_localCollector->isChecked())
call_page = FUNCPAGES_ENUM::LocalCollector;
else if (ui_rw.pb_tabbar_itemCart->isChecked())
call_page = FUNCPAGES_ENUM::ItemCart;
else if (ui_rw.pb_tabbar_workQueue->isChecked())
call_page = FUNCPAGES_ENUM::WorkQueue;
else if (ui_rw.pb_tabbar_options->isChecked(
|
Beta Was this translation helpful? Give feedback.
-
//向不是将调用的页面发送删除请求，是否执行内存释放由对应类自行判断
//TODO 这里代码未来的重复率太高了，或许可以改成模板形式
if (call_page != FUNCPAGES_ENUM::OnlineSearcher && funcPages_pointer.onlineSearcher != NULL)
if (funcPages_pointer.onlineSearcher->tryDelete())
funcPages_pointer.onlineSearcher = NULL;别想了，不可能的，用了模板，函数指针调不出来（因为强制 |
Beta Was this translation helpful? Give feedback.
-
|
isChecked()用来判断该控件是否已经被选中。由于有5个不同的按钮已经被预定义，所以此处使用了五次判断。事实上，由于按钮数量不会轻易改动，这样写已经是最省力的了。 |
Beta Was this translation helpful? Give feedback.
-
|
我终究没搞懂你的代码什么意思，毕竟我没用过Qt吧。 最好全部重构 要么，你把整个设计流程说一遍？？？ |
Beta Was this translation helpful? Give feedback.
-
|
有点困难，但是我尝试一下。 namespace Ui {
class RootWindowU: public Ui_RootWindowU {};
} // namespace Ui这样，我就可以在添加ui_~~~.h的文件中调用它： Ui::RootWindowU ui_rw;这样，我就声明了一个界面的实例（ui_rw），我可以通过这个实例调用其子控件，如： ui_rw.pb_tabbar_onlineSearcher->enabled(true);//将ui_rw对象中的pb_tabbar_onlineSearcher子控件设置为启用有关connect，这里给出它的函数原型，你应该能明白它是怎么工作的了： static QMetaObject::Connection connect(const QObject *sender, const QMetaMethod &signal,const QObject *receiver, const QMetaMethod &method, Qt::ConnectionType type = Qt::AutoConnection);你可能会对这个产生疑惑： ui_rw.setupUi(this);这是UI的初始化，需要在其子控件被使用前调用，这里截取一部分setupUi中的代码，你应该能理解它是做什么的，实际上，它就是声明一些在.ui文件中写道的数据： void setupUi(QWidget *OnlineSearcherU)
{
if (OnlineSearcherU->objectName().isEmpty())
OnlineSearcherU->setObjectName("OnlineSearcherU");
OnlineSearcherU->resize(740, 500);
VL_OnlineSearcherW = new QVBoxLayout(OnlineSearcherU);
VL_OnlineSearcherW->setSpacing(0);
VL_OnlineSearcherW->setObjectName("VL_OnlineSearcherW");
VL_OnlineSearcherW->setContentsMargins(0, 0, 0, 0);
w_searchControllerZone = new QWidget(OnlineSearcherU);
...snip...
VL_OnlineSearcherW->setStretch(1, 10);
retranslateUi(OnlineSearcherU);
QMetaObject::connectSlotsByName(OnlineSearcherU);
} // setupUi然后，你可能担心我的Funcpages出现内存泄漏，事实上，我也担心过这个问题，所以我使用 剩下的如果有其它问题请尽管提出来！毕竟我不想重构了，这些代码才产出没几天呢φ(゜▽゜*)♪ |
Beta Was this translation helpful? Give feedback.
-
|
为什么要在函数中把窗体的信息再写一遍？不应该是读取 至少wxWidgets支持从 |
Beta Was this translation helpful? Give feedback.
-
|
是这样的，QTDesiger只能定义最基本的控件信息，如大小、样式、默认状态、文字等，但是，更为复杂的比如动态列表、控件列表是很难实现的。同时，由于每次更新.ui文件都会调用qmake重新构建ui_~~~.h，所以你不可能通过自己写代码修改QTDesigner生成的窗体，你只能继承它，然后才能在继承的类中更改（事实上是继承QWidget而不是ui_~~~.h中的类） |
Beta Was this translation helpful? Give feedback.
-
|
这一段直接用 bool ConfigManager::loadConfig()
{
QFile configFile;
configFile.setFileName(configFileName);
if (!configFile.open(QIODevice::ReadOnly) || configFile.size() >= 0x100000)
return false;
QString text_oriConfig = configFile.readAll();
configFile.close();
QString text_configHeader;
QRegularExpression regExp;
if (!bText_between(&text_configHeader, &text_oriConfig, "<manifest>", "</manifest>"))
return false;
regExp.setPattern("(?<=\\[for=)\\S*(?=\\])");
if (regExp.match(text_configHeader).captured() != PROGRAMTEXTID)//配置与程序不符
return false;
regExp.setPattern("(?<=\\[createrVersion=)\\S*(?=\\])");
if (regExp.match(text_oriConfig).captured().toUShort() != PROGRAMBUILDVER)//配置与版本不符//TODO此处限制了唯一版本，应有版本兼容性
return false;
QString text_configData;
if(!bText_between(&text_configData,&text_oriConfig, "<data>", "</data>"))
regExp.setPattern("(?<=\\[eptBlocks=)\\S*(?=\\])");
QJsonDocument data_jsonDoc;
QJsonParseError data_jsonError;
data_jsonDoc.fromJson(text_configData.toStdString().c_str(), &data_jsonError);
if (data_jsonError.error != QJsonParseError::NoError)
return false;
//开始解析键值
QJsonObject obj_main;//配置根(/)
QJsonObject obj_onlineSearchEngines = obj_main.value("OnlineSearchEngines").toObject();
QJsonObject obj_localCollectorEngines = obj_main.value("LocalCollectorEngines").toObject();
QJsonObject obj_workflowEngines = obj_main.value("WorkflowEngines").toObject();
QJsonObject obj_working = obj_main.value("Working").toObject();
QJsonObject obj_display = obj_main.value("Display").toObject();
configs.display.styleSheetFileName = obj_display.value("StyleSheet.Filename").toString();
return true;
} |
Beta Was this translation helpful? Give feedback.
-
无论如何，都要写出最少知识原则的代码。而且，这也是遵守SRP的一个体现：你这个函数有很多个修改它的理由，这是不对的，应该只有一个。 临时变量是栈内存，及时释放，不会对性能产生可见的影响。
宁愿操作引用也不要操作指针，看到指针，代表这段代码99%有问题（而且大多数情况下还真有问题），反之，你应该使用智能指针，借助RAII妥善管理资源。 这是编程实践啊。不要争论了，争论没有用，不如试试看 |
Beta Was this translation helpful? Give feedback.
-
|
你有这个函数，对吧： //取两段字符串的中间字符串，失败返回false
bool bText_between(QString* ret, const QString* text, QString left, QString right, int from)
{
const int start = text->indexOf(left, from);
const int from_left = start + left.length();
const int end = text->indexOf(right, from_left);
if (start == -1 || end == -1)
return false;
const int n = end - from_left;
*ret = text->mid(from_left, n);
return true;
}那么我这样: void oops(void)
{
const std::string l {"foo"}, r {"bar"}, txt {"foobar"};
std::string ret {"fooooooo"};
std::thread t1 {bText_between, &ret, &txt, l, r, 0};
std::thread t2 {bText_between, &ret, &txt, l, r, 0}; // undefined behavior
t1.join();
t2.join();
}崩溃 |
Beta Was this translation helpful? Give feedback.
-
|
刚刚又重构了一段 inline void ConfigManager::insertOnlineSearcherEnginesConfigInto(QJsonObject &obj)
{
obj.insert("OnlineSearchEngines", QJsonObject(/*empty*/));
}
inline void ConfigManager::insertLocalCollectorEnginesConfigInto(QJsonObject &obj)
{
obj.insert("LocalCollectorEngines", QJsonObject(/*empty*/));
}
inline void ConfigManager::insertWorkflowEnginesConfigInto(QJsonObject &obj)
{
obj.insert("WorkflowEngines", QJsonObject(/*empty*/));
}
inline void ConfigManager::insertWorkingConfigInto(QJsonObject &obj)
{
obj.insert("Working", QJsonObject(/*empty*/));
}
inline void ConfigManager::insertStyleSheetFileNameConfigInto(QJsonObject &obj)
{
QJsonObject obj_display;
obj_display.insert("StyleSheet.Filename", configs.display.styleSheetFileName);
obj.insert("Display", obj_display);
}
inline void ConfigManager::insertAllConfigsInto(QJsonObject &obj)
{
insertOnlineSearcherEnginesConfigInto(obj);
insertLocalCollectorEnginesConfigInto(obj);
insertWorkflowEnginesConfigInto(obj);
insertWorkingConfigInto(obj);
insertStyleSheetFileNameConfigInto(obj);
}
QJsonDocument ConfigManager::buildJsonConfig()
{
QJsonObject obj_main;//配置根(/)
insertAllConfigsInto(obj_main);
QJsonDocument data_jsonDoc;
data_jsonDoc.setObject(obj_main);
data_jsonDoc.toJson(QJsonDocument::Compact);
return data_jsonDoc;
} |
Beta Was this translation helpful? Give feedback.
-
|
这里是新增的声明： QJsonDocument buildJsonConfig();
void insertOnlineSearcherEnginesConfigInto(QJsonObject &);
void insertLocalCollectorEnginesConfigInto(QJsonObject &);
void insertWorkflowEnginesConfigInto(QJsonObject &);
void insertWorkingConfigInto(QJsonObject &);
void insertStyleSheetFileNameConfigInto(QJsonObject &);
void insertAllConfigsInto(QJsonObject &); |
Beta Was this translation helpful? Give feedback.
-
|
实际上这一段： QJsonDocument data_jsonDoc;
data_jsonDoc.setObject(obj_main);
data_jsonDoc.toJson(QJsonDocument::Compact);仍然违反了得墨忒耳律，应该再拆到另外一个函数中。值得重构。 |
Beta Was this translation helpful? Give feedback.
-
中肯的。如果你给出具体可行的建议，我会尝试去接受。(￣▽￣) |
Beta Was this translation helpful? Give feedback.
-
|
读一读Bob大叔的《代码整洁之道》 |
Beta Was this translation helpful? Give feedback.
-
|
我直接把你整个项目重构一遍吧，也当是我自己练习一下 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
All reactions