Skip to content

Commit b5020a7

Browse files
authored
Merge pull request #50 from Multiwoven/fix/source-defined-curser-default-false
fix: source_defined_cursor default value to false in stream
2 parents e3e71ff + de4072f commit b5020a7

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

integrations/Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ GIT
77
PATH
88
remote: .
99
specs:
10-
multiwoven-integrations (0.1.58)
10+
multiwoven-integrations (0.1.59)
1111
activesupport
1212
async-websocket
1313
csv

integrations/lib/multiwoven/integrations/protocol/protocol.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ class Stream < ProtocolModel
115115
attribute? :supported_sync_modes, Types::Array.of(SyncMode).optional.default(["incremental"])
116116

117117
# Applicable for database streams
118-
attribute? :source_defined_cursor, Types::Bool.default(false).optional
118+
attribute :source_defined_cursor, Types::Bool.default(false)
119119
attribute? :default_cursor_field, Types::Array.of(Types::String).optional
120120
attribute? :source_defined_primary_key, Types::Array.of(Types::Array.of(Types::String)).optional
121121
attribute? :namespace, Types::String.optional

integrations/lib/multiwoven/integrations/rollout.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
module Multiwoven
44
module Integrations
5-
VERSION = "0.1.58"
5+
VERSION = "0.1.59"
66

77
ENABLED_SOURCES = %w[
88
Snowflake

integrations/lib/multiwoven/integrations/source/salesforce_consumer_goods_cloud/schema_helper.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,9 @@ def create_json_schema_for_object(metadata)
118118
"json_schema": json_schema,
119119
"required": required,
120120
"supported_sync_modes": %w[incremental],
121-
"source_defined_primary_key": [primary_key]
121+
"source_defined_primary_key": [primary_key],
122+
"source_defined_cursor": false,
123+
"default_cursor_field": nil
122124
}
123125
end
124126
end

integrations/spec/multiwoven/integrations/source/salesforce_consumer_goods/schema_helper_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@
4545
expect(result[:json_schema]).to be_a(Hash)
4646
expect(result[:required]).to contain_exactly("Field1")
4747
expect(result[:supported_sync_modes]).to contain_exactly("incremental")
48+
expect(result[:source_defined_cursor]).to eq(false)
49+
expect(result[:default_cursor_field]).to eq(nil)
4850
end
4951
end
5052
end

0 commit comments

Comments
 (0)