Skip to content
This repository has been archived by the owner on Jul 25, 2018. It is now read-only.

Search API for relations #27

Open
syncall opened this issue Mar 26, 2017 · 10 comments
Open

Search API for relations #27

syncall opened this issue Mar 26, 2017 · 10 comments

Comments

@syncall
Copy link

syncall commented Mar 26, 2017

Hi, we from team 6 would like to have an API to query relations for one or more keywords. As a result we get a lot of relations.
It would be very good, if the relations actually refer to entities from group 1&2 (type/id). If the don't, pls make it recognizable for us in the result.

GET /relations/search?q=:param&from=:from&size=:size
:param --> some keywords realating to relations (for example: inspired by or just Beethoven)
:from --> get the results from a certain point (e.g. 20)
size: --> return just :size results

Output:
Ordered by relevance

200 --> JSON Object, e.g.: { type: "success", relations: [ ... ] }
404 --> error json { type: "error" } or similar
500 --> error json { type: "error" } or similar
@kordianbruck
Copy link
Contributor

There no model yet for the relations (see #28) but yes, this would be nice. @syncall please either implement this yourself or find someone to do it for you.

@Henni Henni self-assigned this Mar 31, 2017
@syncall
Copy link
Author

syncall commented Apr 1, 2017

Thanks for taking this issue @Henni 👍
At least from my point ov view this is quite similar to issue #33 with the GET /autosuggest part, only without the primary entity. Maybe this can be done with the same data model and in the same go?

@kordianbruck
Copy link
Contributor

@Henni this is the number 1 priority right now. By when can you finish this? Use @lgfrbcsgo to your advantage - please collab on this. We need this fast tracked so G6 can start using this.

@Henni
Copy link
Contributor

Henni commented Apr 17, 2017

Planned for tomorrow.

@sacdallago
Copy link
Member

@kordianbruck was all "I chose you" on @lgfrbcsgo right now

@goldbergtatyana
Copy link

@Henni what is the progress?

@Henni
Copy link
Contributor

Henni commented Apr 19, 2017

I'm currently still working on this, but I have a few issues with the sequelize syntax and their non existent documentation for complex queries.

@sacdallago
Copy link
Member

@Henni as @pfent suggested, by using fn you should get the ability to directly query in SQL :) Unfortunately all these wrappers fall short on complex queries, but I'm sure you'll figure it out :)

@felixschorer
Copy link

What's the current progress on this? I can implement the swagger definitions and a skeleton controller if this hasn't been done yet.

@kordianbruck
Copy link
Contributor

PR is open for that #100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants