From 35aa7b54a740c9ccace4ecddd284a39bcbe6d08e Mon Sep 17 00:00:00 2001 From: aafanasi Date: Thu, 21 Mar 2024 15:00:09 -0300 Subject: [PATCH] MTSDK-322 Unexpected CASizeTooLarge on newChat flow. - Give SessionResponse.maxCustomDataBytes a default value of CustomAttributesStoreImpl.MAX_CUSTOM_DATA_BYTES_UNSET to prevent CA validation when maxCustomDataBytes are not present in SessionResponse. - Update unit test. --- .../cloud/messenger/transport/shyrka/receive/ResponsesTests.kt | 2 ++ .../messenger/transport/shyrka/receive/SessionResponse.kt | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/transport/src/androidTest/kotlin/com/genesys/cloud/messenger/transport/shyrka/receive/ResponsesTests.kt b/transport/src/androidTest/kotlin/com/genesys/cloud/messenger/transport/shyrka/receive/ResponsesTests.kt index 37a6fb90..b8035394 100644 --- a/transport/src/androidTest/kotlin/com/genesys/cloud/messenger/transport/shyrka/receive/ResponsesTests.kt +++ b/transport/src/androidTest/kotlin/com/genesys/cloud/messenger/transport/shyrka/receive/ResponsesTests.kt @@ -7,6 +7,7 @@ import assertk.assertions.isNull import assertk.assertions.isTrue import com.genesys.cloud.messenger.transport.core.ButtonResponse import com.genesys.cloud.messenger.transport.core.ErrorCode +import com.genesys.cloud.messenger.transport.core.MAX_CUSTOM_DATA_BYTES_UNSET import com.genesys.cloud.messenger.transport.shyrka.WebMessagingJson import com.genesys.cloud.messenger.transport.utility.AttachmentValues import com.genesys.cloud.messenger.transport.utility.AuthTest @@ -125,6 +126,7 @@ class ResponsesTests { assertThat(connected).isTrue() assertThat(newSession).isTrue() assertThat(readOnly).isFalse() + assertThat(maxCustomDataBytes).isEqualTo(MAX_CUSTOM_DATA_BYTES_UNSET) } givenDefaultSessionResponseConstructor.run { assertThat(connected).isTrue() diff --git a/transport/src/commonMain/kotlin/com/genesys/cloud/messenger/transport/shyrka/receive/SessionResponse.kt b/transport/src/commonMain/kotlin/com/genesys/cloud/messenger/transport/shyrka/receive/SessionResponse.kt index df22dd23..23a40ffd 100644 --- a/transport/src/commonMain/kotlin/com/genesys/cloud/messenger/transport/shyrka/receive/SessionResponse.kt +++ b/transport/src/commonMain/kotlin/com/genesys/cloud/messenger/transport/shyrka/receive/SessionResponse.kt @@ -1,5 +1,6 @@ package com.genesys.cloud.messenger.transport.shyrka.receive +import com.genesys.cloud.messenger.transport.core.MAX_CUSTOM_DATA_BYTES_UNSET import kotlinx.serialization.Serializable @Serializable @@ -7,5 +8,5 @@ internal data class SessionResponse( val connected: Boolean, val newSession: Boolean = false, val readOnly: Boolean = false, - val maxCustomDataBytes: Int = 0 + val maxCustomDataBytes: Int = MAX_CUSTOM_DATA_BYTES_UNSET, )