[dkg-cli] Python wrapper and simplified steps #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benr-ml
reviewed
Nov 27, 2025
|
|
||
| ```bash | ||
| cargo run --bin dkg-cli process-all --messages-dir ./dkg-messages | ||
| **For new members**: Just run the command without old share. |
Collaborator
Author
There was a problem hiding this comment.
i did not like the rename from init to create-message from last pr since a new member is just initializing the state locally here.
seal/crates/dkg-cli/src/main.rs
Line 325 in 31b5a53
| ``` | ||
|
|
||
| TODO: Discuss what to do with old share. | ||
| Store your old master share securely. It is needed for future rotation. |
Collaborator
Author
There was a problem hiding this comment.
because a continuing member in dkg needs to create message with the old share?
Collaborator
Author
There was a problem hiding this comment.
pub fn new_advanced<R: AllowedRng>(
enc_sk: ecies_v1::PrivateKey<EG>,
nodes: Nodes<EG>,
t: u16, // The number of parties that are needed to reconstruct the full key/signature (f+1).
random_oracle: RandomOracle, // Should be unique for each invocation, but the same for all parties.
secret: Option<G::ScalarType>, // Should be used only for key rotation. <= this
old_t: Option<u16>, // Used only for key rotation
rng: &mut R,
) -> FastCryptoResult<Self> {
joyqvq
force-pushed
the
joy/dkg-cli-improve
branch
from
31b5a53 to
d2fb869
Compare
- fix license
joyqvq
force-pushed
the
joy/dkg-cli-improve
branch
from
a3bc3c3 to
016ee3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create wrapper to cargo commands and sui cli to simplify the dkg steps.
Test plan
tested local rotations 0 -> 1 -> 2