[1/2][aggregator-server] set up server crate with todos #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyqvq
force-pushed
the
joy/aggregator-server
branch
from
76840ea to
758aa00
Compare
joyqvq
force-pushed
the
joy/aggregator-server
branch
from
758aa00 to
0e5df2d
Compare
benr-ml
approved these changes
Dec 7, 2025
| sui-rpc = "0.1.0" | ||
| tonic = "0.14" | ||
|
|
||
| axum = { version = "0.8", features = ["macros"] } |
Collaborator
There was a problem hiding this comment.
let's use those from the other crates
| @@ -0,0 +1,32 @@ | |||
| # Aggregator Server | |||
|
|
|||
| Aggregator server for Seal committee mode. It fetches encrypted partial keys from committee member servers, verifies encrypted signatures. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| Aggregator server for Seal committee mode. It fetches encrypted partial keys from committee member servers, verifies encrypted signatures. | |
| Aggregator server for a Seal committee. It fetches encrypted partial keys from committee member servers, verifies encrypted signatures. |
| # Aggregator Server | ||
|
|
||
| Aggregator server for Seal committee mode. It fetches encrypted partial keys from committee member servers, verifies encrypted signatures. | ||
|
|
Collaborator
There was a problem hiding this comment.
also mention that it uses private api keys for accessing the key servers
|
|
||
| let app = get_mysten_service::<AppState>(package_name!(), package_version!()) | ||
| .merge(Router::new().route("/v1/fetch_key", post(handle_fetch_key))) | ||
| .with_state(state) |
Collaborator
There was a problem hiding this comment.
let's also have /service return error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a scaffolding to agree on the design and high level steps.
Test plan
it runs.