Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibilities with PHP 5.6 #12

Open
bereldhuin opened this issue Nov 17, 2020 · 0 comments
Open

Incompatibilities with PHP 5.6 #12

bereldhuin opened this issue Nov 17, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@bereldhuin
Copy link

Hi,

Trying to make my app comaptible with PHP 7.3, I discovered your repo updating the original HMVC wich I used for years now on PHP 5.6.

It works fine on PHP 7.3, but I have an error on PHP 5.6.40 (Debian Jessie) :

Severity: Parsing Error

Message: syntax error, unexpected '='

Filename: MX/Router.php

Line Number: 154

After commenting the corresponding line, I have an other error ,which is harder to deal with by simply commenting it ;-) :

Severity: Parsing Error

Message: syntax error, unexpected '?'

Filename: MX/Modules.php

Line Number: 78

Looking further in the code, there are many places where Netbeans raises incompatibility error with PHP5.6.

Maybe you should mention this code is only compatible with PHP7+, as the original version is working fine on 5.6.

Any way thanks for your job on the 7+ compatibility which is what's interesting me.

@bereldhuin bereldhuin added the bug Something isn't working label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants