Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out the customized part of jquery-ui.css #244

Open
childers opened this issue Oct 12, 2018 · 4 comments
Open

Figure out the customized part of jquery-ui.css #244

childers opened this issue Oct 12, 2018 · 4 comments
Assignees

Comments

@childers
Copy link
Contributor

When I worked on #631 today, I found that jquery-ui.css (used in result page of blast search) is a customized version of jquery-ui.css, although its name looks like without customized. We should figure out customized part and separate that part from library. That will make our future upgrade more easily. To figure out which part is customized, I noticed that the orange background in result page of blast search comes from that file.

@deming7h777
Copy link
Contributor

only different

I found the difference between jquery-ui.css and jquery-ui-custom.css .
1. remove the tooltip.css which existed in jquery-ui.css
2. remove the tabs.css which existed in jquery-ui.css
3. remove the accordion.css which existed in jquery-ui.css
4. remove the autocomplete.css which existed in jquery-ui.css
5. remove the button.css which existed in jquery-ui.css
6. remove the datepicker.css which existed in jquery-ui.css
7. remove the dialog.css which existed in jquery-ui.css
8. remove the menu.css which existed in jquery-ui.css
9. remove the progressbar.css which existed in jquery-ui.css
10. remove the selectmenu.css which existed in jquery-ui.css
11. remove the spinner.css which existed in jquery-ui.css
12. change background color of widget shadow (attached)

@hsiaoyi0504
Copy link
Member

It would be good to specify the changes with line numbers ...

@hsiaoyi0504
Copy link
Member

At least for what I can imagine right now based on the description above, most of the changes are not very important and actually affect anything except the 12.

@deming7h777
Copy link
Contributor

deming7h777 commented Oct 18, 2018

For now , I think jquery-ui-custom.js can replace by jquery-ui.js, it will be updated easily in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants