From b319ffdfa8298fbc6872c70a0b8871186c12550c Mon Sep 17 00:00:00 2001 From: Ryan Goetz Date: Wed, 5 Jun 2024 12:53:41 -1000 Subject: [PATCH 1/2] Allow eDSL relative times to have Days (DDD). * This matches with the SeqN editor and allows for us to merge the frontend 'eDSL' and 'SeqN' time libraries together. --- sequencing-server/src/lib/codegen/CommandEDSLPreface.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/sequencing-server/src/lib/codegen/CommandEDSLPreface.ts b/sequencing-server/src/lib/codegen/CommandEDSLPreface.ts index 40b670bbd0..4331969ab8 100644 --- a/sequencing-server/src/lib/codegen/CommandEDSLPreface.ts +++ b/sequencing-server/src/lib/codegen/CommandEDSLPreface.ts @@ -3287,7 +3287,6 @@ export function hmsToDuration(hms: HMS_STRING, epoch: boolean = false): Temporal if (!epoch) { if (isNegative) {throw new Error(`Signed time (+/-) is not allowed for Relative Times: ${hms}`);} - if (daysNum !== 0) {throw new Error(`Day (DDD) is not allowed for Relative Times: ${hms}`);} } return Temporal.Duration.from({ days: isNegative ? -daysNum : daysNum, From 1e66caa9d6a7b71b2e475bda114247777befb446 Mon Sep 17 00:00:00 2001 From: Ryan Goetz Date: Wed, 5 Jun 2024 13:59:47 -1000 Subject: [PATCH 2/2] Update e2e snapshot --- sequencing-server/test/__snapshots__/command-types.spec.ts.snap | 1 - 1 file changed, 1 deletion(-) diff --git a/sequencing-server/test/__snapshots__/command-types.spec.ts.snap b/sequencing-server/test/__snapshots__/command-types.spec.ts.snap index c2d777396c..b18805597b 100644 --- a/sequencing-server/test/__snapshots__/command-types.spec.ts.snap +++ b/sequencing-server/test/__snapshots__/command-types.spec.ts.snap @@ -3290,7 +3290,6 @@ export function hmsToDuration(hms: HMS_STRING, epoch: boolean = false): Temporal if (!epoch) { if (isNegative) {throw new Error(\`Signed time (+/-) is not allowed for Relative Times: \${hms}\`);} - if (daysNum !== 0) {throw new Error(\`Day (DDD) is not allowed for Relative Times: \${hms}\`);} } return Temporal.Duration.from({ days: isNegative ? -daysNum : daysNum,