Document repository page and the search results show different sets of documents

[sunu]

The document repository page at /documents shows all documents accessible to the current user. But once we search for a particular query on the documents repository page, the results only include results from public documents. This inconsistency can be confusing for users.

We should let users search through all documents they have access to or show only public documents on the document repository page to be consistent.

[bwbaker1]

@wrynearson @sunu This was recently brought to my attention while meeting with a user. I didn't realize that a user can see every single document that is published or a draft (including drafts they are not collaborators on). I think it is best to only show public documents from the "Explore existing documents" tab (see image below). They can see their own documents from the dashboard. Nonetheless, they do not need access to others drafts.

[kamicut]

This issue involves two changes:

• /documents/ should only show public documents
• The dashboard should only show the user's documents, published documents, and drafts they are a collaborator on

@bwbaker1 can you confirm?

[wrynearson]

@bwbaker1 for the 2nd issue, we have two dashboards. One for document contributors/reviewers (1), and one for administrators (2).

1. 
2. 

For the admin dashboard (2), we should be able to see all documents, regardless of their status. Can you confirm that the user is seeing all reports in their dashboard but should only have access to the contributor/reviewer (1) dashboard?

[bwbaker1]

@wrynearson @kamicut There shouldn't be any changes to either the user or admin dashboard. These show the documents correctly. The only needed change is /documents/ should only show published documents. This is true whether a user is logged in or not.

[sunu]

I've created a PR in the frontend repo with a fix: NASA-IMPACT/nasa-apt-frontend#587

[wrynearson]

@bwbaker1 this is ready for your review

[bwbaker1]

@wrynearson This looks good! It's ready for production.