Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document repository page and the search results show different sets of documents #759

Closed
Tracked by #872
sunu opened this issue Jun 21, 2023 · 7 comments · Fixed by NASA-IMPACT/nasa-apt-frontend#587
Assignees

Comments

@sunu
Copy link
Collaborator

sunu commented Jun 21, 2023

The document repository page at /documents shows all documents accessible to the current user. But once we search for a particular query on the documents repository page, the results only include results from public documents. This inconsistency can be confusing for users.

We should let users search through all documents they have access to or show only public documents on the document repository page to be consistent.

@sunu sunu transferred this issue from NASA-IMPACT/nasa-apt-frontend Jun 21, 2023
@bwbaker1
Copy link
Collaborator

bwbaker1 commented Jun 7, 2024

@wrynearson @sunu This was recently brought to my attention while meeting with a user. I didn't realize that a user can see every single document that is published or a draft (including drafts they are not collaborators on). I think it is best to only show public documents from the "Explore existing documents" tab (see image below). They can see their own documents from the dashboard. Nonetheless, they do not need access to others drafts.

Image

@kamicut
Copy link
Collaborator

kamicut commented Jul 5, 2024

This issue involves two changes:

  • /documents/ should only show public documents
  • The dashboard should only show the user's documents, published documents, and drafts they are a collaborator on

@bwbaker1 can you confirm?

@wrynearson
Copy link
Member

@bwbaker1 for the 2nd issue, we have two dashboards. One for document contributors/reviewers (1), and one for administrators (2).

  1. image
  2. image

For the admin dashboard (2), we should be able to see all documents, regardless of their status. Can you confirm that the user is seeing all reports in their dashboard but should only have access to the contributor/reviewer (1) dashboard?

@bwbaker1
Copy link
Collaborator

bwbaker1 commented Jul 5, 2024

@wrynearson @kamicut There shouldn't be any changes to either the user or admin dashboard. These show the documents correctly. The only needed change is /documents/ should only show published documents. This is true whether a user is logged in or not.

@sunu
Copy link
Collaborator Author

sunu commented Jul 22, 2024

I've created a PR in the frontend repo with a fix: NASA-IMPACT/nasa-apt-frontend#587

@wrynearson
Copy link
Member

@bwbaker1 this is ready for your review

@bwbaker1
Copy link
Collaborator

bwbaker1 commented Aug 6, 2024

@wrynearson This looks good! It's ready for production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants