From f204f03cb79e7863ef14ce04d3cf52947293d5c3 Mon Sep 17 00:00:00 2001 From: Kyle Shores Date: Tue, 24 Sep 2024 10:33:10 -0600 Subject: [PATCH] defaulting LU to 0 instead of 1e-30 --- include/micm/solver/solver_builder.inl | 2 +- test/unit/cuda/solver/test_cuda_lu_decomposition.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/micm/solver/solver_builder.inl b/include/micm/solver/solver_builder.inl index ee188134e..10677664a 100644 --- a/include/micm/solver/solver_builder.inl +++ b/include/micm/solver/solver_builder.inl @@ -386,7 +386,7 @@ namespace micm auto jacobian = BuildJacobian(nonzero_elements, this->number_of_grid_cells_, number_of_species); rates.SetJacobianFlatIds(jacobian); - LinearSolverPolicy linear_solver(jacobian, 1e-30); + LinearSolverPolicy linear_solver(jacobian, 0); std::vector variable_names{ number_of_species }; for (auto& species_pair : species_map) diff --git a/test/unit/cuda/solver/test_cuda_lu_decomposition.cpp b/test/unit/cuda/solver/test_cuda_lu_decomposition.cpp index 58ae0138c..80c5c6600 100644 --- a/test/unit/cuda/solver/test_cuda_lu_decomposition.cpp +++ b/test/unit/cuda/solver/test_cuda_lu_decomposition.cpp @@ -40,7 +40,7 @@ void testCudaRandomMatrix(size_t n_grids) micm::CudaLuDecomposition gpu_lud(gpu_A); - auto gpu_LU = micm::CudaLuDecomposition::GetLUMatrices(gpu_A, 1.0e-30); + auto gpu_LU = micm::CudaLuDecomposition::GetLUMatrices(gpu_A, 0); gpu_A.CopyToDevice(); gpu_LU.first.CopyToDevice(); gpu_LU.second.CopyToDevice(); @@ -51,7 +51,7 @@ void testCudaRandomMatrix(size_t n_grids) gpu_A, gpu_LU.first, gpu_LU.second, [&](const double a, const double b) -> void { EXPECT_LT(std::abs((a-b)/b), 1.0e-03); }); micm::LuDecomposition cpu_lud = micm::LuDecomposition::Create(cpu_A); - auto cpu_LU = micm::LuDecomposition::GetLUMatrices(cpu_A, 1.0e-30); + auto cpu_LU = micm::LuDecomposition::GetLUMatrices(cpu_A, 0); bool singular{ false }; cpu_lud.Decompose(cpu_A, cpu_LU.first, cpu_LU.second, singular);