add error handler for init()

Author: tbauriedel

internal/arguments/arguments.go

@@ -43,7 +43,7 @@ func New() Handler {
 	}
 }
 
-func (args *Handler) CollectArgsFromStdin(availableModules string) {
+func (args *Handler) CollectArgsFromStdin(availableModules string) []error {
 	fmt.Printf(interactiveHelpText+"\n\n", availableModules)
 
 	var errors []error
@@ -59,8 +59,10 @@ func (args *Handler) CollectArgsFromStdin(availableModules string) {
 			continue
 		}
 
-		errors = append(errors, fmt.Errorf("%s is not matching the needed depenency", argument.Name))
+		errors = append(errors, fmt.Errorf("argument '%s' is not matching the needed depenency. Skipping... ", argument.Name))
 	}
+
+	return errors
 }
 
 func (args *Handler) NewPromptStringVar(callback *string, name, defaultValue, usage string, required bool, dependency func() bool) {
@@ -131,8 +133,6 @@ func (args *Handler) newStringPrompt(callback *string, defaultValue, usage strin
 			}
 		}
 	}
-
-	return
 }
 
 func (args *Handler) newBoolPrompt(callback *bool, defaultValue bool, usage string) {

main.go

@@ -114,6 +114,7 @@ var (
 	commandTimeout                                    = 60 * time.Second
 	startTime                                         = time.Now()
 	metric                                            *metrics.Metrics
+	initErrors                                        []error
 )
 
 func init() {
@@ -130,8 +131,8 @@ func init() {
 
 	// Run specific arguments
 	args.NewPromptStringVar(&outputFile, "output", buildFileName(), "Filename for resulting zip", true, nil)
-	args.NewPromptStringSliceVar(&enabledModules, "enable", moduleOrder, "Enabled modules for collection (comma seperated)", false, nil)
-	args.NewPromptStringSliceVar(&disabledModules, "disable", []string{}, "Explicit disabled modules for collection (comma seperated)", false, nil)
+	args.NewPromptStringSliceVar(&enabledModules, "enable", moduleOrder, "Enabled modules for collection (comma separated)", false, nil)
+	args.NewPromptStringSliceVar(&disabledModules, "disable", []string{}, "Explicit disabled modules for collection (comma separated)", false, nil)
 	args.NewPromptBoolVar(&noDetailedCollection, "no-details", false, "Disable detailed collection including logs and more", nil)
 
 	// Icinga 2 specific arguments
@@ -160,7 +161,7 @@ func init() {
 
 	// Start interactive wizard if interactive is enabled
 	if !arguments.NonInteractive {
-		args.CollectArgsFromStdin(strings.Join(moduleOrder, ","))
+		initErrors = args.CollectArgsFromStdin(strings.Join(moduleOrder, ","))
 	}
 
 	// Verify enabled modules
@@ -193,6 +194,13 @@ func main() {
 	// Close collection
 	defer closeCollection()
 
+	// Check for errors in init()
+	if len(initErrors) > 0 {
+		for _, err := range initErrors {
+			c.Log.Info(err)
+		}
+	}
+
 	// Initialize new metrics and defer function to save it to json
 	metric = metrics.New(getVersion())
 	defer func() {