Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop PrestoGP into Parsnip model #22

Open
kyle-messier opened this issue Feb 27, 2024 · 3 comments
Open

Develop PrestoGP into Parsnip model #22

kyle-messier opened this issue Feb 27, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@kyle-messier
Copy link
Collaborator

No description provided.

@kyle-messier kyle-messier added the enhancement New feature or request label Feb 27, 2024
@kyle-messier kyle-messier self-assigned this Feb 27, 2024
@sigmafelix
Copy link
Collaborator

I looked into defining a parsnip model for PrestoGP here, but it doesn't look very promising as parsnip interface is friendly to S3.

@kyle-messier
Copy link
Collaborator Author

And not S4 friendly? PrestoGP is S4

@sigmafelix
Copy link
Collaborator

It looks like parsnip assumes that standard interface of fit and predict (S3 methods) are available in original models to be registered in parsnip. fit and predict takes x and y or formula and data unless certain model class has its own fit method. This is incompatible with S4 interface of PrestoGP (standardGeneric functions prestogp_fit and prestogp_predict operating at model objects (e.g., PrestoGPModel(), VecchiaModel(), etc.).

I tried changing the argument names of prestogp_* into x and y to check if the problem is related to the failure of matching argument names, and I found another error message that is not documented well.

matrix_ is unknown.

I will revisit this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants