From b2b85577490950bd2084f000a8371b2d7d107644 Mon Sep 17 00:00:00 2001
From: Mark Nestor Costantini <mnc33@cam.ac.uk>
Date: Tue, 12 Mar 2024 10:09:45 +0000
Subject: [PATCH] added ratio bias variance to multi closure report

---
 .../multiclosure_analysis.yaml                | 24 ++++++-------------
 .../multiclosure_template.md                  |  3 +++
 .../pca_template.md                           |  3 ---
 3 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/validphys2/src/validphys/compareinconsistentclosuretemplates/multiclosure_analysis.yaml b/validphys2/src/validphys/compareinconsistentclosuretemplates/multiclosure_analysis.yaml
index 65dfaf3cfd..cf27fa9796 100644
--- a/validphys2/src/validphys/compareinconsistentclosuretemplates/multiclosure_analysis.yaml
+++ b/validphys2/src/validphys/compareinconsistentclosuretemplates/multiclosure_analysis.yaml
@@ -146,25 +146,19 @@ compare_settings:
 
 ##################################################################
 #OTHER ANALYSIS SETTINGS
+
 fit: 230124_dis_ict_lam02_fs_122996
 theory:
   from_: fit
 theoryid:
   from_: theory
-use_cuts: "internal"
+use_cuts: internal
+
 lambdavalues:
   - label: "LAMBDA02"
     lambda_value: 0.2
-    fit: 230124_dis_ict_lam02_fs_122996
-    dataset_inputs:
-      from_: fit
-    theory:
-      from_: fit
-    theoryid:
-      from_: theory
     use_t0: True
     t0pdfset: 210223-mw-000_fakepdf
-    use_cuts: "internal"
     explained_variance_ratio: 0.99
     variancepdf: 230124_dis_ict_lam02_fs_122996
     fits:
@@ -196,16 +190,8 @@ lambdavalues:
       - 230124_dis_ict_lam02_fs_966390
   - label: "LAMBDA04"
     lambda_value: 0.4
-    fit: 250124_dis_ict_lam04_fs_102661
-    dataset_inputs:
-      from_: fit
-    theory:
-      from_: fit
-    theoryid:
-      from_: theory
     use_t0: True
     t0pdfset: 210223-mw-000_fakepdf
-    use_cuts: "internal"
     explained_variance_ratio: 0.99
     variancepdf: 250124_dis_ict_lam04_fs_102661
     fits:
@@ -247,6 +233,10 @@ single_point_report:
 pca_report:
   meta: Null
   template: pca_template.md
+ratio_bias_variance_report:
+  meta: Null
+  template: ratio_biasvar_template.md
 
+ 
 actions_:
   - report(main=true)
diff --git a/validphys2/src/validphys/compareinconsistentclosuretemplates/multiclosure_template.md b/validphys2/src/validphys/compareinconsistentclosuretemplates/multiclosure_template.md
index 7ad062bd09..aff62f9182 100644
--- a/validphys2/src/validphys/compareinconsistentclosuretemplates/multiclosure_template.md
+++ b/validphys2/src/validphys/compareinconsistentclosuretemplates/multiclosure_template.md
@@ -12,3 +12,6 @@ Bias Variance Ratio Table
 {@with lambdavalues@}
 [Lambda value of {@label@}]({@pca_report report@})
 {@endwith@}
+
+
+[Ratio bias variance vs Lambda]({@ratio_bias_variance_report report@})
diff --git a/validphys2/src/validphys/compareinconsistentclosuretemplates/pca_template.md b/validphys2/src/validphys/compareinconsistentclosuretemplates/pca_template.md
index 7fba0826e8..2f308bd701 100644
--- a/validphys2/src/validphys/compareinconsistentclosuretemplates/pca_template.md
+++ b/validphys2/src/validphys/compareinconsistentclosuretemplates/pca_template.md
@@ -3,8 +3,5 @@
 ## Table of bias and variance
 {@table_bias_variance_datasets@}
 
-## Ratio bias variance vs Lambda
-{@plot_lambdavalues_bias_variance_values@}
-
 ## L2 condition number
 {@plot_l2_condition_number@}