Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace plotoptions commondata functionality with commondataparser #1172

Closed
Zaharid opened this issue Mar 26, 2021 · 3 comments
Closed

Replace plotoptions commondata functionality with commondataparser #1172

Zaharid opened this issue Mar 26, 2021 · 3 comments
Assignees

Comments

@Zaharid
Copy link
Contributor

Zaharid commented Mar 26, 2021

I am towing around with the commondata parser and it is so much nicer than the older interface. For example in that it keeps the cuts info. Would be great to have it used in places like

table = pd.DataFrame(data.get_kintable(), columns=default_labels[1:])
(and that whole subpackage really) and propagated properly to the relevant parts of dataplots.py (which might allow to clean up the code of plot_fancy, which is anything but).

@Zaharid Zaharid changed the title Replace plotoptions commondata functioality with commondataparser Replace plotoptions commondata functionality with commondataparser Mar 26, 2021
@RosalynLP
Copy link
Contributor

@Zaharid So here are we talking about actually using the new CommonData python objects and then using something like data.systype_table() here? Or do you mean just use the parse_commondata action? In which case I'm not entirely sure what you have in mind - could you please clarify/give an example?

@Zaharid
Copy link
Contributor Author

Zaharid commented Apr 1, 2021

The former. Basically never call commondata.load in the module and use the python stuff instead. That would likely spill to plot_fancy and some other places, which would help simplifying them; dealing with cuts is a big annoyance in there.

@scarlehoff
Copy link
Member

Done in #1678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants