Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test implementations of new commondata format #1436

Closed
Zaharid opened this issue Oct 15, 2021 · 9 comments
Closed

Create test implementations of new commondata format #1436

Zaharid opened this issue Oct 15, 2021 · 9 comments
Assignees
@cschwan @alecandido @enocera @scarlehoff
Labels
data toolchain

Comments

@Zaharid
Copy link
Contributor

Zaharid commented Oct 15, 2021

To make things in #1416 more concrete we agreed to try and produce test implementations of the (still fuzzy) current version of the idea for a couple of datasets.

The datasets should be one DIS and one hadronic and one of them should involve multiple (COMPOUND) fktables.

These should have:

  • A metadata file with the informations in the "runcards" folder, PLOTTING file, COMPOUND file and others.
  • A kinematics file with bin edges and central value in some format.
  • A data file with experimental central value and uncertainties (probably in a separate file).

The uncertainties should support a way of specifying correlated systematics across datasets. Probably also some way to deal with additive vs multiplicative.

Regarding formats, I would think for this a text format of some sort is more adequate (easier to read and exchange around) and also one that trivially round trips with pandas (ie better than csv), so maybe something like json.
@enocera
Copy link
Contributor

enocera commented Nov 10, 2021 •
edited
Loading

Let me see whether I can make any of the above a little more concrete. For the time being, let's focus on the dataset currently called NMCPD. It corresponds to the F2d/F2p ratio measured by NMC. This is the only COMPOUND DIS dataset.
I understand that we want the following files.

  1. * A metadata file with the informations in the "runcards" folder, PLOTTING file, COMPOUND file and others.

My understanding is that this is the first file that a developer would write when implementing a new dataset (or migrating an old dataset to the new format). I think that it should be as simple (minimal) as possible. Let's call it METADATA_NMCPD.json. A possible incarnation may look like as follows.

{
    "setname":  "NMPCPD",
    "arXiv":    "hep-ex/9611022",
    "hepdata":  "https://www.hepdata.net/record/ins426595",
    "ndata":    260,
    "nsys_exp": 5, 
    "proctype": "DIS_F2R",
    "compound": "RATIO",
    "experiment": "NMC",
    "nnpdf31_process": "DIS NC"
}

Here I already have some questions:

  • how are COMPOUND datasets treated by the new tool chain that produces FK tables?
  • which kind of information is actually required from the PLOTTING file?
  • which information should we import from the metadata.txt in the "runcard" folder?
  1. * A kinematics file with bin edges and central value in some format.

  2. * A data file with experimental central value and uncertainties (probably in a separate file).

I understand that these files should be the output of a small python script (for each dataset) that would eventually replace the current filter files in buildmaster. The file METADATA_<nameexp>.json is used as input to such a python script. Let's call the outputs KINEMATICS_NMCPD.json, DATA_NMCPD.json and EXP_UNCS_NMCPD.json. Possible incarnations of these outputs may look like as follows.

KINEMATICS_NMCPD.json 
```
{
    "kinematics_avg": [
	{ "x": [0.0015,
		0.0015,
		0.0015,
		0.0015,
		0.0015,
		0.003,
		0.003,
		0.003,
		0.003,
		0.003,
		0.003,
		0.003,
		0.005,
		0.005,
		0.005,
		0.005,
		0.005,
		0.005,
		0.005,
		0.005,
		0.005,
		0.008,
		0.008,
		0.008,
		0.008,
		0.008,
		0.008,
		0.008,
		0.008,
		0.008,
		0.008,
		0.008,
		0.008,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0125,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.0175,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.025,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.035,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.05,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.07,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.09,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.11,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.14,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.18,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.225,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.275,
		0.35,
		0.35,
		0.35,
		0.35,
		0.35,
		0.35,
		0.35,
		0.35,
		0.35,
		0.35,
		0.35,
		0.35,
		0.35,
		0.45,
		0.45,
		0.45,
		0.45,
		0.45,
		0.45,
		0.45,
		0.45,
		0.45,
		0.45,
		0.45,
		0.45,
		0.55,
		0.55,
		0.55,
		0.55,
		0.55,
		0.55,
		0.55,
		0.55,
		0.55,
		0.55,
		0.55,
		0.675,
		0.675,
		0.675,
		0.675,
		0.675,
		0.675,
		0.675,
		0.675,
		0.675,
		0.675
	       ] },
	{ "Q2": [0.16,
		 0.25,
		 0.35,
		 0.45,
		 0.6,
		 0.17,
		 0.25,
		 0.35,
		 0.45,
		 0.63,
		 0.88,
		 1.12,
		 0.16,
		 0.25,
		 0.35,
		 0.45,
		 0.61,
		 0.88,
		 1.13,
		 1.38,
		 1.71,
		 0.16,
		 0.25,
		 0.35,
		 0.45,
		 0.64,
		 0.86,
		 1.12,
		 1.37,
		 1.75,
		 2.24,
		 2.73,
		 3.46,
		 0.16,
		 0.26,
		 0.35,
		 0.45,
		 0.62,
		 0.88,
		 1.12,
		 1.37,
		 1.74,
		 2.23,
		 2.74,
		 3.46,
		 4.47,
		 5.41,
		 0.25,
		 0.35,
		 0.45,
		 0.62,
		 0.88,
		 1.12,
		 1.37,
		 1.75,
		 2.24,
		 2.73,
		 3.48,
		 4.47,
		 5.49,
		 6.83,
		 0.26,
		 0.35,
		 0.45,
		 0.62,
		 0.86,
		 1.13,
		 1.37,
		 1.74,
		 2.24,
		 2.74,
		 3.45,
		 4.47,
		 5.48,
		 6.92,
		 8.92,
		 0.36,
		 0.45,
		 0.64,
		 0.86,
		 1.13,
		 1.38,
		 1.74,
		 2.24,
		 2.74,
		 3.46,
		 4.45,
		 5.47,
		 6.92,
		 8.96,
		 11.45,
		 14.36,
		 0.46,
		 0.61,
		 0.88,
		 1.13,
		 1.37,
		 1.74,
		 2.25,
		 2.74,
		 3.46,
		 4.46,
		 5.46,
		 6.9,
		 8.93,
		 11.44,
		 14.82,
		 19.19,
		 0.68,
		 0.86,
		 1.11,
		 1.38,
		 1.74,
		 2.24,
		 2.75,
		 3.47,
		 4.47,
		 5.47,
		 6.91,
		 8.91,
		 11.4,
		 14.89,
		 19.63,
		 26.07,
		 0.9,
		 1.11,
		 1.38,
		 1.76,
		 2.24,
		 2.75,
		 3.49,
		 4.47,
		 5.46,
		 6.91,
		 8.92,
		 11.37,
		 14.87,
		 19.74,
		 26.36,
		 34.74,
		 1.13,
		 1.38,
		 1.75,
		 2.24,
		 2.74,
		 3.49,
		 4.47,
		 5.46,
		 6.9,
		 8.92,
		 11.37,
		 14.85,
		 19.74,
		 26.52,
		 35.32,
		 44.94,
		 1.4,
		 1.75,
		 2.24,
		 2.74,
		 3.47,
		 4.48,
		 5.47,
		 6.9,
		 8.92,
		 11.37,
		 14.84,
		 19.76,
		 26.55,
		 35.28,
		 46.95,
		 1.82,
		 2.24,
		 2.75,
		 3.47,
		 4.47,
		 5.49,
		 6.92,
		 8.93,
		 11.37,
		 14.85,
		 19.75,
		 26.61,
		 35.37,
		 47.01,
		 63.04,
		 2.28,
		 2.74,
		 3.48,
		 4.47,
		 5.47,
		 6.97,
		 8.93,
		 11.38,
		 14.85,
		 19.74,
		 26.64,
		 35.42,
		 46.95,
		 63.23,
		 2.78,
		 3.46,
		 4.47,
		 5.47,
		 6.89,
		 8.94,
		 11.37,
		 14.87,
		 19.74,
		 26.6,
		 35.43,
		 46.98,
		 63.48,
		 90.68,
		 3.57,
		 4.51,
		 5.48,
		 6.9,
		 8.91,
		 11.43,
		 14.85,
		 19.74,
		 26.63,
		 35.45,
		 47.12,
		 63.52,
		 96.35,
		 4.54,
		 5.47,
		 6.93,
		 8.92,
		 11.34,
		 14.89,
		 19.77,
		 26.64,
		 35.5,
		 47.26,
		 63.65,
		 98.05,
		 5.53,
		 6.88,
		 8.91,
		 11.34,
		 14.85,
		 19.74,
		 26.64,
		 35.57,
		 47.16,
		 63.56,
		 98.82,
		 7.04,
		 8.88,
		 11.36,
		 14.85,
		 19.79,
		 26.49,
		 35.4,
		 47.03,
		 63.53,
		 99.03
		] },
	{ "y" : [0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0,
		 0.0
		] }
    ]
    "kinematics_min": [
	{ "x": null },
	{ "Q2": null },
	{ "y": null }
    ]
    "kinematics_max": [
	{ "x": null },
	{ "Q2": null },
	{ "y": null }
    ]
}
```
DATA_NMCPD.json 
```
{
    "data" : [0.9815,
	      1.003,
	      0.9675,
	      1.033,
	      0.9912,
	      1.008,
	      0.9824,
	      0.9825,
	      0.9736,
	      0.9704,
	      0.9921,
	      0.9959,
	      1.005,
	      1,
	      1.014,
	      0.9945,
	      0.9795,
	      0.9966,
	      0.9893,
	      0.9959,
	      0.9842,
	      0.9817,
	      1.011,
	      0.9993,
	      1.02,
	      0.9618,
	      0.9775,
	      0.9642,
	      0.9714,
	      0.9891,
	      0.975,
	      0.9837,
	      0.9924,
	      0.9683,
	      1.008,
	      0.953,
	      0.969,
	      0.9872,
	      0.968,
	      0.9624,
	      0.9797,
	      0.9747,
	      0.9738,
	      0.9813,
	      0.9844,
	      0.9734,
	      0.9821,
	      0.9573,
	      0.9747,
	      1.007,
	      0.9939,
	      0.9645,
	      0.9685,
	      0.9834,
	      0.9925,
	      0.9763,
	      0.968,
	      0.9761,
	      0.9716,
	      0.9817,
	      0.9942,
	      0.9493,
	      0.9601,
	      0.9408,
	      0.962,
	      0.9585,
	      0.9631,
	      0.9849,
	      0.9802,
	      0.9677,
	      0.9581,
	      0.979,
	      0.9764,
	      0.9592,
	      0.9893,
	      0.9738,
	      0.9557,
	      0.9264,
	      0.9308,
	      0.9618,
	      0.9723,
	      0.9633,
	      0.9554,
	      0.9572,
	      0.9766,
	      0.9565,
	      0.9611,
	      0.9669,
	      0.9817,
	      0.9686,
	      0.9572,
	      0.9439,
	      0.9101,
	      0.9539,
	      0.9204,
	      0.9738,
	      0.94,
	      0.9532,
	      0.9526,
	      0.9642,
	      0.9597,
	      0.9551,
	      0.9577,
	      0.9682,
	      0.9578,
	      0.9532,
	      0.9698,
	      0.9635,
	      0.9488,
	      0.9595,
	      1.001,
	      0.981,
	      0.971,
	      0.9477,
	      0.9449,
	      0.9486,
	      0.937,
	      0.945,
	      0.9367,
	      0.9394,
	      0.9328,
	      0.9432,
	      0.9371,
	      0.9592,
	      0.9678,
	      0.9351,
	      0.9385,
	      0.9413,
	      0.9313,
	      0.9445,
	      0.936,
	      0.9397,
	      0.942,
	      0.9245,
	      0.9218,
	      0.9254,
	      0.9291,
	      0.9319,
	      0.9554,
	      0.9233,
	      0.9264,
	      0.9005,
	      0.9227,
	      0.915,
	      0.9292,
	      0.9205,
	      0.9114,
	      0.9409,
	      0.9291,
	      0.9266,
	      0.9263,
	      0.9272,
	      0.9123,
	      0.9272,
	      0.905,
	      0.9039,
	      0.914,
	      0.9427,
	      0.9056,
	      0.9223,
	      0.8966,
	      0.9132,
	      0.9242,
	      0.9212,
	      0.9147,
	      0.8981,
	      0.9068,
	      0.9018,
	      0.8924,
	      0.905,
	      0.8453,
	      0.8859,
	      0.8781,
	      0.9173,
	      0.8983,
	      0.8811,
	      0.9134,
	      0.8869,
	      0.8622,
	      0.8676,
	      0.8787,
	      0.862,
	      0.8684,
	      0.8641,
	      0.8715,
	      0.897,
	      0.8552,
	      0.8761,
	      0.8714,
	      0.8702,
	      0.8445,
	      0.8607,
	      0.8464,
	      0.8534,
	      0.8549,
	      0.8617,
	      0.8651,
	      0.867,
	      0.8343,
	      0.8218,
	      0.8219,
	      0.8637,
	      0.8542,
	      0.8505,
	      0.8302,
	      0.8377,
	      0.8202,
	      0.8459,
	      0.8269,
	      0.8334,
	      0.832,
	      0.8444,
	      0.8104,
	      0.8027,
	      0.8205,
	      0.7953,
	      0.8332,
	      0.7939,
	      0.8222,
	      0.8188,
	      0.7828,
	      0.792,
	      0.8055,
	      0.8197,
	      0.762,
	      0.7732,
	      0.7614,
	      0.7771,
	      0.7608,
	      0.7698,
	      0.7793,
	      0.7754,
	      0.7626,
	      0.7529,
	      0.7705,
	      0.7474,
	      0.7575,
	      0.7632,
	      0.7254,
	      0.7209,
	      0.7323,
	      0.7442,
	      0.728,
	      0.7345,
	      0.7419,
	      0.7263,
	      0.7281,
	      0.7641,
	      0.6626,
	      0.7622,
	      0.6989,
	      0.7365,
	      0.7418,
	      0.7988,
	      0.7357,
	      0.6717,
	      0.7194,
	      0.6959,
	      0.702,
	      0.7724
    ]
}
```
EXP_UNCS_NMCPD.json 
```
{
    "statistical": [0.0203,
		    0.0212,
		    0.0205,
		    0.0258,
		    0.0176,
		    0.0277,
		    0.0171,
		    0.0137,
		    0.0129,
		    0.0118,
		    0.0108,
		    0.0116,
		    0.0615,
		    0.025,
		    0.0208,
		    0.0172,
		    0.0092,
		    0.0157,
		    0.0137,
		    0.0128,
		    0.0098,
		    0.0547,
		    0.025,
		    0.0213,
		    0.018,
		    0.0091,
		    0.0083,
		    0.0088,
		    0.01,
		    0.0083,
		    0.0086,
		    0.0097,
		    0.0122,
		    0.0543,
		    0.032,
		    0.0233,
		    0.0205,
		    0.0127,
		    0.0108,
		    0.0092,
		    0.0098,
		    0.0072,
		    0.0085,
		    0.0103,
		    0.0087,
		    0.0095,
		    0.0134,
		    0.0402,
		    0.0301,
		    0.0268,
		    0.0161,
		    0.0155,
		    0.0129,
		    0.0119,
		    0.0084,
		    0.0087,
		    0.0098,
		    0.0092,
		    0.01,
		    0.0143,
		    0.0107,
		    0.0375,
		    0.0287,
		    0.0313,
		    0.0131,
		    0.0154,
		    0.0124,
		    0.0107,
		    0.0076,
		    0.0071,
		    0.0074,
		    0.0065,
		    0.0085,
		    0.0097,
		    0.0085,
		    0.01,
		    0.0375,
		    0.034,
		    0.0207,
		    0.0179,
		    0.0183,
		    0.0138,
		    0.0089,
		    0.0087,
		    0.009,
		    0.0069,
		    0.0088,
		    0.0111,
		    0.0101,
		    0.0115,
		    0.0107,
		    0.0144,
		    0.0412,
		    0.0214,
		    0.0213,
		    0.0167,
		    0.0138,
		    0.0092,
		    0.0077,
		    0.0077,
		    0.0058,
		    0.0069,
		    0.0085,
		    0.0076,
		    0.0097,
		    0.0087,
		    0.009,
		    0.0119,
		    0.0438,
		    0.0344,
		    0.0542,
		    0.0197,
		    0.0117,
		    0.0111,
		    0.0096,
		    0.0069,
		    0.0079,
		    0.0095,
		    0.0082,
		    0.0105,
		    0.0105,
		    0.0103,
		    0.0103,
		    0.0157,
		    0.054,
		    0.0537,
		    0.0281,
		    0.014,
		    0.0136,
		    0.0124,
		    0.0082,
		    0.0089,
		    0.0106,
		    0.0092,
		    0.0114,
		    0.0115,
		    0.0116,
		    0.0114,
		    0.0147,
		    0.0222,
		    0.068,
		    0.0306,
		    0.0169,
		    0.0151,
		    0.0153,
		    0.0097,
		    0.0098,
		    0.0117,
		    0.0102,
		    0.0127,
		    0.0126,
		    0.013,
		    0.0124,
		    0.0147,
		    0.0209,
		    0.0345,
		    0.031,
		    0.0143,
		    0.0127,
		    0.0125,
		    0.009,
		    0.0087,
		    0.0095,
		    0.0081,
		    0.01,
		    0.0097,
		    0.0101,
		    0.0098,
		    0.011,
		    0.0149,
		    0.0191,
		    0.0193,
		    0.0146,
		    0.015,
		    0.0106,
		    0.0117,
		    0.012,
		    0.0093,
		    0.0108,
		    0.0109,
		    0.0114,
		    0.0108,
		    0.0122,
		    0.0153,
		    0.0202,
		    0.0297,
		    0.0172,
		    0.0161,
		    0.0109,
		    0.0121,
		    0.0137,
		    0.0101,
		    0.0112,
		    0.0112,
		    0.0116,
		    0.0112,
		    0.0126,
		    0.0155,
		    0.0186,
		    0.0248,
		    0.0203,
		    0.0155,
		    0.0141,
		    0.0163,
		    0.0142,
		    0.0134,
		    0.0128,
		    0.0135,
		    0.0127,
		    0.014,
		    0.0169,
		    0.0214,
		    0.0265,
		    0.0349,
		    0.0158,
		    0.0134,
		    0.0143,
		    0.012,
		    0.0165,
		    0.0118,
		    0.0113,
		    0.0109,
		    0.012,
		    0.0147,
		    0.0162,
		    0.0213,
		    0.0253,
		    0.0242,
		    0.0245,
		    0.0161,
		    0.0211,
		    0.0227,
		    0.0158,
		    0.0146,
		    0.016,
		    0.0187,
		    0.0222,
		    0.0281,
		    0.0296,
		    0.0356,
		    0.0296,
		    0.028,
		    0.03,
		    0.0282,
		    0.0205,
		    0.0216,
		    0.0267,
		    0.0331,
		    0.0345,
		    0.0458,
		    0.0361,
		    0.0465,
		    0.0353,
		    0.0395,
		    0.0281,
		    0.0235,
		    0.033,
		    0.0373,
		    0.0513,
		    0.0645
		   ],
    "systematic": [
	{"sys_1": ["ADD", "CORR",
		   0.0009815,
		   0.001003,
		   0.001935,
		   0.001033,
		   0.0009912,
		   0.001008,
		   0.0009824,
		   0.001965,
		   0.0019472,
		   0.0019408,
		   0.0009921,
		   0.0009959,
		   0.00201,
		   0.001,
		   0.002028,
		   0.001989,
		   0.001959,
		   0.0019932,
		   0.0019786,
		   0.0009959,
		   0.0009842,
		   0.0019634,
		   0.001011,
		   0.0019986,
		   0.00204,
		   0.0019236,
		   0.001955,
		   0.0019284,
		   0.0019428,
		   0.0009891,
		   0.000975,
		   0.0019674,
		   0.0029772,
		   0.0019366,
		   0.002016,
		   0.001906,
		   0.001938,
		   0.0019744,
		   0.001936,
		   0.0019248,
		   0.0019594,
		   0.0019494,
		   0.0019476,
		   0.0009813,
		   0.0009844,
		   0.0019468,
		   0.0009821,
		   0.0019146,
		   0.0019494,
		   0.002014,
		   0.0019878,
		   0.001929,
		   0.001937,
		   0.0019668,
		   0.001985,
		   0.0019526,
		   0.000968,
		   0.0019522,
		   0.0009716,
		   0.0019634,
		   0.0009942,
		   0.0018986,
		   0.0019202,
		   0.0018816,
		   0.001924,
		   0.001917,
		   0.0019262,
		   0.0029547,
		   0.0019604,
		   0.0019354,
		   0.0019162,
		   0.000979,
		   0.0019528,
		   0.0019184,
		   0.0019786,
		   0.0009738,
		   0.0019114,
		   0.0018528,
		   0.0018616,
		   0.0019236,
		   0.0019446,
		   0.0019266,
		   0.0019108,
		   0.0019144,
		   0.0019532,
		   0.001913,
		   0.0009611,
		   0.0019338,
		   0.0019634,
		   0.0019372,
		   0.0009572,
		   0.0009439,
		   0.0018202,
		   0.0019078,
		   0.0018408,
		   0.0019476,
		   0.00188,
		   0.0028596,
		   0.0019052,
		   0.0019284,
		   0.0019194,
		   0.0009551,
		   0.0009577,
		   0.0009682,
		   0.0019156,
		   0.0009532,
		   0.0009698,
		   0.0009635,
		   0.0018976,
		   0.001919,
		   0.002002,
		   0.001962,
		   0.002913,
		   0.0018954,
		   0.0018898,
		   0.0018972,
		   0.001874,
		   0.000945,
		   0.0018734,
		   0.0018788,
		   0.0018656,
		   0.0009432,
		   0.0009371,
		   0.0009592,
		   0.0019356,
		   0.0018702,
		   0.0028155,
		   0.0028239,
		   0.0018626,
		   0.001889,
		   0.001872,
		   0.0018794,
		   0.000942,
		   0.001849,
		   0.0009218,
		   0.0018508,
		   0.0009291,
		   0.0009319,
		   0.0009554,
		   0.0009233,
		   0.0018528,
		   0.0027015,
		   0.0027681,
		   0.002745,
		   0.0027876,
		   0.001841,
		   0.0018228,
		   0.0018818,
		   0.0018582,
		   0.0009266,
		   0.0018526,
		   0.0018544,
		   0.0009123,
		   0.0009272,
		   0.000905,
		   0.0009039,
		   0.002742,
		   0.0028281,
		   0.0027168,
		   0.0027669,
		   0.0017932,
		   0.0018264,
		   0.0018484,
		   0.0018424,
		   0.0009147,
		   0.0017962,
		   0.0018136,
		   0.0009018,
		   0.0008924,
		   0.000905,
		   0.0008453,
		   0.0026577,
		   0.0026343,
		   0.0027519,
		   0.0017966,
		   0.0017622,
		   0.0018268,
		   0.0017738,
		   0.0017244,
		   0.0017352,
		   0.0017574,
		   0.000862,
		   0.0008684,
		   0.0008641,
		   0.0008715,
		   0.000897,
		   0.0025656,
		   0.0017522,
		   0.0017428,
		   0.0017404,
		   0.001689,
		   0.0017214,
		   0.0016928,
		   0.0017068,
		   0.0017098,
		   0.0008617,
		   0.0008651,
		   0.000867,
		   0.0008343,
		   0.0008218,
		   0.0016438,
		   0.0017274,
		   0.0017084,
		   0.001701,
		   0.0016604,
		   0.0016754,
		   0.0016404,
		   0.0016918,
		   0.0008269,
		   0.0008334,
		   0.000832,
		   0.0008444,
		   0.0008104,
		   0.0008027,
		   0.001641,
		   0.0015906,
		   0.0016664,
		   0.0015878,
		   0.0008222,
		   0.0016376,
		   0.0015656,
		   0.000792,
		   0.0008055,
		   0.0008197,
		   0.000762,
		   0.0007732,
		   0.0007614,
		   0.0015542,
		   0.0015216,
		   0.0015396,
		   0.0007793,
		   0.0007754,
		   0.0015252,
		   0.0007529,
		   0.0007705,
		   0.0007474,
		   0.0007575,
		   0.0007632,
		   0.0007254,
		   0.0014418,
		   0.0014646,
		   0.0007442,
		   0.000728,
		   0.001469,
		   0.0007419,
		   0.0007263,
		   0.0007281,
		   0.0007641,
		   0.0006626,
		   0.0007622,
		   0.0006989,
		   0.0007365,
		   0.0007418,
		   0.0015976,
		   0.0014714,
		   0.0006717,
		   0.0007194,
		   0.0006959,
		   0.000702,
		   0.0007724
		  ] },
	{"sys_2": ["ADD", "CORR",
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0029451,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0058098,
		   -0.002016,
		   -0.000953,
		   0,
		   0.0009872,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0057438,
		   -0.0019494,
		   -0.001007,
		   0.0009939,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0056958,
		   -0.0057606,
		   -0.0028224,
		   -0.000962,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0057342,
		   -0.0055584,
		   -0.0018616,
		   -0.0009618,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0054606,
		   -0.0057234,
		   -0.0018408,
		   -0.0009738,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0056928,
		   -0.005757,
		   -0.006006,
		   -0.000981,
		   0,
		   0,
		   -0.0009449,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0058068,
		   -0.0056106,
		   -0.0009385,
		   0,
		   0,
		   -0.0009445,
		   -0.000936,
		   -0.0009397,
		   -0.000942,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0055584,
		   -0.0009005,
		   0,
		   0,
		   0,
		   -0.0009205,
		   -0.0009114,
		   -0.0009409,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.000914,
		   0,
		   0,
		   0,
		   0,
		   -0.0009132,
		   -0.0009242,
		   -0.0009212,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0026577,
		   0.0008781,
		   0,
		   -0.0008983,
		   -0.0008811,
		   -0.0009134,
		   -0.0008869,
		   -0.0008622,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0025656,
		   0.0008761,
		   0,
		   -0.0008702,
		   -0.0008445,
		   -0.0008607,
		   -0.0008464,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0041095,
		   0.0008637,
		   0,
		   -0.0008505,
		   -0.0008302,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0041025,
		   0.0015906,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0054397,
		   0.0030432,
		   0.0015396,
		   0.0007793,
		   0.0007754,
		   0.0015252,
		   0.0007529,
		   0.0007705,
		   0.0007474,
		   0,
		   0,
		   0,
		   0.0057672,
		   0.0036615,
		   0.0029768,
		   0.002184,
		   0.002938,
		   0.0022257,
		   0.0014526,
		   0.0007281,
		   0.0007641,
		   0,
		   0,
		   0.0048923,
		   0.004419,
		   0.0044508,
		   0.0047928,
		   0.0044142,
		   0.0026868,
		   0.0021582,
		   0.0006959,
		   0,
		   0
		  ] },
	{"sys_3": ["ADD", "CORR",
		   0.0107965,
		   0.013039,
		   0.0106425,
		   0.019627,
		   0.0118944,
		   0.007056,
		   0.004912,
		   0.0108075,
		   0.009736,
		   0.0058224,
		   0.0069447,
		   0.0079672,
		   0.00201,
		   0.003,
		   0.004056,
		   0.003978,
		   0.0088155,
		   0.0019932,
		   0.0029679,
		   0.0029877,
		   0.004921,
		   0.0019634,
		   0.002022,
		   0.0019986,
		   0.00306,
		   0.0028854,
		   0.0048875,
		   0.004821,
		   0.0038856,
		   0.0019782,
		   0.00195,
		   0.0039348,
		   0.0079392,
		   0.0019366,
		   0.002016,
		   0.001906,
		   0.001938,
		   0.0009872,
		   0.000968,
		   0.0028872,
		   0.0029391,
		   0.0019494,
		   0.0038952,
		   0.0009813,
		   0.0019688,
		   0.0038936,
		   0.0058926,
		   0.0019146,
		   0.0019494,
		   0.002014,
		   0.0009939,
		   0.0009645,
		   0.0009685,
		   0.0009834,
		   0.001985,
		   0.0009763,
		   0.000968,
		   0.0009761,
		   0.0029148,
		   0.0019634,
		   0.0039768,
		   0.0009493,
		   0.0019202,
		   0.0018816,
		   0.000962,
		   0.0009585,
		   0.0009631,
		   0.0009849,
		   0.0009802,
		   0.0009677,
		   0.0009581,
		   0.001958,
		   0.0009764,
		   0.0009592,
		   0.0029679,
		   0.0038952,
		   0.0019114,
		   0.0009264,
		   0.0009308,
		   0.0009618,
		   0.0009723,
		   0.0009633,
		   0.0009554,
		   0.0009572,
		   0.0009766,
		   0.0009565,
		   0.0009611,
		   0.0009669,
		   0.0009817,
		   0.0009686,
		   0.0009572,
		   0.0028317,
		   0.0009101,
		   0.0009539,
		   0.0009204,
		   0.0009738,
		   0.00094,
		   0.0009532,
		   0.0009526,
		   0.0009642,
		   0.0009597,
		   0.0009551,
		   0.0009577,
		   0.0009682,
		   0.0009578,
		   0,
		   0.0009698,
		   0.001927,
		   0.0009488,
		   0.0009595,
		   0.001001,
		   0.000981,
		   0.000971,
		   0.0009477,
		   0.0009449,
		   0.0009486,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0009432,
		   0.0009371,
		   0.0019184,
		   0.0009678,
		   0.0009351,
		   0.0009385,
		   0.0009413,
		   0.0009313,
		   0.0009445,
		   0.000936,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0009319,
		   0.0009554,
		   0.0018466,
		   0.0009264,
		   0.0009005,
		   0.0009227,
		   0.000915,
		   0.0009292,
		   0.0009205,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.000905,
		   0.0018078,
		   0.000914,
		   0.0009427,
		   0.0009056,
		   0.0009223,
		   0.0008966,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0008453,
		   0.0008859,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.000897,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0008027,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0007614,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0007254,
		   0.0007209,
		   0.0007323,
		   0.0007442,
		   0.000728,
		   0.0007345,
		   0.0007419,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0013978,
		   0.001473,
		   0.0014836,
		   0.0007988,
		   0.0007357,
		   0,
		   0,
		   0.0006959,
		   0.000702,
		   0.0015448
		  ] },
	{"sys_4": ["ADD", "CORR",
		   0,
		   0.001003,
		   0,
		   0,
		   0,
		   0.001008,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.001,
		   -0.001014,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.001011,
		   0,
		   -0.00102,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.001007,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0009557,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0009101,
		   -0.0009539,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0009488,
		   -0.0009595,
		   -0.001001,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0009678,
		   -0.0009351,
		   -0.0009385,
		   -0.0009413,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0009264,
		   -0.0009005,
		   -0.0009227,
		   -0.000915,
		   0,
		   0,
		   -0.0009114,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.001828,
		   -0.0018854,
		   -0.0009056,
		   -0.0009223,
		   -0.0008966,
		   -0.0009132,
		   -0.0009242,
		   -0.0009212,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.0017718,
		   -0.0017562,
		   -0.0018346,
		   -0.0008983,
		   -0.0008811,
		   -0.0009134,
		   -0.0008869,
		   -0.0008622,
		   -0.0008676,
		   -0.0008787,
		   -0.000862,
		   0,
		   0,
		   0,
		   0,
		   -0.0025656,
		   -0.0026283,
		   -0.0017428,
		   -0.0008702,
		   -0.0008445,
		   -0.0008607,
		   -0.0008464,
		   -0.0008534,
		   -0.0008549,
		   -0.0008617,
		   -0.0008651,
		   -0.000867,
		   0,
		   0,
		   -0.0032876,
		   -0.0034548,
		   -0.0017084,
		   -0.001701,
		   -0.0008302,
		   -0.0016754,
		   -0.0008202,
		   -0.0008459,
		   -0.0008269,
		   -0.0008334,
		   -0.000832,
		   -0.0008444,
		   0,
		   0,
		   -0.004923,
		   -0.0023859,
		   -0.0024996,
		   -0.0015878,
		   -0.0016444,
		   -0.0016376,
		   -0.0015656,
		   -0.001584,
		   -0.0008055,
		   -0.0008197,
		   -0.000762,
		   0,
		   0,
		   -0.0054397,
		   -0.003804,
		   -0.0023094,
		   -0.0023379,
		   -0.0015508,
		   -0.0022878,
		   -0.0015058,
		   -0.001541,
		   -0.0007474,
		   -0.0007575,
		   -0.0007632,
		   0,
		   -0.0028836,
		   -0.0021969,
		   -0.0014884,
		   -0.001456,
		   -0.001469,
		   -0.0014838,
		   -0.0014526,
		   -0.0014562,
		   -0.0007641,
		   -0.0006626,
		   -0.0007622,
		   0.0027956,
		   0.0022095,
		   0.0007418,
		   0,
		   -0.0007357,
		   -0.0013434,
		   -0.0014388,
		   -0.0013918,
		   -0.001404,
		   -0.0015448
		  ] },
	{"sys_5": ["ADD", "CORR",
		   0,
		   0.001003,
		   0,
		   0,
		   0,
		   0.001008,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.001,
		   -0.001014,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.001011,
		   0,
		   -0.00102,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   -0.001007,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0009557,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0009101,
		   0.0009539,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0009488,
		   0.0009595,
		   -0.001001,
		   0.000981,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0009678,
		   0.0009351,
		   0.0009385,
		   0.0009413,
		   0.0009313,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0018528,
		   0.0009005,
		   0.0009227,
		   0.000915,
		   0.0009292,
		   0.0009205,
		   0.0009114,
		   0.0009409,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.001828,
		   0.0018854,
		   0.0009056,
		   0.0009223,
		   0.0008966,
		   0.0009132,
		   0.0009242,
		   0.0009212,
		   0.0009147,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0,
		   0.0026577,
		   0.0017562,
		   0.0018346,
		   0.0008983,
		   0.0008811,
		   0.0009134,
		   0.0008869,
		   0.0008622,
		   0.0008676,
		   0.0008787,
		   0.000862,
		   0.0008684,
		   0.0008641,
		   0,
		   0,
		   0.0025656,
		   0.0026283,
		   0.0017428,
		   0.0017404,
		   0.0008445,
		   0.0017214,
		   0.0008464,
		   0.0008534,
		   0.0008549,
		   0.0008617,
		   0.0008651,
		   0.000867,
		   0.0008343,
		   0.0008218,
		   0.0041095,
		   0.0034548,
		   0.0017084,
		   0.001701,
		   0.0016604,
		   0.0016754,
		   0.0008202,
		   0.0008459,
		   0.0008269,
		   0.0008334,
		   0.000832,
		   0.0008444,
		   0.0008104,
		   0,
		   0.004923,
		   0.0031812,
		   0.0024996,
		   0.0023817,
		   0.0016444,
		   0.0016376,
		   0.0015656,
		   0.001584,
		   0.001611,
		   0.0008197,
		   0.000762,
		   0.0007732,
		   0.0007614,
		   0.0054397,
		   0.0045648,
		   0.0030792,
		   0.0023379,
		   0.0015508,
		   0.0022878,
		   0.0015058,
		   0.001541,
		   0.0014948,
		   0.0007575,
		   0.0007632,
		   0.0007254,
		   0.0028836,
		   0.0029292,
		   0.0022326,
		   0.001456,
		   0.001469,
		   0.0014838,
		   0.0014526,
		   0.0014562,
		   0.0015282,
		   0.0006626,
		   0.0007622,
		   -0.0027956,
		   -0.0022095,
		   -0.0007418,
		   -0.0007988,
		   0.0007357,
		   0.0013434,
		   0.0021582,
		   0.0020877,
		   0.002106,
		   0.0023172
		  ] }
    ]    
}
```

Some remarks.

  • Incidentally, I realised that, in this specific experiment, the inelasticity y wasn't defined in the original buildmaster implementation, a fact that leads to a column of zeroes. This is inconsequential, however this is incorrect. That's an example of why, in my opinion, we shouldn't just "filter" the current COMMONDATA to convert old data into the new format. A fresh implementation may fix all these small bugs. With a fresh implementation we can also make sure that the data is retrieved from Hepdata as much as possible (NMC is on Hepdata, but the current rawdata file was taken from somewhere else - it's impossible to tell from where).
  • For some datasets, bin edges are not specified (as in the above case).
  • It's not yet clear to me how to accommodate dataset variants.
  • I think that the format is sufficiently flexible to accommodate multi-differential distributions (shouldn't it be just a matter of adding more entries to the KINEMATICS file?). I also think that we can specify "extrinsic" uncertainties in the METADATA and then have additional files, in a format similar to the EXP_UNC file, for these.

@alecandido
Copy link
Member

alecandido commented Nov 10, 2021 •
edited
Loading

May I suggest to use a details tag?

Like the following:

<details><summary>ciao come va?</summary>
<pre>
bene grazie
</pre>
</details>

Very long output makes the end of answer (and the rest of the conversation) a bit harder to access...

@alecandido
Copy link
Member

I reply to things I'm aware of, but @cschwan's answer would be better than mine.

  • the flow of information between this and runcards should be the other way round: you define things in commondata, then if they are needed even in runcards we import them (though might be useful to take something during implementation since @cschwan already carefully worked out some stuffs)
  • at the moment plotting and metadata in runcards are together in a single file: I would say that we don't have to be consistent, but it would be nicer to be; so if we want them split we should rework even runcards ones (that takes nothing, it's just a matter of choices)
  • this is a bit trivial and maybe opinionated: I would not rely on filenames to group things, better to put in a single folder 
    <DATASET>/
|-- metadata.json
|-- plotting.json
|-- kinematics.json
|-- data.json
|-- exp_uncs.json
  • I'm not sure .json is the best format for these kind of data (standard is good, but maybe a suitable format might even be binary, if it's a standard one), but since it's not readable in any case, I would suggest to minimize blanks, and make it on a single line (i.e. like in standard library compact example, see next), or otherwise to compress them 
    import json
json.dumps([1, 2, 3, {'4': 5, '6': 7}], separators=(',', ':'))

@Zaharid
Copy link
Contributor Author

Zaharid commented Nov 17, 2021

Let me see whether I can make any of the above a little more concrete. For the time being, let's focus on the dataset currently called NMCPD. It corresponds to the F2d/F2p ratio measured by NMC. This is the only COMPOUND DIS dataset. I understand that we want the following files.

1. > ```
   > * A metadata file with the informations in the "runcards" folder, PLOTTING file, COMPOUND file and others.
   > ```

My understanding is that this is the first file that a developer would write when implementing a new dataset (or migrating an old dataset to the new format). I think that it should be as simple (minimal) as possible. Let's call it METADATA_NMCPD.json. A possible incarnation may look like as follows.

{
    "setname":  "NMPCPD",
    "arXiv":    "hep-ex/9611022",
    "hepdata":  "https://www.hepdata.net/record/ins426595",
    "ndata":    260,
    "nsys_exp": 5, 
    "proctype": "DIS_F2R",
    "compound": "RATIO",
    "experiment": "NMC",
    "nnpdf31_process": "DIS NC"
}

As discussed, I think the YAML format may be more adequate for this.

Here I already have some questions:

* how are `COMPOUND` datasets treated by the new tool chain that produces FK tables?

I would think that very similarly to now from the point of view of the input information required (?)

* which kind of information is actually required from the `PLOTTING` file?

At this stage, I would say "all of it" and in the same format.

* which information should we import from the `metadata.txt` in the "runcard" folder?

All?

1. > ```
   > * A kinematics file with bin edges and central value in some format.
   > ```

2. > ```
   > * A data file with experimental central value and uncertainties (probably in a separate file).
   > ```

I understand that these files should be the output of a small python script (for each dataset) that would eventually replace the current filter files in buildmaster. The file METADATA_<nameexp>.json is used as input to such a python script. Let's call the outputs KINEMATICS_NMCPD.json, DATA_NMCPD.json and EXP_UNCS_NMCPD.json. Possible incarnations of these outputs may look like as follows.

As @alecandido was saying, having these in a folder might be a good idea.

KINEMATICS_NMCPD.json
DATA_NMCPD.json
EXP_UNCS_NMCPD.json

Some remarks.

* Incidentally, I realised that, in this specific experiment, the inelasticity `y` wasn't defined in the original buildmaster implementation, a fact that leads to a column of zeroes. This is inconsequential, however this is incorrect. That's an example of why, in my opinion, we shouldn't just "filter" the current `COMMONDATA` to convert old data into the new format. A fresh implementation may fix all these small bugs. With a fresh implementation we can also make sure that the data is retrieved from Hepdata as much as possible (NMC is on Hepdata, but the current rawdata file was taken from somewhere else - it's impossible to tell from where).

* For some datasets, bin edges are not specified (as in the above case).

I think inventing them (on a case by case basis) might be better than complicating the format with undefined support.

* It's not yet clear to me how to accommodate dataset variants.

Would need to be thought, but once everything is in a folder, it would be a matter of adding the files plus various kinds of information in the runcard, such as what are the variants and what is the default variant. For example (haven't really thought this too much):

variants:
   atlas_correlation_choice:
        exp_uncertainties_data:  EXP_UNC_ATLAS.json

default_variant: None # Ignore the above by default.
* I think that the format is sufficiently flexible to accommodate multi-differential distributions (shouldn't it be just a matter of adding more entries to the `KINEMATICS` file?). I also think that we can specify "extrinsic" uncertainties in the `METADATA` and then have additional files, in a format similar to the `EXP_UNC` file, for these.

Yes, we should just have n kinematics. The external uncertainties would be a file with the same format and added to the runcard.

That begs the question if we should have yet another piece of configuration for what the defaults are (as discussed elsewhere).

@enocera
Copy link
Contributor

enocera commented Nov 17, 2021

@Zaharid Thanks for the detailed replies, that I'm going to use to work further on the prototype.

@scarlehoff
Copy link
Member

@enocera I'm available for both helping with the prototype and acting as a pressure element, just let me know.

@enocera
Copy link
Contributor

enocera commented Jan 13, 2022

@scarlehoff Thanks - this is appreciated. I'll open a PR soon-ish and we will start from there.

@enocera
Copy link
Contributor

enocera commented Jan 13, 2022

@scarlehoff You've got my blessing to piss me off.

@enocera enocera mentioned this issue Jan 19, 2022
Closed
3 tasks
@scarlehoff
Copy link
Member

Superseded by #1709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cschwan cschwan

@alecandido alecandido

@enocera enocera

@scarlehoff scarlehoff

Labels
data toolchain
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cschwan @Zaharid @alecandido @enocera @scarlehoff