[Bug:] Inconsistent inputs for evaluate() functions in the recruitment module

[Bai-Li-NOAA]

Describe the bug

The evaluate() function in the Beverton Holt SR class requires phi_0 as the second parameter, while the evaluate() function from the recruitment base class uses ssbzero as the second parameter. Should these parameters be consistent? Additionally, the R test for the Beverton-Holt SR module uses ssb0 as input. Could this be a typo, and should it actually be phi_0

Describe how to reproduce the bug

See links in the description block.

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which browser are you seeing the problem on?

No response

Which version of FIMS are you seeing the problem on?

No response

Additional context

No response

[kellijohnson-NOAA]

Wait until after sprint 2 is done, change during week of Aug. 5th. Should be changed in dev. Code needs to be made consistent in the naming structure. @msupernaw will do this!

[kellijohnson-NOAA]

@msupernaw can you do this now that dev_MS is merged into dev?

[msupernaw]

yup, I'll do it Monday morning in dev. Write it on a sticky note for me😀

…

On Thu, Oct 10, 2024 at 4:40 PM Kelli Johnson ***@***.***> wrote: @msupernaw <https://github.com/msupernaw> can you do this now that dev_MS is merged into dev? — Reply to this email directly, view it on GitHub <#653 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFUSEE5ZPBAS5HUEWJGUR3Z23Q5HAVCNFSM6AAAAABLNIJ4GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVHE4TSOBTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Matthew Supernaw Mathematical Statistician *National Oceanic and Atmospheric Administration* *Office Of Science and Technology* *NOAA Fisheries | *U.S. Department of Commerce Phone 248 - 396 - 7797