You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm on leave all of next week so leaving some notes in this issue in case further work is needed before I can continue it or if folks just want to explore the approach we're attempting to take.
What's working:
a new function create_fims_output() calls new get_estimates() and get_fits() functions to create tibbles and returns them as a list
the get_estimates() function returns all the parameters and derived quantities that are reported in the JSON output
the get_fits() function returns the observed and expected values for indices of abundance
continue development on get_fits() to process age comps and any other data types (incomplete output processing shouldn't impact the test noted above)
work with @msupernaw to add a few more things to the output in the JSON file (@kellijohnson-NOAA has a list of ideas that could be added to this issue)
fill in lots of missing values in the tibbles that get returned by those functions (in some cases because it's not yet in the JSON output, like the uncertainty estimates)
refactor some of the functions to convert the many loops that I used into some more efficient approach that depends on apply functions or stuff in tidyverse or tidyjson (but only if it doesn't make the code really hard to understand and develop)
The text was updated successfully, but these errors were encountered:
@iantaylor-NOAA thank you for your patience. We have been refactoring the .json output based on the need for parameter vectors and some of your comments. You will have a new version by Monday September 23rd that should be easier to parse in R though still not complete with everything that is needed to create the two desired data frames.
Thanks for the update and good to hear about the progress. I'm unavailable Sept 25 - Oct 6 (on the bottom trawl survey), so if there's someone else available to continue the work on the R code for JSON processing, I'm happy to hand this over. Otherwise I can pick up after I return.
Description
I've been working in the
r-json
branch as directed by @kellijohnson-NOAA to convert new JSON output into the format specified in the Design document for R output.I'm on leave all of next week so leaving some notes in this issue in case further work is needed before I can continue it or if folks just want to explore the approach we're attempting to take.
What's working:
create_fims_output()
calls newget_estimates()
andget_fits()
functions to create tibbles and returns them as a listget_estimates()
function returns all the parameters and derived quantities that are reported in the JSON outputget_fits()
function returns the observed and expected values for indices of abundanceWhat's next:
get_fits()
to process age comps and any other data types (incomplete output processing shouldn't impact the test noted above)The text was updated successfully, but these errors were encountered: