Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer Issue]: Need GitHub actions to turn off FIMS_DEBUG_LOG() #681

Open
kellijohnson-NOAA opened this issue Nov 1, 2024 · 0 comments
Labels
status: triage_needed This is not approved for this milestone, do not work on it yet

Comments

@kellijohnson-NOAA
Copy link
Contributor

Description

In dev and other branches, FIMS_DEBUG_LOG() can be used to add debugging statements to the log file if -DFIMS_DEBUG is added the the makevars file. We want to have a GitHub action that removes this flag from the Makevars and Makevars.win files prior to merging anything into main. Second, we want to have a GitHub action that uses grep or something to stop all PR to main that have FIMS_DEBUG_LOG statements in the code.

This is not super pressing at the moment b/c no branch actually has this flag turned on but it will be needed in M3 at a minimum.

@kellijohnson-NOAA kellijohnson-NOAA added the status: triage_needed This is not approved for this milestone, do not work on it yet label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: triage_needed This is not approved for this milestone, do not work on it yet
Projects
None yet
Development

No branches or pull requests

1 participant