Responding to suggestion from Ian on my pull request.

Author: Anthony

freanalysis_aerosol/freanalysis_aerosol/__init__.py

@@ -11,7 +11,7 @@
 @dataclass
 class Metadata:
     """Helper class that stores the metadata needed by the plugin."""
-    frequency: str = "monthly"object
+    frequency: str = "monthly"
     realm: str = "atmos"
 
     @staticmethod
@@ -206,5 +206,4 @@ def run_analysis(self, catalog, png_dir, reference_catalog=None, config={}):
             )
             figure.save(Path(png_dir) / f"{name}.png")
             figure_paths.append(Path(png_dir)/ f"{name}.png")
-        return figure_paths
-object
+        return figure_paths

freanalysis_land/freanalysis_land/land.py

@@ -11,8 +11,8 @@
 
 
 class LandAnalysisScript(AnalysisScript):
-    """Abstract base class for analysis scripts.  User-defined analysis scripts
-       should inhert from this class and override the requires and run_analysis methods.
+    """A class for performing various analysis tasks relating to GFDL land model output,
+       inherits from the AnalysisScipt base class.
 
     Attributes:
        description: Longer form description for the analysis.
@@ -78,7 +78,7 @@ def global_map(self,dataset,var,dates,plt_time=None,colormap='viridis',title='')
         lon = dataset.lon
         lat = dataset.lat
 
-        if plt_time == None: plt_time=len(dates)-1
+        if plt_time is None: plt_time=len(dates)-1
 
         data = dataset[var][plt_time].values
         projection = ccrs.PlateCarree()
@@ -157,7 +157,7 @@ def timeseries(self, dataset,var,dates_period,var_range=None,minlon = 0,maxlon =
         calculates the monthly and annual means of the specified variable and plots the seasonal and annual means.
         
         '''
-        if var_range != None:
+        if var_range is not None:
             data_filtered = dataset.where((dataset[var] > var_range[0]) & (dataset[var] <= var_range[1]) &
                                         (dataset.lat >= minlat) & (dataset.lon >= minlon) &
                                         (dataset.lat <= maxlat) & (dataset.lon <= maxlon))
@@ -171,7 +171,7 @@ def timeseries(self, dataset,var,dates_period,var_range=None,minlon = 0,maxlon =
         data_df['monthly_mean'] = data_filtered.resample(time='YE').mean(dim=['lat','lon'],skipna=True)[var].values
         data_df['monthly_shift'] = data_df['monthly_mean'].shift(1)
 
-        if timerange != None:
+        if timerange is not None:
             ys, ye = (str(timerange[0]),str(timerange[1]))
             plot_df = data_df.loc[f'{ys}-1-1':f'{ye}-1-1']
         else:

tests/my_land_analysis.py

@@ -0,0 +1,10 @@
+
+
+from freanalysis_land.land import LandAnalysisScript
+
+def test_land_analysis_script():
+    land = LandAnalysisScript()
+    land.run_analysis("/work/a2p/lm4p2sc_GSWP3_hist_irr_catalog.json","/work/a2p/")
+    
+
+test_land_analysis_script()