Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and modify output units for BMI variables in main and noah_om_grid branches #117

Open
SnowHydrology opened this issue Sep 6, 2024 · 0 comments
Assignees

Comments

@SnowHydrology
Copy link
Contributor

Some variable units were transformed to match NWM v3.0 output. However, this should not be done in the model's BMI specification as it affects how variables are passed from one model to another in a NextGen formulation.

For example, we had to revert the change to water%evapotrans so that Noah-OM would once again work when coupled to CFE and TOPMODEL: #115

This issue is to check the BMI implementation of the main and noah_om_grid branches to ensure variable units are correct and that no transforms are performed in get_value.

See example here of the variable ECAN, which needs to be fixed:

For each variable, the developer must update:

  • the variable description and units in output_items
  • the units in noahowp_var_units
  • the dest value in noahowp_get_float
  • the variable equation in noahowp_set_float
@SnowHydrology SnowHydrology self-assigned this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant