You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some variable units were transformed to match NWM v3.0 output. However, this should not be done in the model's BMI specification as it affects how variables are passed from one model to another in a NextGen formulation.
For example, we had to revert the change to water%evapotrans so that Noah-OM would once again work when coupled to CFE and TOPMODEL: #115
This issue is to check the BMI implementation of the main and noah_om_grid branches to ensure variable units are correct and that no transforms are performed in get_value.
See example here of the variable ECAN, which needs to be fixed:
Some variable units were transformed to match NWM v3.0 output. However, this should not be done in the model's BMI specification as it affects how variables are passed from one model to another in a NextGen formulation.
For example, we had to revert the change to
water%evapotrans
so that Noah-OM would once again work when coupled to CFE and TOPMODEL: #115This issue is to check the BMI implementation of the
main
andnoah_om_grid
branches to ensure variable units are correct and that no transforms are performed inget_value
.See example here of the variable
ECAN
, which needs to be fixed:noah-owp-modular/bmi/bmi_noahowp.f90
Line 942 in 37d8d82
For each variable, the developer must update:
output_items
noahowp_var_units
dest
value innoahowp_get_float
noahowp_set_float
The text was updated successfully, but these errors were encountered: