Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _strain_dict_index from StrainCollection class #134

Closed
4 tasks done
CunliangGeng opened this issue Apr 5, 2023 · 0 comments · Fixed by #142
Closed
4 tasks done

remove _strain_dict_index from StrainCollection class #134

CunliangGeng opened this issue Apr 5, 2023 · 0 comments · Fixed by #142
Assignees

Comments

@CunliangGeng
Copy link
Member

CunliangGeng commented Apr 5, 2023

Attribute _strain_dict_index(or lookup_index) in StrainCollection class records the indices of strains. However it's mainly used as fixed indices by get_links method, which causes problems when the strains are updated.

@CunliangGeng CunliangGeng added this to the refactor codebase milestone Apr 5, 2023
@CunliangGeng CunliangGeng self-assigned this Apr 5, 2023
@CunliangGeng CunliangGeng linked a pull request May 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant