Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocation-based unit tests for Julia v.1.11 #354

Closed
Alexsp32 opened this issue Oct 30, 2024 · 0 comments · Fixed by #355
Closed

Allocation-based unit tests for Julia v.1.11 #354

Alexsp32 opened this issue Oct 30, 2024 · 0 comments · Fixed by #355
Labels
tests missing unit tests and test regressions

Comments

@Alexsp32
Copy link
Member

Changes to Julia's LinearAlgebra module are making unit tests based on the number of memory allocations fail again. Previously fixed in #336 for v1.10.0.

We shouldn't be using allocations to test functionality, or if we are, we should rephrase the tests to work for arbitrary allocation numbers, e.g. "ring polymer version of a function for 10 beads should make 10 times the allocations as the base version".
@Alexsp32 Alexsp32 added the tests missing unit tests and test regressions label Oct 30, 2024
This was referenced Oct 30, 2024
Merged
Merged
@Alexsp32 Alexsp32 linked a pull request Oct 31, 2024 that will close this issue
Memory allocation tests now check upper bounds #355
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests missing unit tests and test regressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Memory allocation tests now check upper bounds NQCD/NQCDynamics.jl
1 participant
@Alexsp32