-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project.toml #112
Update Project.toml #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this should have been caught quite a while ago, but PowerGraphics uses the old PowerSimulations BookKeeping
struct in testing, so the tests are not compatible with the version of PowerSimulations that PowerAnalytics = "^0.6"
requires. PowerGraphics also calls PowerSimulations outside of testing, though minimally.
@GabrielKS yeah, the interaction between PG and PSI is kinda broken right now. I'll try to fix it if I have time. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 5.60% 88.49% +82.89%
==========================================
Files 6 6
Lines 339 339
==========================================
+ Hits 19 300 +281
+ Misses 320 39 -281
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass for me, approving without too strict a review since the initial scope was so small. Noting that I had to delete my old test_results
directory and make it regenerate before the tests worked, but now that I have a new test_results
directory I don't have to delete it between tests.
No description provided.