Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project.toml #112

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Update Project.toml #112

merged 9 commits into from
Feb 8, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jan 28, 2024

No description provided.

@jd-lara jd-lara requested a review from GabrielKS January 28, 2024 23:56
Copy link

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should have been caught quite a while ago, but PowerGraphics uses the old PowerSimulations BookKeeping struct in testing, so the tests are not compatible with the version of PowerSimulations that PowerAnalytics = "^0.6" requires. PowerGraphics also calls PowerSimulations outside of testing, though minimally.

@jd-lara
Copy link
Member Author

jd-lara commented Feb 2, 2024

@GabrielKS yeah, the interaction between PG and PSI is kinda broken right now. I'll try to fix it if I have time.

@jd-lara jd-lara requested a review from GabrielKS February 8, 2024 21:49
@jd-lara jd-lara self-assigned this Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b0a625) 5.60% compared to head (1dfae8a) 88.49%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #112       +/-   ##
==========================================
+ Coverage   5.60%   88.49%   +82.89%     
==========================================
  Files          6        6               
  Lines        339      339               
==========================================
+ Hits          19      300      +281     
+ Misses       320       39      -281     
Flag Coverage Δ
unittests 88.49% <100.00%> (+82.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/call_plots.jl 76.66% <ø> (+76.66%) ⬆️
src/definitions.jl 88.88% <100.00%> (+63.49%) ⬆️
src/make_report.jl 100.00% <ø> (+100.00%) ⬆️
src/plot_recipes.jl 97.18% <100.00%> (+97.18%) ⬆️
src/plotly_recipes.jl 97.29% <100.00%> (+97.29%) ⬆️

Copy link

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass for me, approving without too strict a review since the initial scope was so small. Noting that I had to delete my old test_results directory and make it regenerate before the tests worked, but now that I have a new test_results directory I don't have to delete it between tests.

@jd-lara jd-lara merged commit 353ea1d into main Feb 8, 2024
7 checks passed
@jd-lara jd-lara deleted the jd-lara-patch-1 branch July 10, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants