Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the integrated test #241

Open
wenyikuang opened this issue Oct 23, 2024 · 4 comments
Open

fix the integrated test #241

wenyikuang opened this issue Oct 23, 2024 · 4 comments
Assignees

Comments

@wenyikuang
Copy link
Collaborator


     _ __         _     __,              _ __
    ( /  )    o  //   /(    _/_       / ( /  )     _/_    /
     /--< , ,,  // __/  `.  /  __ _, /<  /--< __,  /  _, /
    /___/(_/_(_(/_(_/_(___)(__(_)(__/ |_/___/(_/(_(__(__/ /_
      Executing BuildStock projects with grace since 2018


Traceback (most recent call last):
  File "/usr/local/bin/buildstock_local", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/buildstockbatch/utils.py", line 120, in run_with_error_capture
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/buildstockbatch/local.py", line 456, in main
    LocalBatch.validate_project(args.project_filename)
  File "/usr/local/lib/python3.8/site-packages/buildstockbatch/local.py", line 167, in validate_project
    super(cls, cls).validate_project(project_file)
  File "/usr/local/lib/python3.8/site-packages/buildstockbatch/base.py", line 268, in validate_project
    assert cls.validate_sampler(project_file)
  File "/usr/local/lib/python3.8/site-packages/buildstockbatch/base.py", line 333, in validate_sampler
    return BuildStockBatchBase.validate_buildstock_csv(project_file, buildstock_df)
  File "/usr/local/lib/python3.8/site-packages/buildstockbatch/base.py", line 357, in validate_buildstock_csv
    raise ValidationError("\n".join(errors))
buildstockbatch.exc.ValidationError: Column rentable_area in buildstock_csv is not available in options_lookup.tsv

@wenyikuang wenyikuang self-assigned this Oct 23, 2024
@wenyikuang
Copy link
Collaborator Author

Looks like /Comstock/resources/options_lookup.tsv need update follow with ymls/../samples/bsb-integration-test.csv or vice versa.

@rHorsey
Copy link
Collaborator

rHorsey commented Oct 29, 2024

@wenyikuang which branches of bsb and comstock?

@wenyikuang
Copy link
Collaborator Author

@wenyikuang
Copy link
Collaborator Author

  • rebase from main branch of bsb and rebuild from there
    -- may need change the dbuilstock.csv path to there

Problems may faced:

  • number of sample is too low and facing divide 0 issue

Could be tweaked:

  • Run some fast measure to do sanity check instead of slow ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants