Skip to content

Commit 0843cee

Browse files
rraustadrraustad
committed
Update min fields and add note, update ExpandObjects, update transition rules and code.
1 parent 297b7c8 commit 0843cee

File tree

4 files changed

+73
-11
lines changed

4 files changed

+73
-11
lines changed

‎idd/Energy+.idd.in

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28770,7 +28770,7 @@ HVACTemplate:Zone:Unitary,
2877028770
\object-list ZoneNames
2877128771
A2, \field Template Unitary System Name
2877228772
\required-field
28773-
\note Enter the name of an HVACTemplate:System:Unitary, HVACTemplate:System:UnitaryHeatPump:AirTtoAir,
28773+
\note Enter the name of an HVACTemplate:System:Unitary, HVACTemplate:System:UnitaryHeatPump:AirToAir,
2877428774
\note or HVACTemplate:System:UnitarySystem object serving this zone.
2877528775
\type object-list
2877628776
\object-list CompactHVACSystemUnitary
@@ -35887,7 +35887,7 @@ ZoneHVAC:PackagedTerminalAirConditioner,
3588735887
\memo Packaged terminal air conditioner (PTAC). Forced-convection heating-cooling unit
3588835888
\memo with supply fan, direct expansion (DX) cooling coil, heating coil (gas, electric, hot
3588935889
\memo water, or steam) and fixed-position outdoor air mixer.
35890-
\min-fields 18
35890+
\min-fields 19
3589135891
A1, \field Name
3589235892
\required-field
3589335893
\type alpha
@@ -35952,6 +35952,7 @@ ZoneHVAC:PackagedTerminalAirConditioner,
3595235952
\key Yes
3595335953
\key No
3595435954
\default Yes
35955+
\note This field is not used when Design Specification Multispeed Object Type input is present
3595535956
\note When Yes is selected the minimum air flow rate is used.
3595635957
\note When No is selected the maximum air flow rate is used.
3595735958
N4 , \field Cooling Outdoor Air Flow Rate
@@ -36076,7 +36077,7 @@ ZoneHVAC:PackagedTerminalHeatPump,
3607636077
\memo supply fan, direct expansion (DX) cooling coil, DX heating coil (air-to-air heat
3607736078
\memo pump), supplemental heating coil (gas, electric, hot water, or steam), and
3607836079
\memo fixed-position outdoor air mixer.
36079-
\min-fields 26
36080+
\min-fields 27
3608036081
A1, \field Name
3608136082
\required-field
3608236083
\type alpha
@@ -36140,6 +36141,7 @@ ZoneHVAC:PackagedTerminalHeatPump,
3614036141
\key Yes
3614136142
\key No
3614236143
\default Yes
36144+
\note This field is not used when Design Specification Multispeed Object Type input is present
3614336145
\note When Yes is selected the minimum air flow rate is used.
3614436146
\note When No is selected the maximum air flow rate is used.
3614536147
N4 , \field Cooling Outdoor Air Flow Rate
@@ -36297,7 +36299,7 @@ ZoneHVAC:WaterToAirHeatPump,
3629736299
\memo Water-to-air heat pump. Forced-convection heating-cooling unit with supply fan,
3629836300
\memo water-to-air cooling and heating coils, supplemental heating coil (gas, electric, hot
3629936301
\memo water, or steam), and fixed-position outdoor air mixer.
36300-
\min-fields 21
36302+
\min-fields 22
3630136303
A1, \field Name
3630236304
\required-field
3630336305
\type alpha
@@ -36357,6 +36359,7 @@ ZoneHVAC:WaterToAirHeatPump,
3635736359
\key Yes
3635836360
\key No
3635936361
\default Yes
36362+
\note This field is not used when Design Specification Multispeed Object Type input is present
3636036363
\note When Yes is selected the minimum air flow rate is used.
3636136364
\note When No is selected the maximum air flow rate is used.
3636236365
N4 , \field Cooling Outdoor Air Flow Rate
@@ -63415,12 +63418,13 @@ AirLoopHVAC:UnitarySystem,
6341563418
\note Enter the supply air volume flow rate as a fraction of the heating capacity.
6341663419
\note Required field when No Load Supply Air Flow Rate Method is FlowPerHeatingCapacity.
6341763420
A23, \field No Load Supply Air Flow Rate Control Set To Low Speed
63418-
\type choice
63419-
\key Yes
63420-
\key No
63421-
\default Yes
63422-
\note When Yes is selected the minimum air flow rate is used.
63423-
\note When No is selected the maximum air flow rate is used.
63421+
\type choice
63422+
\key Yes
63423+
\key No
63424+
\default Yes
63425+
\note This field is not used when Design Specification Multispeed Object Type input is present
63426+
\note When Yes is selected the minimum air flow rate is used.
63427+
\note When No is selected the maximum air flow rate is used.
6342463428
N17, \field Maximum Supply Air Temperature
6342563429
\type real
6342663430
\units C

‎src/ExpandObjects/epfilter.f90

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16103,6 +16103,7 @@ SUBROUTINE CreateNewUnitary
1610316103
CALL AddToObjStr('No Load Fraction of Autosized Heating Supply Air Flow Rate','')
1610416104
CALL AddToObjStr('No Load Supply Air Flow Rate Per Unit of Capacity During Cooling Operation {m3/s-W','')
1610516105
CALL AddToObjStr('No Load Supply Air Flow Rate Per Unit of Capacity During Heating Operation {m3/s-W','')
16106+
CALL AddToObjStr('No Load Supply Air Flow Rate Control Set To Low Speed','')
1610616107
CALL AddToObjStr('Maximum Supply Air Temperature {C}', 'Autosize')
1610716108
CALL AddToObjFld('Maximum Outdoor Dry-Bulb Temperature for Supplemental Heater Operation {C}', base + ussSuppReHeatMaxODBOff,'')
1610816109
CALL AddToObjStr('Outdoor Dry-Bulb Temperature Sensor Node Name', '')
@@ -25050,6 +25051,7 @@ SUBROUTINE CreatePTAC
2505025051
CALL AddToObjFld('No Load Supply Air Flow Rate {m3/s}', &
2505125052
base + ptaczSupplyNoLoadFlowRateOff,'')
2505225053
END IF
25054+
CALL AddToObjStr('No Load Supply Air Flow Rate Control Set To Low Speed','')
2505325055
IF (isDedOutAirNameBlank) THEN
2505425056
CALL AddToObjStr('Cooling Outdoor Air Flow Rate {m3/s}','autosize')
2505525057
CALL AddToObjStr('Heating Outdoor Air Flow Rate {m3/s}','autosize')
@@ -25657,6 +25659,7 @@ SUBROUTINE CreatePTHP
2565725659
CALL AddToObjFld('No Load Supply Air Flow Rate {m3/s}', &
2565825660
base + pthpzSupplyNoLoadFlowRateOff,'')
2565925661
END IF
25662+
CALL AddToObjStr('No Load Supply Air Flow Rate Control Set To Low Speed','')
2566025663
IF (isDedOutAirNameBlank) THEN
2566125664
CALL AddToObjStr('Cooling Outdoor Air Flow Rate {m3/s}','autosize')
2566225665
CALL AddToObjStr('Heating Outdoor Air Flow Rate {m3/s}','autosize')
@@ -30025,6 +30028,7 @@ SUBROUTINE CreateWaterAirHP
3002530028
CALL AddToObjStr('Heating Supply Air Flow Rate {m3/s}','autosize')
3002630029
CALL AddToObjFld('No Load Supply Air Flow Rate {m3/s}', &
3002730030
base + wahpSupplyNoLoadFlowRateOff,'')
30031+
CALL AddToObjStr('No Load Supply Air Flow Rate Control Set To Low Speed','')
3002830032
IF (isDedOutAirNameBlank) THEN
3002930033
CALL AddToObjStr('Cooling Outdoor Air Flow Rate {m3/s}','autosize')
3003030034
CALL AddToObjStr('Heating Outdoor Air Flow Rate {m3/s}','autosize')

‎src/Transition/CreateNewIDFUsingRulesV24_1_0.f90

Lines changed: 43 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,18 @@ SUBROUTINE CreateNewIDFUsingRules(EndOfFile,DiffOnly,InLfn,AskForInput,InputFile
382382
! CurArgs = CurArgs + 1
383383

384384
! If your original object starts with A, insert the rules here
385-
385+
CASE('AIRLOOPHVAC:UNITARYSYSTEM') ! add new input field No Load Supply Air Flow Rate Control Set To Low Speed
386+
CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
387+
nodiff=.false.
388+
OutArgs(38)=InArgs(38)
389+
! OutArgs(39) is added. If existing coil is VS DX cooling or heating coil then set YES, otherwise set NO
390+
IF ( SameString(InArgs(12),'Coil:Heating:DX:VariableSpeed') .or. SameString(InArgs(15),'Coil:Cooling:DX:VariableSpeed') ) THEN
391+
OutArgs(39) = 'YES'
392+
ELSE
393+
OutArgs(39) = 'NO'
394+
END IF
395+
OutArgs(40:CurArgs+1)=InArgs(39:CurArgs)
396+
CurArgs = CurArgs + 1
386397
! If your original object starts with C, insert the rules here
387398
CASE('COMFORTVIEWFACTORANGLES')
388399
CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
@@ -434,6 +445,37 @@ SUBROUTINE CreateNewIDFUsingRules(EndOfFile,DiffOnly,InLfn,AskForInput,InputFile
434445
! If your original object starts with W, insert the rules here
435446

436447
! If your original object starts with Z, insert the rules here
448+
CASE('ZONEHVAC:PACKAGEDTERMINALAIRCONDTIIONER') ! add new input field No Load Supply Air Flow Rate Control Set To Low Speed
449+
CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
450+
nodiff=.false.
451+
OutArgs(9)=InArgs(9)
452+
! OutArgs(39) is added. If existing coil is VS DX cooling or heating coil then set YES, otherwise set NO
453+
IF ( SameString(InArgs(18),'Coil:Cooling:DX:VariableSpeed') ) THEN
454+
OutArgs(10) = 'YES'
455+
ELSE
456+
OutArgs(10) = 'NO'
457+
END IF
458+
OutArgs(11:CurArgs+1)=InArgs(10:CurArgs)
459+
CurArgs = CurArgs + 1
460+
CASE('ZONEHVAC:PACKAGEDTERMINALHEATPUMP') ! add new input field No Load Supply Air Flow Rate Control Set To Low Speed
461+
CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
462+
nodiff=.false.
463+
OutArgs(9)=InArgs(9)
464+
! OutArgs(39) is added. If existing coil is VS DX cooling or heating coil then set YES, otherwise set NO
465+
IF ( SameString(InArgs(16),'Coil:Heating:DX:VariableSpeed') .or. SameString(InArgs(19),'Coil:Cooling:DX:VariableSpeed') ) THEN
466+
OutArgs(10) = 'YES'
467+
ELSE
468+
OutArgs(10) = 'NO'
469+
END IF
470+
OutArgs(11:CurArgs+1)=InArgs(10:CurArgs)
471+
CurArgs = CurArgs + 1
472+
CASE('ZONEHVAC:WATERTOAIRHEATPUMP') ! add new input field No Load Supply Air Flow Rate Control Set To Low Speed
473+
CALL GetNewObjectDefInIDD(ObjectName,NwNumArgs,NwAorN,NwReqFld,NwObjMinFlds,NwFldNames,NwFldDefaults,NwFldUnits)
474+
nodiff=.false.
475+
OutArgs(9)=InArgs(9)
476+
OutArgs(10) = 'NO' ! Coil:Heating:WaterToAirHeatPump:VariableSpeedEquationFit was not previously used to set no load air flow rate
477+
OutArgs(11:CurArgs+1)=InArgs(10:CurArgs)
478+
CurArgs = CurArgs + 1
437479

438480
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
439481
! Changes for report variables, meters, tables -- update names !

‎src/Transition/InputRulesFiles/Rules23-2-0-to-24-1-0.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ The alpha/numeric A/N numbers are not as important here.
1212

1313
# Object Change: ObjectStartsWithA
1414

15+
# Object Change: AirloopHVAC:UnitarySystem
16+
Field 39 (A23) No Load Supply Air Flow Rate Control Set To Low Speed is inserted. The remaining fields are shifted down. If the cooling or heating coil is Coil:*:DX:VariableSpeed the field is Yes, otherwise No.
17+
1518
# Object Change: ObjectStartsWithB
1619

1720
# Object Change: ComfortViewFactorAngles
@@ -83,3 +86,12 @@ Field 13 (A7) Mean Radiant Temperature Calculation Type (mean_radiant_temperatur
8386
# Object Change: ObjectStartsWithY
8487

8588
# Object Change: ObjectStartsWithZ
89+
90+
# Object Change: ZoneHVAC:PackagedTerminalAirConditioner
91+
Field 10 (A7) No Load Supply Air Flow Rate Control Set To Low Speed is inserted. The remaining fields are shifted down. If the cooling is Coil:Cooling:DX:VariableSpeed the field is Yes, otherwise No.
92+
93+
# Object Change: ZoneHVAC:PackagedTerminalHeatPump
94+
Field 10 (A7) No Load Supply Air Flow Rate Control Set To Low Speed is inserted. The remaining fields are shifted down. If the cooling or heating coil is Coil:*:DX:VariableSpeed the field is Yes, otherwise No.
95+
96+
# Object Change: ZoneHVAC:WaterToAirHeatPump
97+
Field 10 (A7) No Load Supply Air Flow Rate Control Set To Low Speed is inserted. The remaining fields are shifted down. The value can be set to No.

0 commit comments

Comments
 (0)