Merge pull request #10495 from NREL/ghe_bugs

Fix GHE Bugs

Author: Myoldmopar

.decent_ci-Linux.yaml

@@ -5,7 +5,7 @@ compilers:
     collect_performance_results: true
     skip_regression: true
     s3_upload_bucket: energyplus
-    num_parallel_builds: 18
+    num_parallel_builds: 16
 
   - name: "gcc"
     version: "13.2"
@@ -20,7 +20,7 @@ compilers:
     ctest_filter: -E "integration.*"
     skip_regression: true
     skip_packaging: true
-    num_parallel_builds: 18
+    num_parallel_builds: 16
 
   - name: "gcc"
     version: "13.2"
@@ -35,4 +35,4 @@ compilers:
     ctest_filter: -R "integration.*"
     skip_regression: true
     skip_packaging: true
-    num_parallel_builds: 18
+    num_parallel_builds: 16

dictionary.dic

@@ -0,0 +1,32 @@
+AirLoopHVAC
+AirToAir
+BalancedFlow
+Celdek
+CeldekPad
+CoilSystem
+ComponentModel
+ConstantVolume
+DetailedGeometry
+Evaporative
+EvaporativeCooler
+FlatPlate
+HeatExchanger
+HeatExchangerAssisted
+HVACDOAS
+Liesen
+NoFans
+OutdoorAir
+OutdoorAirSystem
+PhotovoltaicThermal
+ResearchSpecial
+SensibleAndLatent
+SolarCollector
+SystemModel
+TerminalUnit
+UnglazedTranspired
+UnitarySystem
+UserDefined
+VariableRefrigerantFlow
+VariableVolume
+WetCoil
+ZoneHVAC

src/EnergyPlus/Data/BaseData.hh

@@ -54,6 +54,7 @@ struct EnergyPlusData; // Forward declaration
 
 struct BaseGlobalStruct
 {
+    virtual ~BaseGlobalStruct() = default;
     virtual void init_state([[maybe_unused]] EnergyPlusData &state) = 0;
     virtual void clear_state() = 0;
 };

src/EnergyPlus/Data/CommonIncludes.hh

@@ -159,7 +159,6 @@
 #include <EnergyPlus/GlobalNames.hh>
 #include <EnergyPlus/GroundHeatExchangers.hh>
 #include <EnergyPlus/GroundTemperatureModeling/FiniteDifferenceGroundTemperatureModel.hh>
-#include <EnergyPlus/GroundTemperatureModeling/GroundTemperatureModelManager.hh>
 #include <EnergyPlus/HVACControllers.hh>
 #include <EnergyPlus/HVACCooledBeam.hh>
 #include <EnergyPlus/HVACDXHeatPumpSystem.hh>

src/EnergyPlus/Data/EnergyPlusData.hh

@@ -50,8 +50,6 @@
 
 // C++ Headers
 #include <memory>
-#include <string>
-#include <unordered_map>
 
 // EnergyPlus Headers
 #include <EnergyPlus/Data/BaseData.hh>

src/EnergyPlus/GroundHeatExchangers.cc

@@ -47,6 +47,7 @@
 
 // C++ Headers
 #include <cmath>
+#include <iterator>
 #include <vector>
 
 // ObjexxFCL Headers
@@ -487,12 +488,10 @@ GLHEResponseFactors::GLHEResponseFactors(EnergyPlusData &state, std::string cons
     }
 
     this->numGFuncPairs = static_cast<int>(tmpLntts.size());
-    this->LNTTS.dimension(this->numGFuncPairs, 0.0);
-    this->GFNC.dimension(this->numGFuncPairs, 0.0);
 
     for (int i = 1; i <= (int)tmpLntts.size(); ++i) {
-        this->LNTTS(i) = tmpLntts[i - 1];
-        this->GFNC(i) = tmpGvals[i - 1];
+        this->LNTTS.push_back(tmpLntts[i - 1]);
+        this->GFNC.push_back(tmpGvals[i - 1]);
     }
 }
 
@@ -649,7 +648,7 @@ BuildAndGetResponseFactorsObjectFromSingleBHs(EnergyPlusData &state, std::vector
     // Make new props object which has the mean values of the other props objects referenced by the individual BH objects
     std::shared_ptr<GLHEVertProps> thisProps(new GLHEVertProps);
     thisProps->name = format("Response Factor Auto Generated Mean Props No: {}", state.dataGroundHeatExchanger->numAutoGeneratedResponseFactors + 1);
-    for (auto &thisBH : state.dataGroundHeatExchanger->singleBoreholesVector) {
+    for (auto &thisBH : singleBHsForRFVect) {
         thisProps->bhDiameter += thisBH->props->bhDiameter;
         thisProps->bhLength += thisBH->props->bhLength;
         thisProps->bhTopDepth += thisBH->props->bhTopDepth;
@@ -962,18 +961,12 @@ void GLHEVert::calcUniformBHWallTempGFunctions(EnergyPlusData &state)
         boreholes.emplace_back(bh->props->bhLength, bh->props->bhTopDepth, bh->props->bhDiameter / 2.0, bh->xLoc, bh->yLoc);
     }
 
-    // convert time to a std::vector from an Array1D
-    std::vector<double> time;
-    for (auto &v : this->myRespFactors->time) {
-        time.push_back(v);
-    }
-
     // Obtain number of segments by adaptive discretization
     gt::segments::adaptive adptDisc;
     int nSegments = adptDisc.discretize(this->bhLength, this->totalTubeLength);
 
-    this->myRespFactors->GFNC =
-        gt::gfunction::uniform_borehole_wall_temperature(boreholes, time, this->soil.diffusivity, nSegments, true, state.dataGlobal->numThread);
+    this->myRespFactors->GFNC = gt::gfunction::uniform_borehole_wall_temperature(
+        boreholes, this->myRespFactors->time, this->soil.diffusivity, nSegments, true, state.dataGlobal->numThread);
 }
 
 //******************************************************************************
@@ -989,8 +982,8 @@ void GLHEVert::calcGFunctions(EnergyPlusData &state)
 
     // save data for later
     if (state.files.outputControl.glhe && !state.dataSysVars->DisableGLHECaching) {
-        myCacheData["Response Factors"]["time"] = std::vector<Real64>(this->myRespFactors->time.begin(), this->myRespFactors->time.end());
-        myCacheData["Response Factors"]["LNTTS"] = std::vector<Real64>(this->myRespFactors->LNTTS.begin(), this->myRespFactors->LNTTS.end());
+        myCacheData["Response Factors"]["time"] = std::vector<Real64>(this->myRespFactors->time);
+        myCacheData["Response Factors"]["LNTTS"] = std::vector<Real64>(this->myRespFactors->LNTTS);
         myCacheData["Response Factors"]["GFNC"] = std::vector<Real64>(this->myRespFactors->GFNC.begin(), this->myRespFactors->GFNC.end());
         writeGLHECacheToFile(state);
     }
@@ -1025,17 +1018,12 @@ void GLHEVert::setupTimeVectors()
         }
     }
 
-    // Setup the arrays
-    this->myRespFactors->time.dimension(tempLNTTS.size(), 0.0);
-    this->myRespFactors->LNTTS.dimension(tempLNTTS.size(), 0.0);
-    this->myRespFactors->GFNC.dimension(tempLNTTS.size(), 0.0);
-
-    int index = 1;
-    for (auto const &thisLNTTS : tempLNTTS) {
-        this->myRespFactors->time(index) = exp(thisLNTTS) * t_s;
-        this->myRespFactors->LNTTS(index) = thisLNTTS;
-        ++index;
-    }
+    this->myRespFactors->LNTTS = tempLNTTS;
+    this->myRespFactors->time = tempLNTTS;
+    std::transform(this->myRespFactors->time.begin(), this->myRespFactors->time.end(), this->myRespFactors->time.begin(), [&t_s](auto &c) {
+        return exp(c) * t_s;
+    });
+    this->myRespFactors->GFNC = std::vector<Real64>(tempLNTTS.size(), 0.0);
 }
 
 //******************************************************************************
@@ -1045,15 +1033,15 @@ void GLHEVert::calcUniformHeatFluxGFunctions(EnergyPlusData &state)
     DisplayString(state, "Initializing GroundHeatExchanger:System: " + this->name);
 
     // Calculate the g-functions
-    for (size_t lntts_index = 1; lntts_index <= this->myRespFactors->LNTTS.size(); ++lntts_index) {
+    for (size_t lntts_index = 0; lntts_index < this->myRespFactors->LNTTS.size(); ++lntts_index) {
         for (auto const &bh_i : this->myRespFactors->myBorholes) {
             Real64 sum_T_ji = 0;
             for (auto const &bh_j : this->myRespFactors->myBorholes) {
-                sum_T_ji += doubleIntegral(bh_i, bh_j, this->myRespFactors->time(lntts_index));
+                sum_T_ji += doubleIntegral(bh_i, bh_j, this->myRespFactors->time[lntts_index]);
             }
-            this->myRespFactors->GFNC(lntts_index) += sum_T_ji;
+            this->myRespFactors->GFNC[lntts_index] += sum_T_ji;
         }
-        this->myRespFactors->GFNC(lntts_index) /= (2 * this->totalTubeLength);
+        this->myRespFactors->GFNC[lntts_index] /= (2 * this->totalTubeLength);
 
         std::stringstream ss;
         ss << std::fixed << std::setprecision(1) << float(lntts_index) / this->myRespFactors->LNTTS.size() * 100;
@@ -1375,25 +1363,18 @@ void GLHEVert::combineShortAndLongTimestepGFunctions()
     }
 
     // Add the rest of the long time-step g-functions to the combined curve
-    for (int index_longTS = this->myRespFactors->GFNC.l(); index_longTS <= this->myRespFactors->GFNC.u(); ++index_longTS) {
-        GFNC_combined.push_back(this->myRespFactors->GFNC(index_longTS));
-        LNTTS_combined.push_back(this->myRespFactors->LNTTS(index_longTS));
+    for (int index_longTS = 0; index_longTS < this->myRespFactors->GFNC.size(); ++index_longTS) {
+        GFNC_combined.push_back(this->myRespFactors->GFNC[index_longTS]);
+        LNTTS_combined.push_back(this->myRespFactors->LNTTS[index_longTS]);
     }
 
-    // Move combined values into right data struct
-    this->myRespFactors->time.deallocate();
-    this->myRespFactors->LNTTS.deallocate();
-    this->myRespFactors->GFNC.deallocate();
+    this->myRespFactors->time = LNTTS_combined;
+    std::transform(this->myRespFactors->time.begin(), this->myRespFactors->time.end(), this->myRespFactors->time.begin(), [&t_s](auto &c) {
+        return exp(c) * t_s;
+    });
 
-    this->myRespFactors->time.dimension(GFNC_combined.size(), 0.0);
-    this->myRespFactors->LNTTS.dimension(GFNC_combined.size(), 0.0);
-    this->myRespFactors->GFNC.dimension(GFNC_combined.size(), 0.0);
-
-    for (unsigned int index = 0; index < GFNC_combined.size(); ++index) {
-        this->myRespFactors->time[index] = exp(LNTTS_combined[index]) * t_s;
-        this->myRespFactors->LNTTS[index] = LNTTS_combined[index];
-        this->myRespFactors->GFNC[index] = GFNC_combined[index];
-    }
+    this->myRespFactors->LNTTS = LNTTS_combined;
+    this->myRespFactors->GFNC = GFNC_combined;
 }
 
 void GLHEBase::makeThisGLHECacheAndCompareWithFileCache(EnergyPlusData &state)
@@ -1460,13 +1441,13 @@ void GLHEVert::readCacheFileAndCompareWithThisGLHECache(EnergyPlusData &state)
 
     if (gFunctionsExist) {
         // Populate the time array
-        this->myRespFactors->time = Array1D<Real64>(myCacheData["Response Factors"]["time"].get<std::vector<Real64>>());
+        this->myRespFactors->time = std::vector<Real64>(myCacheData["Response Factors"]["time"].get<std::vector<Real64>>());
 
         // Populate the lntts array
-        this->myRespFactors->LNTTS = Array1D<Real64>(myCacheData["Response Factors"]["LNTTS"].get<std::vector<Real64>>());
+        this->myRespFactors->LNTTS = std::vector<Real64>(myCacheData["Response Factors"]["LNTTS"].get<std::vector<Real64>>());
 
         // Populate the g-function array
-        this->myRespFactors->GFNC = Array1D<Real64>(myCacheData["Response Factors"]["GFNC"].get<std::vector<Real64>>());
+        this->myRespFactors->GFNC = std::vector<Real64>(myCacheData["Response Factors"]["GFNC"].get<std::vector<Real64>>());
     }
 }
 
@@ -1522,18 +1503,13 @@ void GLHESlinky::calcGFunctions(EnergyPlusData &state)
     int NPairs = static_cast<int>((tLg_max - tLg_min) / (tLg_grid) + 1);
 
     // Allocate and setup g-function arrays
-    this->myRespFactors->GFNC.allocate(NPairs);
-    this->myRespFactors->LNTTS.allocate(NPairs);
+    this->myRespFactors->GFNC = std::vector<Real64>(NPairs, 0.0);
+    this->myRespFactors->LNTTS = std::vector<Real64>(NPairs, 0.0);
     this->QnMonthlyAgg.allocate(static_cast<int>(this->maxSimYears * 12));
     this->QnHr.allocate(730 + this->AGG + this->SubAGG);
     this->QnSubHr.allocate(static_cast<int>((this->SubAGG + 1) * maxTSinHr + 1));
     this->LastHourN.allocate(this->SubAGG + 1);
 
-    for (int i = 1; i <= NPairs; ++i) {
-        this->myRespFactors->GFNC(i) = 0.0;
-        this->myRespFactors->LNTTS(i) = 0.0;
-    }
-
     // Calculate the number of loops (per trench) and number of trenches to be involved
     // Due to the symmetry of a slinky GHX field, we need only calculate about
     // on quarter of the rings' tube wall temperature perturbation to get the
@@ -1652,8 +1628,8 @@ void GLHESlinky::calcGFunctions(EnergyPlusData &state)
             }         // n1
         }             // m1
 
-        this->myRespFactors->GFNC(NT) = (gFunc * (this->coilDiameter / 2.0)) / (4 * Constant::Pi * fraction * this->numTrenches * this->numCoils);
-        this->myRespFactors->LNTTS(NT) = tLg;
+        this->myRespFactors->GFNC[NT - 1] = (gFunc * (this->coilDiameter / 2.0)) / (4 * Constant::Pi * fraction * this->numTrenches * this->numCoils);
+        this->myRespFactors->LNTTS[NT - 1] = tLg;
 
     } // NT time
 }
@@ -1834,7 +1810,7 @@ inline bool GLHEBase::isEven(int const val)
 
 //******************************************************************************
 
-Real64 GLHESlinky::integral(int const m, int const n, int const m1, int const n1, Real64 const t, Real64 const eta, Real64 const J0)
+Real64 GLHESlinky::integral(int const m, int const n, int const m1, int const n1, Real64 const t, Real64 const eta, int const J0)
 {
     // SUBROUTINE INFORMATION:
     //       AUTHOR:          Matt Mitchell
@@ -1848,33 +1824,28 @@ Real64 GLHESlinky::integral(int const m, int const n, int const m1, int const n1
     // Simpson's 1/3 rule of integration
 
     // SUBROUTINE LOCAL VARIABLE DECLARATIONS:
-    Real64 sumIntF = 0.0;
     Real64 theta = 0.0;
     constexpr Real64 theta1 = 0.0;
     constexpr Real64 theta2 = 2 * Constant::Pi;
-    Array1D<Real64> f(J0, 0.0);
+    std::vector<Real64> f;
 
     Real64 h = (theta2 - theta1) / (J0 - 1);
 
     // Calculate the function at various equally spaced x values
-    for (int j = 1; j <= J0; ++j) {
-
-        theta = theta1 + (j - 1) * h;
-
-        f(j) = nearFieldResponseFunction(m, n, m1, n1, eta, theta, t);
+    for (int j = 0; j < J0; ++j) {
+        theta = theta1 + j * h;
+        f.push_back(nearFieldResponseFunction(m, n, m1, n1, eta, theta, t));
+    }
 
-        if (j == 1 || j == J0) {
-            f(j) = f(j);
-        } else if (isEven(j)) {
-            f(j) = 4 * f(j);
+    for (int j = 1; j < J0 - 1; ++j) {
+        if (!isEven(j)) {
+            f[j] = 4 * f[j];
         } else {
-            f(j) = 2 * f(j);
+            f[j] = 2 * f[j];
         }
-
-        sumIntF += f(j);
     }
 
-    return (h / 3) * sumIntF;
+    return (h / 3) * std::reduce(f.begin(), f.end());
 }
 
 //******************************************************************************
@@ -1896,29 +1867,25 @@ Real64 GLHESlinky::doubleIntegral(int const m, int const n, int const m1, int co
     constexpr Real64 eta1 = 0.0;
     constexpr Real64 eta2 = 2 * Constant::Pi;
 
-    Real64 sumIntF = 0.0;
-    Array1D<Real64> g(I0, 0.0);
+    std::vector<Real64> g;
 
     Real64 h = (eta2 - eta1) / (I0 - 1);
 
     // Calculates the value of the function at various equally spaced values
-    for (int i = 1; i <= I0; ++i) {
-
-        Real64 eta = eta1 + (i - 1) * h;
-        g(i) = integral(m, n, m1, n1, t, eta, J0);
+    for (int i = 0; i < I0; ++i) {
+        Real64 eta = eta1 + i * h;
+        g.push_back(integral(m, n, m1, n1, t, eta, J0));
+    }
 
-        if (i == 1 || i == I0) {
-            g(i) = g(i);
-        } else if (isEven(i)) {
-            g(i) = 4 * g(i);
+    for (int i = 1; i < g.size() - 1; ++i) {
+        if (!isEven(i)) {
+            g[i] = 4 * g[i];
         } else {
-            g(i) = 2 * g(i);
+            g[i] = 2 * g[i];
         }
-
-        sumIntF += g(i);
     }
 
-    return (h / 3) * sumIntF;
+    return (h / 3) * std::reduce(g.begin(), g.end());
 }
 
 //******************************************************************************