Skip to content

Commit

Permalink
Correct DOAS VS DX cooling coil sizing
Browse files Browse the repository at this point in the history
  • Loading branch information
rraustad committed Dec 16, 2023
1 parent 08733a7 commit aeec774
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion src/EnergyPlus/VariableSpeedCoils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4809,13 +4809,24 @@ namespace VariableSpeedCoils {
if (state.dataSize->CurOASysNum > 0 && state.dataAirLoop->OutsideAirSys(state.dataSize->CurOASysNum).AirLoopDOASNum > -1) {
auto &thisAirloopDOAS =
state.dataAirLoopHVACDOAS->airloopDOAS[state.dataAirLoop->OutsideAirSys(state.dataSize->CurOASysNum).AirLoopDOASNum];
VolFlowRate = thisAirloopDOAS.SizingMassFlow / state.dataEnvrn->StdRhoAir;
VolFlowRate = varSpeedCoil.RatedAirVolFlowRate;
MixTemp = thisAirloopDOAS.SizingCoolOATemp;
SupTemp = thisAirloopDOAS.PrecoolTemp;
MixHumRat = thisAirloopDOAS.SizingCoolOAHumRat;
SupHumRat = thisAirloopDOAS.PrecoolHumRat;
RatedCapCoolTotalDes = VolFlowRate * state.dataEnvrn->StdRhoAir *
(Psychrometrics::PsyHFnTdbW(MixTemp, MixHumRat) - Psychrometrics::PsyHFnTdbW(SupTemp, SupHumRat));
if (varSpeedCoil.MSCCapFTemp(varSpeedCoil.NormSpedLevel) > 0) {
MixWetBulb = Psychrometrics::PsyTwbFnTdbWPb(state, MixTemp, MixHumRat, state.dataEnvrn->StdBaroPress, RoutineName);
if (varSpeedCoil.CondenserType == DataHeatBalance::RefrigCondenserType::Air) {
RatedSourceTempCool = thisAirloopDOAS.SizingCoolOATemp;
} else {
RatedSourceTempCool = GetVSCoilRatedSourceTemp(state, DXCoilNum);
}
TotCapTempModFac =
Curve::CurveValue(state, varSpeedCoil.MSCCapFTemp(varSpeedCoil.NormSpedLevel), MixWetBulb, RatedSourceTempCool);
RatedCapCoolTotalDes /= TotCapTempModFac;
}
} else {
auto &finalSysSizing = state.dataSize->FinalSysSizing(state.dataSize->CurSysNum);
VolFlowRate = varSpeedCoil.RatedAirVolFlowRate;
Expand Down

5 comments on commit aeec774

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10332-DOAS-incorrect-system-name-in-CoilDetails (rraustad) - Win64-Windows-10-VisualStudio-16: OK (2753 of 2759 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 783
  • Failed: 6

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10332-DOAS-incorrect-system-name-in-CoilDetails (rraustad) - x86_64-MacOS-10.17-clang-14.0.0: OK (3532 of 3546 tests passed, 0 test warnings)

Messages:\n

  • 8 tests had: Table big diffs.

Failures:\n

integration Test Summary

  • Passed: 783
  • Failed: 6

regression Test Summary

  • Passed: 778
  • Failed: 8

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10332-DOAS-incorrect-system-name-in-CoilDetails (rraustad) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3573 of 3587 tests passed, 0 test warnings)

Messages:\n

  • 8 tests had: Table big diffs.

Failures:\n

integration Test Summary

  • Passed: 786
  • Failed: 6

regression Test Summary

  • Passed: 798
  • Failed: 8

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10332-DOAS-incorrect-system-name-in-CoilDetails (rraustad) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: Tests Failed (689 of 790 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 689
  • Failed: 101

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10332-DOAS-incorrect-system-name-in-CoilDetails (rraustad) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1971 of 1972 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1485
  • Failed: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.