Hotfix #10961 - New E+ 25.1 warnings for Schedule:Year + #10955 #10966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
Defect
jmarrec
commented
Mar 4, 2025
Comment on lines
+97
to
+102
| for (int i = 0; i < (int)s_sched->scheduleTypes.size(); ++i) { | ||
| if (s_sched->scheduleTypes[i]->Name == name) { | ||
| return i; | ||
| } | ||
| } | ||
| return SchedNum_Invalid; |
There was a problem hiding this comment.
Return the same constexpr int for clarity.
And use braces so we can set a breakpoint if we want to. (we should tell clang-format to always do that IMHO)
| @@ -1094,7 +1097,7 @@ namespace Sched { | |||
| if (lAlphaBlanks(2)) { | |||
| ShowWarningEmptyField(state, eoh, cAlphaFields(2)); | |||
| ShowContinueError(state, "Schedule will not be validated."); | |||
| } else if ((sched->schedTypeNum = GetScheduleTypeNum(state, Alphas(2))) == 0) { | |||
| } else if ((sched->schedTypeNum = GetScheduleTypeNum(state, Alphas(2))) == SchedNum_Invalid) { | |||
There was a problem hiding this comment.
Fix for Schedule:Year
jmarrec
changed the title
jmarrec
commented
Mar 4, 2025
| @@ -3119,8 +3119,7 @@ void OpenOutputTabularFile(EnergyPlusData &state) | |||
| open_tbl_stream(state, iStyle, state.dataStrGlobals->outputTblXmlFilePath, state.files.outputControl.tabular); | |||
| tbl_stream << "<?xml version=\"1.0\"?>\n"; | |||
| tbl_stream << "<EnergyPlusTabularReports>\n"; | |||
| tbl_stream << " <state.dataHeatBal->BuildingName>" << ConvertToEscaped(state.dataHeatBal->BuildingName) | |||
| << "</state.dataHeatBal->BuildingName>\n"; | |||
| tbl_stream << " <BuildingName>" << ConvertToEscaped(state.dataHeatBal->BuildingName) << "</BuildingName>\n"; | |||
There was a problem hiding this comment.
- Fix for unintended xml output #10955
|
|
|
|
|
diffs in AtticRoof_RadiantBarriers eplusout.err ---
+++
@@ -1,46 +1,4 @@
-line skipped-- ** Warning ** ProcessScheduleInput: Schedule:Year = LIGHTING SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = CLOTHES DRYER EXHAUST SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = CLOTHES DRYER SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = CLOTHES WASHER SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = COOKING RANGE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = COOLING SEASON SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = DHW FIXTURES SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = DISHWASHER SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = EXTERIOR LIGHTING SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = FRIDGE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = HEATING SEASON SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = MISC PLUG LOADS SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = MISC TV SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
- ** Warning ** ProcessScheduleInput: Schedule:Year = OCCUPANTS SCHEDULE
- ** ~~~ ** Schedule Type Limits Name = FRACTIONAL, item not found.
- ** ~~~ ** Schedule will not be validated.
************* Note that the following warning(s) may/will occur if you have not enclosed your zone completely.
** Warning ** Entered Zone Volumes differ from calculated zone volume(s).
** ~~~ ** ...use Output:Diagnostics,DisplayExtraWarnings; to show more details on individual zones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
GetScheduleTypeNum returns 0 for the first one found (vector is 0-indexed)
Pull Request Author
Reviewer