Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects WWHP heat recovery identification and plant water flow rate sizing #10969

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Corrects WWHP heat recovery identification and plant water flow rate sizing #10969

wants to merge 1 commit into from

Conversation

rraustad
Copy link
Contributor

@rraustad rraustad commented Mar 4, 2025

Pull request overview

Description of the purpose of this PR

This change allows a WWHP heat recovery unit to be correctly identified and act as a passive plant object that does not increase plant water flow rate.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Mar 4, 2025
@rraustad
Copy link
Contributor Author

rraustad commented Mar 4, 2025 •
edited
Loading

Plant sizing corrected in this branch (among other sizing changes):

Component Sizing Information, PlantLoop, COOLSYS1, Maximum Loop Flow Rate [m3/s], 0.20312

rraustad
rraustad commented Mar 4, 2025
View reviewed changes
src/EnergyPlus/PlantLoopHeatPumpEIR.cc
}
if (this->sourceSideNodes.outlet == thisLoopSide.NodeNumOut) {
sourceSideIsPlantOutlet = true;
break;
Copy link
Contributor Author

@rraustad rraustad Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the order of the PlantLoop objects is such that either of these checks is last in the loops, the break will bypass the conditional check below that identifies the WWHP as a heat recovery unit. Note the order of the PlantLoop objects in the defect file is different than the original example file and was purposely changed to show this defect (and a WWHP was added to test this part of the code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
EnergyPlus 25.1
Development

Successfully merging this pull request may close these issues.

PlantLoop object order can lead to water-to-water heat pump (WWHP) being missed as a heat recovery unit
3 participants
@rraustad @nrel-bot-2 @nrel-bot-2c