Skip to content

Rename the schematron file extension to .sch #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2025
Merged

Conversation

shorowit
Copy link
Contributor

Pull Request Description

Addresses #1821. Tests NREL/OpenStudio#5333.

Can't merge this in until the next OS release.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Dec 19, 2024
@shorowit shorowit mentioned this pull request Feb 6, 2025
5 tasks
@shorowit shorowit moved this from Blocker/On Hold to In progress in OpenStudio-HPXML Mar 4, 2025
@shorowit shorowit added this to the 1.10.0 milestone Mar 18, 2025
@shorowit shorowit changed the base branch from master to os1_10_0 May 3, 2025 15:56
shorowit added 2 commits May 3, 2025 10:01
…nto schematron_sch

# Conflicts:
#	Changelog.md
#	HPXMLtoOpenStudio/resources/version.rb
#	docs/source/workflow_inputs.rst
@shorowit shorowit marked this pull request as ready for review May 3, 2025 17:40
@shorowit shorowit merged commit 239c095 into os1_10_0 May 3, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in OpenStudio-HPXML May 3, 2025
@shorowit shorowit deleted the schematron_sch branch May 3, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant