Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong check for F_NotchType's value #247

Closed
R-Quancard opened this issue Jun 13, 2023 · 2 comments
Closed

Wrong check for F_NotchType's value #247

R-Quancard opened this issue Jun 13, 2023 · 2 comments

Comments

@R-Quancard
Copy link

Hello,
I've noticed that mode 3 of F_NotchType could not be used because CheckInputs only allows 0, 1 or 2. Actually, the suitable check is there (allowing 0 to 3) but an additional one blocks the case F_NotchType = 3, so that second one should be removed.

! F_NotchType
IF ((CntrPar%F_NotchType < 0) .OR. (CntrPar%F_NotchType > 3)) THEN
ErrVar%aviFAIL = -1
ErrVar%ErrMsg = 'F_NotchType must be 0, 1, 2, or 3.'
ENDIF
! F_NotchType
IF ((CntrPar%F_NotchType < 0) .OR. (CntrPar%F_NotchType > 2)) THEN
ErrVar%aviFAIL = -1
ErrVar%ErrMsg = 'F_NotchType must be 0, 1, or 2.'
ENDIF

@dzalkind
Copy link
Collaborator

Good catch...thanks!

I have pushed a change to #246.

Best, Dan

@dzalkind
Copy link
Collaborator

This should be in the develop branch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants