Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return monthly data with months as integers rather than abbreviated strings #3

Open
GUI opened this issue Nov 13, 2014 · 2 comments
Open

Comments

@GUI
Copy link
Member

GUI commented Nov 13, 2014

Feedback from our API Usability Testing: In the solar resource output, we return monthly data as an object where the keys are month abbreviations (eg, "jan", "mar"). It was suggested that we use integers for months instead (so 1-12), which is a little more universal, and also makes things easier to sort on or iterate through.

@reger
Copy link
Collaborator

reger commented Nov 14, 2014

This was because the original python service returned the data that way.

@GUI
Copy link
Member Author

GUI commented Nov 14, 2014

Yeah, I don't think we can necessarily make changes like this in any of our existing APIs due to backwards compatibility issues, but I think this would be a good thing to generally discuss the next time we're releasing a new version or a new API that deals with months.

GUI pushed a commit that referenced this issue May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants