Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused arguments in ResStockArguments measure #1266

Closed
shorowit opened this issue Jul 10, 2024 · 2 comments
Closed

Unused arguments in ResStockArguments measure #1266

shorowit opened this issue Jul 10, 2024 · 2 comments
Labels

Comments

@shorowit
Copy link
Contributor

shorowit commented Jul 10, 2024

I noticed a couple unused arguments in the ResStockArguments measure:

  • ceiling_insulation_r
  • heat_pump_backup_use_existing_system

Either they should be used or, if it's correct that they aren't used, they should be removed.

@shorowit shorowit added the bug label Jul 10, 2024
@joseph-robertson
Copy link
Contributor

joseph-robertson commented Jul 10, 2024

ApplyUpgrade uses them here and here. Maybe there's another way to pass them through; I'm open to suggestions.

@shorowit
Copy link
Contributor Author

Thanks, I didn't consider that it might be used downstream. I'll close this then. (I guess there could be a comment next to the arguments stating they are used by ApplyUpgrade, though presumably a test would fail if someone thought they were unused and actually tried to remove them.)

@shorowit shorowit closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants