New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplyUpgrade can fail silently #1287

Closed

joseph-robertson opened this issue Aug 21, 2024 · 0 comments · Fixed by #1294

Labels

bug

Contributor

joseph-robertson commented Aug 21, 2024 •

edited

Loading

Before adding this commit on #1254, ResStockArguments was failing and causing ApplyUpgrade to preemptively return (as successful but without writing an upgraded.xml file): https://github.com/NREL/resstock/blob/develop/measures/ApplyUpgrade/measure.rb#L299-L301

We need to update ApplyUpgrade (and maybe BuildExistingModel) to fail if ResStockArguments fails.

This may be true for any measure that the BuildExistingModel and ApplyUpgrade meta measures call, not just ResStockArguments.

joseph-robertson added the bug label

joseph-robertson mentioned this issue

ApplyUpgrade: register ResStockArguments runner results to main runner #1294

Merged

6 tasks

joseph-robertson closed this as completed in #1294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment