Rounding feedback opportunity timestamp #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this currently breaks simulations from running since the rest of the code has not been adapted to handle the noise in the timestamps, but will help in testing the situation where it was breaking on the server
simulation will now work with the jittering the previous commit added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a bugfix for an issue where, on the server, feedback opportunities would not execute because the timestamp had a small amount of variance in seconds and the engine expected the timestamp to be an exact match (e.g., a script should trigger at studio on 04-08-22 13:00:00 but the timestamp for the script's actionable feedback is 04-08-22 13:00:04, which would not exact match). The current fix involves flooring the feedback opportunity's timestamp to the nearest 5 mins, which works for now but there might be more robust ways to handle this issue (see #13).
This PR also updates the simulation code for testing locally, where now a small amount of jitter to the system clock is added throughout the simulation. This more closely mimics how the code would execute on the server where, due to execution time, some parts of the code would not execute--for example--every 30 mins on the dot.