set history.maxReviews setting limit to 15, migration changes all Collection Settings that specify a history.maxReviews >15 or = -1 to 15. Does not delete history as part of operation. History records will be pruned to new limit on subsequent review updates.

Author: cd-rite

api/source/service/ReviewService.js

@@ -506,9 +506,7 @@ from
       await connection.query('START TRANSACTION')
 
       if (counts[0].updates) {
-        if (historyMaxReviews !== -1) {
           await connection.query(sqlHistoryPrune, [ historyMaxReviews ])
-        }
         if (historyMaxReviews !== 0) {
           await connection.query(sqlHistory)
         }
@@ -1289,9 +1287,7 @@ where
     async function transaction () {
       await connection.query('START TRANSACTION')
       if (counts[0].updates) {
-        if (historyMaxReviews !== -1) {
           await connection.query(sqlHistoryPrune, [ historyMaxReviews ])
-        }
         if (historyMaxReviews !== 0) {
           await connection.query(sqlHistory)
         }

api/source/service/migrations/0033.js

@@ -0,0 +1,23 @@
+const MigrationHandler = require('./lib/MigrationHandler')
+
+const upMigration = [
+  `UPDATE collection
+   SET settings = JSON_SET(settings, '$.history.maxReviews', 15)
+   WHERE JSON_EXTRACT(settings, '$.history.maxReviews') = -1
+      OR JSON_EXTRACT(settings, '$.history.maxReviews') > 15
+  `
+]
+
+const downMigration = [
+]
+
+const migrationHandler = new MigrationHandler(upMigration, downMigration)
+module.exports = {
+  up: async (pool) => {
+    await migrationHandler.up(pool, __filename)
+  },
+  down: async (pool) => {
+    await migrationHandler.down(pool, __filename)
+  }
+}
+

api/source/specification/stig-manager.yaml

@@ -4960,7 +4960,7 @@ components:
       properties:
         maxReviews:
           example: 5
-          maximum: 50
+          maximum: 15
           minimum: -1
           type: integer
       required:

client/src/js/SM/CollectionForm.js

@@ -1675,10 +1675,9 @@ SM.Collection.HistorySettings.MaxReviewsComboBox = Ext.extend(Ext.form.ComboBox,
         let data = [
             [0, 'disabled']
         ]
-        for (let limit = 1; limit < 51; limit++) {
+        for (let limit = 1; limit < 16; limit++) {
             data.push([limit, `capped at ${limit}`])
         }
-        data.push([-1, 'unlimited'])
         this.store = new Ext.data.SimpleStore({
             fields: ['value', 'display']
         })