Skip to content

fix Windows support for exectuable search and test running #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhpohovey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Windows support for exectuable search and test running #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,23 @@ def find_executables(root_dir):
# Skip if it's a library file
if path.suffix.lower() in ('.dll', '.so', '.dylib'):
continue
# On Windows, only include .exe files
if sys.platform == 'win32' and path.suffix.lower() != '.exe':
continue
executables.append(path)

return executables

def run_single_test_instance(executable, args, output_file, global_args, run_description):
"""Run a single instance of a test executable with specific arguments."""
exe_path = str(executable)
exe_path = str(executable.resolve())
exe_name = executable.name

safe_print(f"Starting {exe_name} {run_description}")

try:
cmd = [f"./{exe_name}"]
# Use the full path to the executable for crossplat compat
cmd = [exe_path]
cmd.extend(args)
if global_args:
cmd.extend(global_args)
Expand Down