Skip to content

Commit 6d49dac

Browse files
committed
Use single image type
Signed-off-by: Evan Lezar <elezar@nvidia.com>
1 parent f34d434 commit 6d49dac

File tree

7 files changed

+5
-118
lines changed

7 files changed

+5
-118
lines changed

.common-ci.yml

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,6 @@ trigger-pipeline:
7878
.dist-ubi9:
7979
variables:
8080
DIST: "ubi9"
81-
rules:
82-
- when: manual
83-
allow_failure: false
84-
85-
.dist-ubuntu20.04:
86-
variables:
87-
DIST: "ubuntu20.04"
8881

8982
# Define the platform targets
9083
.platform-amd64:
@@ -133,23 +126,6 @@ trigger-pipeline:
133126
- .scan-base
134127

135128
# Define the scan targets
136-
scan-ubuntu20.04-amd64:
137-
extends:
138-
- .scan
139-
- .dist-ubuntu20.04
140-
- .platform-amd64
141-
needs:
142-
- image-ubuntu20.04
143-
144-
scan-ubuntu20.04-arm64:
145-
extends:
146-
- .scan
147-
- .dist-ubuntu20.04
148-
- .platform-arm64
149-
needs:
150-
- image-ubuntu20.04
151-
- scan-ubuntu20.04-amd64
152-
153129
scan-ubi9-amd64:
154130
extends:
155131
- .scan
@@ -243,10 +219,3 @@ release:staging-ubi9:
243219
- .dist-ubi9
244220
needs:
245221
- image-ubi9
246-
247-
release:staging-ubuntu20.04:
248-
extends:
249-
- .release:staging
250-
- .dist-ubuntu20.04
251-
needs:
252-
- image-ubuntu20.04

.github/workflows/image.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ on:
2525
jobs:
2626
build:
2727
runs-on: linux-amd64-cpu4
28-
strategy:
29-
matrix:
30-
dist: [ubuntu20.04, ubi9]
3128
steps:
3229
- uses: actions/checkout@v4
3330
name: Check out code
@@ -66,4 +63,4 @@ jobs:
6663
VERSION: ${COMMIT_SHORT_SHA}
6764
run: |
6865
echo "${VERSION}"
69-
make -f deployments/container/Makefile build-${{ matrix.dist }}
66+
make -f deployments/container/Makefile build

.gitlab-ci.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,3 @@ image-ubi9:
7676
extends:
7777
- .image-build
7878
- .dist-ubi9
79-
80-
image-ubuntu20.04:
81-
extends:
82-
- .image-build
83-
- .dist-ubuntu20.04

.nvidia-ci.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,6 @@ image-ubi9:
7070
- .image-pull
7171
- .dist-ubi9
7272

73-
image-ubuntu20.04:
74-
extends:
75-
- .image-pull
76-
- .dist-ubuntu20.04
77-
7873
# We skip the integration tests for the internal CI:
7974
.integration:
8075
stage: test
@@ -118,11 +113,6 @@ image-ubuntu20.04:
118113

119114
# Define the external release targets
120115
# Release to NGC
121-
release:ngc-ubuntu20.04:
122-
extends:
123-
- .release:ngc
124-
- .dist-ubuntu20.04
125-
126116
release:ngc-ubi9:
127117
extends:
128118
- .release:ngc

deployments/container/Dockerfile.ubuntu renamed to deployments/container/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# limitations under the License.
1414

1515
ARG GOLANG_VERSION=1.23.1
16+
# We use an ubuntu20.04 base image to allow for a more efficient multi-arch build.
1617
FROM --platform=${BUILDOS}/amd64 nvcr.io/nvidia/cuda:12.3.2-base-ubuntu20.04 AS build
1718

1819
RUN apt-get update && \
@@ -42,7 +43,7 @@ RUN if [ "$TARGETARCH" = "amd64" ]; then \
4243
fi && \
4344
make CC=${cc} GOARCH=${TARGETARCH} PREFIX=/artifacts cmds
4445

45-
FROM nvcr.io/nvidia/cuda:12.3.2-base-ubuntu20.04
46+
FROM nvcr.io/nvidia/cuda:12.3.2-base-ubi9
4647

4748
ENV NVIDIA_DISABLE_REQUIRE="true"
4849
ENV NVIDIA_VISIBLE_DEVICES=all

deployments/container/Dockerfile.ubi9

Lines changed: 0 additions & 61 deletions
This file was deleted.

deployments/container/Makefile

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ OUT_IMAGE_TAG = $(OUT_IMAGE_VERSION)-$(DIST)
3838
OUT_IMAGE = $(OUT_IMAGE_NAME):$(OUT_IMAGE_TAG)
3939

4040
##### Public rules #####
41-
DEFAULT_PUSH_TARGET := ubuntu20.04
42-
DISTRIBUTIONS = $(DEFAULT_PUSH_TARGET) ubi9
41+
DEFAULT_PUSH_TARGET := ubi9
42+
DISTRIBUTIONS = $(DEFAULT_PUSH_TARGET)
4343

4444
IMAGE_TARGETS := $(patsubst %,image-%,$(DISTRIBUTIONS))
4545
BUILD_TARGETS := $(patsubst %,build-%,$(DISTRIBUTIONS))
@@ -86,10 +86,6 @@ $(IMAGE_TARGETS): image-%:
8686
-f $(DOCKERFILE) \
8787
$(CURDIR)
8888

89-
build-ubuntu%: DOCKERFILE_SUFFIX := ubuntu
90-
91-
build-ubi9: DOCKERFILE_SUFFIX := ubi9
92-
9389
# Handle the default build target.
9490
.PHONY: build
9591
build: $(DEFAULT_PUSH_TARGET)

0 commit comments

Comments
 (0)