Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript resize functions fire when they shouldn't #339

Open
miken32 opened this issue May 1, 2023 · 1 comment
Open

JavaScript resize functions fire when they shouldn't #339

miken32 opened this issue May 1, 2023 · 1 comment

Comments

@miken32
Copy link

miken32 commented May 1, 2023

In edit.js the functions resizeMouseUp() and resizeMouseDown() are firing in response to context menu right clicks. The fix is simple, for both functions. Add near the top of the functions:

if (event.button > 0)
  return true;

In particular, resizeMouseUp() triggers a save of the map on the server side, but is doing no checking on the values. This was causing problems for us, with NaN getting written into the width and height properties of textboxes, breaking the entire map.

@miken32
Copy link
Author

miken32 commented Jun 7, 2024

This continues to be a problem for us; it seems weird to spend time fixing bugs in a version of PHP that's been unsupported for almost a decade instead of looking at QOL fixes like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant