Skip to content

Commit 718a898

Browse files
Fix running CLI with join column for target data (#356)
* Fix running CLI with join column for target data * Pin pytest version to fix tox tests * Ignore E704 errors raised by flake8 all of a sudden... --------- Co-authored-by: Niels Nuyttens <niels@nannyml.com>
1 parent 2af5e7b commit 718a898

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

nannyml/runner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,6 @@ def _add_targets_to_analysis_data(
298298
analysis_data: pd.DataFrame, target_data: pd.DataFrame, join_column: Optional[str]
299299
) -> pd.DataFrame:
300300
if join_column is not None:
301-
return analysis_data.merge(target_data, on=target_data.join_column)
301+
return analysis_data.merge(target_data, on=join_column)
302302
else:
303303
return analysis_data.join(target_data)

setup.cfg

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[flake8]
22
max-line-length = 120
33
max-complexity = 18
4-
ignore = E203, E266, W503
4+
ignore = E203, E266, E704, W503
55
docstring-convention = google
66
per-file-ignores = __init__.py:F401
77
exclude = .git,
@@ -62,7 +62,7 @@ python =
6262
[testenv]
6363
allowlist_externals = pytest
6464
deps =
65-
pytest
65+
pytest==6.2.5
6666
pytest-cov
6767
pytest-mock
6868
pytest-lazy-fixture

0 commit comments

Comments
 (0)